From: Simon Richter <Simon.Richter@hogyros.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, matthew@wil.cx,
grundler@parisc-linux.org, parisc-linux@parisc-linux.org,
paulus@samba.org, linuxppc-dev@ozlabs.org, lethal@linux-sh.org,
kkojima@rr.iij4u.or.jp, dwmw2@infradead.org,
linux-mtd@lists.infradead.org
Subject: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
Date: Tue, 13 Dec 2005 14:34:04 +0100 [thread overview]
Message-ID: <439ECDCC.80707@hogyros.de> (raw)
In-Reply-To: <20051213001028.GS23349@stusta.de>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
Hi,
Adrian Bunk wrote:
>>It's a problem introduced by your patch because the resulting defconfig
>>file becomes _wrong_ by your change, and other changes in the defconfig
>>are thereby hidden.
>>...
> No, CONFIG_BROKEN=y in a defconfig file is a bug.
Indeed, but that's not the point. A defconfig file should be the result
of running one of the various configuration targets; yours are
hand-patched. If you run the defconfig target, it will copy the config
file and run oldconfig, thus resulting in a different configuration file
(because options may now be gone and hence disabled) than what was in
the defconfig, and thus people may come to the wrong conclusion that if
a driver is enabled in a defconfig file, it will be built.
Simon
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 307 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Simon Richter <Simon.Richter@hogyros.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: tony.luck@intel.com, linux-ia64@vger.kernel.org,
grundler@parisc-linux.org, matthew@wil.cx,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
lethal@linux-sh.org, linux-mtd@lists.infradead.org,
dwmw2@infradead.org, kkojima@rr.iij4u.or.jp,
parisc-linux@parisc-linux.org
Subject: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
Date: Tue, 13 Dec 2005 14:34:04 +0100 [thread overview]
Message-ID: <439ECDCC.80707@hogyros.de> (raw)
In-Reply-To: <20051213001028.GS23349@stusta.de>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
Hi,
Adrian Bunk wrote:
>>It's a problem introduced by your patch because the resulting defconfig
>>file becomes _wrong_ by your change, and other changes in the defconfig
>>are thereby hidden.
>>...
> No, CONFIG_BROKEN=y in a defconfig file is a bug.
Indeed, but that's not the point. A defconfig file should be the result
of running one of the various configuration targets; yours are
hand-patched. If you run the defconfig target, it will copy the config
file and run oldconfig, thus resulting in a different configuration file
(because options may now be gone and hence disabled) than what was in
the defconfig, and thus people may come to the wrong conclusion that if
a driver is enabled in a defconfig file, it will be built.
Simon
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 307 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Simon Richter <Simon.Richter@hogyros.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, matthew@wil.cx,
grundler@parisc-linux.org, parisc-linux@parisc-linux.org,
paulus@samba.org, linuxppc-dev@ozlabs.org, lethal@linux-sh.org,
kkojima@rr.iij4u.or.jp, dwmw2@infradead.org,
linux-mtd@lists.infradead.org
Subject: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
Date: Tue, 13 Dec 2005 13:34:04 +0000 [thread overview]
Message-ID: <439ECDCC.80707@hogyros.de> (raw)
In-Reply-To: <20051213001028.GS23349@stusta.de>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
Hi,
Adrian Bunk wrote:
>>It's a problem introduced by your patch because the resulting defconfig
>>file becomes _wrong_ by your change, and other changes in the defconfig
>>are thereby hidden.
>>...
> No, CONFIG_BROKEN=y in a defconfig file is a bug.
Indeed, but that's not the point. A defconfig file should be the result
of running one of the various configuration targets; yours are
hand-patched. If you run the defconfig target, it will copy the config
file and run oldconfig, thus resulting in a different configuration file
(because options may now be gone and hence disabled) than what was in
the defconfig, and thus people may come to the wrong conclusion that if
a driver is enabled in a defconfig file, it will be built.
Simon
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 307 bytes --]
next prev parent reply other threads:[~2005-12-13 13:34 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-11 18:52 [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y Adrian Bunk
2005-12-11 18:52 ` Adrian Bunk
2005-12-11 18:52 ` Adrian Bunk
2005-12-11 19:21 ` Russell King
2005-12-11 19:21 ` Russell King
2005-12-11 19:31 ` Adrian Bunk
2005-12-11 19:31 ` Adrian Bunk
2005-12-11 19:44 ` Russell King
2005-12-11 19:44 ` Russell King
2005-12-13 0:10 ` Adrian Bunk
2005-12-13 0:10 ` Adrian Bunk
2005-12-13 0:10 ` Adrian Bunk
2005-12-13 13:34 ` Simon Richter [this message]
2005-12-13 13:34 ` Simon Richter
2005-12-13 13:34 ` Simon Richter
2005-12-13 14:00 ` Adrian Bunk
2005-12-13 14:00 ` Adrian Bunk
2005-12-13 14:00 ` Adrian Bunk
2005-12-13 14:00 ` Adrian Bunk
2005-12-13 17:31 ` Russell King
2005-12-13 17:31 ` Russell King
2005-12-13 17:31 ` Russell King
2005-12-13 17:38 ` Geert Uytterhoeven
2005-12-13 19:53 ` Russell King
2005-12-13 20:09 ` Adrian Bunk
2005-12-13 18:05 ` [2.6 patch] don't allow users to " Adrian Bunk
2005-12-13 18:05 ` Adrian Bunk
2005-12-13 18:05 ` Adrian Bunk
2005-12-13 18:28 ` Geert Uytterhoeven
2005-12-13 18:28 ` Geert Uytterhoeven
2005-12-13 18:28 ` Geert Uytterhoeven
2005-12-13 18:28 ` Geert Uytterhoeven
2005-12-13 18:51 ` Adrian Bunk
2005-12-13 18:51 ` Adrian Bunk
2005-12-13 18:51 ` Adrian Bunk
2005-12-13 18:51 ` Adrian Bunk
2005-12-13 18:59 ` Jesper Juhl
2005-12-13 18:59 ` Jesper Juhl
2005-12-13 18:59 ` Jesper Juhl
2005-12-13 18:59 ` Jesper Juhl
2005-12-13 20:01 ` Russell King
2005-12-13 20:01 ` Russell King
2005-12-13 20:01 ` Russell King
2005-12-13 20:19 ` Adrian Bunk
2005-12-13 20:19 ` Adrian Bunk
2005-12-13 20:19 ` Adrian Bunk
2005-12-13 22:01 ` Russell King
2005-12-13 22:01 ` Russell King
2005-12-13 22:01 ` Russell King
2005-12-12 9:38 ` [2.6 patch] defconfig's shouldn't " David Woodhouse
2005-12-12 9:38 ` David Woodhouse
2005-12-12 9:38 ` David Woodhouse
2005-12-13 0:05 ` [RFC: 2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers Adrian Bunk
2005-12-13 0:06 ` Adrian Bunk
2005-12-14 11:50 ` [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439ECDCC.80707@hogyros.de \
--to=simon.richter@hogyros.de \
--cc=bunk@stusta.de \
--cc=dwmw2@infradead.org \
--cc=grundler@parisc-linux.org \
--cc=kkojima@rr.iij4u.or.jp \
--cc=lethal@linux-sh.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matthew@wil.cx \
--cc=parisc-linux@parisc-linux.org \
--cc=paulus@samba.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.