All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Daniel Mack <daniel@caiaq.de>,
	Matt Fleming <matt@console-pimps.org>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Eric Miao <eric.y.miao@gmail.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Jarkko Lavinen <jarkko.lavinen@nokia.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Cliff Brake <cbrake@bec-systems.com>,
	Pierre Ossman <pierre@ossman.eu>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org,
	Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH] mmc: move regulator handling to core
Date: Thu, 3 Dec 2009 14:58:25 +0000	[thread overview]
Message-ID: <20091203145825.GA26651@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20091203132241.GB31533@rakim.wolfsonmicro.main>

On Thu, Dec 03, 2009 at 01:22:41PM +0000, Mark Brown wrote:
> On Thu, Dec 03, 2009 at 02:14:23PM +0100, Daniel Mack wrote:
> > I would expect the power to be killed when the last user stops using it.
> > Which should result in the same effect if you only have one host, one
> > regulator, and one user.
> 
> Yes, it's always fine in that case (modulo always_on and/or regulators
> without power control).  This goes back to the thing about using
> regulator_get_exclusive(), the message given was that the MMC drivers
> really needed to be able to guarantee that the power would be removed
> when that was requested.

If you take some cards through a series of steps and they stop responding,
it's normally because you've caused their internal state machine to
transition to "invalid" mode.

Further commands are ignored.  The only recovery is to power cycle them.

As for the regulator support in mmci, I can't say anything about it - I
don't have anything which uses it (not that I have any desire at present
to bring a MMC or SD card near Linux after my relatively new 128MB MMC
card got totally buggered with pxamci - that's not to say that Linux is
at fault, but the utter crap that seemingly most MMC/SD cards are.  Hence
why I'm not listed as maintainer of mmci.)

The regulator support in mmci is purely Linus' domain.

WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: move regulator handling to core
Date: Thu, 3 Dec 2009 14:58:25 +0000	[thread overview]
Message-ID: <20091203145825.GA26651@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20091203132241.GB31533@rakim.wolfsonmicro.main>

On Thu, Dec 03, 2009 at 01:22:41PM +0000, Mark Brown wrote:
> On Thu, Dec 03, 2009 at 02:14:23PM +0100, Daniel Mack wrote:
> > I would expect the power to be killed when the last user stops using it.
> > Which should result in the same effect if you only have one host, one
> > regulator, and one user.
> 
> Yes, it's always fine in that case (modulo always_on and/or regulators
> without power control).  This goes back to the thing about using
> regulator_get_exclusive(), the message given was that the MMC drivers
> really needed to be able to guarantee that the power would be removed
> when that was requested.

If you take some cards through a series of steps and they stop responding,
it's normally because you've caused their internal state machine to
transition to "invalid" mode.

Further commands are ignored.  The only recovery is to power cycle them.

As for the regulator support in mmci, I can't say anything about it - I
don't have anything which uses it (not that I have any desire at present
to bring a MMC or SD card near Linux after my relatively new 128MB MMC
card got totally buggered with pxamci - that's not to say that Linux is
at fault, but the utter crap that seemingly most MMC/SD cards are.  Hence
why I'm not listed as maintainer of mmci.)

The regulator support in mmci is purely Linus' domain.

  parent reply	other threads:[~2009-12-03 14:59 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03 12:46 [PATCH] mmc: move regulator handling to core Daniel Mack
2009-12-03 12:46 ` Daniel Mack
2009-12-03 13:06 ` Mark Brown
2009-12-03 13:06   ` Mark Brown
2009-12-03 13:14   ` Daniel Mack
2009-12-03 13:14     ` Daniel Mack
2009-12-03 13:22     ` Mark Brown
2009-12-03 13:22       ` Mark Brown
2009-12-03 13:32       ` Daniel Mack
2009-12-03 13:32         ` Daniel Mack
2009-12-03 13:40         ` Mark Brown
2009-12-03 13:40           ` Mark Brown
2009-12-03 13:43           ` Daniel Mack
2009-12-03 13:43             ` Daniel Mack
2009-12-03 14:58       ` Russell King - ARM Linux [this message]
2009-12-03 14:58         ` Russell King - ARM Linux
2009-12-03 15:09         ` Mark Brown
2009-12-03 15:09           ` Mark Brown
2009-12-03 14:27 ` Adrian Hunter
2009-12-03 14:27   ` Adrian Hunter
2009-12-03 14:27   ` Adrian Hunter
2009-12-03 19:20   ` Daniel Mack
2009-12-03 19:20     ` Daniel Mack
2009-12-03 19:20     ` Daniel Mack
2009-12-03 20:12     ` Adrian Hunter
2009-12-03 20:12       ` Adrian Hunter
2009-12-03 20:12       ` Adrian Hunter
2009-12-04 11:58       ` Daniel Mack
2009-12-04 11:58         ` Daniel Mack
2009-12-04 11:58         ` Daniel Mack
2009-12-12  0:58         ` Daniel Mack
2009-12-12  0:58           ` Daniel Mack
2009-12-12  0:58           ` Daniel Mack
2009-12-14 17:43           ` Madhusudhan
2009-12-14 17:43             ` Madhusudhan
2009-12-14 17:43             ` Madhusudhan
2009-12-15  5:44         ` David Brownell
2009-12-15  5:44           ` David Brownell
2009-12-15  5:44           ` David Brownell
2010-08-27 19:03 ` Chris Ball
2010-08-27 19:03   ` Chris Ball
2010-08-28 14:48   ` Linus Walleij
2010-08-28 14:48     ` Linus Walleij
2010-08-29 13:27     ` Mark Brown
2010-08-29 13:27       ` Mark Brown
2010-08-29 15:30       ` Linus Walleij
2010-08-29 15:30         ` Linus Walleij
2010-08-31 11:07         ` Mark Brown
2010-08-31 11:07           ` Mark Brown
2010-08-31 12:15           ` Linus Walleij
2010-08-31 12:15             ` Linus Walleij
2010-08-31 12:15             ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091203145825.GA26651@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=adrian.hunter@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=cbrake@bec-systems.com \
    --cc=daniel@caiaq.de \
    --cc=dbrownell@users.sourceforge.net \
    --cc=eric.y.miao@gmail.com \
    --cc=jarkko.lavinen@nokia.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=matt@console-pimps.org \
    --cc=pierre@ossman.eu \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.