All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.ml.walleij@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Chris Ball <cjb@laptop.org>, Daniel Mack <daniel@caiaq.de>,
	linux-kernel@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>,
	Pierre Ossman <pierre@ossman.eu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matt Fleming <matt@console-pimps.org>,
	Adrian Hunter <adrian.hunter@nokia.com>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Eric Miao <eric.y.miao@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Cliff Brake <cbrake@bec-systems.com>,
	Jarkko Lavinen <jarkko.lavinen@nokia.com>,
	Madhusudhan <madhu.cr@ti.com>,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: move regulator handling to core
Date: Sun, 29 Aug 2010 17:30:48 +0200	[thread overview]
Message-ID: <AANLkTim+cOSt=kjXXh_w+b4mzCiZN76HQ3az7SJKmOxR@mail.gmail.com> (raw)
In-Reply-To: <20100829132711.GB10233@opensource.wolfsonmicro.com>

2010/8/29 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Sat, Aug 28, 2010 at 04:48:58PM +0200, Linus Walleij wrote:
>> 2010/8/27 Chris Ball <cjb@laptop.org>:
>
>> > Looks like this patch got dropped because of the missing modifications
>> > to arch/arm/mach-omap2/mmc-twl4030.c.  Are we still interested in the
>> > patch otherwise, and can anyone help with that?
>
>> Actually just before the summer I submitted something not quite similar:
>> I moved all regulator handling *out* of the MMC core because I didn't
>> trust the way reference counting was being handled.
>
> This seems like the wrong approach; if there's a problem it'd seem much
> better to fix the core code that everything is sharing rather than
> factor it out - the location of the code is orthogonal to its
> helpfulness.

I actually did not move the essential regulator bits out just enable/disable,
so that these were in the sites where the regulators were actually
enabled/disabled in respective driver. That makes the internal
regulator reference count do the trick.

I can get that patch into shape easily, if for nothing else it's a nice
discussion item.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: move regulator handling to core
Date: Sun, 29 Aug 2010 17:30:48 +0200	[thread overview]
Message-ID: <AANLkTim+cOSt=kjXXh_w+b4mzCiZN76HQ3az7SJKmOxR@mail.gmail.com> (raw)
In-Reply-To: <20100829132711.GB10233@opensource.wolfsonmicro.com>

2010/8/29 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Sat, Aug 28, 2010 at 04:48:58PM +0200, Linus Walleij wrote:
>> 2010/8/27 Chris Ball <cjb@laptop.org>:
>
>> > Looks like this patch got dropped because of the missing modifications
>> > to arch/arm/mach-omap2/mmc-twl4030.c. ?Are we still interested in the
>> > patch otherwise, and can anyone help with that?
>
>> Actually just before the summer I submitted something not quite similar:
>> I moved all regulator handling *out* of the MMC core because I didn't
>> trust the way reference counting was being handled.
>
> This seems like the wrong approach; if there's a problem it'd seem much
> better to fix the core code that everything is sharing rather than
> factor it out - the location of the code is orthogonal to its
> helpfulness.

I actually did not move the essential regulator bits out just enable/disable,
so that these were in the sites where the regulators were actually
enabled/disabled in respective driver. That makes the internal
regulator reference count do the trick.

I can get that patch into shape easily, if for nothing else it's a nice
discussion item.

Yours,
Linus Walleij

  reply	other threads:[~2010-08-29 15:30 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03 12:46 [PATCH] mmc: move regulator handling to core Daniel Mack
2009-12-03 12:46 ` Daniel Mack
2009-12-03 13:06 ` Mark Brown
2009-12-03 13:06   ` Mark Brown
2009-12-03 13:14   ` Daniel Mack
2009-12-03 13:14     ` Daniel Mack
2009-12-03 13:22     ` Mark Brown
2009-12-03 13:22       ` Mark Brown
2009-12-03 13:32       ` Daniel Mack
2009-12-03 13:32         ` Daniel Mack
2009-12-03 13:40         ` Mark Brown
2009-12-03 13:40           ` Mark Brown
2009-12-03 13:43           ` Daniel Mack
2009-12-03 13:43             ` Daniel Mack
2009-12-03 14:58       ` Russell King - ARM Linux
2009-12-03 14:58         ` Russell King - ARM Linux
2009-12-03 15:09         ` Mark Brown
2009-12-03 15:09           ` Mark Brown
2009-12-03 14:27 ` Adrian Hunter
2009-12-03 14:27   ` Adrian Hunter
2009-12-03 14:27   ` Adrian Hunter
2009-12-03 19:20   ` Daniel Mack
2009-12-03 19:20     ` Daniel Mack
2009-12-03 19:20     ` Daniel Mack
2009-12-03 20:12     ` Adrian Hunter
2009-12-03 20:12       ` Adrian Hunter
2009-12-03 20:12       ` Adrian Hunter
2009-12-04 11:58       ` Daniel Mack
2009-12-04 11:58         ` Daniel Mack
2009-12-04 11:58         ` Daniel Mack
2009-12-12  0:58         ` Daniel Mack
2009-12-12  0:58           ` Daniel Mack
2009-12-12  0:58           ` Daniel Mack
2009-12-14 17:43           ` Madhusudhan
2009-12-14 17:43             ` Madhusudhan
2009-12-14 17:43             ` Madhusudhan
2009-12-15  5:44         ` David Brownell
2009-12-15  5:44           ` David Brownell
2009-12-15  5:44           ` David Brownell
2010-08-27 19:03 ` Chris Ball
2010-08-27 19:03   ` Chris Ball
2010-08-28 14:48   ` Linus Walleij
2010-08-28 14:48     ` Linus Walleij
2010-08-29 13:27     ` Mark Brown
2010-08-29 13:27       ` Mark Brown
2010-08-29 15:30       ` Linus Walleij [this message]
2010-08-29 15:30         ` Linus Walleij
2010-08-31 11:07         ` Mark Brown
2010-08-31 11:07           ` Mark Brown
2010-08-31 12:15           ` Linus Walleij
2010-08-31 12:15             ` Linus Walleij
2010-08-31 12:15             ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTim+cOSt=kjXXh_w+b4mzCiZN76HQ3az7SJKmOxR@mail.gmail.com' \
    --to=linus.ml.walleij@gmail.com \
    --cc=adrian.hunter@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=cbrake@bec-systems.com \
    --cc=cjb@laptop.org \
    --cc=daniel@caiaq.de \
    --cc=dbrownell@users.sourceforge.net \
    --cc=eric.y.miao@gmail.com \
    --cc=jarkko.lavinen@nokia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=madhu.cr@ti.com \
    --cc=matt@console-pimps.org \
    --cc=pierre@ossman.eu \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.