From: David Brownell <david-b@pacbell.net>
To: Daniel Mack <daniel@caiaq.de>
Cc: Adrian Hunter <adrian.hunter@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Pierre Ossman <pierre@ossman.eu>,
Andrew Morton <akpm@linux-foundation.org>,
Matt Fleming <matt@console-pimps.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Linus Walleij <linus.walleij@stericsson.com>,
Eric Miao <eric.y.miao@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Cliff Brake <cbrake@bec-systems.com>,
"Lavinen Jarkko \(Nokia-D/Helsinki\)" <jarkko.lavinen@nokia.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mmc: move regulator handling to core
Date: Mon, 14 Dec 2009 21:44:08 -0800 [thread overview]
Message-ID: <200912142144.08591.david-b@pacbell.net> (raw)
In-Reply-To: <20091204115805.GS14091@buzzloop.caiaq.de>
On Friday 04 December 2009, Daniel Mack wrote:
> On Thu, Dec 03, 2009 at 10:12:36PM +0200, Adrian Hunter wrote:
> > Daniel Mack wrote:
> > >On Thu, Dec 03, 2009 at 04:27:39PM +0200, Adrian Hunter wrote:
>
> > >>What about arch/arm/mach-omap2/mmc-twl4030.c ?
> > >
> > >Argh, missed that one. And this particular case doesn't fit to my
> > >modifications. I don't know the code well ... We would need to
> > >have a struct mmc_host * in all the functions there calling
> > >mmc_regulator_{set,get}_ocr. Any idea how to resolve that?
Finish separating the HSMMC setup from the OMAP2 setup, then the
HSMMC stuff will be a lot easier to cope with. The HSMMC stuff
is never used with the mfd/menelaus transceiver/slot switch stuff;
including those data structures caused lots of hassles.
The only real issue with the HSMMC stuff is that it's got to continue
working with the many wiring options now in use.
> Moving the regulator handling to the mmc core would require a major
> cleanup to all this code, but I don't have such hardware to test my
> modifications. Can anyone help here?
Simplest to borrow a Beagle. Make sure whatever you do
can handle both standard SDHC cards, and also 8-bit HSMMC.
Once that works, the rest will fall out pretty easily.
- Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Daniel Mack <daniel@caiaq.de>
Cc: Adrian Hunter <adrian.hunter@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Pierre Ossman <pierre@ossman.eu>,
Andrew Morton <akpm@linux-foundation.org>,
Matt Fleming <matt@console-pimps.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Linus Walleij <linus.walleij@stericsson.com>,
Eric Miao <eric.y.miao@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Cliff Brake <cbrake@bec-systems.com>,
"Lavinen Jarkko (Nokia-D/Helsinki)" <jarkko.lavinen@nokia.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mmc: move regulator handling to core
Date: Mon, 14 Dec 2009 21:44:08 -0800 [thread overview]
Message-ID: <200912142144.08591.david-b@pacbell.net> (raw)
In-Reply-To: <20091204115805.GS14091@buzzloop.caiaq.de>
On Friday 04 December 2009, Daniel Mack wrote:
> On Thu, Dec 03, 2009 at 10:12:36PM +0200, Adrian Hunter wrote:
> > Daniel Mack wrote:
> > >On Thu, Dec 03, 2009 at 04:27:39PM +0200, Adrian Hunter wrote:
>
> > >>What about arch/arm/mach-omap2/mmc-twl4030.c ?
> > >
> > >Argh, missed that one. And this particular case doesn't fit to my
> > >modifications. I don't know the code well ... We would need to
> > >have a struct mmc_host * in all the functions there calling
> > >mmc_regulator_{set,get}_ocr. Any idea how to resolve that?
Finish separating the HSMMC setup from the OMAP2 setup, then the
HSMMC stuff will be a lot easier to cope with. The HSMMC stuff
is never used with the mfd/menelaus transceiver/slot switch stuff;
including those data structures caused lots of hassles.
The only real issue with the HSMMC stuff is that it's got to continue
working with the many wiring options now in use.
> Moving the regulator handling to the mmc core would require a major
> cleanup to all this code, but I don't have such hardware to test my
> modifications. Can anyone help here?
Simplest to borrow a Beagle. Make sure whatever you do
can handle both standard SDHC cards, and also 8-bit HSMMC.
Once that works, the rest will fall out pretty easily.
- Dave
WARNING: multiple messages have this Message-ID (diff)
From: david-b@pacbell.net (David Brownell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: move regulator handling to core
Date: Mon, 14 Dec 2009 21:44:08 -0800 [thread overview]
Message-ID: <200912142144.08591.david-b@pacbell.net> (raw)
In-Reply-To: <20091204115805.GS14091@buzzloop.caiaq.de>
On Friday 04 December 2009, Daniel Mack wrote:
> On Thu, Dec 03, 2009 at 10:12:36PM +0200, Adrian Hunter wrote:
> > Daniel Mack wrote:
> > >On Thu, Dec 03, 2009 at 04:27:39PM +0200, Adrian Hunter wrote:
>
> > >>What about arch/arm/mach-omap2/mmc-twl4030.c ?
> > >
> > >Argh, missed that one. And this particular case doesn't fit to my
> > >modifications. I don't know the code well ... We would need to
> > >have a struct mmc_host * in all the functions there calling
> > >mmc_regulator_{set,get}_ocr. Any idea how to resolve that?
Finish separating the HSMMC setup from the OMAP2 setup, then the
HSMMC stuff will be a lot easier to cope with. The HSMMC stuff
is never used with the mfd/menelaus transceiver/slot switch stuff;
including those data structures caused lots of hassles.
The only real issue with the HSMMC stuff is that it's got to continue
working with the many wiring options now in use.
> Moving the regulator handling to the mmc core would require a major
> cleanup to all this code, but I don't have such hardware to test my
> modifications. Can anyone help here?
Simplest to borrow a Beagle. Make sure whatever you do
can handle both standard SDHC cards, and also 8-bit HSMMC.
Once that works, the rest will fall out pretty easily.
- Dave
next prev parent reply other threads:[~2009-12-15 5:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 12:46 [PATCH] mmc: move regulator handling to core Daniel Mack
2009-12-03 12:46 ` Daniel Mack
2009-12-03 13:06 ` Mark Brown
2009-12-03 13:06 ` Mark Brown
2009-12-03 13:14 ` Daniel Mack
2009-12-03 13:14 ` Daniel Mack
2009-12-03 13:22 ` Mark Brown
2009-12-03 13:22 ` Mark Brown
2009-12-03 13:32 ` Daniel Mack
2009-12-03 13:32 ` Daniel Mack
2009-12-03 13:40 ` Mark Brown
2009-12-03 13:40 ` Mark Brown
2009-12-03 13:43 ` Daniel Mack
2009-12-03 13:43 ` Daniel Mack
2009-12-03 14:58 ` Russell King - ARM Linux
2009-12-03 14:58 ` Russell King - ARM Linux
2009-12-03 15:09 ` Mark Brown
2009-12-03 15:09 ` Mark Brown
2009-12-03 14:27 ` Adrian Hunter
2009-12-03 14:27 ` Adrian Hunter
2009-12-03 14:27 ` Adrian Hunter
2009-12-03 19:20 ` Daniel Mack
2009-12-03 19:20 ` Daniel Mack
2009-12-03 19:20 ` Daniel Mack
2009-12-03 20:12 ` Adrian Hunter
2009-12-03 20:12 ` Adrian Hunter
2009-12-03 20:12 ` Adrian Hunter
2009-12-04 11:58 ` Daniel Mack
2009-12-04 11:58 ` Daniel Mack
2009-12-04 11:58 ` Daniel Mack
2009-12-12 0:58 ` Daniel Mack
2009-12-12 0:58 ` Daniel Mack
2009-12-12 0:58 ` Daniel Mack
2009-12-14 17:43 ` Madhusudhan
2009-12-14 17:43 ` Madhusudhan
2009-12-14 17:43 ` Madhusudhan
2009-12-15 5:44 ` David Brownell [this message]
2009-12-15 5:44 ` David Brownell
2009-12-15 5:44 ` David Brownell
2010-08-27 19:03 ` Chris Ball
2010-08-27 19:03 ` Chris Ball
2010-08-28 14:48 ` Linus Walleij
2010-08-28 14:48 ` Linus Walleij
2010-08-29 13:27 ` Mark Brown
2010-08-29 13:27 ` Mark Brown
2010-08-29 15:30 ` Linus Walleij
2010-08-29 15:30 ` Linus Walleij
2010-08-31 11:07 ` Mark Brown
2010-08-31 11:07 ` Mark Brown
2010-08-31 12:15 ` Linus Walleij
2010-08-31 12:15 ` Linus Walleij
2010-08-31 12:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912142144.08591.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cbrake@bec-systems.com \
--cc=daniel@caiaq.de \
--cc=eric.y.miao@gmail.com \
--cc=jarkko.lavinen@nokia.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=matt@console-pimps.org \
--cc=pierre@ossman.eu \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.