From: Daniel Mack <daniel@caiaq.de> To: Adrian Hunter <adrian.hunter@nokia.com> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Mark Brown <broonie@opensource.wolfsonmicro.com>, Liam Girdwood <lrg@slimlogic.co.uk>, Pierre Ossman <pierre@ossman.eu>, Andrew Morton <akpm@linux-foundation.org>, Matt Fleming <matt@console-pimps.org>, David Brownell <dbrownell@users.sourceforge.net>, Russell King <rmk+kernel@arm.linux.org.uk>, Linus Walleij <linus.walleij@stericsson.com>, Eric Miao <eric.y.miao@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Cliff Brake <cbrake@bec-systems.com>, "Lavinen Jarkko (Nokia-D/Helsinki)" <jarkko.lavinen@nokia.com>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "madhu.cr@ti.com >> Madhusudhan Chikkature" <madhu.cr@ti.com> Subject: Re: [PATCH] mmc: move regulator handling to core Date: Fri, 4 Dec 2009 12:58:05 +0100 [thread overview] Message-ID: <20091204115805.GS14091@buzzloop.caiaq.de> (raw) In-Reply-To: <4B181BB4.1020800@nokia.com> On Thu, Dec 03, 2009 at 10:12:36PM +0200, Adrian Hunter wrote: > Daniel Mack wrote: > >On Thu, Dec 03, 2009 at 04:27:39PM +0200, Adrian Hunter wrote: > >>What about arch/arm/mach-omap2/mmc-twl4030.c ? > > > >Argh, missed that one. And this particular case doesn't fit to my > >modifications. I don't know the code well ... We would need to > >have a struct mmc_host * in all the functions there calling > >mmc_regulator_{set,get}_ocr. Any idea how to resolve that? > > > > Pass it down from the omap_hsmmc driver. It's not that easy, unfortunately, because this code does not conform to all the other mmc host drivers in tree. I don't understand why things are done the way it is currently implemented. Why isn't there a mmc_host for each slot, and why is a regulator reference acquired for each slot, and not once for the whole device? Even with the default 'vcc' supply factored out to the mmc core, the 'vmmc_aux' regulator would still need some extra attention, but I would also do that from the omap_hsmmc driver rather than in the plaform support code. Moving the regulator handling to the mmc core would require a major cleanup to all this code, but I don't have such hardware to test my modifications. Can anyone help here? Thanks, Daniel
WARNING: multiple messages have this Message-ID (diff)
From: daniel@caiaq.de (Daniel Mack) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] mmc: move regulator handling to core Date: Fri, 4 Dec 2009 12:58:05 +0100 [thread overview] Message-ID: <20091204115805.GS14091@buzzloop.caiaq.de> (raw) In-Reply-To: <4B181BB4.1020800@nokia.com> On Thu, Dec 03, 2009 at 10:12:36PM +0200, Adrian Hunter wrote: > Daniel Mack wrote: > >On Thu, Dec 03, 2009 at 04:27:39PM +0200, Adrian Hunter wrote: > >>What about arch/arm/mach-omap2/mmc-twl4030.c ? > > > >Argh, missed that one. And this particular case doesn't fit to my > >modifications. I don't know the code well ... We would need to > >have a struct mmc_host * in all the functions there calling > >mmc_regulator_{set,get}_ocr. Any idea how to resolve that? > > > > Pass it down from the omap_hsmmc driver. It's not that easy, unfortunately, because this code does not conform to all the other mmc host drivers in tree. I don't understand why things are done the way it is currently implemented. Why isn't there a mmc_host for each slot, and why is a regulator reference acquired for each slot, and not once for the whole device? Even with the default 'vcc' supply factored out to the mmc core, the 'vmmc_aux' regulator would still need some extra attention, but I would also do that from the omap_hsmmc driver rather than in the plaform support code. Moving the regulator handling to the mmc core would require a major cleanup to all this code, but I don't have such hardware to test my modifications. Can anyone help here? Thanks, Daniel
next prev parent reply other threads:[~2009-12-04 11:58 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-12-03 12:46 [PATCH] mmc: move regulator handling to core Daniel Mack 2009-12-03 12:46 ` Daniel Mack 2009-12-03 13:06 ` Mark Brown 2009-12-03 13:06 ` Mark Brown 2009-12-03 13:14 ` Daniel Mack 2009-12-03 13:14 ` Daniel Mack 2009-12-03 13:22 ` Mark Brown 2009-12-03 13:22 ` Mark Brown 2009-12-03 13:32 ` Daniel Mack 2009-12-03 13:32 ` Daniel Mack 2009-12-03 13:40 ` Mark Brown 2009-12-03 13:40 ` Mark Brown 2009-12-03 13:43 ` Daniel Mack 2009-12-03 13:43 ` Daniel Mack 2009-12-03 14:58 ` Russell King - ARM Linux 2009-12-03 14:58 ` Russell King - ARM Linux 2009-12-03 15:09 ` Mark Brown 2009-12-03 15:09 ` Mark Brown 2009-12-03 14:27 ` Adrian Hunter 2009-12-03 14:27 ` Adrian Hunter 2009-12-03 14:27 ` Adrian Hunter 2009-12-03 19:20 ` Daniel Mack 2009-12-03 19:20 ` Daniel Mack 2009-12-03 19:20 ` Daniel Mack 2009-12-03 20:12 ` Adrian Hunter 2009-12-03 20:12 ` Adrian Hunter 2009-12-03 20:12 ` Adrian Hunter 2009-12-04 11:58 ` Daniel Mack [this message] 2009-12-04 11:58 ` Daniel Mack 2009-12-04 11:58 ` Daniel Mack 2009-12-12 0:58 ` Daniel Mack 2009-12-12 0:58 ` Daniel Mack 2009-12-12 0:58 ` Daniel Mack 2009-12-14 17:43 ` Madhusudhan 2009-12-14 17:43 ` Madhusudhan 2009-12-14 17:43 ` Madhusudhan 2009-12-15 5:44 ` David Brownell 2009-12-15 5:44 ` David Brownell 2009-12-15 5:44 ` David Brownell 2010-08-27 19:03 ` Chris Ball 2010-08-27 19:03 ` Chris Ball 2010-08-28 14:48 ` Linus Walleij 2010-08-28 14:48 ` Linus Walleij 2010-08-29 13:27 ` Mark Brown 2010-08-29 13:27 ` Mark Brown 2010-08-29 15:30 ` Linus Walleij 2010-08-29 15:30 ` Linus Walleij 2010-08-31 11:07 ` Mark Brown 2010-08-31 11:07 ` Mark Brown 2010-08-31 12:15 ` Linus Walleij 2010-08-31 12:15 ` Linus Walleij 2010-08-31 12:15 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091204115805.GS14091@buzzloop.caiaq.de \ --to=daniel@caiaq.de \ --cc=adrian.hunter@nokia.com \ --cc=akpm@linux-foundation.org \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=cbrake@bec-systems.com \ --cc=dbrownell@users.sourceforge.net \ --cc=eric.y.miao@gmail.com \ --cc=jarkko.lavinen@nokia.com \ --cc=linus.walleij@stericsson.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=lrg@slimlogic.co.uk \ --cc=madhu.cr@ti.com \ --cc=matt@console-pimps.org \ --cc=pierre@ossman.eu \ --cc=rmk+kernel@arm.linux.org.uk \ --cc=robert.jarzmik@free.fr \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.