All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: linux-next: build failure after merge of the final tree (net tree related)
Date: Tue, 27 Apr 2010 10:18:04 -0700 (PDT)	[thread overview]
Message-ID: <20100427.101804.13765995.davem@davemloft.net> (raw)
In-Reply-To: <20100427.093430.258110898.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Tue, 27 Apr 2010 09:34:30 -0700 (PDT)

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 27 Apr 2010 15:25:16 +1000
> 
>> After merging the bkl-ioctl tree, today's linux-next build (powerpc
>> ppc44x_defconfig) failed like this:
>> 
>> net/bridge/br_multicast.c: In function 'br_ip6_multicast_alloc_query':
>> net/bridge/br_multicast.c:469: error: implicit declaration of function 'csum_ipv6_magic'
>> 
>> Introduced by commit 08b202b6726459626c73ecfa08fcdc8c3efc76c2 ("bridge
>> br_multicast: IPv6 MLD support") from the net tree.
>> 
>> csum_ipv6_magic is declared in net/ip6_checksum.h ...
> 
> Bummer, powerpc is one of the few platforms that doesn't get the header
> file implicitly so you always trip over this whereas we never see it in
> x86 and sparc64 builds :-)
> 
> I'll fix this, thanks!

I just committed the following for this:

bridge: Fix build of ipv6 multicast code.

Based upon a report from Stephen Rothwell:

--------------------
net/bridge/br_multicast.c: In function 'br_ip6_multicast_alloc_query':
net/bridge/br_multicast.c:469: error: implicit declaration of function 'csum_ipv6_magic'

Introduced by commit 08b202b6726459626c73ecfa08fcdc8c3efc76c2 ("bridge
br_multicast: IPv6 MLD support") from the net tree.

csum_ipv6_magic is declared in net/ip6_checksum.h ...
--------------------

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/bridge/br_multicast.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index e481dbd..2048ef0 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -28,6 +28,7 @@
 #include <net/ipv6.h>
 #include <net/mld.h>
 #include <net/addrconf.h>
+#include <net/ip6_checksum.h>
 #endif
 
 #include "br_private.h"
-- 
1.7.0.4


  reply	other threads:[~2010-04-27 17:18 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27  5:25 linux-next: build failure after merge of the final tree (net tree related) Stephen Rothwell
2010-04-27  5:25 ` Stephen Rothwell
2010-04-27 16:34 ` David Miller
2010-04-27 17:18   ` David Miller [this message]
2010-04-28  1:11     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2012-01-09  5:38 Stephen Rothwell
2012-01-09  5:38 ` Stephen Rothwell
2012-01-09  6:52 ` David Miller
2012-01-16  7:36   ` Glauber Costa
2012-01-16  7:36     ` Glauber Costa
2011-12-22  6:07 Stephen Rothwell
2011-12-22  6:07 ` Stephen Rothwell
2011-12-22  6:16 ` Eric Dumazet
2011-12-22  7:01 ` David Miller
2011-11-02  5:37 Stephen Rothwell
2011-11-02  5:37 ` Stephen Rothwell
2011-11-02  5:50 ` David Miller
2011-08-15  5:20 Stephen Rothwell
2011-08-15  5:56 ` David Miller
2011-08-16  5:28   ` Stephen Rothwell
2011-08-16  6:11     ` David Miller
2011-08-16  6:57       ` Stephen Rothwell
2011-08-16  7:17         ` David Miller
2011-06-23  5:29 Stephen Rothwell
2011-06-23  5:29 ` Stephen Rothwell
2011-06-23 13:04 ` Alexey Dobriyan
2011-06-27  5:29   ` Stephen Rothwell
2011-06-29  6:09     ` Stephen Rothwell
2011-06-29  9:58       ` David Miller
2011-06-23  5:25 Stephen Rothwell
2011-06-23  5:25 ` Stephen Rothwell
2011-06-27  5:35 ` Stephen Rothwell
2011-06-27  5:35   ` Stephen Rothwell
2011-06-29  6:01   ` Stephen Rothwell
2011-06-29  6:01     ` Stephen Rothwell
2011-06-29  9:56     ` David Miller
2011-06-08  5:54 Stephen Rothwell
2011-06-08  5:54 ` Stephen Rothwell
2011-06-08  7:16 ` David Miller
2011-04-21 22:10 Stephen Rothwell
2011-04-21 22:10 ` Stephen Rothwell
2011-04-21 22:19 ` David Miller
2011-02-03  4:13 Stephen Rothwell
2011-02-03  4:13 ` Stephen Rothwell
2011-02-03  4:46 ` David Miller
2011-02-03  5:14   ` Stephen Rothwell
2010-11-15  0:46 Stephen Rothwell
2010-11-15  0:46 ` Stephen Rothwell
2010-11-15 16:52 ` David Miller
2010-11-15 16:58   ` Eric Dumazet
2010-10-18  7:36 Stephen Rothwell
2010-10-18  7:36 ` Stephen Rothwell
2010-10-18  8:06 ` David Miller
2010-09-27  5:44 Stephen Rothwell
2010-09-27  5:44 ` Stephen Rothwell
2010-09-27  8:17 ` David Miller
2010-09-27 15:55 ` Ohad Ben-Cohen
2010-09-27 15:55   ` Ohad Ben-Cohen
2010-09-27 18:04   ` John W. Linville
2010-09-27 18:18     ` David Miller
2010-09-27 18:25       ` John W. Linville
2010-09-27 18:38         ` Ohad Ben-Cohen
2010-09-27 18:44           ` John W. Linville
2010-09-27 19:01             ` Ohad Ben-Cohen
2010-09-27 19:06               ` Ohad Ben-Cohen
2010-09-27 19:44                 ` John W. Linville
2010-09-27 19:44                   ` John W. Linville
2010-09-27 20:18                   ` Ohad Ben-Cohen
2010-09-03  1:47 Stephen Rothwell
2010-09-03  1:47 ` Stephen Rothwell
2010-09-03  1:52 ` Stephen Rothwell
2010-09-03  1:52   ` Stephen Rothwell
2010-09-03  2:16   ` David Miller
2010-09-03  2:14 ` David Miller
2010-08-31  3:18 Stephen Rothwell
2010-08-31  3:18 ` Stephen Rothwell
2010-08-31  4:43 ` David Miller
2010-08-30  3:04 Stephen Rothwell
2010-08-30  3:04 ` Stephen Rothwell
2010-08-30  3:29 ` Simon Horman
2010-08-30  4:23   ` David Miller
2010-08-25  2:09 Stephen Rothwell
2010-08-25  2:09 ` Stephen Rothwell
2010-08-25  4:22 ` Rasesh Mody
2010-08-25  7:35   ` David Miller
2010-08-25 20:59     ` David Miller
2010-08-25 21:53       ` Rasesh Mody
2010-08-25 21:53         ` Rasesh Mody
2010-08-26  1:05       ` Stephen Rothwell
2010-08-23  3:27 Stephen Rothwell
2010-08-23  3:27 ` Stephen Rothwell
2010-08-23  3:31 ` David Miller
2010-07-29  4:13 Stephen Rothwell
2010-07-29  4:13 ` Stephen Rothwell
2010-07-29  5:21 ` David Miller
2010-03-29  6:43 Stephen Rothwell
2010-03-29  6:43 ` Stephen Rothwell
2010-03-29  6:52 ` Eric Dumazet
2010-03-29  6:59   ` Eric Dumazet
2010-03-29  8:01     ` David Miller
2010-03-29  8:04       ` Stephen Rothwell
2010-03-29  7:01   ` Stephen Rothwell
2010-03-18  4:23 Stephen Rothwell
2010-03-18  4:23 ` Stephen Rothwell
2010-03-18  6:23 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427.101804.13765995.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.