All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org, mirq-linux@rere.qmqm.pl
Subject: Re: linux-next: build failure after merge of the final tree (net tree related)
Date: Thu, 21 Apr 2011 15:19:25 -0700 (PDT)	[thread overview]
Message-ID: <20110421.151925.226786245.davem@davemloft.net> (raw)
In-Reply-To: <20110422081008.e7ebab59.sfr@canb.auug.org.au>

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 22 Apr 2011 08:10:08 +1000

> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc chrp32_defconfig)
> failed like this:
> 
> drivers/net/mv643xx_eth.c: In function 'port_start':
> drivers/net/mv643xx_eth.c:2250: error: 'dev' undeclared (first use in this function)
> 
> Caused by commit aad59c431b77 ("net: mv643xx: convert to hw_features").

I just pushed the following fix, thanks!

--------------------
mv643xx_eth: Fix build regression.

>From Stephen Rothwell:

--------------------
After merging the final tree, today's linux-next build (powerpc chrp32_defconfig)
failed like this:

drivers/net/mv643xx_eth.c: In function 'port_start':
drivers/net/mv643xx_eth.c:2250: error: 'dev' undeclared (first use in this function)

Caused by commit aad59c431b77 ("net: mv643xx: convert to hw_features").
--------------------

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/mv643xx_eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 29605a3..57c2ac0 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -2247,7 +2247,7 @@ static void port_start(struct mv643xx_eth_private *mp)
 	 * frames to RX queue #0, and include the pseudo-header when
 	 * calculating receive checksums.
 	 */
-	mv643xx_eth_set_features(dev, dev->features);
+	mv643xx_eth_set_features(mp->dev, mp->dev->features);
 
 	/*
 	 * Treat BPDUs as normal multicasts, and disable partition mode.
-- 
1.7.4.3


  reply	other threads:[~2011-04-21 22:20 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 22:10 linux-next: build failure after merge of the final tree (net tree related) Stephen Rothwell
2011-04-21 22:10 ` Stephen Rothwell
2011-04-21 22:19 ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-01-09  5:38 Stephen Rothwell
2012-01-09  5:38 ` Stephen Rothwell
2012-01-09  6:52 ` David Miller
2012-01-16  7:36   ` Glauber Costa
2012-01-16  7:36     ` Glauber Costa
2011-12-22  6:07 Stephen Rothwell
2011-12-22  6:07 ` Stephen Rothwell
2011-12-22  6:16 ` Eric Dumazet
2011-12-22  7:01 ` David Miller
2011-11-02  5:37 Stephen Rothwell
2011-11-02  5:37 ` Stephen Rothwell
2011-11-02  5:50 ` David Miller
2011-08-15  5:20 Stephen Rothwell
2011-08-15  5:56 ` David Miller
2011-08-16  5:28   ` Stephen Rothwell
2011-08-16  6:11     ` David Miller
2011-08-16  6:57       ` Stephen Rothwell
2011-08-16  7:17         ` David Miller
2011-06-23  5:29 Stephen Rothwell
2011-06-23  5:29 ` Stephen Rothwell
2011-06-23 13:04 ` Alexey Dobriyan
2011-06-27  5:29   ` Stephen Rothwell
2011-06-29  6:09     ` Stephen Rothwell
2011-06-29  9:58       ` David Miller
2011-06-23  5:25 Stephen Rothwell
2011-06-23  5:25 ` Stephen Rothwell
2011-06-27  5:35 ` Stephen Rothwell
2011-06-27  5:35   ` Stephen Rothwell
2011-06-29  6:01   ` Stephen Rothwell
2011-06-29  6:01     ` Stephen Rothwell
2011-06-29  9:56     ` David Miller
2011-06-08  5:54 Stephen Rothwell
2011-06-08  5:54 ` Stephen Rothwell
2011-06-08  7:16 ` David Miller
2011-02-03  4:13 Stephen Rothwell
2011-02-03  4:13 ` Stephen Rothwell
2011-02-03  4:46 ` David Miller
2011-02-03  5:14   ` Stephen Rothwell
2010-11-15  0:46 Stephen Rothwell
2010-11-15  0:46 ` Stephen Rothwell
2010-11-15 16:52 ` David Miller
2010-11-15 16:58   ` Eric Dumazet
2010-10-18  7:36 Stephen Rothwell
2010-10-18  7:36 ` Stephen Rothwell
2010-10-18  8:06 ` David Miller
2010-09-27  5:44 Stephen Rothwell
2010-09-27  5:44 ` Stephen Rothwell
2010-09-27  8:17 ` David Miller
2010-09-27 15:55 ` Ohad Ben-Cohen
2010-09-27 15:55   ` Ohad Ben-Cohen
2010-09-27 18:04   ` John W. Linville
2010-09-27 18:18     ` David Miller
2010-09-27 18:25       ` John W. Linville
2010-09-27 18:38         ` Ohad Ben-Cohen
2010-09-27 18:44           ` John W. Linville
2010-09-27 19:01             ` Ohad Ben-Cohen
2010-09-27 19:06               ` Ohad Ben-Cohen
2010-09-27 19:44                 ` John W. Linville
2010-09-27 19:44                   ` John W. Linville
2010-09-27 20:18                   ` Ohad Ben-Cohen
2010-09-03  1:47 Stephen Rothwell
2010-09-03  1:47 ` Stephen Rothwell
2010-09-03  1:52 ` Stephen Rothwell
2010-09-03  1:52   ` Stephen Rothwell
2010-09-03  2:16   ` David Miller
2010-09-03  2:14 ` David Miller
2010-08-31  3:18 Stephen Rothwell
2010-08-31  3:18 ` Stephen Rothwell
2010-08-31  4:43 ` David Miller
2010-08-30  3:04 Stephen Rothwell
2010-08-30  3:04 ` Stephen Rothwell
2010-08-30  3:29 ` Simon Horman
2010-08-30  4:23   ` David Miller
2010-08-25  2:09 Stephen Rothwell
2010-08-25  2:09 ` Stephen Rothwell
2010-08-25  4:22 ` Rasesh Mody
2010-08-25  7:35   ` David Miller
2010-08-25 20:59     ` David Miller
2010-08-25 21:53       ` Rasesh Mody
2010-08-25 21:53         ` Rasesh Mody
2010-08-26  1:05       ` Stephen Rothwell
2010-08-23  3:27 Stephen Rothwell
2010-08-23  3:27 ` Stephen Rothwell
2010-08-23  3:31 ` David Miller
2010-07-29  4:13 Stephen Rothwell
2010-07-29  4:13 ` Stephen Rothwell
2010-07-29  5:21 ` David Miller
2010-04-27  5:25 Stephen Rothwell
2010-04-27  5:25 ` Stephen Rothwell
2010-04-27 16:34 ` David Miller
2010-04-27 17:18   ` David Miller
2010-04-28  1:11     ` Stephen Rothwell
2010-03-29  6:43 Stephen Rothwell
2010-03-29  6:43 ` Stephen Rothwell
2010-03-29  6:52 ` Eric Dumazet
2010-03-29  6:59   ` Eric Dumazet
2010-03-29  8:01     ` David Miller
2010-03-29  8:04       ` Stephen Rothwell
2010-03-29  7:01   ` Stephen Rothwell
2010-03-18  4:23 Stephen Rothwell
2010-03-18  4:23 ` Stephen Rothwell
2010-03-18  6:23 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110421.151925.226786245.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.