From: Stephen Rothwell <sfr@canb.auug.org.au> To: David Miller <davem@davemloft.net>, <netdev@vger.kernel.org> Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Glauber Costa <glommer@parallels.com> Subject: linux-next: build failure after merge of the final tree (net tree related) Date: Mon, 9 Jan 2012 16:38:12 +1100 [thread overview] Message-ID: <20120109163812.4cb695944ea9716953afbfc9@canb.auug.org.au> (raw) [-- Attachment #1: Type: text/plain, Size: 2834 bytes --] Hi , After merging the final tree, today's linux-next build (powerpc allnoconfig) failed like this: In file included from include/linux/tcp.h:211:0, from include/linux/ipv6.h:221, from include/net/ipv6.h:16, from include/linux/sunrpc/clnt.h:26, from include/linux/nfs_fs.h:50, from init/do_mounts.c:20: include/net/sock.h: In function 'sk_update_clone': include/net/sock.h:1109:3: error: implicit declaration of function 'sock_update_memcg' [-Werror=implicit-function-declaration] Caused by commit f3f511e1ce6f ("net: fix sock_clone reference mismatch with tcp memcontrol") from the net tree. In this build, CONFIG_INET is not set. I applied the following patch for today: From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Mon, 9 Jan 2012 16:33:16 +1100 Subject: [PATCH] net: sk_update_clone is only used in net/core/sock.c so move it there. Fixes build errors when CONFIG_INET is not defeined: In file included from include/linux/tcp.h:211:0, from include/linux/ipv6.h:221, from include/net/ipv6.h:16, from include/linux/sunrpc/clnt.h:26, from include/linux/nfs_fs.h:50, from init/do_mounts.c:20: include/net/sock.h: In function 'sk_update_clone': include/net/sock.h:1109:3: error: implicit declaration of function 'sock_update_memcg' [-Werror=implicit-function-declaration] Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- include/net/sock.h | 6 ------ net/core/sock.c | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index 0ed65e3..bb972d2 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -1103,12 +1103,6 @@ sk_sockets_allocated_read_positive(struct sock *sk) return percpu_counter_sum_positive(prot->sockets_allocated); } -static inline void sk_update_clone(const struct sock *sk, struct sock *newsk) -{ - if (mem_cgroup_sockets_enabled && sk->sk_cgrp) - sock_update_memcg(newsk); -} - static inline int proto_sockets_allocated_sum_positive(struct proto *prot) { diff --git a/net/core/sock.c b/net/core/sock.c index e80b64f..c3ae73d 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1272,6 +1272,12 @@ void sk_release_kernel(struct sock *sk) } EXPORT_SYMBOL(sk_release_kernel); +static void sk_update_clone(const struct sock *sk, struct sock *newsk) +{ + if (mem_cgroup_sockets_enabled && sk->sk_cgrp) + sock_update_memcg(newsk); +} + /** * sk_clone_lock - clone a socket, and lock its clone * @sk: the socket to clone -- 1.7.8.197.g73c6b -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au> To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Glauber Costa <glommer@parallels.com> Subject: linux-next: build failure after merge of the final tree (net tree related) Date: Mon, 9 Jan 2012 16:38:12 +1100 [thread overview] Message-ID: <20120109163812.4cb695944ea9716953afbfc9@canb.auug.org.au> (raw) [-- Attachment #1: Type: text/plain, Size: 2834 bytes --] Hi , After merging the final tree, today's linux-next build (powerpc allnoconfig) failed like this: In file included from include/linux/tcp.h:211:0, from include/linux/ipv6.h:221, from include/net/ipv6.h:16, from include/linux/sunrpc/clnt.h:26, from include/linux/nfs_fs.h:50, from init/do_mounts.c:20: include/net/sock.h: In function 'sk_update_clone': include/net/sock.h:1109:3: error: implicit declaration of function 'sock_update_memcg' [-Werror=implicit-function-declaration] Caused by commit f3f511e1ce6f ("net: fix sock_clone reference mismatch with tcp memcontrol") from the net tree. In this build, CONFIG_INET is not set. I applied the following patch for today: From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Mon, 9 Jan 2012 16:33:16 +1100 Subject: [PATCH] net: sk_update_clone is only used in net/core/sock.c so move it there. Fixes build errors when CONFIG_INET is not defeined: In file included from include/linux/tcp.h:211:0, from include/linux/ipv6.h:221, from include/net/ipv6.h:16, from include/linux/sunrpc/clnt.h:26, from include/linux/nfs_fs.h:50, from init/do_mounts.c:20: include/net/sock.h: In function 'sk_update_clone': include/net/sock.h:1109:3: error: implicit declaration of function 'sock_update_memcg' [-Werror=implicit-function-declaration] Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- include/net/sock.h | 6 ------ net/core/sock.c | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index 0ed65e3..bb972d2 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -1103,12 +1103,6 @@ sk_sockets_allocated_read_positive(struct sock *sk) return percpu_counter_sum_positive(prot->sockets_allocated); } -static inline void sk_update_clone(const struct sock *sk, struct sock *newsk) -{ - if (mem_cgroup_sockets_enabled && sk->sk_cgrp) - sock_update_memcg(newsk); -} - static inline int proto_sockets_allocated_sum_positive(struct proto *prot) { diff --git a/net/core/sock.c b/net/core/sock.c index e80b64f..c3ae73d 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1272,6 +1272,12 @@ void sk_release_kernel(struct sock *sk) } EXPORT_SYMBOL(sk_release_kernel); +static void sk_update_clone(const struct sock *sk, struct sock *newsk) +{ + if (mem_cgroup_sockets_enabled && sk->sk_cgrp) + sock_update_memcg(newsk); +} + /** * sk_clone_lock - clone a socket, and lock its clone * @sk: the socket to clone -- 1.7.8.197.g73c6b -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2012-01-09 5:38 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-01-09 5:38 Stephen Rothwell [this message] 2012-01-09 5:38 ` linux-next: build failure after merge of the final tree (net tree related) Stephen Rothwell 2012-01-09 6:52 ` David Miller 2012-01-16 7:36 ` Glauber Costa 2012-01-16 7:36 ` Glauber Costa -- strict thread matches above, loose matches on Subject: below -- 2011-12-22 6:07 Stephen Rothwell 2011-12-22 6:07 ` Stephen Rothwell 2011-12-22 6:16 ` Eric Dumazet 2011-12-22 7:01 ` David Miller 2011-11-02 5:37 Stephen Rothwell 2011-11-02 5:37 ` Stephen Rothwell 2011-11-02 5:50 ` David Miller 2011-08-15 5:20 Stephen Rothwell 2011-08-15 5:56 ` David Miller 2011-08-16 5:28 ` Stephen Rothwell 2011-08-16 6:11 ` David Miller 2011-08-16 6:57 ` Stephen Rothwell 2011-08-16 7:17 ` David Miller 2011-06-23 5:29 Stephen Rothwell 2011-06-23 5:29 ` Stephen Rothwell 2011-06-23 13:04 ` Alexey Dobriyan 2011-06-27 5:29 ` Stephen Rothwell 2011-06-29 6:09 ` Stephen Rothwell 2011-06-29 9:58 ` David Miller 2011-06-23 5:25 Stephen Rothwell 2011-06-23 5:25 ` Stephen Rothwell 2011-06-27 5:35 ` Stephen Rothwell 2011-06-27 5:35 ` Stephen Rothwell 2011-06-29 6:01 ` Stephen Rothwell 2011-06-29 6:01 ` Stephen Rothwell 2011-06-29 9:56 ` David Miller 2011-06-08 5:54 Stephen Rothwell 2011-06-08 5:54 ` Stephen Rothwell 2011-06-08 7:16 ` David Miller 2011-04-21 22:10 Stephen Rothwell 2011-04-21 22:10 ` Stephen Rothwell 2011-04-21 22:19 ` David Miller 2011-02-03 4:13 Stephen Rothwell 2011-02-03 4:13 ` Stephen Rothwell 2011-02-03 4:46 ` David Miller 2011-02-03 5:14 ` Stephen Rothwell 2010-11-15 0:46 Stephen Rothwell 2010-11-15 0:46 ` Stephen Rothwell 2010-11-15 16:52 ` David Miller 2010-11-15 16:58 ` Eric Dumazet 2010-10-18 7:36 Stephen Rothwell 2010-10-18 7:36 ` Stephen Rothwell 2010-10-18 8:06 ` David Miller 2010-09-27 5:44 Stephen Rothwell 2010-09-27 5:44 ` Stephen Rothwell 2010-09-27 8:17 ` David Miller 2010-09-27 15:55 ` Ohad Ben-Cohen 2010-09-27 15:55 ` Ohad Ben-Cohen 2010-09-27 18:04 ` John W. Linville 2010-09-27 18:18 ` David Miller 2010-09-27 18:25 ` John W. Linville 2010-09-27 18:38 ` Ohad Ben-Cohen 2010-09-27 18:44 ` John W. Linville 2010-09-27 19:01 ` Ohad Ben-Cohen 2010-09-27 19:06 ` Ohad Ben-Cohen 2010-09-27 19:44 ` John W. Linville 2010-09-27 19:44 ` John W. Linville 2010-09-27 20:18 ` Ohad Ben-Cohen 2010-09-03 1:47 Stephen Rothwell 2010-09-03 1:47 ` Stephen Rothwell 2010-09-03 1:52 ` Stephen Rothwell 2010-09-03 1:52 ` Stephen Rothwell 2010-09-03 2:16 ` David Miller 2010-09-03 2:14 ` David Miller 2010-08-31 3:18 Stephen Rothwell 2010-08-31 3:18 ` Stephen Rothwell 2010-08-31 4:43 ` David Miller 2010-08-30 3:04 Stephen Rothwell 2010-08-30 3:04 ` Stephen Rothwell 2010-08-30 3:29 ` Simon Horman 2010-08-30 4:23 ` David Miller 2010-08-25 2:09 Stephen Rothwell 2010-08-25 2:09 ` Stephen Rothwell 2010-08-25 4:22 ` Rasesh Mody 2010-08-25 7:35 ` David Miller 2010-08-25 20:59 ` David Miller 2010-08-25 21:53 ` Rasesh Mody 2010-08-25 21:53 ` Rasesh Mody 2010-08-26 1:05 ` Stephen Rothwell 2010-08-23 3:27 Stephen Rothwell 2010-08-23 3:27 ` Stephen Rothwell 2010-08-23 3:31 ` David Miller 2010-07-29 4:13 Stephen Rothwell 2010-07-29 4:13 ` Stephen Rothwell 2010-07-29 5:21 ` David Miller 2010-04-27 5:25 Stephen Rothwell 2010-04-27 5:25 ` Stephen Rothwell 2010-04-27 16:34 ` David Miller 2010-04-27 17:18 ` David Miller 2010-04-28 1:11 ` Stephen Rothwell 2010-03-29 6:43 Stephen Rothwell 2010-03-29 6:43 ` Stephen Rothwell 2010-03-29 6:52 ` Eric Dumazet 2010-03-29 6:59 ` Eric Dumazet 2010-03-29 8:01 ` David Miller 2010-03-29 8:04 ` Stephen Rothwell 2010-03-29 7:01 ` Stephen Rothwell 2010-03-18 4:23 Stephen Rothwell 2010-03-18 4:23 ` Stephen Rothwell 2010-03-18 6:23 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120109163812.4cb695944ea9716953afbfc9@canb.auug.org.au \ --to=sfr@canb.auug.org.au \ --cc=davem@davemloft.net \ --cc=glommer@parallels.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.