From: Felipe Balbi <balbi@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: "Paul Walmsley" <paul@pwsan.com>, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Tero Kristo" <t-kristo@ti.com>, "Benoît Cousson" <b-cousson@ti.com>, "Felipe Balbi" <balbi@ti.com> Subject: Re: [PATCHv2 09/12] ARM: OMAP2+: usb_host_fs: add custom setup_preprogram for usb_host_fs (fsusb) Date: Mon, 11 Jun 2012 10:13:02 +0300 [thread overview] Message-ID: <20120611071301.GC6845@arwen.pp.htv.fi> (raw) In-Reply-To: <20120611063416.GT12766@atomide.com> [-- Attachment #1: Type: text/plain, Size: 3276 bytes --] On Sun, Jun 10, 2012 at 11:34:17PM -0700, Tony Lindgren wrote: > Hi, > > Similar comments to the asess patch on this one below. > > * Paul Walmsley <paul@pwsan.com> [120610 17:57]: > > --- /dev/null > > +++ b/include/linux/platform_data/fsusb.h > > This would be better as include/linux/platform_data/omap-usb.h. > > > +#include <plat/omap_hwmod.h> > > This include should not be needed here if the hwmod function is > a static function in the some hwmod*.c file. > > > +/* HCCOMMANDSTATUS: the register offset of the HCCOMMANDSTATUS register */ > > +#define HCCOMMANDSTATUS 0x0008 > > + > > +/* HCCOMMANDSTATUS_HCR: the bitmask of the host controller reset flag */ > > +#define HCCOMMANDSTATUS_HCR_MASK (1 << 0) > > I think these already have standard defines in some OHCI header? > Felipe may be able to comment more on this? Well, yeah... but it's defined on drivers/usb/host/ohci.h and it's actually a structure: | /* | * This is the structure of the OHCI controller's memory mapped I/O region. | * You must use readl() and writel() (in <asm/io.h>) to access these fields!! | * Layout is in section 7 (and appendix B) of the spec. | */ | struct ohci_regs { | /* control and status registers (section 7.1) */ | __hc32 revision; | __hc32 control; | __hc32 cmdstatus; | __hc32 intrstatus; | __hc32 intrenable; | __hc32 intrdisable; | | /* memory pointers (section 7.2) */ | __hc32 hcca; | __hc32 ed_periodcurrent; | __hc32 ed_controlhead; | __hc32 ed_controlcurrent; | __hc32 ed_bulkhead; | __hc32 ed_bulkcurrent; | __hc32 donehead; | | /* frame counters (section 7.3) */ | __hc32 fminterval; | __hc32 fmremaining; | __hc32 fmnumber; | __hc32 periodicstart; | __hc32 lsthresh; | | /* Root hub ports (section 7.4) */ | struct ohci_roothub_regs { | __hc32 a; | __hc32 b; | __hc32 status; | #define MAX_ROOT_PORTS 15 /* maximum OHCI root hub ports (RH_A_NDP) */ | __hc32 portstatus [MAX_ROOT_PORTS]; | } roothub; | | /* and optional "legacy support" registers (appendix B) at 0x0100 */ | | } __attribute__ ((aligned(32))); [...] | /* | * HcCommandStatus (cmdstatus) register masks | */ | #define OHCI_HCR (1 << 0) /* host controller reset */ | #define OHCI_CLF (1 << 1) /* control list filled */ | #define OHCI_BLF (1 << 2) /* bulk list filled */ | #define OHCI_OCR (1 << 3) /* ownership change request */ | #define OHCI_SOC (3 << 16) /* scheduling overrun count */ > > +static int fsusb_reset_host_controller(const char *name, void __iomem *base) > > +{ > > + int i; > > + > > + writel(HCCOMMANDSTATUS_HCR_MASK, base + HCCOMMANDSTATUS); > > + > > + for (i = 0; i < MAX_FSUSB_HCR_TIME; i++) { > > + if (!(readl(base + HCCOMMANDSTATUS) & HCCOMMANDSTATUS_HCR_MASK)) > > + break; > > + udelay(1); > > + } > > + > > + if (i == MAX_FSUSB_HCR_TIME) { > > + pr_warn("%s: %s: host controller reset failed (waited %d usec)\n", > > + __func__, name, MAX_FSUSB_HCR_TIME); > > + return -EBUSY; > > + } > > + > > + return 0; > > +} > > This should be "static inline int fsusb_reset_host_controller" as it's > in a header. why is it even in a header ? Only hwmod_fsusb_preprogram() will use it anyway. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv2 09/12] ARM: OMAP2+: usb_host_fs: add custom setup_preprogram for usb_host_fs (fsusb) Date: Mon, 11 Jun 2012 10:13:02 +0300 [thread overview] Message-ID: <20120611071301.GC6845@arwen.pp.htv.fi> (raw) In-Reply-To: <20120611063416.GT12766@atomide.com> On Sun, Jun 10, 2012 at 11:34:17PM -0700, Tony Lindgren wrote: > Hi, > > Similar comments to the asess patch on this one below. > > * Paul Walmsley <paul@pwsan.com> [120610 17:57]: > > --- /dev/null > > +++ b/include/linux/platform_data/fsusb.h > > This would be better as include/linux/platform_data/omap-usb.h. > > > +#include <plat/omap_hwmod.h> > > This include should not be needed here if the hwmod function is > a static function in the some hwmod*.c file. > > > +/* HCCOMMANDSTATUS: the register offset of the HCCOMMANDSTATUS register */ > > +#define HCCOMMANDSTATUS 0x0008 > > + > > +/* HCCOMMANDSTATUS_HCR: the bitmask of the host controller reset flag */ > > +#define HCCOMMANDSTATUS_HCR_MASK (1 << 0) > > I think these already have standard defines in some OHCI header? > Felipe may be able to comment more on this? Well, yeah... but it's defined on drivers/usb/host/ohci.h and it's actually a structure: | /* | * This is the structure of the OHCI controller's memory mapped I/O region. | * You must use readl() and writel() (in <asm/io.h>) to access these fields!! | * Layout is in section 7 (and appendix B) of the spec. | */ | struct ohci_regs { | /* control and status registers (section 7.1) */ | __hc32 revision; | __hc32 control; | __hc32 cmdstatus; | __hc32 intrstatus; | __hc32 intrenable; | __hc32 intrdisable; | | /* memory pointers (section 7.2) */ | __hc32 hcca; | __hc32 ed_periodcurrent; | __hc32 ed_controlhead; | __hc32 ed_controlcurrent; | __hc32 ed_bulkhead; | __hc32 ed_bulkcurrent; | __hc32 donehead; | | /* frame counters (section 7.3) */ | __hc32 fminterval; | __hc32 fmremaining; | __hc32 fmnumber; | __hc32 periodicstart; | __hc32 lsthresh; | | /* Root hub ports (section 7.4) */ | struct ohci_roothub_regs { | __hc32 a; | __hc32 b; | __hc32 status; | #define MAX_ROOT_PORTS 15 /* maximum OHCI root hub ports (RH_A_NDP) */ | __hc32 portstatus [MAX_ROOT_PORTS]; | } roothub; | | /* and optional "legacy support" registers (appendix B) at 0x0100 */ | | } __attribute__ ((aligned(32))); [...] | /* | * HcCommandStatus (cmdstatus) register masks | */ | #define OHCI_HCR (1 << 0) /* host controller reset */ | #define OHCI_CLF (1 << 1) /* control list filled */ | #define OHCI_BLF (1 << 2) /* bulk list filled */ | #define OHCI_OCR (1 << 3) /* ownership change request */ | #define OHCI_SOC (3 << 16) /* scheduling overrun count */ > > +static int fsusb_reset_host_controller(const char *name, void __iomem *base) > > +{ > > + int i; > > + > > + writel(HCCOMMANDSTATUS_HCR_MASK, base + HCCOMMANDSTATUS); > > + > > + for (i = 0; i < MAX_FSUSB_HCR_TIME; i++) { > > + if (!(readl(base + HCCOMMANDSTATUS) & HCCOMMANDSTATUS_HCR_MASK)) > > + break; > > + udelay(1); > > + } > > + > > + if (i == MAX_FSUSB_HCR_TIME) { > > + pr_warn("%s: %s: host controller reset failed (waited %d usec)\n", > > + __func__, name, MAX_FSUSB_HCR_TIME); > > + return -EBUSY; > > + } > > + > > + return 0; > > +} > > This should be "static inline int fsusb_reset_host_controller" as it's > in a header. why is it even in a header ? Only hwmod_fsusb_preprogram() will use it anyway. -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120611/eb35b2f2/attachment.sig>
next prev parent reply other threads:[~2012-06-11 7:20 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-11 0:45 [PATCHv2 00/12] ARM: OMAP: core/hwmod: first set of fixes for 3.5-rc Paul Walmsley 2012-06-11 0:45 ` Paul Walmsley 2012-06-11 0:45 ` [PATCHv2 01/12] ARM: OMAP: PM: Lock clocks list while generating summary Paul Walmsley 2012-06-11 0:45 ` Paul Walmsley 2012-06-11 0:45 ` [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer Paul Walmsley 2012-06-11 0:45 ` Paul Walmsley 2012-06-14 16:47 ` Cousson, Benoit 2012-06-14 16:47 ` Cousson, Benoit 2012-06-14 18:04 ` Paul Walmsley 2012-06-14 18:04 ` Paul Walmsley 2012-06-14 20:13 ` Cousson, Benoit 2012-06-14 20:13 ` Cousson, Benoit 2012-06-15 0:18 ` Paul Walmsley 2012-06-15 0:18 ` Paul Walmsley 2012-06-15 13:28 ` Cousson, Benoit 2012-06-15 13:28 ` Cousson, Benoit 2012-07-04 12:48 ` Paul Walmsley 2012-07-04 12:48 ` Paul Walmsley 2012-07-04 12:53 ` Paul Walmsley 2012-07-04 12:53 ` Paul Walmsley 2012-07-04 14:27 ` Kevin Hilman 2012-07-04 14:27 ` Kevin Hilman 2012-07-04 14:53 ` Paul Walmsley 2012-07-04 14:53 ` Paul Walmsley 2012-07-04 16:14 ` Benoit Cousson 2012-07-04 16:14 ` Benoit Cousson 2012-07-04 16:41 ` Tero Kristo 2012-07-04 16:41 ` Tero Kristo 2012-07-04 16:43 ` Benoit Cousson 2012-07-04 16:43 ` Benoit Cousson 2012-07-04 19:02 ` Paul Walmsley 2012-07-04 19:02 ` Paul Walmsley 2012-07-04 16:57 ` Benoit Cousson 2012-07-04 16:57 ` Benoit Cousson 2012-07-04 18:59 ` Paul Walmsley 2012-07-04 18:59 ` Paul Walmsley 2012-07-05 22:06 ` Kevin Hilman 2012-07-05 22:06 ` Kevin Hilman 2012-07-04 16:01 ` Benoit Cousson 2012-07-04 16:01 ` Benoit Cousson 2012-07-04 19:05 ` Paul Walmsley 2012-07-04 19:05 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 03/12] ARM: OMAP4+: hwmod: fix issue causing IPs not going back to Smart-Standby Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 04/12] ARM: OMAP4: hwmod data: fix 32k sync timer idle modes Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 9:31 ` Cousson, Benoit 2012-06-11 9:31 ` Cousson, Benoit 2012-06-13 17:22 ` Paul Walmsley 2012-06-13 17:22 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 05/12] ARM: OMAP2+: hwmod: add setup_preprogram hook Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 06/12] ARM: OMAP2+: hwmod: add flag to prevent hwmod code from touching IP block during init Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 07/12] ARM: OMAP4+: AESS: enable internal auto-gating during initial setup Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 6:29 ` Tony Lindgren 2012-06-11 6:29 ` Tony Lindgren 2012-06-14 9:49 ` Paul Walmsley 2012-06-14 9:49 ` Paul Walmsley 2012-06-14 9:59 ` Tony Lindgren 2012-06-14 9:59 ` Tony Lindgren 2012-06-11 0:46 ` [PATCHv2 08/12] ARM: OMAP4: hwmod data: add SL2IF hardreset line Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-14 12:55 ` Cousson, Benoit 2012-06-14 12:55 ` Cousson, Benoit 2012-06-14 17:09 ` Paul Walmsley 2012-06-14 17:09 ` Paul Walmsley 2012-06-14 21:07 ` Cousson, Benoit 2012-06-14 21:07 ` Cousson, Benoit 2012-06-14 23:02 ` Paul Walmsley 2012-06-14 23:02 ` Paul Walmsley 2012-06-15 9:11 ` Cousson, Benoit 2012-06-15 9:11 ` Cousson, Benoit 2012-06-11 0:46 ` [PATCHv2 09/12] ARM: OMAP2+: usb_host_fs: add custom setup_preprogram for usb_host_fs (fsusb) Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 6:34 ` Tony Lindgren 2012-06-11 6:34 ` Tony Lindgren 2012-06-11 7:13 ` Felipe Balbi [this message] 2012-06-11 7:13 ` Felipe Balbi 2012-06-11 7:41 ` Tony Lindgren 2012-06-11 7:41 ` Tony Lindgren 2012-06-11 7:48 ` Felipe Balbi 2012-06-11 7:48 ` Felipe Balbi 2012-06-11 8:03 ` Tony Lindgren 2012-06-11 8:03 ` Tony Lindgren 2012-06-11 9:12 ` Felipe Balbi 2012-06-11 9:12 ` Felipe Balbi 2012-06-11 0:46 ` [PATCHv2 10/12] ARM: OMAP2+: CM: increase the module disable timeout Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 11/12] ARM: OMAP4: clock data: add clockdomains for clocks used as main clocks Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 16:28 ` Cousson, Benoit 2012-06-11 16:28 ` Cousson, Benoit 2012-06-11 16:59 ` Paul Walmsley 2012-06-11 16:59 ` Paul Walmsley 2012-06-11 20:15 ` Cousson, Benoit 2012-06-11 20:15 ` Cousson, Benoit 2012-06-11 0:46 ` [PATCHv2 12/12] ARM: OMAP4: hwmod data: do not enable or reset the McPDM during kernel init Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 9:54 ` Cousson, Benoit 2012-06-11 9:54 ` Cousson, Benoit 2012-10-30 4:05 ` Paul Walmsley 2012-10-30 4:05 ` Paul Walmsley 2012-10-30 7:41 ` Péter Ujfalusi 2012-10-30 7:41 ` Péter Ujfalusi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120611071301.GC6845@arwen.pp.htv.fi \ --to=balbi@ti.com \ --cc=b-cousson@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=t-kristo@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.