From: "Cousson, Benoit" <b-cousson@ti.com> To: Paul Walmsley <paul@pwsan.com> Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tero Kristo <t-kristo@ti.com> Subject: Re: [PATCHv2 08/12] ARM: OMAP4: hwmod data: add SL2IF hardreset line Date: Thu, 14 Jun 2012 14:55:06 +0200 [thread overview] Message-ID: <4FD9DF2A.3010000@ti.com> (raw) In-Reply-To: <20120611004614.20034.50895.stgit@dusk> Hi Paul, On 6/11/2012 2:46 AM, Paul Walmsley wrote: > On boot, the sl2if module can't be enabled. The following message is > logged: > > omap_hwmod: sl2if: cannot be enabled for reset (3) > > This is probably because the SL2IF is still being held in hardreset. > The SL2IF's hardreset line is shared with one of the IVAHD's hardreset > lines; see for example Table 3-536 "RM_IVAHD_RSTCTRL" in the OMAP4430 > TRM Rev. AA (SWPU231AA). To work around this, add the SL2IF's > hardreset line to the hwmod data. This is correct from a hardware > perspective and also will prevent the hwmod from attempting to enable > the SL2IF during reset. The driver for this IP block will need to > handle its integration until the appropriate way to handle the IVAHD > integration can be elucidated. I don't think we should allow that at hwmod level. This line is already handled by the IVAHD hwmod. We will then have some potential issue since nothing will prevent the concurrent access. Moreover that IP is only used by the IVAHD and thus should be handled by the same driver. The SL2 being inside the IVA subsystem, it should be reset when the IVA will be reset and thus does not require an individual control. I guess, we should just mark the dependency with some external power resource to avoid the fmwk to try to enable that automatically. It is similar to DSS sub IPs and to some extend McPDM for my point of view. Maybe we should rename HWMOD_EXT_OPT_MAIN_CLK with something more generic like HWMOD_EXT_POWER_DEP to highlight the dependency with an external resource. It can be a external clock or another module. Regards, Benoit > Signed-off-by: Paul Walmsley <paul@pwsan.com> > Cc: Tero Kristo <t-kristo@ti.com> > --- > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > index 7700d6d..037424f 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > @@ -2597,15 +2597,22 @@ static struct omap_hwmod_class omap44xx_sl2if_hwmod_class = { > .name = "sl2if", > }; > > +static struct omap_hwmod_rst_info omap44xx_sl2if_resets[] = { > + { .name = "logic", .rst_shift = 2 }, > +}; > + > /* sl2if */ > static struct omap_hwmod omap44xx_sl2if_hwmod = { > .name = "sl2if", > .class = &omap44xx_sl2if_hwmod_class, > .clkdm_name = "ivahd_clkdm", > + .rst_lines = omap44xx_sl2if_resets, > + .rst_lines_cnt = ARRAY_SIZE(omap44xx_sl2if_resets), > .prcm = { > .omap4 = { > .clkctrl_offs = OMAP4_CM_IVAHD_SL2_CLKCTRL_OFFSET, > .context_offs = OMAP4_RM_IVAHD_SL2_CONTEXT_OFFSET, > + .rstctrl_offs = OMAP4_RM_IVAHD_RSTCTRL_OFFSET, > .modulemode = MODULEMODE_HWCTRL, > }, > }, > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv2 08/12] ARM: OMAP4: hwmod data: add SL2IF hardreset line Date: Thu, 14 Jun 2012 14:55:06 +0200 [thread overview] Message-ID: <4FD9DF2A.3010000@ti.com> (raw) In-Reply-To: <20120611004614.20034.50895.stgit@dusk> Hi Paul, On 6/11/2012 2:46 AM, Paul Walmsley wrote: > On boot, the sl2if module can't be enabled. The following message is > logged: > > omap_hwmod: sl2if: cannot be enabled for reset (3) > > This is probably because the SL2IF is still being held in hardreset. > The SL2IF's hardreset line is shared with one of the IVAHD's hardreset > lines; see for example Table 3-536 "RM_IVAHD_RSTCTRL" in the OMAP4430 > TRM Rev. AA (SWPU231AA). To work around this, add the SL2IF's > hardreset line to the hwmod data. This is correct from a hardware > perspective and also will prevent the hwmod from attempting to enable > the SL2IF during reset. The driver for this IP block will need to > handle its integration until the appropriate way to handle the IVAHD > integration can be elucidated. I don't think we should allow that at hwmod level. This line is already handled by the IVAHD hwmod. We will then have some potential issue since nothing will prevent the concurrent access. Moreover that IP is only used by the IVAHD and thus should be handled by the same driver. The SL2 being inside the IVA subsystem, it should be reset when the IVA will be reset and thus does not require an individual control. I guess, we should just mark the dependency with some external power resource to avoid the fmwk to try to enable that automatically. It is similar to DSS sub IPs and to some extend McPDM for my point of view. Maybe we should rename HWMOD_EXT_OPT_MAIN_CLK with something more generic like HWMOD_EXT_POWER_DEP to highlight the dependency with an external resource. It can be a external clock or another module. Regards, Benoit > Signed-off-by: Paul Walmsley <paul@pwsan.com> > Cc: Tero Kristo <t-kristo@ti.com> > --- > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > index 7700d6d..037424f 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > @@ -2597,15 +2597,22 @@ static struct omap_hwmod_class omap44xx_sl2if_hwmod_class = { > .name = "sl2if", > }; > > +static struct omap_hwmod_rst_info omap44xx_sl2if_resets[] = { > + { .name = "logic", .rst_shift = 2 }, > +}; > + > /* sl2if */ > static struct omap_hwmod omap44xx_sl2if_hwmod = { > .name = "sl2if", > .class = &omap44xx_sl2if_hwmod_class, > .clkdm_name = "ivahd_clkdm", > + .rst_lines = omap44xx_sl2if_resets, > + .rst_lines_cnt = ARRAY_SIZE(omap44xx_sl2if_resets), > .prcm = { > .omap4 = { > .clkctrl_offs = OMAP4_CM_IVAHD_SL2_CLKCTRL_OFFSET, > .context_offs = OMAP4_RM_IVAHD_SL2_CONTEXT_OFFSET, > + .rstctrl_offs = OMAP4_RM_IVAHD_RSTCTRL_OFFSET, > .modulemode = MODULEMODE_HWCTRL, > }, > }, > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2012-06-14 12:55 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-11 0:45 [PATCHv2 00/12] ARM: OMAP: core/hwmod: first set of fixes for 3.5-rc Paul Walmsley 2012-06-11 0:45 ` Paul Walmsley 2012-06-11 0:45 ` [PATCHv2 01/12] ARM: OMAP: PM: Lock clocks list while generating summary Paul Walmsley 2012-06-11 0:45 ` Paul Walmsley 2012-06-11 0:45 ` [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer Paul Walmsley 2012-06-11 0:45 ` Paul Walmsley 2012-06-14 16:47 ` Cousson, Benoit 2012-06-14 16:47 ` Cousson, Benoit 2012-06-14 18:04 ` Paul Walmsley 2012-06-14 18:04 ` Paul Walmsley 2012-06-14 20:13 ` Cousson, Benoit 2012-06-14 20:13 ` Cousson, Benoit 2012-06-15 0:18 ` Paul Walmsley 2012-06-15 0:18 ` Paul Walmsley 2012-06-15 13:28 ` Cousson, Benoit 2012-06-15 13:28 ` Cousson, Benoit 2012-07-04 12:48 ` Paul Walmsley 2012-07-04 12:48 ` Paul Walmsley 2012-07-04 12:53 ` Paul Walmsley 2012-07-04 12:53 ` Paul Walmsley 2012-07-04 14:27 ` Kevin Hilman 2012-07-04 14:27 ` Kevin Hilman 2012-07-04 14:53 ` Paul Walmsley 2012-07-04 14:53 ` Paul Walmsley 2012-07-04 16:14 ` Benoit Cousson 2012-07-04 16:14 ` Benoit Cousson 2012-07-04 16:41 ` Tero Kristo 2012-07-04 16:41 ` Tero Kristo 2012-07-04 16:43 ` Benoit Cousson 2012-07-04 16:43 ` Benoit Cousson 2012-07-04 19:02 ` Paul Walmsley 2012-07-04 19:02 ` Paul Walmsley 2012-07-04 16:57 ` Benoit Cousson 2012-07-04 16:57 ` Benoit Cousson 2012-07-04 18:59 ` Paul Walmsley 2012-07-04 18:59 ` Paul Walmsley 2012-07-05 22:06 ` Kevin Hilman 2012-07-05 22:06 ` Kevin Hilman 2012-07-04 16:01 ` Benoit Cousson 2012-07-04 16:01 ` Benoit Cousson 2012-07-04 19:05 ` Paul Walmsley 2012-07-04 19:05 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 03/12] ARM: OMAP4+: hwmod: fix issue causing IPs not going back to Smart-Standby Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 04/12] ARM: OMAP4: hwmod data: fix 32k sync timer idle modes Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 9:31 ` Cousson, Benoit 2012-06-11 9:31 ` Cousson, Benoit 2012-06-13 17:22 ` Paul Walmsley 2012-06-13 17:22 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 05/12] ARM: OMAP2+: hwmod: add setup_preprogram hook Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 06/12] ARM: OMAP2+: hwmod: add flag to prevent hwmod code from touching IP block during init Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 07/12] ARM: OMAP4+: AESS: enable internal auto-gating during initial setup Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 6:29 ` Tony Lindgren 2012-06-11 6:29 ` Tony Lindgren 2012-06-14 9:49 ` Paul Walmsley 2012-06-14 9:49 ` Paul Walmsley 2012-06-14 9:59 ` Tony Lindgren 2012-06-14 9:59 ` Tony Lindgren 2012-06-11 0:46 ` [PATCHv2 08/12] ARM: OMAP4: hwmod data: add SL2IF hardreset line Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-14 12:55 ` Cousson, Benoit [this message] 2012-06-14 12:55 ` Cousson, Benoit 2012-06-14 17:09 ` Paul Walmsley 2012-06-14 17:09 ` Paul Walmsley 2012-06-14 21:07 ` Cousson, Benoit 2012-06-14 21:07 ` Cousson, Benoit 2012-06-14 23:02 ` Paul Walmsley 2012-06-14 23:02 ` Paul Walmsley 2012-06-15 9:11 ` Cousson, Benoit 2012-06-15 9:11 ` Cousson, Benoit 2012-06-11 0:46 ` [PATCHv2 09/12] ARM: OMAP2+: usb_host_fs: add custom setup_preprogram for usb_host_fs (fsusb) Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 6:34 ` Tony Lindgren 2012-06-11 6:34 ` Tony Lindgren 2012-06-11 7:13 ` Felipe Balbi 2012-06-11 7:13 ` Felipe Balbi 2012-06-11 7:41 ` Tony Lindgren 2012-06-11 7:41 ` Tony Lindgren 2012-06-11 7:48 ` Felipe Balbi 2012-06-11 7:48 ` Felipe Balbi 2012-06-11 8:03 ` Tony Lindgren 2012-06-11 8:03 ` Tony Lindgren 2012-06-11 9:12 ` Felipe Balbi 2012-06-11 9:12 ` Felipe Balbi 2012-06-11 0:46 ` [PATCHv2 10/12] ARM: OMAP2+: CM: increase the module disable timeout Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 0:46 ` [PATCHv2 11/12] ARM: OMAP4: clock data: add clockdomains for clocks used as main clocks Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 16:28 ` Cousson, Benoit 2012-06-11 16:28 ` Cousson, Benoit 2012-06-11 16:59 ` Paul Walmsley 2012-06-11 16:59 ` Paul Walmsley 2012-06-11 20:15 ` Cousson, Benoit 2012-06-11 20:15 ` Cousson, Benoit 2012-06-11 0:46 ` [PATCHv2 12/12] ARM: OMAP4: hwmod data: do not enable or reset the McPDM during kernel init Paul Walmsley 2012-06-11 0:46 ` Paul Walmsley 2012-06-11 9:54 ` Cousson, Benoit 2012-06-11 9:54 ` Cousson, Benoit 2012-10-30 4:05 ` Paul Walmsley 2012-10-30 4:05 ` Paul Walmsley 2012-10-30 7:41 ` Péter Ujfalusi 2012-10-30 7:41 ` Péter Ujfalusi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4FD9DF2A.3010000@ti.com \ --to=b-cousson@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=t-kristo@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.