From: Paul Walmsley <paul@pwsan.com>
To: "Cousson, Benoit" <b-cousson@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCHv2 08/12] ARM: OMAP4: hwmod data: add SL2IF hardreset line
Date: Thu, 14 Jun 2012 11:09:58 -0600 (MDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206141052240.30212@utopia.booyaka.com> (raw)
In-Reply-To: <4FD9DF2A.3010000@ti.com>
Hi
On Thu, 14 Jun 2012, Cousson, Benoit wrote:
> I don't think we should allow that at hwmod level. This line is already
> handled by the IVAHD hwmod. We will then have some potential issue since
> nothing will prevent the concurrent access.
> Moreover that IP is only used by the IVAHD and thus should be handled by the
> same driver. The SL2 being inside the IVA subsystem, it should be reset when
> the IVA will be reset and thus does not require an individual control.
If a hardreset line will affect an IP block, then the line should be
listed as one of the IP block's hardreset lines. Otherwise, the hwmod
data will not accurately reflect the hardware -- the ultimate goal.
> I guess, we should just mark the dependency with some external power resource
> to avoid the fmwk to try to enable that automatically.
Right now, the presence of a hardreset line will effectively cause the
hwmod code to ignore the IP block from a reset and enable point of view.
So the IP block won't be enabled automatically right now anyway, since we
still don't have a clear sense of how to handle those.
> It is similar to DSS sub IPs and to some extend McPDM for my point of view.
These seem like different cases to me.
The DSS has no hardreset and the sub-IPs have their own softreset bits.
As far as I know, the main reason why we can't have individual reset
functions for the DSS sub-IPs is because we don't have hierarchical IP
block enable/disable implemented in the hwmod code, not any real hardware
constraint.
McPDM has a functional clock dependency on an external (non-SoC) device
that's only controllable via I2C. And, the McPDM can block the ABE
clockdomain from going idle. That's just wacky.
So those cases seem quite different to me. One is a software issue. And
the other is an off-chip (non-OMAP) dependency, unlike the SL2IF/IVAHD
issue in which all the needed resources are still on-chip.
> Maybe we should rename HWMOD_EXT_OPT_MAIN_CLK with something more
> generic like HWMOD_EXT_POWER_DEP to highlight the dependency with an
> external resource. It can be a external clock or another module.
Yes, I agree that it would be convenient to have some flag, either on the
hwmod or the hardreset line, to indicate that some of the reset lines are
shared.
- Paul
WARNING: multiple messages have this Message-ID (diff)
From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 08/12] ARM: OMAP4: hwmod data: add SL2IF hardreset line
Date: Thu, 14 Jun 2012 11:09:58 -0600 (MDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206141052240.30212@utopia.booyaka.com> (raw)
In-Reply-To: <4FD9DF2A.3010000@ti.com>
Hi
On Thu, 14 Jun 2012, Cousson, Benoit wrote:
> I don't think we should allow that at hwmod level. This line is already
> handled by the IVAHD hwmod. We will then have some potential issue since
> nothing will prevent the concurrent access.
> Moreover that IP is only used by the IVAHD and thus should be handled by the
> same driver. The SL2 being inside the IVA subsystem, it should be reset when
> the IVA will be reset and thus does not require an individual control.
If a hardreset line will affect an IP block, then the line should be
listed as one of the IP block's hardreset lines. Otherwise, the hwmod
data will not accurately reflect the hardware -- the ultimate goal.
> I guess, we should just mark the dependency with some external power resource
> to avoid the fmwk to try to enable that automatically.
Right now, the presence of a hardreset line will effectively cause the
hwmod code to ignore the IP block from a reset and enable point of view.
So the IP block won't be enabled automatically right now anyway, since we
still don't have a clear sense of how to handle those.
> It is similar to DSS sub IPs and to some extend McPDM for my point of view.
These seem like different cases to me.
The DSS has no hardreset and the sub-IPs have their own softreset bits.
As far as I know, the main reason why we can't have individual reset
functions for the DSS sub-IPs is because we don't have hierarchical IP
block enable/disable implemented in the hwmod code, not any real hardware
constraint.
McPDM has a functional clock dependency on an external (non-SoC) device
that's only controllable via I2C. And, the McPDM can block the ABE
clockdomain from going idle. That's just wacky.
So those cases seem quite different to me. One is a software issue. And
the other is an off-chip (non-OMAP) dependency, unlike the SL2IF/IVAHD
issue in which all the needed resources are still on-chip.
> Maybe we should rename HWMOD_EXT_OPT_MAIN_CLK with something more
> generic like HWMOD_EXT_POWER_DEP to highlight the dependency with an
> external resource. It can be a external clock or another module.
Yes, I agree that it would be convenient to have some flag, either on the
hwmod or the hardreset line, to indicate that some of the reset lines are
shared.
- Paul
next prev parent reply other threads:[~2012-06-14 17:09 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 0:45 [PATCHv2 00/12] ARM: OMAP: core/hwmod: first set of fixes for 3.5-rc Paul Walmsley
2012-06-11 0:45 ` Paul Walmsley
2012-06-11 0:45 ` [PATCHv2 01/12] ARM: OMAP: PM: Lock clocks list while generating summary Paul Walmsley
2012-06-11 0:45 ` Paul Walmsley
2012-06-11 0:45 ` [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer Paul Walmsley
2012-06-11 0:45 ` Paul Walmsley
2012-06-14 16:47 ` Cousson, Benoit
2012-06-14 16:47 ` Cousson, Benoit
2012-06-14 18:04 ` Paul Walmsley
2012-06-14 18:04 ` Paul Walmsley
2012-06-14 20:13 ` Cousson, Benoit
2012-06-14 20:13 ` Cousson, Benoit
2012-06-15 0:18 ` Paul Walmsley
2012-06-15 0:18 ` Paul Walmsley
2012-06-15 13:28 ` Cousson, Benoit
2012-06-15 13:28 ` Cousson, Benoit
2012-07-04 12:48 ` Paul Walmsley
2012-07-04 12:48 ` Paul Walmsley
2012-07-04 12:53 ` Paul Walmsley
2012-07-04 12:53 ` Paul Walmsley
2012-07-04 14:27 ` Kevin Hilman
2012-07-04 14:27 ` Kevin Hilman
2012-07-04 14:53 ` Paul Walmsley
2012-07-04 14:53 ` Paul Walmsley
2012-07-04 16:14 ` Benoit Cousson
2012-07-04 16:14 ` Benoit Cousson
2012-07-04 16:41 ` Tero Kristo
2012-07-04 16:41 ` Tero Kristo
2012-07-04 16:43 ` Benoit Cousson
2012-07-04 16:43 ` Benoit Cousson
2012-07-04 19:02 ` Paul Walmsley
2012-07-04 19:02 ` Paul Walmsley
2012-07-04 16:57 ` Benoit Cousson
2012-07-04 16:57 ` Benoit Cousson
2012-07-04 18:59 ` Paul Walmsley
2012-07-04 18:59 ` Paul Walmsley
2012-07-05 22:06 ` Kevin Hilman
2012-07-05 22:06 ` Kevin Hilman
2012-07-04 16:01 ` Benoit Cousson
2012-07-04 16:01 ` Benoit Cousson
2012-07-04 19:05 ` Paul Walmsley
2012-07-04 19:05 ` Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 03/12] ARM: OMAP4+: hwmod: fix issue causing IPs not going back to Smart-Standby Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 04/12] ARM: OMAP4: hwmod data: fix 32k sync timer idle modes Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-11 9:31 ` Cousson, Benoit
2012-06-11 9:31 ` Cousson, Benoit
2012-06-13 17:22 ` Paul Walmsley
2012-06-13 17:22 ` Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 05/12] ARM: OMAP2+: hwmod: add setup_preprogram hook Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 06/12] ARM: OMAP2+: hwmod: add flag to prevent hwmod code from touching IP block during init Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 07/12] ARM: OMAP4+: AESS: enable internal auto-gating during initial setup Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-11 6:29 ` Tony Lindgren
2012-06-11 6:29 ` Tony Lindgren
2012-06-14 9:49 ` Paul Walmsley
2012-06-14 9:49 ` Paul Walmsley
2012-06-14 9:59 ` Tony Lindgren
2012-06-14 9:59 ` Tony Lindgren
2012-06-11 0:46 ` [PATCHv2 08/12] ARM: OMAP4: hwmod data: add SL2IF hardreset line Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-14 12:55 ` Cousson, Benoit
2012-06-14 12:55 ` Cousson, Benoit
2012-06-14 17:09 ` Paul Walmsley [this message]
2012-06-14 17:09 ` Paul Walmsley
2012-06-14 21:07 ` Cousson, Benoit
2012-06-14 21:07 ` Cousson, Benoit
2012-06-14 23:02 ` Paul Walmsley
2012-06-14 23:02 ` Paul Walmsley
2012-06-15 9:11 ` Cousson, Benoit
2012-06-15 9:11 ` Cousson, Benoit
2012-06-11 0:46 ` [PATCHv2 09/12] ARM: OMAP2+: usb_host_fs: add custom setup_preprogram for usb_host_fs (fsusb) Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-11 6:34 ` Tony Lindgren
2012-06-11 6:34 ` Tony Lindgren
2012-06-11 7:13 ` Felipe Balbi
2012-06-11 7:13 ` Felipe Balbi
2012-06-11 7:41 ` Tony Lindgren
2012-06-11 7:41 ` Tony Lindgren
2012-06-11 7:48 ` Felipe Balbi
2012-06-11 7:48 ` Felipe Balbi
2012-06-11 8:03 ` Tony Lindgren
2012-06-11 8:03 ` Tony Lindgren
2012-06-11 9:12 ` Felipe Balbi
2012-06-11 9:12 ` Felipe Balbi
2012-06-11 0:46 ` [PATCHv2 10/12] ARM: OMAP2+: CM: increase the module disable timeout Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 11/12] ARM: OMAP4: clock data: add clockdomains for clocks used as main clocks Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-11 16:28 ` Cousson, Benoit
2012-06-11 16:28 ` Cousson, Benoit
2012-06-11 16:59 ` Paul Walmsley
2012-06-11 16:59 ` Paul Walmsley
2012-06-11 20:15 ` Cousson, Benoit
2012-06-11 20:15 ` Cousson, Benoit
2012-06-11 0:46 ` [PATCHv2 12/12] ARM: OMAP4: hwmod data: do not enable or reset the McPDM during kernel init Paul Walmsley
2012-06-11 0:46 ` Paul Walmsley
2012-06-11 9:54 ` Cousson, Benoit
2012-06-11 9:54 ` Cousson, Benoit
2012-10-30 4:05 ` Paul Walmsley
2012-10-30 4:05 ` Paul Walmsley
2012-10-30 7:41 ` Péter Ujfalusi
2012-10-30 7:41 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206141052240.30212@utopia.booyaka.com \
--to=paul@pwsan.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.