From: "Darrick J. Wong" <darrick.wong@oracle.com> To: Christoph Hellwig <hch@infradead.org> Cc: P??draig Brady <P@draigBrady.com>, Anna Schumaker <Anna.Schumaker@netapp.com>, linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, zab@zabbo.net, viro@zeniv.linux.org.uk, clm@fb.com, mtk.manpages@gmail.com, andros@netapp.com Subject: Re: [PATCH v5 9/9] btrfs: btrfs_copy_file_range() only supports reflinks Date: Wed, 14 Oct 2015 11:46:08 -0700 [thread overview] Message-ID: <20151014184608.GK850@birch.djwong.org> (raw) In-Reply-To: <20151013072959.GB10794@infradead.org> On Tue, Oct 13, 2015 at 12:29:59AM -0700, Christoph Hellwig wrote: > On Mon, Oct 12, 2015 at 04:41:06PM -0700, Darrick J. Wong wrote: > > One of the patches in last week's XFS reflink patchbomb adds FALLOC_FL_UNSHARE > > flag; at the moment it _only_ forces copy-on-write of shared blocks, and it > > leaves holes alone. > > Yes, I've seen the implementation. > > > Obviously we haven't yet figured out what are peoples' preferences in terms of > > "fill the holes and unshare the shared" vs. "only unshare the shared" vs. "only > > fill the holes". It isn't that hard to add a FALLOC_FL_UNSHARE_FILL_HOLES flag > > that fills the holes while unsharing is going on. > > > > Personally I suspect that the most interest is in filling holes and unsharing, > > because they don't want to pay for allocation at a critical stage for anywhere > > in the file. But I could be wrong, so allowing both goals to be expressed via > > mode allows flexibility. > > Exactly. And a normal falloc should do just that - fill holes and > ensure that we don't need to COW already allocated locks. So I don't > think we need a new fallocate interface for that. The documentation for fallocate ought to be updated to include that as part of guaranteeing that subsequent writes to the range won't fail due to ENOSPC, shared blocks will be unshared. Incidentally, btrfs leaves shared blocks alone. OTOH, given that it's totally COW it probably doesn't make sense to unshare blocks anyway... but maybe I also don't want to dive into btrfs f-allocation behavior at this time. :) Ok, so I'll rework the XFS funshare code into something that hangs off the regular fallocate call, and get rid of the explicit 'funshare' bits. > The question is if we > want a copy interface that gives you the same semantics as if you also > called an fallocate on the destination range. For that case we'd > usually want to avoid doing the clone and instead do a in-kernel or > hardware assisted copy and then fill the holes with unwritten extents. Probably; I can easily imagine people wanting to fill the holes and also not wanting them filled. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-api" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Cc: P??draig Brady <P@draigBrady.com>, Anna Schumaker <Anna.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, zab-ugsP4Wv/S6ZeoWH0uzbU5w@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, clm-b10kYP2dOMg@public.gmane.org, mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, andros-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org Subject: Re: [PATCH v5 9/9] btrfs: btrfs_copy_file_range() only supports reflinks Date: Wed, 14 Oct 2015 11:46:08 -0700 [thread overview] Message-ID: <20151014184608.GK850@birch.djwong.org> (raw) In-Reply-To: <20151013072959.GB10794-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> On Tue, Oct 13, 2015 at 12:29:59AM -0700, Christoph Hellwig wrote: > On Mon, Oct 12, 2015 at 04:41:06PM -0700, Darrick J. Wong wrote: > > One of the patches in last week's XFS reflink patchbomb adds FALLOC_FL_UNSHARE > > flag; at the moment it _only_ forces copy-on-write of shared blocks, and it > > leaves holes alone. > > Yes, I've seen the implementation. > > > Obviously we haven't yet figured out what are peoples' preferences in terms of > > "fill the holes and unshare the shared" vs. "only unshare the shared" vs. "only > > fill the holes". It isn't that hard to add a FALLOC_FL_UNSHARE_FILL_HOLES flag > > that fills the holes while unsharing is going on. > > > > Personally I suspect that the most interest is in filling holes and unsharing, > > because they don't want to pay for allocation at a critical stage for anywhere > > in the file. But I could be wrong, so allowing both goals to be expressed via > > mode allows flexibility. > > Exactly. And a normal falloc should do just that - fill holes and > ensure that we don't need to COW already allocated locks. So I don't > think we need a new fallocate interface for that. The documentation for fallocate ought to be updated to include that as part of guaranteeing that subsequent writes to the range won't fail due to ENOSPC, shared blocks will be unshared. Incidentally, btrfs leaves shared blocks alone. OTOH, given that it's totally COW it probably doesn't make sense to unshare blocks anyway... but maybe I also don't want to dive into btrfs f-allocation behavior at this time. :) Ok, so I'll rework the XFS funshare code into something that hangs off the regular fallocate call, and get rid of the explicit 'funshare' bits. > The question is if we > want a copy interface that gives you the same semantics as if you also > called an fallocate on the destination range. For that case we'd > usually want to avoid doing the clone and instead do a in-kernel or > hardware assisted copy and then fill the holes with unwritten extents. Probably; I can easily imagine people wanting to fill the holes and also not wanting them filled. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-api" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-14 18:46 UTC|newest] Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-30 17:26 [PATCH v5 0/9] VFS: In-kernel copy system call Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-09-30 17:26 ` [PATCH v5 1/9] vfs: add copy_file_range syscall and vfs helper Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-09-30 17:26 ` [PATCH v5 2/9] x86: add sys_copy_file_range to syscall tables Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-09-30 17:26 ` [PATCH v5 3/9] btrfs: add .copy_file_range file operation Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-09-30 17:26 ` [PATCH v5 4/9] vfs: Copy should check len after file open mode Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-10-11 14:22 ` Christoph Hellwig 2015-10-11 14:22 ` Christoph Hellwig 2015-09-30 17:26 ` [PATCH v5 5/9] vfs: Copy shouldn't forbid ranges inside the same file Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-10-11 14:22 ` Christoph Hellwig 2015-10-14 17:37 ` Anna Schumaker 2015-10-14 17:37 ` Anna Schumaker 2015-10-14 17:37 ` Anna Schumaker 2015-10-14 18:25 ` Christoph Hellwig 2015-10-14 18:27 ` Anna Schumaker 2015-10-14 18:27 ` Anna Schumaker 2015-10-14 18:27 ` Anna Schumaker 2015-09-30 17:26 ` [PATCH v5 6/9] vfs: Copy should use file_out rather than file_in Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-10-11 14:24 ` Christoph Hellwig 2015-09-30 17:26 ` [PATCH v5 7/9] vfs: Remove copy_file_range mountpoint checks Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-10-11 14:23 ` Christoph Hellwig 2015-10-14 17:41 ` Anna Schumaker 2015-10-14 17:41 ` Anna Schumaker 2015-10-14 18:25 ` Christoph Hellwig 2015-10-14 18:25 ` Christoph Hellwig 2015-09-30 17:26 ` [PATCH v5 8/9] vfs: Add vfs_copy_file_range() support for pagecache copies Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-10-08 1:40 ` Neil Brown 2015-10-09 11:15 ` Pádraig Brady 2015-10-09 11:15 ` Pádraig Brady 2015-10-13 20:25 ` Anna Schumaker 2015-10-13 20:25 ` Anna Schumaker 2015-10-14 7:41 ` Christoph Hellwig 2015-10-14 7:41 ` Christoph Hellwig 2015-10-13 19:45 ` Anna Schumaker 2015-10-13 19:45 ` Anna Schumaker 2015-10-13 19:45 ` Anna Schumaker 2015-10-11 14:22 ` Christoph Hellwig 2015-10-11 14:22 ` Christoph Hellwig 2015-10-12 23:17 ` Darrick J. Wong 2015-10-12 23:17 ` Darrick J. Wong 2015-10-13 3:36 ` Trond Myklebust 2015-10-13 7:19 ` Darrick J. Wong 2015-10-13 7:19 ` Darrick J. Wong 2015-10-13 7:30 ` Christoph Hellwig 2015-10-13 7:30 ` Christoph Hellwig 2015-10-13 7:27 ` Christoph Hellwig 2015-10-13 7:27 ` Christoph Hellwig 2015-11-10 6:24 ` Darrick J. Wong 2015-10-14 17:59 ` Anna Schumaker 2015-10-14 17:59 ` Anna Schumaker 2015-10-14 17:59 ` Anna Schumaker 2015-10-14 18:08 ` Andy Lutomirski 2015-10-14 18:27 ` Christoph Hellwig 2015-10-14 18:38 ` Andy Lutomirski 2015-10-14 18:38 ` Andy Lutomirski 2015-10-14 18:49 ` Christoph Hellwig 2015-10-14 18:49 ` Christoph Hellwig 2015-10-14 18:53 ` Andy Lutomirski 2015-10-14 19:14 ` Austin S Hemmelgarn 2015-10-14 19:14 ` Austin S Hemmelgarn 2015-10-14 19:39 ` Pádraig Brady 2015-10-14 19:39 ` Pádraig Brady 2015-10-15 5:56 ` Christoph Hellwig 2015-10-15 5:56 ` Christoph Hellwig 2015-10-14 19:08 ` Austin S Hemmelgarn 2015-10-14 19:08 ` Austin S Hemmelgarn 2015-10-15 6:36 ` Christoph Hellwig 2015-10-15 6:36 ` Christoph Hellwig 2015-10-15 12:24 ` Austin S Hemmelgarn 2015-10-15 12:24 ` Austin S Hemmelgarn 2015-10-16 5:38 ` Christoph Hellwig 2015-10-16 5:38 ` Christoph Hellwig 2015-10-16 11:46 ` Austin S Hemmelgarn 2015-10-16 12:02 ` Pádraig Brady 2015-10-16 12:02 ` Pádraig Brady 2015-10-16 12:24 ` Christoph Hellwig 2015-10-16 12:24 ` Christoph Hellwig 2015-10-16 12:46 ` Austin S Hemmelgarn 2015-10-16 12:46 ` Austin S Hemmelgarn 2015-10-16 12:21 ` Christoph Hellwig 2015-10-16 12:21 ` Christoph Hellwig 2015-10-16 12:50 ` Austin S Hemmelgarn 2015-10-16 13:12 ` Christoph Hellwig 2015-10-16 14:11 ` Austin S Hemmelgarn 2015-10-14 18:11 ` Darrick J. Wong 2015-10-14 18:11 ` Darrick J. Wong 2015-10-14 18:26 ` Andy Lutomirski 2015-09-30 17:26 ` [PATCH v5 9/9] btrfs: btrfs_copy_file_range() only supports reflinks Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-10-11 14:29 ` Christoph Hellwig 2015-10-11 14:29 ` Christoph Hellwig 2015-10-12 10:23 ` Pádraig Brady 2015-10-12 10:23 ` Pádraig Brady 2015-10-12 14:34 ` Christoph Hellwig 2015-10-12 23:41 ` Darrick J. Wong 2015-10-12 23:41 ` Darrick J. Wong 2015-10-13 7:29 ` Christoph Hellwig 2015-10-13 7:29 ` Christoph Hellwig 2015-10-14 18:46 ` Darrick J. Wong [this message] 2015-10-14 18:46 ` Darrick J. Wong 2015-10-15 6:00 ` Christoph Hellwig 2015-10-16 11:49 ` Chris Mason 2015-10-16 11:49 ` Chris Mason 2015-10-16 11:49 ` Chris Mason 2015-10-16 12:25 ` Christoph Hellwig 2015-10-16 12:25 ` Christoph Hellwig 2015-10-16 13:19 ` Chris Mason 2015-10-16 13:19 ` Chris Mason 2015-10-16 13:19 ` Chris Mason 2015-10-16 21:44 ` Dave Chinner 2015-10-17 13:44 ` Chris Mason 2015-10-17 13:44 ` Chris Mason 2015-10-17 13:44 ` Chris Mason 2015-10-15 8:35 ` Dave Chinner 2015-10-15 8:35 ` Dave Chinner 2015-09-30 17:26 ` [PATCH v5 10/9] copy_file_range.2: New page documenting copy_file_range() Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker 2015-09-30 17:26 ` Anna Schumaker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151014184608.GK850@birch.djwong.org \ --to=darrick.wong@oracle.com \ --cc=Anna.Schumaker@netapp.com \ --cc=P@draigBrady.com \ --cc=andros@netapp.com \ --cc=clm@fb.com \ --cc=hch@infradead.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=mtk.manpages@gmail.com \ --cc=viro@zeniv.linux.org.uk \ --cc=zab@zabbo.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.