* [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-08-15 14:14 ` Peter Griffin
0 siblings, 0 replies; 19+ messages in thread
From: Peter Griffin @ 2017-08-15 14:14 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, z.liuxinliang, zourongrong,
kong.kongxinwei, puck.chen, airlied
Cc: john.stultz, dri-devel, andrey.konovalov, guodong.xu, shawn.guo,
Peter Griffin, stable
This patch fixes the following soft lockup:
BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
On weston idle-timeout the IP is powered down and reset
asserted. On weston resume we get a massive vblank
IRQ storm due to the LDI registers having lost some state.
This state loss is caused by ade_crtc_atomic_begin() not
calling ade_ldi_set_mode(). With this patch applied
resuming from Weston idle-timeout works well.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index c96c228..72c6357 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc *crtc,
{
struct ade_crtc *acrtc = to_ade_crtc(crtc);
struct ade_hw_ctx *ctx = acrtc->ctx;
+ struct drm_display_mode *mode = &crtc->state->mode;
+ struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
if (!ctx->power_on)
(void)ade_power_up(ctx);
+ ade_ldi_set_mode(acrtc, mode, adj_mode);
}
static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-08-15 14:14 ` Peter Griffin
0 siblings, 0 replies; 19+ messages in thread
From: Peter Griffin @ 2017-08-15 14:14 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes the following soft lockup:
BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
On weston idle-timeout the IP is powered down and reset
asserted. On weston resume we get a massive vblank
IRQ storm due to the LDI registers having lost some state.
This state loss is caused by ade_crtc_atomic_begin() not
calling ade_ldi_set_mode(). With this patch applied
resuming from Weston idle-timeout works well.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Cc: stable at vger.kernel.org
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index c96c228..72c6357 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc *crtc,
{
struct ade_crtc *acrtc = to_ade_crtc(crtc);
struct ade_hw_ctx *ctx = acrtc->ctx;
+ struct drm_display_mode *mode = &crtc->state->mode;
+ struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
if (!ctx->power_on)
(void)ade_power_up(ctx);
+ ade_ldi_set_mode(acrtc, mode, adj_mode);
}
static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
2017-08-15 14:14 ` Peter Griffin
(?)
@ 2017-08-28 8:44 ` Xinliang Liu
2017-08-28 8:51 ` Daniel Vetter
-1 siblings, 1 reply; 19+ messages in thread
From: Xinliang Liu @ 2017-08-28 8:44 UTC (permalink / raw)
To: Peter Griffin, seanpaul
Cc: Guodong Xu, Feng Chen, Linux Kernel Mailing List, dri-devel,
Liuxinliang (Matthew Liu),
XinWei Kong, stable, Rongrong Zou, Andrey Konovalov, LAKML
[-- Attachment #1.1: Type: text/plain, Size: 2008 bytes --]
Hi,
On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote:
> This patch fixes the following soft lockup:
> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
>
Thanks Peter,
This patch looks good to me.
Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
@Sean, could you please help to apply to drm-misc if others has no more
comments, thanks.
Thanks,
Xinliang
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index c96c228..72c6357 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc
> *crtc,
> {
> struct ade_crtc *acrtc = to_ade_crtc(crtc);
> struct ade_hw_ctx *ctx = acrtc->ctx;
> + struct drm_display_mode *mode = &crtc->state->mode;
> + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
>
> if (!ctx->power_on)
> (void)ade_power_up(ctx);
> + ade_ldi_set_mode(acrtc, mode, adj_mode);
> }
>
> static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
[-- Attachment #1.2: Type: text/html, Size: 4365 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
2017-08-28 8:44 ` Xinliang Liu
2017-08-28 8:51 ` Daniel Vetter
@ 2017-08-28 8:51 ` Daniel Vetter
0 siblings, 0 replies; 19+ messages in thread
From: Daniel Vetter @ 2017-08-28 8:51 UTC (permalink / raw)
To: Xinliang Liu
Cc: Peter Griffin, seanpaul, Guodong Xu, Feng Chen,
Linux Kernel Mailing List, dri-devel, Liuxinliang (Matthew Liu),
XinWei Kong, stable, Rongrong Zou, Andrey Konovalov, LAKML
On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote:
> Hi,
>
> On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote:
>
> > This patch fixes the following soft lockup:
> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
> >
> > On weston idle-timeout the IP is powered down and reset
> > asserted. On weston resume we get a massive vblank
> > IRQ storm due to the LDI registers having lost some state.
> >
> > This state loss is caused by ade_crtc_atomic_begin() not
> > calling ade_ldi_set_mode(). With this patch applied
> > resuming from Weston idle-timeout works well.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > Tested-by: John Stultz <john.stultz@linaro.org>
> >
>
> Thanks Peter,
> This patch looks good to me.
> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
>
> @Sean, could you please help to apply to drm-misc if others has no more
> comments, thanks.
hisilicon isn't maintained in drm-misc, and you're the maintainer. This is
not how it works. So either
a) pick up the patch and send out a pull request to Dave Airlie
b) move hisilicon over to drm-misc and become a drm-misc maintainer
yourself. This needs a MAINTAINERS update to point the git tree at
drm-misc.
drm-misc maintainers don't maintain everyone else's driver as a service,
that simply doesn't scale.
Thanks, Daniel
>
> Thanks,
> Xinliang
>
>
> > Cc: stable@vger.kernel.org
> > ---
> > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > index c96c228..72c6357 100644
> > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc
> > *crtc,
> > {
> > struct ade_crtc *acrtc = to_ade_crtc(crtc);
> > struct ade_hw_ctx *ctx = acrtc->ctx;
> > + struct drm_display_mode *mode = &crtc->state->mode;
> > + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
> >
> > if (!ctx->power_on)
> > (void)ade_power_up(ctx);
> > + ade_ldi_set_mode(acrtc, mode, adj_mode);
> > }
> >
> > static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
> > --
> > 2.7.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 19+ messages in thread
* [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-08-28 8:51 ` Daniel Vetter
0 siblings, 0 replies; 19+ messages in thread
From: Daniel Vetter @ 2017-08-28 8:51 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote:
> Hi,
>
> On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote:
>
> > This patch fixes the following soft lockup:
> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
> >
> > On weston idle-timeout the IP is powered down and reset
> > asserted. On weston resume we get a massive vblank
> > IRQ storm due to the LDI registers having lost some state.
> >
> > This state loss is caused by ade_crtc_atomic_begin() not
> > calling ade_ldi_set_mode(). With this patch applied
> > resuming from Weston idle-timeout works well.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > Tested-by: John Stultz <john.stultz@linaro.org>
> >
>
> ??Thanks Peter,
> This patch looks good to me.
> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>?
>
> @Sean, could you please help to apply to drm-misc if others has no more
> comments, thanks.
hisilicon isn't maintained in drm-misc, and you're the maintainer. This is
not how it works. So either
a) pick up the patch and send out a pull request to Dave Airlie
b) move hisilicon over to drm-misc and become a drm-misc maintainer
yourself. This needs a MAINTAINERS update to point the git tree at
drm-misc.
drm-misc maintainers don't maintain everyone else's driver as a service,
that simply doesn't scale.
Thanks, Daniel
>
> Thanks,
> Xinliang
> ?
>
> > Cc: stable at vger.kernel.org
> > ---
> > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > index c96c228..72c6357 100644
> > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc
> > *crtc,
> > {
> > struct ade_crtc *acrtc = to_ade_crtc(crtc);
> > struct ade_hw_ctx *ctx = acrtc->ctx;
> > + struct drm_display_mode *mode = &crtc->state->mode;
> > + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
> >
> > if (!ctx->power_on)
> > (void)ade_power_up(ctx);
> > + ade_ldi_set_mode(acrtc, mode, adj_mode);
> > }
> >
> > static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
> > --
> > 2.7.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-08-28 8:51 ` Daniel Vetter
0 siblings, 0 replies; 19+ messages in thread
From: Daniel Vetter @ 2017-08-28 8:51 UTC (permalink / raw)
To: Xinliang Liu
Cc: Liuxinliang (Matthew Liu),
seanpaul, Guodong Xu, Feng Chen, Linux Kernel Mailing List,
dri-devel, Peter Griffin, XinWei Kong, stable, Rongrong Zou,
Andrey Konovalov, LAKML
On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote:
> Hi,
>
> On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote:
>
> > This patch fixes the following soft lockup:
> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
> >
> > On weston idle-timeout the IP is powered down and reset
> > asserted. On weston resume we get a massive vblank
> > IRQ storm due to the LDI registers having lost some state.
> >
> > This state loss is caused by ade_crtc_atomic_begin() not
> > calling ade_ldi_set_mode(). With this patch applied
> > resuming from Weston idle-timeout works well.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > Tested-by: John Stultz <john.stultz@linaro.org>
> >
>
> Thanks Peter,
> This patch looks good to me.
> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
>
> @Sean, could you please help to apply to drm-misc if others has no more
> comments, thanks.
hisilicon isn't maintained in drm-misc, and you're the maintainer. This is
not how it works. So either
a) pick up the patch and send out a pull request to Dave Airlie
b) move hisilicon over to drm-misc and become a drm-misc maintainer
yourself. This needs a MAINTAINERS update to point the git tree at
drm-misc.
drm-misc maintainers don't maintain everyone else's driver as a service,
that simply doesn't scale.
Thanks, Daniel
>
> Thanks,
> Xinliang
>
>
> > Cc: stable@vger.kernel.org
> > ---
> > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > index c96c228..72c6357 100644
> > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> > @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc
> > *crtc,
> > {
> > struct ade_crtc *acrtc = to_ade_crtc(crtc);
> > struct ade_hw_ctx *ctx = acrtc->ctx;
> > + struct drm_display_mode *mode = &crtc->state->mode;
> > + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
> >
> > if (!ctx->power_on)
> > (void)ade_power_up(ctx);
> > + ade_ldi_set_mode(acrtc, mode, adj_mode);
> > }
> >
> > static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
> > --
> > 2.7.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
2017-08-28 8:51 ` Daniel Vetter
@ 2017-08-28 9:27 ` Xinliang Liu
-1 siblings, 0 replies; 19+ messages in thread
From: Xinliang Liu @ 2017-08-28 9:27 UTC (permalink / raw)
To: Xinliang Liu, Peter Griffin, seanpaul, Guodong Xu, Feng Chen,
Linux Kernel Mailing List, dri-devel, Liuxinliang (Matthew Liu),
XinWei Kong, stable, Rongrong Zou, Andrey Konovalov, LAKML
Hi Daniel,
On 28 August 2017 at 16:51, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote:
>> Hi,
>>
>> On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote:
>>
>> > This patch fixes the following soft lockup:
>> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>> >
>> > On weston idle-timeout the IP is powered down and reset
>> > asserted. On weston resume we get a massive vblank
>> > IRQ storm due to the LDI registers having lost some state.
>> >
>> > This state loss is caused by ade_crtc_atomic_begin() not
>> > calling ade_ldi_set_mode(). With this patch applied
>> > resuming from Weston idle-timeout works well.
>> >
>> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>> > Tested-by: John Stultz <john.stultz@linaro.org>
>> >
>>
>> Thanks Peter,
>> This patch looks good to me.
>> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
>>
>> @Sean, could you please help to apply to drm-misc if others has no more
>> comments, thanks.
>
> hisilicon isn't maintained in drm-misc, and you're the maintainer. This is
> not how it works. So either
> a) pick up the patch and send out a pull request to Dave Airlie
> b) move hisilicon over to drm-misc and become a drm-misc maintainer
> yourself. This needs a MAINTAINERS update to point the git tree at
> drm-misc.
>
> drm-misc maintainers don't maintain everyone else's driver as a service,
> that simply doesn't scale.
Sorry for my misunderstanding and thanks for pointing out that how
drm-misc works.
So I will pick up the patch and send a pull request.
Thanks,
Xinliang
>
> Thanks, Daniel
>
>>
>> Thanks,
>> Xinliang
>>
>>
>> > Cc: stable@vger.kernel.org
>> > ---
>> > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
>> > 1 file changed, 3 insertions(+)
>> >
>> > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> > b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> > index c96c228..72c6357 100644
>> > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> > @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc
>> > *crtc,
>> > {
>> > struct ade_crtc *acrtc = to_ade_crtc(crtc);
>> > struct ade_hw_ctx *ctx = acrtc->ctx;
>> > + struct drm_display_mode *mode = &crtc->state->mode;
>> > + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
>> >
>> > if (!ctx->power_on)
>> > (void)ade_power_up(ctx);
>> > + ade_ldi_set_mode(acrtc, mode, adj_mode);
>> > }
>> >
>> > static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
>> > --
>> > 2.7.4
>> >
>> > _______________________________________________
>> > dri-devel mailing list
>> > dri-devel@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>> >
>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 19+ messages in thread
* [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-08-28 9:27 ` Xinliang Liu
0 siblings, 0 replies; 19+ messages in thread
From: Xinliang Liu @ 2017-08-28 9:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi Daniel,
On 28 August 2017 at 16:51, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote:
>> Hi,
>>
>> On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote:
>>
>> > This patch fixes the following soft lockup:
>> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>> >
>> > On weston idle-timeout the IP is powered down and reset
>> > asserted. On weston resume we get a massive vblank
>> > IRQ storm due to the LDI registers having lost some state.
>> >
>> > This state loss is caused by ade_crtc_atomic_begin() not
>> > calling ade_ldi_set_mode(). With this patch applied
>> > resuming from Weston idle-timeout works well.
>> >
>> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>> > Tested-by: John Stultz <john.stultz@linaro.org>
>> >
>>
>> Thanks Peter,
>> This patch looks good to me.
>> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
>>
>> @Sean, could you please help to apply to drm-misc if others has no more
>> comments, thanks.
>
> hisilicon isn't maintained in drm-misc, and you're the maintainer. This is
> not how it works. So either
> a) pick up the patch and send out a pull request to Dave Airlie
> b) move hisilicon over to drm-misc and become a drm-misc maintainer
> yourself. This needs a MAINTAINERS update to point the git tree at
> drm-misc.
>
> drm-misc maintainers don't maintain everyone else's driver as a service,
> that simply doesn't scale.
Sorry for my misunderstanding and thanks for pointing out that how
drm-misc works.
So I will pick up the patch and send a pull request.
Thanks,
Xinliang
>
> Thanks, Daniel
>
>>
>> Thanks,
>> Xinliang
>>
>>
>> > Cc: stable at vger.kernel.org
>> > ---
>> > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
>> > 1 file changed, 3 insertions(+)
>> >
>> > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> > b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> > index c96c228..72c6357 100644
>> > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> > @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc
>> > *crtc,
>> > {
>> > struct ade_crtc *acrtc = to_ade_crtc(crtc);
>> > struct ade_hw_ctx *ctx = acrtc->ctx;
>> > + struct drm_display_mode *mode = &crtc->state->mode;
>> > + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
>> >
>> > if (!ctx->power_on)
>> > (void)ade_power_up(ctx);
>> > + ade_ldi_set_mode(acrtc, mode, adj_mode);
>> > }
>> >
>> > static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
>> > --
>> > 2.7.4
>> >
>> > _______________________________________________
>> > dri-devel mailing list
>> > dri-devel at lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>> >
>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
2017-08-28 9:27 ` Xinliang Liu
(?)
@ 2017-10-23 17:34 ` Peter Griffin
2017-10-25 1:00 ` liuxinliang
-1 siblings, 1 reply; 19+ messages in thread
From: Peter Griffin @ 2017-10-23 17:34 UTC (permalink / raw)
To: Xinliang Liu
Cc: seanpaul, Guodong Xu, Feng Chen, Linux Kernel Mailing List,
dri-devel, Liuxinliang (Matthew Liu),
XinWei Kong, stable, Rongrong Zou, Andrey Konovalov, LAKML
[-- Attachment #1.1: Type: text/plain, Size: 1878 bytes --]
Hi Xinliang,
On 28 August 2017 at 10:27, Xinliang Liu <xinliang.liu@linaro.org> wrote:
> Hi Daniel,
>
> On 28 August 2017 at 16:51, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote:
> >> Hi,
> >>
> >> On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org>
> wrote:
> >>
> >> > This patch fixes the following soft lockup:
> >> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
> >> >
> >> > On weston idle-timeout the IP is powered down and reset
> >> > asserted. On weston resume we get a massive vblank
> >> > IRQ storm due to the LDI registers having lost some state.
> >> >
> >> > This state loss is caused by ade_crtc_atomic_begin() not
> >> > calling ade_ldi_set_mode(). With this patch applied
> >> > resuming from Weston idle-timeout works well.
> >> >
> >> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> >> > Tested-by: John Stultz <john.stultz@linaro.org>
> >> >
> >>
> >> Thanks Peter,
> >> This patch looks good to me.
> >> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
> >>
> >> @Sean, could you please help to apply to drm-misc if others has no more
> >> comments, thanks.
> >
> > hisilicon isn't maintained in drm-misc, and you're the maintainer. This
> is
> > not how it works. So either
> > a) pick up the patch and send out a pull request to Dave Airlie
> > b) move hisilicon over to drm-misc and become a drm-misc maintainer
> > yourself. This needs a MAINTAINERS update to point the git tree at
> > drm-misc.
> >
> > drm-misc maintainers don't maintain everyone else's driver as a service,
> > that simply doesn't scale.
>
> Sorry for my misunderstanding and thanks for pointing out that how
> drm-misc works.
> So I will pick up the patch and send a pull request.
>
Did you send the pull request?
I still can't see this patch in the latest kernel RC.
Peter.
[-- Attachment #1.2: Type: text/html, Size: 2899 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
2017-10-23 17:34 ` Peter Griffin
@ 2017-10-25 1:00 ` liuxinliang
0 siblings, 0 replies; 19+ messages in thread
From: liuxinliang @ 2017-10-25 1:00 UTC (permalink / raw)
To: Peter Griffin, Xinliang Liu
Cc: seanpaul, Guodong Xu, Feng Chen, Linux Kernel Mailing List,
dri-devel, XinWei Kong, stable, Rongrong Zou, Andrey Konovalov,
LAKML
[-- Attachment #1.1: Type: text/plain, Size: 2491 bytes --]
Hi Peter,
On 2017/10/24 1:34, Peter Griffin wrote:
> Hi Xinliang,
>
> On 28 August 2017 at 10:27, Xinliang Liu <xinliang.liu@linaro.org
> <mailto:xinliang.liu@linaro.org>> wrote:
>
> Hi Daniel,
>
> On 28 August 2017 at 16:51, Daniel Vetter <daniel@ffwll.ch
> <mailto:daniel@ffwll.ch>> wrote:
> > On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote:
> >> Hi,
> >>
> >> On 15 August 2017 at 22:14, Peter Griffin
> <peter.griffin@linaro.org <mailto:peter.griffin@linaro.org>> wrote:
> >>
> >> > This patch fixes the following soft lockup:
> >> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
> >> >
> >> > On weston idle-timeout the IP is powered down and reset
> >> > asserted. On weston resume we get a massive vblank
> >> > IRQ storm due to the LDI registers having lost some state.
> >> >
> >> > This state loss is caused by ade_crtc_atomic_begin() not
> >> > calling ade_ldi_set_mode(). With this patch applied
> >> > resuming from Weston idle-timeout works well.
> >> >
> >> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org
> <mailto:peter.griffin@linaro.org>>
> >> > Tested-by: John Stultz <john.stultz@linaro.org
> <mailto:john.stultz@linaro.org>>
> >> >
> >>
> >> Thanks Peter,
> >> This patch looks good to me.
> >> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org
> <mailto:xinliang.liu@linaro.org>>
> >>
> >> @Sean, could you please help to apply to drm-misc if others has
> no more
> >> comments, thanks.
> >
> > hisilicon isn't maintained in drm-misc, and you're the
> maintainer. This is
> > not how it works. So either
> > a) pick up the patch and send out a pull request to Dave Airlie
> > b) move hisilicon over to drm-misc and become a drm-misc maintainer
> > yourself. This needs a MAINTAINERS update to point the git tree at
> > drm-misc.
> >
> > drm-misc maintainers don't maintain everyone else's driver as a
> service,
> > that simply doesn't scale.
>
> Sorry for my misunderstanding and thanks for pointing out that how
> drm-misc works.
> So I will pick up the patch and send a pull request.
>
>
> Did you send the pull request?
>
> I still can't see this patch in the latest kernel RC.
I have sent in last cycle, it seems it didn't catch last cycle. Maybe I
need to resend again this cycle.
Will send soon.
Thanks,
Xinliang
>
> Peter.
[-- Attachment #1.2: Type: text/html, Size: 5482 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
2017-06-29 20:54 ` Peter Griffin
(?)
@ 2017-06-30 5:55 ` Greg KH
-1 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2017-06-30 5:55 UTC (permalink / raw)
To: Peter Griffin
Cc: linux-arm-kernel, linux-kernel, z.liuxinliang, zourongrong,
kong.kongxinwei, puck.chen, airlied, stable, john.stultz,
dri-devel, andrey.konovalov, fathi.boudra
On Thu, Jun 29, 2017 at 09:54:38PM +0100, Peter Griffin wrote:
> This patch fixes the following soft lockup:
> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
> 1 file changed, 3 insertions(+)
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-06-30 5:55 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2017-06-30 5:55 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 29, 2017 at 09:54:38PM +0100, Peter Griffin wrote:
> This patch fixes the following soft lockup:
> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
> 1 file changed, 3 insertions(+)
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-06-30 5:55 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2017-06-30 5:55 UTC (permalink / raw)
To: Peter Griffin
Cc: puck.chen, linux-kernel, stable, z.liuxinliang, kong.kongxinwei,
dri-devel, zourongrong, fathi.boudra, andrey.konovalov,
linux-arm-kernel
On Thu, Jun 29, 2017 at 09:54:38PM +0100, Peter Griffin wrote:
> This patch fixes the following soft lockup:
> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
> 1 file changed, 3 insertions(+)
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
2017-06-29 20:54 ` Peter Griffin
(?)
(?)
@ 2017-06-29 21:10 ` John Stultz
-1 siblings, 0 replies; 19+ messages in thread
From: John Stultz @ 2017-06-29 21:10 UTC (permalink / raw)
To: Peter Griffin
Cc: linux-arm-kernel, lkml, Liuxinliang (Matthew Liu),
Rongrong Zou, XinWei Kong, Feng Chen, David Airlie, stable,
dri-devel, Andrey Konovalov, Fathi Boudra
On Thu, Jun 29, 2017 at 1:54 PM, Peter Griffin <peter.griffin@linaro.org> wrote:
> This patch fixes the following soft lockup:
> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
While the issue hasn't seemingly come up with Android, I've been
running with this patch in my tree for a while without issue. So..
Tested-by: John Stultz <john.stultz@linaro.org>
thanks
-john
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-06-29 21:10 ` John Stultz
0 siblings, 0 replies; 19+ messages in thread
From: John Stultz @ 2017-06-29 21:10 UTC (permalink / raw)
To: Peter Griffin
Cc: linux-arm-kernel, lkml, Liuxinliang (Matthew Liu),
Rongrong Zou, XinWei Kong, Feng Chen, David Airlie, stable,
dri-devel, Andrey Konovalov, Fathi Boudra
On Thu, Jun 29, 2017 at 1:54 PM, Peter Griffin <peter.griffin@linaro.org> wrote:
> This patch fixes the following soft lockup:
> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
While the issue hasn't seemingly come up with Android, I've been
running with this patch in my tree for a while without issue. So..
Tested-by: John Stultz <john.stultz@linaro.org>
thanks
-john
^ permalink raw reply [flat|nested] 19+ messages in thread
* [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-06-29 21:10 ` John Stultz
0 siblings, 0 replies; 19+ messages in thread
From: John Stultz @ 2017-06-29 21:10 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 29, 2017 at 1:54 PM, Peter Griffin <peter.griffin@linaro.org> wrote:
> This patch fixes the following soft lockup:
> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
While the issue hasn't seemingly come up with Android, I've been
running with this patch in my tree for a while without issue. So..
Tested-by: John Stultz <john.stultz@linaro.org>
thanks
-john
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-06-29 21:10 ` John Stultz
0 siblings, 0 replies; 19+ messages in thread
From: John Stultz @ 2017-06-29 21:10 UTC (permalink / raw)
To: Peter Griffin
Cc: Feng Chen, lkml, stable, Liuxinliang (Matthew Liu),
XinWei Kong, dri-devel, Rongrong Zou, Fathi Boudra,
Andrey Konovalov, linux-arm-kernel
On Thu, Jun 29, 2017 at 1:54 PM, Peter Griffin <peter.griffin@linaro.org> wrote:
> This patch fixes the following soft lockup:
> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
While the issue hasn't seemingly come up with Android, I've been
running with this patch in my tree for a while without issue. So..
Tested-by: John Stultz <john.stultz@linaro.org>
thanks
-john
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-06-29 20:54 ` Peter Griffin
0 siblings, 0 replies; 19+ messages in thread
From: Peter Griffin @ 2017-06-29 20:54 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, z.liuxinliang, zourongrong,
kong.kongxinwei, puck.chen, airlied
Cc: stable, john.stultz, dri-devel, andrey.konovalov, fathi.boudra,
Peter Griffin
This patch fixes the following soft lockup:
BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
On weston idle-timeout the IP is powered down and reset
asserted. On weston resume we get a massive vblank
IRQ storm due to the LDI registers having lost some state.
This state loss is caused by ade_crtc_atomic_begin() not
calling ade_ldi_set_mode(). With this patch applied
resuming from Weston idle-timeout works well.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index c96c228..72c6357 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc *crtc,
{
struct ade_crtc *acrtc = to_ade_crtc(crtc);
struct ade_hw_ctx *ctx = acrtc->ctx;
+ struct drm_display_mode *mode = &crtc->state->mode;
+ struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
if (!ctx->power_on)
(void)ade_power_up(ctx);
+ ade_ldi_set_mode(acrtc, mode, adj_mode);
}
static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
@ 2017-06-29 20:54 ` Peter Griffin
0 siblings, 0 replies; 19+ messages in thread
From: Peter Griffin @ 2017-06-29 20:54 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes the following soft lockup:
BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
On weston idle-timeout the IP is powered down and reset
asserted. On weston resume we get a massive vblank
IRQ storm due to the LDI registers having lost some state.
This state loss is caused by ade_crtc_atomic_begin() not
calling ade_ldi_set_mode(). With this patch applied
resuming from Weston idle-timeout works well.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index c96c228..72c6357 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc *crtc,
{
struct ade_crtc *acrtc = to_ade_crtc(crtc);
struct ade_hw_ctx *ctx = acrtc->ctx;
+ struct drm_display_mode *mode = &crtc->state->mode;
+ struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
if (!ctx->power_on)
(void)ade_power_up(ctx);
+ ade_ldi_set_mode(acrtc, mode, adj_mode);
}
static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
end of thread, other threads:[~2017-10-25 1:08 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-15 14:14 [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured Peter Griffin
2017-08-15 14:14 ` Peter Griffin
2017-08-28 8:44 ` Xinliang Liu
2017-08-28 8:51 ` Daniel Vetter
2017-08-28 8:51 ` Daniel Vetter
2017-08-28 8:51 ` Daniel Vetter
2017-08-28 9:27 ` Xinliang Liu
2017-08-28 9:27 ` Xinliang Liu
2017-10-23 17:34 ` Peter Griffin
2017-10-25 1:00 ` liuxinliang
-- strict thread matches above, loose matches on Subject: below --
2017-06-29 20:54 Peter Griffin
2017-06-29 20:54 ` Peter Griffin
2017-06-29 21:10 ` John Stultz
2017-06-29 21:10 ` John Stultz
2017-06-29 21:10 ` John Stultz
2017-06-29 21:10 ` John Stultz
2017-06-30 5:55 ` Greg KH
2017-06-30 5:55 ` Greg KH
2017-06-30 5:55 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.