From: Jiri Olsa <jolsa@redhat.com> To: John Garry <john.garry@huawei.com> Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, namhyung@kernel.org, ak@linux.intel.com, wcohen@redhat.com, will.deacon@arm.com, ganapatrao.kulkarni@cavium.com, catalin.marinas@arm.com, mark.rutland@arm.com, xuwei5@hisilicon.com, linuxarm@huawei.com, zhangshaokun@hisilicon.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/5] perf jevents: add support for arch recommended events Date: Wed, 6 Dec 2017 14:36:07 +0100 [thread overview] Message-ID: <20171206133607.GA12508@krava> (raw) In-Reply-To: <1512490399-94107-3-git-send-email-john.garry@huawei.com> On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: > For some architectures (like arm64), there are architecture- > defined recommended events. Vendors may not be obliged to > follow the recommendation and may implement their own pmu > event for a specific event code. > > This patch adds support for parsing events from arch-defined > recommended JSONs, and then fixing up vendor events when > they have implemented these events as recommended. in the previous patch you added the vendor support, so you have arch|vendor|platform key for the event list and perf have the most current/local event list why would you need to fix it? if there's new event list, the table gets updated, perf is rebuilt.. I'm clearly missing something ;-) > In the vendor JSON, to specify that the event is supported > according to the recommendation, only the event code is > added to the JSON entry - no other event elements need be > added, like below: > [ > { > "EventCode": "0x40", > }, > > ] > > The pmu event parsing will check for "BriefDescription" > field presence only for this. > > If "BriefDescription" is present, then it is implied > that the vendor has implemented their own custom event, > and there is no fixup. Other fields are ignored. if we are going this way, please use some new token, this list is supposed to be human readable thanks, jirka
WARNING: multiple messages have this Message-ID (diff)
From: jolsa@redhat.com (Jiri Olsa) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 2/5] perf jevents: add support for arch recommended events Date: Wed, 6 Dec 2017 14:36:07 +0100 [thread overview] Message-ID: <20171206133607.GA12508@krava> (raw) In-Reply-To: <1512490399-94107-3-git-send-email-john.garry@huawei.com> On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: > For some architectures (like arm64), there are architecture- > defined recommended events. Vendors may not be obliged to > follow the recommendation and may implement their own pmu > event for a specific event code. > > This patch adds support for parsing events from arch-defined > recommended JSONs, and then fixing up vendor events when > they have implemented these events as recommended. in the previous patch you added the vendor support, so you have arch|vendor|platform key for the event list and perf have the most current/local event list why would you need to fix it? if there's new event list, the table gets updated, perf is rebuilt.. I'm clearly missing something ;-) > In the vendor JSON, to specify that the event is supported > according to the recommendation, only the event code is > added to the JSON entry - no other event elements need be > added, like below: > [ > { > "EventCode": "0x40", > }, > > ] > > The pmu event parsing will check for "BriefDescription" > field presence only for this. > > If "BriefDescription" is present, then it is implied > that the vendor has implemented their own custom event, > and there is no fixup. Other fields are ignored. if we are going this way, please use some new token, this list is supposed to be human readable thanks, jirka
next prev parent reply other threads:[~2017-12-06 13:36 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-05 16:13 [RFC PATCH 0/5] perf events patches for improved ARM64 support John Garry 2017-12-05 16:13 ` John Garry 2017-12-05 16:13 ` [RFC PATCH 1/5] perf jevents: add support for pmu events vendor subdirectory John Garry 2017-12-05 16:13 ` John Garry 2017-12-06 13:38 ` Jiri Olsa 2017-12-06 13:38 ` Jiri Olsa 2017-12-06 14:41 ` John Garry 2017-12-06 14:41 ` John Garry 2017-12-05 16:13 ` [RFC PATCH 2/5] perf jevents: add support for arch recommended events John Garry 2017-12-05 16:13 ` John Garry 2017-12-05 17:27 ` Andi Kleen 2017-12-05 17:27 ` Andi Kleen 2017-12-06 8:34 ` John Garry 2017-12-06 8:34 ` John Garry 2017-12-06 13:36 ` Jiri Olsa [this message] 2017-12-06 13:36 ` Jiri Olsa 2017-12-06 15:20 ` John Garry 2017-12-06 15:20 ` John Garry 2017-12-08 12:29 ` Jiri Olsa 2017-12-08 12:29 ` Jiri Olsa 2017-12-08 15:42 ` John Garry 2017-12-08 15:42 ` John Garry 2017-12-09 7:31 ` Jiri Olsa 2017-12-09 7:31 ` Jiri Olsa 2017-12-11 10:25 ` John Garry 2017-12-11 10:25 ` John Garry 2017-12-15 11:22 ` John Garry 2017-12-15 11:22 ` John Garry 2017-12-16 18:47 ` Andi Kleen 2017-12-16 18:47 ` Andi Kleen 2018-01-02 12:07 ` John Garry 2018-01-02 12:07 ` John Garry 2018-01-02 17:48 ` Andi Kleen 2018-01-02 17:48 ` Andi Kleen 2018-01-03 12:22 ` John Garry 2018-01-03 12:22 ` John Garry 2017-12-21 19:39 ` Jiri Olsa 2017-12-21 19:39 ` Jiri Olsa 2018-01-04 17:17 ` John Garry 2018-01-04 17:17 ` John Garry 2018-01-08 14:08 ` Jiri Olsa 2018-01-08 14:08 ` Jiri Olsa 2017-12-06 13:37 ` Jiri Olsa 2017-12-06 13:37 ` Jiri Olsa 2017-12-06 14:40 ` John Garry 2017-12-06 14:40 ` John Garry 2017-12-08 12:31 ` Jiri Olsa 2017-12-08 12:31 ` Jiri Olsa 2017-12-08 15:38 ` John Garry 2017-12-08 15:38 ` John Garry 2017-12-09 7:26 ` Jiri Olsa 2017-12-09 7:26 ` Jiri Olsa 2017-12-05 16:13 ` [RFC PATCH 3/5] perf vendor events arm64: add armv8 recommended events JSON John Garry 2017-12-05 16:13 ` John Garry 2017-12-05 16:13 ` [RFC PATCH 4/5] perf vendor events arm64: relocate thunderx2 JSON John Garry 2017-12-05 16:13 ` John Garry 2017-12-05 16:13 ` [RFC PATCH 5/5] perf vendor events arm64: add HiSilicon hip08 JSON John Garry 2017-12-05 16:13 ` John Garry 2017-12-06 16:42 ` [RFC PATCH 0/5] perf events patches for improved ARM64 support William Cohen 2017-12-06 16:42 ` William Cohen 2017-12-06 17:35 ` John Garry 2017-12-06 17:35 ` John Garry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171206133607.GA12508@krava \ --to=jolsa@redhat.com \ --cc=acme@kernel.org \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=catalin.marinas@arm.com \ --cc=ganapatrao.kulkarni@cavium.com \ --cc=john.garry@huawei.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mark.rutland@arm.com \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=wcohen@redhat.com \ --cc=will.deacon@arm.com \ --cc=xuwei5@hisilicon.com \ --cc=zhangshaokun@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.