All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, <peterz@infradead.org>,
	<mingo@redhat.com>, <acme@kernel.org>,
	<alexander.shishkin@linux.intel.com>, <namhyung@kernel.org>,
	<wcohen@redhat.com>, <will.deacon@arm.com>,
	<ganapatrao.kulkarni@cavium.com>, <catalin.marinas@arm.com>,
	<mark.rutland@arm.com>, <xuwei5@hisilicon.com>,
	<linuxarm@huawei.com>, <zhangshaokun@hisilicon.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/5] perf jevents: add support for arch recommended events
Date: Tue, 2 Jan 2018 12:07:46 +0000	[thread overview]
Message-ID: <edd01090-755e-fd73-434b-b910272c625a@huawei.com> (raw)
In-Reply-To: <20171216184701.GB25156@tassilo.jf.intel.com>

On 16/12/2017 18:47, Andi Kleen wrote:

Hi Andi,

>> Won't this all potentially have a big maintainence cost?
>
> No. It's all auto generated.
>
> The only cost is slightly bigger binary size.
>
> I would hope your event files are auto generated too.
>

No, they're not - we are just manually transcribing the event data from 
the architecture reference manual (for arch-defined events) or internal 
text document (for custom events).

Can you describe how you autogenerate the JSONs? Do you have some 
internal proprietary HW file format describing events, with files 
supplied from HW designer, which you can just translate into a JSON? 
Would the files support deferencing events to improve scalability?

>> I just don't know how this schema scales with more archs and more platforms
>> supported. It's just early days now...
>
> Only perf will get slightly bigger, but memory is not exactly expensive.
>
> In fact, the extra memory won't even be faulted in if it's not used,
> so it's only disk space.

Much appreciated,
John

>
> -Andi
>
> .
>

WARNING: multiple messages have this Message-ID (diff)
From: john.garry@huawei.com (John Garry)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/5] perf jevents: add support for arch recommended events
Date: Tue, 2 Jan 2018 12:07:46 +0000	[thread overview]
Message-ID: <edd01090-755e-fd73-434b-b910272c625a@huawei.com> (raw)
In-Reply-To: <20171216184701.GB25156@tassilo.jf.intel.com>

On 16/12/2017 18:47, Andi Kleen wrote:

Hi Andi,

>> Won't this all potentially have a big maintainence cost?
>
> No. It's all auto generated.
>
> The only cost is slightly bigger binary size.
>
> I would hope your event files are auto generated too.
>

No, they're not - we are just manually transcribing the event data from 
the architecture reference manual (for arch-defined events) or internal 
text document (for custom events).

Can you describe how you autogenerate the JSONs? Do you have some 
internal proprietary HW file format describing events, with files 
supplied from HW designer, which you can just translate into a JSON? 
Would the files support deferencing events to improve scalability?

>> I just don't know how this schema scales with more archs and more platforms
>> supported. It's just early days now...
>
> Only perf will get slightly bigger, but memory is not exactly expensive.
>
> In fact, the extra memory won't even be faulted in if it's not used,
> so it's only disk space.

Much appreciated,
John

>
> -Andi
>
> .
>

  reply	other threads:[~2018-01-02 12:08 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 16:13 [RFC PATCH 0/5] perf events patches for improved ARM64 support John Garry
2017-12-05 16:13 ` John Garry
2017-12-05 16:13 ` [RFC PATCH 1/5] perf jevents: add support for pmu events vendor subdirectory John Garry
2017-12-05 16:13   ` John Garry
2017-12-06 13:38   ` Jiri Olsa
2017-12-06 13:38     ` Jiri Olsa
2017-12-06 14:41     ` John Garry
2017-12-06 14:41       ` John Garry
2017-12-05 16:13 ` [RFC PATCH 2/5] perf jevents: add support for arch recommended events John Garry
2017-12-05 16:13   ` John Garry
2017-12-05 17:27   ` Andi Kleen
2017-12-05 17:27     ` Andi Kleen
2017-12-06  8:34     ` John Garry
2017-12-06  8:34       ` John Garry
2017-12-06 13:36   ` Jiri Olsa
2017-12-06 13:36     ` Jiri Olsa
2017-12-06 15:20     ` John Garry
2017-12-06 15:20       ` John Garry
2017-12-08 12:29       ` Jiri Olsa
2017-12-08 12:29         ` Jiri Olsa
2017-12-08 15:42         ` John Garry
2017-12-08 15:42           ` John Garry
2017-12-09  7:31           ` Jiri Olsa
2017-12-09  7:31             ` Jiri Olsa
2017-12-11 10:25             ` John Garry
2017-12-11 10:25               ` John Garry
2017-12-15 11:22             ` John Garry
2017-12-15 11:22               ` John Garry
2017-12-16 18:47               ` Andi Kleen
2017-12-16 18:47                 ` Andi Kleen
2018-01-02 12:07                 ` John Garry [this message]
2018-01-02 12:07                   ` John Garry
2018-01-02 17:48                   ` Andi Kleen
2018-01-02 17:48                     ` Andi Kleen
2018-01-03 12:22                     ` John Garry
2018-01-03 12:22                       ` John Garry
2017-12-21 19:39               ` Jiri Olsa
2017-12-21 19:39                 ` Jiri Olsa
2018-01-04 17:17                 ` John Garry
2018-01-04 17:17                   ` John Garry
2018-01-08 14:08                   ` Jiri Olsa
2018-01-08 14:08                     ` Jiri Olsa
2017-12-06 13:37   ` Jiri Olsa
2017-12-06 13:37     ` Jiri Olsa
2017-12-06 14:40     ` John Garry
2017-12-06 14:40       ` John Garry
2017-12-08 12:31       ` Jiri Olsa
2017-12-08 12:31         ` Jiri Olsa
2017-12-08 15:38         ` John Garry
2017-12-08 15:38           ` John Garry
2017-12-09  7:26           ` Jiri Olsa
2017-12-09  7:26             ` Jiri Olsa
2017-12-05 16:13 ` [RFC PATCH 3/5] perf vendor events arm64: add armv8 recommended events JSON John Garry
2017-12-05 16:13   ` John Garry
2017-12-05 16:13 ` [RFC PATCH 4/5] perf vendor events arm64: relocate thunderx2 JSON John Garry
2017-12-05 16:13   ` John Garry
2017-12-05 16:13 ` [RFC PATCH 5/5] perf vendor events arm64: add HiSilicon hip08 JSON John Garry
2017-12-05 16:13   ` John Garry
2017-12-06 16:42 ` [RFC PATCH 0/5] perf events patches for improved ARM64 support William Cohen
2017-12-06 16:42   ` William Cohen
2017-12-06 17:35   ` John Garry
2017-12-06 17:35     ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edd01090-755e-fd73-434b-b910272c625a@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=ganapatrao.kulkarni@cavium.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wcohen@redhat.com \
    --cc=will.deacon@arm.com \
    --cc=xuwei5@hisilicon.com \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.