From: John Garry <john.garry@huawei.com> To: Jiri Olsa <jolsa@redhat.com> Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>, <alexander.shishkin@linux.intel.com>, <namhyung@kernel.org>, <ak@linux.intel.com>, <wcohen@redhat.com>, <will.deacon@arm.com>, <ganapatrao.kulkarni@cavium.com>, <catalin.marinas@arm.com>, <mark.rutland@arm.com>, <xuwei5@hisilicon.com>, <linuxarm@huawei.com>, <zhangshaokun@hisilicon.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: Re: [RFC PATCH 2/5] perf jevents: add support for arch recommended events Date: Wed, 6 Dec 2017 14:40:10 +0000 [thread overview] Message-ID: <f58001e9-86fa-c6e6-b9c7-fb748d340da1@huawei.com> (raw) In-Reply-To: <20171206133752.GB12508@krava> On 06/12/2017 13:37, Jiri Olsa wrote: > On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: > > SNIP > >> --- >> tools/perf/pmu-events/jevents.c | 215 ++++++++++++++++++++++++++++++++++++---- >> 1 file changed, 198 insertions(+), 17 deletions(-) >> >> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c >> index a0d489e..a820ed4 100644 >> --- a/tools/perf/pmu-events/jevents.c >> +++ b/tools/perf/pmu-events/jevents.c >> @@ -42,6 +42,7 @@ >> #include <dirent.h> >> #include <sys/time.h> /* getrlimit */ >> #include <sys/resource.h> /* getrlimit */ >> +#include <sys/queue.h> >> #include <ftw.h> >> #include <sys/stat.h> >> #include "jsmn.h" >> @@ -366,6 +367,94 @@ static int print_events_table_entry(void *data, char *name, char *event, >> return 0; >> } >> >> +struct event_struct { >> + char *name; >> + char *event; >> + char *desc; >> + char *long_desc; >> + char *pmu; >> + char *unit; >> + char *perpkg; >> + char *metric_expr; >> + char *metric_name; >> + char *metric_group; >> + LIST_ENTRY(event_struct) list; > > is there any reason you don't use the 'struct list_head' ? > I dont think we want another thingie involved for lists Hi jirka, The linux kernel headers are not used for jevents tool. I would rather use them if possible... Thanks, John > > jirka > > . >
WARNING: multiple messages have this Message-ID (diff)
From: john.garry@huawei.com (John Garry) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 2/5] perf jevents: add support for arch recommended events Date: Wed, 6 Dec 2017 14:40:10 +0000 [thread overview] Message-ID: <f58001e9-86fa-c6e6-b9c7-fb748d340da1@huawei.com> (raw) In-Reply-To: <20171206133752.GB12508@krava> On 06/12/2017 13:37, Jiri Olsa wrote: > On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: > > SNIP > >> --- >> tools/perf/pmu-events/jevents.c | 215 ++++++++++++++++++++++++++++++++++++---- >> 1 file changed, 198 insertions(+), 17 deletions(-) >> >> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c >> index a0d489e..a820ed4 100644 >> --- a/tools/perf/pmu-events/jevents.c >> +++ b/tools/perf/pmu-events/jevents.c >> @@ -42,6 +42,7 @@ >> #include <dirent.h> >> #include <sys/time.h> /* getrlimit */ >> #include <sys/resource.h> /* getrlimit */ >> +#include <sys/queue.h> >> #include <ftw.h> >> #include <sys/stat.h> >> #include "jsmn.h" >> @@ -366,6 +367,94 @@ static int print_events_table_entry(void *data, char *name, char *event, >> return 0; >> } >> >> +struct event_struct { >> + char *name; >> + char *event; >> + char *desc; >> + char *long_desc; >> + char *pmu; >> + char *unit; >> + char *perpkg; >> + char *metric_expr; >> + char *metric_name; >> + char *metric_group; >> + LIST_ENTRY(event_struct) list; > > is there any reason you don't use the 'struct list_head' ? > I dont think we want another thingie involved for lists Hi jirka, The linux kernel headers are not used for jevents tool. I would rather use them if possible... Thanks, John > > jirka > > . >
next prev parent reply other threads:[~2017-12-06 14:40 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-05 16:13 [RFC PATCH 0/5] perf events patches for improved ARM64 support John Garry 2017-12-05 16:13 ` John Garry 2017-12-05 16:13 ` [RFC PATCH 1/5] perf jevents: add support for pmu events vendor subdirectory John Garry 2017-12-05 16:13 ` John Garry 2017-12-06 13:38 ` Jiri Olsa 2017-12-06 13:38 ` Jiri Olsa 2017-12-06 14:41 ` John Garry 2017-12-06 14:41 ` John Garry 2017-12-05 16:13 ` [RFC PATCH 2/5] perf jevents: add support for arch recommended events John Garry 2017-12-05 16:13 ` John Garry 2017-12-05 17:27 ` Andi Kleen 2017-12-05 17:27 ` Andi Kleen 2017-12-06 8:34 ` John Garry 2017-12-06 8:34 ` John Garry 2017-12-06 13:36 ` Jiri Olsa 2017-12-06 13:36 ` Jiri Olsa 2017-12-06 15:20 ` John Garry 2017-12-06 15:20 ` John Garry 2017-12-08 12:29 ` Jiri Olsa 2017-12-08 12:29 ` Jiri Olsa 2017-12-08 15:42 ` John Garry 2017-12-08 15:42 ` John Garry 2017-12-09 7:31 ` Jiri Olsa 2017-12-09 7:31 ` Jiri Olsa 2017-12-11 10:25 ` John Garry 2017-12-11 10:25 ` John Garry 2017-12-15 11:22 ` John Garry 2017-12-15 11:22 ` John Garry 2017-12-16 18:47 ` Andi Kleen 2017-12-16 18:47 ` Andi Kleen 2018-01-02 12:07 ` John Garry 2018-01-02 12:07 ` John Garry 2018-01-02 17:48 ` Andi Kleen 2018-01-02 17:48 ` Andi Kleen 2018-01-03 12:22 ` John Garry 2018-01-03 12:22 ` John Garry 2017-12-21 19:39 ` Jiri Olsa 2017-12-21 19:39 ` Jiri Olsa 2018-01-04 17:17 ` John Garry 2018-01-04 17:17 ` John Garry 2018-01-08 14:08 ` Jiri Olsa 2018-01-08 14:08 ` Jiri Olsa 2017-12-06 13:37 ` Jiri Olsa 2017-12-06 13:37 ` Jiri Olsa 2017-12-06 14:40 ` John Garry [this message] 2017-12-06 14:40 ` John Garry 2017-12-08 12:31 ` Jiri Olsa 2017-12-08 12:31 ` Jiri Olsa 2017-12-08 15:38 ` John Garry 2017-12-08 15:38 ` John Garry 2017-12-09 7:26 ` Jiri Olsa 2017-12-09 7:26 ` Jiri Olsa 2017-12-05 16:13 ` [RFC PATCH 3/5] perf vendor events arm64: add armv8 recommended events JSON John Garry 2017-12-05 16:13 ` John Garry 2017-12-05 16:13 ` [RFC PATCH 4/5] perf vendor events arm64: relocate thunderx2 JSON John Garry 2017-12-05 16:13 ` John Garry 2017-12-05 16:13 ` [RFC PATCH 5/5] perf vendor events arm64: add HiSilicon hip08 JSON John Garry 2017-12-05 16:13 ` John Garry 2017-12-06 16:42 ` [RFC PATCH 0/5] perf events patches for improved ARM64 support William Cohen 2017-12-06 16:42 ` William Cohen 2017-12-06 17:35 ` John Garry 2017-12-06 17:35 ` John Garry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f58001e9-86fa-c6e6-b9c7-fb748d340da1@huawei.com \ --to=john.garry@huawei.com \ --cc=acme@kernel.org \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=catalin.marinas@arm.com \ --cc=ganapatrao.kulkarni@cavium.com \ --cc=jolsa@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mark.rutland@arm.com \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=wcohen@redhat.com \ --cc=will.deacon@arm.com \ --cc=xuwei5@hisilicon.com \ --cc=zhangshaokun@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.