* [MODERATED] qemu patch for mb_clear
@ 2018-12-21 0:31 Andi Kleen
2019-01-09 17:09 ` [MODERATED] " Konrad Rzeszutek Wilk
2019-03-01 14:37 ` Josh Poimboeuf
0 siblings, 2 replies; 8+ messages in thread
From: Andi Kleen @ 2018-12-21 0:31 UTC (permalink / raw)
To: speck
For reference here is the qemu patch needed for using MB_CLEAR in a KVM
guest.
-Andi
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 677a3bd5fb25..77a1149e4bb3 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -1038,7 +1038,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
.feat_names = {
NULL, NULL, "avx512-4vnniw", "avx512-4fmaps",
NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL,
+ NULL, NULL, "mbclear", NULL,
NULL, NULL, NULL, NULL,
NULL, NULL, "pconfig", NULL,
NULL, NULL, NULL, NULL,
^ permalink raw reply related [flat|nested] 8+ messages in thread* [MODERATED] Re: qemu patch for mb_clear
2018-12-21 0:31 [MODERATED] qemu patch for mb_clear Andi Kleen
@ 2019-01-09 17:09 ` Konrad Rzeszutek Wilk
2019-01-09 17:33 ` Andi Kleen
2019-01-09 21:44 ` Paolo Bonzini
2019-03-01 14:37 ` Josh Poimboeuf
1 sibling, 2 replies; 8+ messages in thread
From: Konrad Rzeszutek Wilk @ 2019-01-09 17:09 UTC (permalink / raw)
To: speck
On Thu, Dec 20, 2018 at 04:31:01PM -0800, speck for Andi Kleen wrote:
>
> For reference here is the qemu patch needed for using MB_CLEAR in a KVM
> guest.
I thought it was called 'MD_CLEAR' ?
>
> -Andi
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 677a3bd5fb25..77a1149e4bb3 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -1038,7 +1038,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> .feat_names = {
> NULL, NULL, "avx512-4vnniw", "avx512-4fmaps",
> NULL, NULL, NULL, NULL,
> - NULL, NULL, NULL, NULL,
> + NULL, NULL, "mbclear", NULL,
> NULL, NULL, NULL, NULL,
> NULL, NULL, "pconfig", NULL,
> NULL, NULL, NULL, NULL,
^ permalink raw reply [flat|nested] 8+ messages in thread* [MODERATED] Re: qemu patch for mb_clear
2019-01-09 17:09 ` [MODERATED] " Konrad Rzeszutek Wilk
@ 2019-01-09 17:33 ` Andi Kleen
2019-01-09 21:44 ` Paolo Bonzini
1 sibling, 0 replies; 8+ messages in thread
From: Andi Kleen @ 2019-01-09 17:33 UTC (permalink / raw)
To: speck
On Wed, Jan 09, 2019 at 12:09:19PM -0500, speck for Konrad Rzeszutek Wilk wrote:
> On Thu, Dec 20, 2018 at 04:31:01PM -0800, speck for Andi Kleen wrote:
> >
> > For reference here is the qemu patch needed for using MB_CLEAR in a KVM
> > guest.
>
> I thought it was called 'MD_CLEAR' ?
So far it's still called MB_CLEAR in the white papers AFAIK.
-Andi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [MODERATED] Re: qemu patch for mb_clear
2019-01-09 17:09 ` [MODERATED] " Konrad Rzeszutek Wilk
2019-01-09 17:33 ` Andi Kleen
@ 2019-01-09 21:44 ` Paolo Bonzini
2019-01-09 21:55 ` Andi Kleen
1 sibling, 1 reply; 8+ messages in thread
From: Paolo Bonzini @ 2019-01-09 21:44 UTC (permalink / raw)
To: speck
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
On 09/01/19 18:09, speck for Konrad Rzeszutek Wilk wrote:
> On Thu, Dec 20, 2018 at 04:31:01PM -0800, speck for Andi Kleen wrote:
>>
>> For reference here is the qemu patch needed for using MB_CLEAR in a KVM
>> guest.
>
> I thought it was called 'MD_CLEAR' ?
>
>>
>> -Andi
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index 677a3bd5fb25..77a1149e4bb3 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -1038,7 +1038,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>> .feat_names = {
>> NULL, NULL, "avx512-4vnniw", "avx512-4fmaps",
>> NULL, NULL, NULL, NULL,
>> - NULL, NULL, NULL, NULL,
>> + NULL, NULL, "mbclear", NULL,
>> NULL, NULL, NULL, NULL,
>> NULL, NULL, "pconfig", NULL,
>> NULL, NULL, NULL, NULL,
Are there any CPU families which will all have it (e.g. IceLake server,
Cascade Lake?). Prerelease/prototype silicon does not count.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread* [MODERATED] Re: qemu patch for mb_clear
2019-01-09 21:44 ` Paolo Bonzini
@ 2019-01-09 21:55 ` Andi Kleen
2019-01-09 22:37 ` Paolo Bonzini
0 siblings, 1 reply; 8+ messages in thread
From: Andi Kleen @ 2019-01-09 21:55 UTC (permalink / raw)
To: speck
> >> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> >> index 677a3bd5fb25..77a1149e4bb3 100644
> >> --- a/target/i386/cpu.c
> >> +++ b/target/i386/cpu.c
> >> @@ -1038,7 +1038,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> >> .feat_names = {
> >> NULL, NULL, "avx512-4vnniw", "avx512-4fmaps",
> >> NULL, NULL, NULL, NULL,
> >> - NULL, NULL, NULL, NULL,
> >> + NULL, NULL, "mbclear", NULL,
> >> NULL, NULL, NULL, NULL,
> >> NULL, NULL, "pconfig", NULL,
> >> NULL, NULL, NULL, NULL,
>
> Are there any CPU families which will all have it (e.g. IceLake server,
> Cascade Lake?). Prerelease/prototype silicon does not count.
All the past ones which get the VERW microcode update
(somewhere between Nehalem and Skylake)
Future systems which don't have/need VERW won't have it in fact
-Andi
^ permalink raw reply [flat|nested] 8+ messages in thread* [MODERATED] Re: qemu patch for mb_clear
2019-01-09 21:55 ` Andi Kleen
@ 2019-01-09 22:37 ` Paolo Bonzini
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2019-01-09 22:37 UTC (permalink / raw)
To: speck
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
On 09/01/19 22:55, speck for Andi Kleen wrote:
>>>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>>>> index 677a3bd5fb25..77a1149e4bb3 100644
>>>> --- a/target/i386/cpu.c
>>>> +++ b/target/i386/cpu.c
>>>> @@ -1038,7 +1038,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>>>> .feat_names = {
>>>> NULL, NULL, "avx512-4vnniw", "avx512-4fmaps",
>>>> NULL, NULL, NULL, NULL,
>>>> - NULL, NULL, NULL, NULL,
>>>> + NULL, NULL, "mbclear", NULL,
>>>> NULL, NULL, NULL, NULL,
>>>> NULL, NULL, "pconfig", NULL,
>>>> NULL, NULL, NULL, NULL,
>>
>> Are there any CPU families which will all have it (e.g. IceLake server,
>> Cascade Lake?). Prerelease/prototype silicon does not count.
>
> All the past ones which get the VERW microcode update
> (somewhere between Nehalem and Skylake)
>
> Future systems which don't have/need VERW won't have it in fact
Then
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks!
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [MODERATED] Re: qemu patch for mb_clear
2018-12-21 0:31 [MODERATED] qemu patch for mb_clear Andi Kleen
2019-01-09 17:09 ` [MODERATED] " Konrad Rzeszutek Wilk
@ 2019-03-01 14:37 ` Josh Poimboeuf
2019-03-01 15:11 ` Josh Poimboeuf
1 sibling, 1 reply; 8+ messages in thread
From: Josh Poimboeuf @ 2019-03-01 14:37 UTC (permalink / raw)
To: speck
On Thu, Dec 20, 2018 at 04:31:01PM -0800, speck for Andi Kleen wrote:
>
> For reference here is the qemu patch needed for using MB_CLEAR in a KVM
> guest.
>
> -Andi
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 677a3bd5fb25..77a1149e4bb3 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -1038,7 +1038,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> .feat_names = {
> NULL, NULL, "avx512-4vnniw", "avx512-4fmaps",
> NULL, NULL, NULL, NULL,
> - NULL, NULL, NULL, NULL,
> + NULL, NULL, "mbclear", NULL,
> NULL, NULL, NULL, NULL,
> NULL, NULL, "pconfig", NULL,
> NULL, NULL, NULL, NULL,
Is this still the latest version of the qemu patch? I assume this needs
to be updated to MD_CLEAR.
--
Josh
^ permalink raw reply [flat|nested] 8+ messages in thread* [MODERATED] Re: qemu patch for mb_clear
2019-03-01 14:37 ` Josh Poimboeuf
@ 2019-03-01 15:11 ` Josh Poimboeuf
0 siblings, 0 replies; 8+ messages in thread
From: Josh Poimboeuf @ 2019-03-01 15:11 UTC (permalink / raw)
To: speck
On Fri, Mar 01, 2019 at 08:37:29AM -0600, Josh Poimboeuf wrote:
> On Thu, Dec 20, 2018 at 04:31:01PM -0800, speck for Andi Kleen wrote:
> >
> > For reference here is the qemu patch needed for using MB_CLEAR in a KVM
> > guest.
> >
> > -Andi
> >
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index 677a3bd5fb25..77a1149e4bb3 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
> > @@ -1038,7 +1038,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> > .feat_names = {
> > NULL, NULL, "avx512-4vnniw", "avx512-4fmaps",
> > NULL, NULL, NULL, NULL,
> > - NULL, NULL, NULL, NULL,
> > + NULL, NULL, "mbclear", NULL,
> > NULL, NULL, NULL, NULL,
> > NULL, NULL, "pconfig", NULL,
> > NULL, NULL, NULL, NULL,
>
> Is this still the latest version of the qemu patch? I assume this needs
> to be updated to MD_CLEAR.
Also:
- A patch title and description would be helpful.
- Calling it "md-clear" (with the dash) would be preferable, as people
constantly get confused when the names differ (and apparently qemu
uses dashes instead of underscores).
--
Josh
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-01 15:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-21 0:31 [MODERATED] qemu patch for mb_clear Andi Kleen
2019-01-09 17:09 ` [MODERATED] " Konrad Rzeszutek Wilk
2019-01-09 17:33 ` Andi Kleen
2019-01-09 21:44 ` Paolo Bonzini
2019-01-09 21:55 ` Andi Kleen
2019-01-09 22:37 ` Paolo Bonzini
2019-03-01 14:37 ` Josh Poimboeuf
2019-03-01 15:11 ` Josh Poimboeuf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.