* [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync()
@ 2019-03-21 8:58 ` Wei Yongjun
0 siblings, 0 replies; 10+ messages in thread
From: Wei Yongjun @ 2019-03-21 8:58 UTC (permalink / raw)
To: Jon Maloy, Ying Xue, Hoang Le
Cc: Wei Yongjun, netdev, tipc-discussion, kernel-janitors
Fix the return value check which testing the wrong variable
in tipc_mcast_send_sync().
Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/tipc/bcast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
index 5264a8ff6e01..a41c0fa9c650 100644
--- a/net/tipc/bcast.c
+++ b/net/tipc/bcast.c
@@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
/* Allocate dummy message */
_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
- if (!skb)
+ if (!_skb)
return -ENOMEM;
/* Preparing for 'synching' header */
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync()
@ 2019-03-21 8:58 ` Wei Yongjun
0 siblings, 0 replies; 10+ messages in thread
From: Wei Yongjun @ 2019-03-21 8:58 UTC (permalink / raw)
To: Jon Maloy, Ying Xue, Hoang Le
Cc: Wei Yongjun, netdev, tipc-discussion, kernel-janitors
Fix the return value check which testing the wrong variable
in tipc_mcast_send_sync().
Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/tipc/bcast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
index 5264a8ff6e01..a41c0fa9c650 100644
--- a/net/tipc/bcast.c
+++ b/net/tipc/bcast.c
@@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
/* Allocate dummy message */
_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
- if (!skb)
+ if (!_skb)
return -ENOMEM;
/* Preparing for 'synching' header */
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync()
2019-03-21 8:58 ` Wei Yongjun
@ 2019-03-21 8:58 ` Eric Dumazet
-1 siblings, 0 replies; 10+ messages in thread
From: Eric Dumazet @ 2019-03-21 8:58 UTC (permalink / raw)
To: Wei Yongjun, Jon Maloy, Ying Xue, Hoang Le
Cc: netdev, tipc-discussion, kernel-janitors
On 03/21/2019 01:58 AM, Wei Yongjun wrote:
> Fix the return value check which testing the wrong variable
> in tipc_mcast_send_sync().
>
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> net/tipc/bcast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
> index 5264a8ff6e01..a41c0fa9c650 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
>
> /* Allocate dummy message */
> _skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
> - if (!skb)
> + if (!_skb)
> return -ENOMEM;
>
> /* Preparing for 'synching' header */
>
>
>
Thanks for the patch, but some 'Reported-by:' tags are missing :/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync()
@ 2019-03-21 8:58 ` Eric Dumazet
0 siblings, 0 replies; 10+ messages in thread
From: Eric Dumazet @ 2019-03-21 8:58 UTC (permalink / raw)
To: Wei Yongjun, Jon Maloy, Ying Xue, Hoang Le
Cc: netdev, tipc-discussion, kernel-janitors
On 03/21/2019 01:58 AM, Wei Yongjun wrote:
> Fix the return value check which testing the wrong variable
> in tipc_mcast_send_sync().
>
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> net/tipc/bcast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
> index 5264a8ff6e01..a41c0fa9c650 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
>
> /* Allocate dummy message */
> _skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
> - if (!skb)
> + if (!_skb)
> return -ENOMEM;
>
> /* Preparing for 'synching' header */
>
>
>
Thanks for the patch, but some 'Reported-by:' tags are missing :/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync()
2019-03-21 8:58 ` Wei Yongjun
@ 2019-03-25 6:31 ` Wei Yongjun
-1 siblings, 0 replies; 10+ messages in thread
From: Wei Yongjun @ 2019-03-25 6:31 UTC (permalink / raw)
To: Jon Maloy, Ying Xue, Hoang Le, Eric Dumazet
Cc: Wei Yongjun, netdev, tipc-discussion, kernel-janitors, Hulk Robot
Fix the return value check which testing the wrong variable
in tipc_mcast_send_sync().
Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: add reported-by
---
net/tipc/bcast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
index 88edfb358ae7..76e14dc08bb9 100644
--- a/net/tipc/bcast.c
+++ b/net/tipc/bcast.c
@@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
/* Allocate dummy message */
_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
- if (!skb)
+ if (!_skb)
return -ENOMEM;
/* Preparing for 'synching' header */
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync()
@ 2019-03-25 6:31 ` Wei Yongjun
0 siblings, 0 replies; 10+ messages in thread
From: Wei Yongjun @ 2019-03-25 6:31 UTC (permalink / raw)
To: Jon Maloy, Ying Xue, Hoang Le, Eric Dumazet
Cc: Wei Yongjun, netdev, tipc-discussion, kernel-janitors, Hulk Robot
Fix the return value check which testing the wrong variable
in tipc_mcast_send_sync().
Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: add reported-by
---
net/tipc/bcast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
index 88edfb358ae7..76e14dc08bb9 100644
--- a/net/tipc/bcast.c
+++ b/net/tipc/bcast.c
@@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
/* Allocate dummy message */
_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
- if (!skb)
+ if (!_skb)
return -ENOMEM;
/* Preparing for 'synching' header */
^ permalink raw reply related [flat|nested] 10+ messages in thread* RE: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync()
2019-03-25 6:31 ` Wei Yongjun
@ 2019-03-25 16:29 ` Jon Maloy
-1 siblings, 0 replies; 10+ messages in thread
From: Jon Maloy @ 2019-03-25 16:29 UTC (permalink / raw)
To: Wei Yongjun, Ying Xue, Hoang Huu Le, Eric Dumazet
Cc: netdev, tipc-discussion, kernel-janitors, Hulk Robot
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org>
> On Behalf Of Wei Yongjun
> Sent: 25-Mar-19 07:31
> To: Jon Maloy <jon.maloy@ericsson.com>; Ying Xue
> <ying.xue@windriver.com>; Hoang Huu Le <hoang.h.le@dektech.com.au>;
> Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>; netdev@vger.kernel.org;
> tipc-discussion@lists.sourceforge.net; kernel-janitors@vger.kernel.org; Hulk
> Robot <hulkci@huawei.com>
> Subject: [PATCH net-next v2] tipc: fix return value check in
> tipc_mcast_send_sync()
>
> Fix the return value check which testing the wrong variable in
> tipc_mcast_send_sync().
>
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> v1 -> v2: add reported-by
> ---
> net/tipc/bcast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index
> 88edfb358ae7..76e14dc08bb9 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net,
> struct sk_buff *skb,
>
> /* Allocate dummy message */
> _skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
> - if (!skb)
> + if (!_skb)
> return -ENOMEM;
>
> /* Preparing for 'synching' header */
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync()
@ 2019-03-25 16:29 ` Jon Maloy
0 siblings, 0 replies; 10+ messages in thread
From: Jon Maloy @ 2019-03-25 16:29 UTC (permalink / raw)
To: Wei Yongjun, Ying Xue, Hoang Huu Le, Eric Dumazet
Cc: netdev, tipc-discussion, kernel-janitors, Hulk Robot
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org>
> On Behalf Of Wei Yongjun
> Sent: 25-Mar-19 07:31
> To: Jon Maloy <jon.maloy@ericsson.com>; Ying Xue
> <ying.xue@windriver.com>; Hoang Huu Le <hoang.h.le@dektech.com.au>;
> Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>; netdev@vger.kernel.org;
> tipc-discussion@lists.sourceforge.net; kernel-janitors@vger.kernel.org; Hulk
> Robot <hulkci@huawei.com>
> Subject: [PATCH net-next v2] tipc: fix return value check in
> tipc_mcast_send_sync()
>
> Fix the return value check which testing the wrong variable in
> tipc_mcast_send_sync().
>
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> v1 -> v2: add reported-by
> ---
> net/tipc/bcast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index
> 88edfb358ae7..76e14dc08bb9 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net,
> struct sk_buff *skb,
>
> /* Allocate dummy message */
> _skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
> - if (!skb)
> + if (!_skb)
> return -ENOMEM;
>
> /* Preparing for 'synching' header */
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync()
2019-03-25 6:31 ` Wei Yongjun
@ 2019-03-26 18:39 ` David Miller
-1 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2019-03-26 18:39 UTC (permalink / raw)
To: weiyongjun1
Cc: jon.maloy, ying.xue, hoang.h.le, eric.dumazet, netdev,
tipc-discussion, kernel-janitors, hulkci
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Mon, 25 Mar 2019 06:31:09 +0000
> Fix the return value check which testing the wrong variable
> in tipc_mcast_send_sync().
>
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> v1 -> v2: add reported-by
Applied.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync()
@ 2019-03-26 18:39 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2019-03-26 18:39 UTC (permalink / raw)
To: weiyongjun1
Cc: jon.maloy, ying.xue, hoang.h.le, eric.dumazet, netdev,
tipc-discussion, kernel-janitors, hulkci
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Mon, 25 Mar 2019 06:31:09 +0000
> Fix the return value check which testing the wrong variable
> in tipc_mcast_send_sync().
>
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> v1 -> v2: add reported-by
Applied.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-03-26 18:40 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 8:58 [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync() Wei Yongjun
2019-03-21 8:58 ` Wei Yongjun
2019-03-21 8:58 ` Eric Dumazet
2019-03-21 8:58 ` Eric Dumazet
2019-03-25 6:31 ` [PATCH net-next v2] " Wei Yongjun
2019-03-25 6:31 ` Wei Yongjun
2019-03-25 16:29 ` Jon Maloy
2019-03-25 16:29 ` Jon Maloy
2019-03-26 18:39 ` David Miller
2019-03-26 18:39 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.