From: Jason Gunthorpe <jgg@ziepe.ca>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
"masahiroy@kernel.org" <masahiroy@kernel.org>,
"leon@kernel.org" <leon@kernel.org>,
"Laurent.pinchart@ideasonboard.com"
<Laurent.pinchart@ideasonboard.com>,
"kieran.bingham+renesas@ideasonboard.com"
<kieran.bingham+renesas@ideasonboard.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nico@fluxnic.net" <nico@fluxnic.net>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"a.hajda@samsung.com" <a.hajda@samsung.com>,
"jonas@kwiboo.se" <jonas@kwiboo.se>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"airlied@linux.ie" <airlied@linux.ie>,
"jernej.skrabec@siol.net" <jernej.skrabec@siol.net>
Subject: Re: [RFC 0/6] Regressions for "imply" behavior change
Date: Fri, 10 Apr 2020 14:13:20 -0300 [thread overview]
Message-ID: <20200410171320.GN11886@ziepe.ca> (raw)
In-Reply-To: <7d9410a4b7d0ef975f7cbd8f0b6762df114df539.camel@mellanox.com>
On Fri, Apr 10, 2020 at 02:40:42AM +0000, Saeed Mahameed wrote:
> This assumes that the module using FOO has its own flag representing
> FOO which is not always the case.
>
> for example in mlx5 we use VXLAN config flag directly to compile VXLAN
> related files:
>
> mlx5/core/Makefile:
>
> obj-$(CONFIG_MLX5_CORE) += mlx5_core.o
>
> mlx5_core-y := mlx5_core.o
> mlx5_core-$(VXLAN) += mlx5_vxlan.o
>
> and in mlx5_main.o we do:
Does this work if VXLAN = m ?
> if (IS_ENABLED(VXLAN))
> mlx5_vxlan_init()
>
> after the change in imply semantics:
> our options are:
>
> 1) use IS_REACHABLE(VXLAN) instead of IS_ENABLED(VXLAN)
>
> 2) have MLX5_VXLAN in mlx5 Kconfig and use IS_ENABLED(MLX5_VXLAN)
> config MLX5_VXLAN
> depends on VXLAN || !VXLAN
> bool
Does this trick work when vxlan is a bool not a tristate?
Why not just put the VXLAN || !VXLAN directly on MLX5_CORE?
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"airlied@linux.ie" <airlied@linux.ie>,
"jernej.skrabec@siol.net" <jernej.skrabec@siol.net>,
"arnd@arndb.de" <arnd@arndb.de>,
"leon@kernel.org" <leon@kernel.org>,
"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"masahiroy@kernel.org" <masahiroy@kernel.org>,
"nico@fluxnic.net" <nico@fluxnic.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"a.hajda@samsung.com" <a.hajda@samsung.com>,
"jonas@kwiboo.se" <jonas@kwiboo.se>,
"kieran.bingham+renesas@ideasonboard.com"
<kieran.bingham+renesas@ideasonboard.com>,
"Laurent.pinchart@ideasonboard.com"
<Laurent.pinchart@ideasonboard.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [RFC 0/6] Regressions for "imply" behavior change
Date: Fri, 10 Apr 2020 14:13:20 -0300 [thread overview]
Message-ID: <20200410171320.GN11886@ziepe.ca> (raw)
In-Reply-To: <7d9410a4b7d0ef975f7cbd8f0b6762df114df539.camel@mellanox.com>
On Fri, Apr 10, 2020 at 02:40:42AM +0000, Saeed Mahameed wrote:
> This assumes that the module using FOO has its own flag representing
> FOO which is not always the case.
>
> for example in mlx5 we use VXLAN config flag directly to compile VXLAN
> related files:
>
> mlx5/core/Makefile:
>
> obj-$(CONFIG_MLX5_CORE) += mlx5_core.o
>
> mlx5_core-y := mlx5_core.o
> mlx5_core-$(VXLAN) += mlx5_vxlan.o
>
> and in mlx5_main.o we do:
Does this work if VXLAN = m ?
> if (IS_ENABLED(VXLAN))
> mlx5_vxlan_init()
>
> after the change in imply semantics:
> our options are:
>
> 1) use IS_REACHABLE(VXLAN) instead of IS_ENABLED(VXLAN)
>
> 2) have MLX5_VXLAN in mlx5 Kconfig and use IS_ENABLED(MLX5_VXLAN)
> config MLX5_VXLAN
> depends on VXLAN || !VXLAN
> bool
Does this trick work when vxlan is a bool not a tristate?
Why not just put the VXLAN || !VXLAN directly on MLX5_CORE?
Jason
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-10 17:13 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 20:27 [RFC 0/6] Regressions for "imply" behavior change Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 20:27 ` [RFC 1/6] thunder: select PTP driver if possible Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 20:27 ` [RFC 2/6] net/mlx5e: fix VXLAN dependency Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 20:27 ` [RFC 3/6] LiquidIO VF: add dependency for PTP_1588_CLOCK Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 21:10 ` kbuild test robot
2020-04-08 21:13 ` Arnd Bergmann
2020-04-08 20:27 ` [RFC 4/6] drm/bridge/sii8620: fix extcon dependency Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-10 6:56 ` Andrzej Hajda
2020-04-10 6:56 ` Andrzej Hajda
2020-04-14 15:04 ` Arnd Bergmann
2020-04-14 15:04 ` Arnd Bergmann
2020-04-14 15:37 ` Daniel Vetter
2020-04-14 15:37 ` Daniel Vetter
2020-04-15 6:58 ` Jani Nikula
2020-04-15 6:58 ` Jani Nikula
2020-04-08 20:27 ` [RFC 5/6] drm/rcar-du: fix selection of CMM driver Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-14 20:17 ` Laurent Pinchart
2020-04-14 20:17 ` Laurent Pinchart
2020-04-14 20:38 ` Arnd Bergmann
2020-04-14 20:38 ` Arnd Bergmann
2020-04-14 20:51 ` Laurent Pinchart
2020-04-14 20:51 ` Laurent Pinchart
2020-04-14 21:10 ` Arnd Bergmann
2020-04-14 21:10 ` Arnd Bergmann
2020-04-15 14:13 ` Geert Uytterhoeven
2020-04-15 14:13 ` Geert Uytterhoeven
2020-04-15 15:18 ` Arnd Bergmann
2020-04-15 15:18 ` Arnd Bergmann
2020-04-15 19:07 ` Arnd Bergmann
2020-04-15 19:07 ` Arnd Bergmann
2020-04-15 21:12 ` Laurent Pinchart
2020-04-15 21:12 ` Laurent Pinchart
2020-04-15 21:22 ` Arnd Bergmann
2020-04-15 21:22 ` Arnd Bergmann
2020-04-16 6:51 ` Daniel Vetter
2020-04-16 6:51 ` Daniel Vetter
2020-04-16 15:17 ` Laurent Pinchart
2020-04-16 15:17 ` Laurent Pinchart
2020-04-08 20:27 ` [RFC 6/6] drm/rcar-du: fix lvds dependency Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 20:38 ` [RFC 0/6] Regressions for "imply" behavior change Nicolas Pitre
2020-04-08 20:38 ` Nicolas Pitre
2020-04-08 20:46 ` Saeed Mahameed
2020-04-08 20:46 ` Saeed Mahameed
2020-04-08 20:49 ` Arnd Bergmann
2020-04-08 20:49 ` Arnd Bergmann
2020-04-08 21:17 ` Nicolas Pitre
2020-04-08 21:17 ` Nicolas Pitre
2020-04-08 22:42 ` Jason Gunthorpe
2020-04-08 22:42 ` Jason Gunthorpe
2020-04-09 8:41 ` Jani Nikula
2020-04-09 8:41 ` Jani Nikula
2020-04-10 2:40 ` Saeed Mahameed
2020-04-10 2:40 ` Saeed Mahameed
2020-04-10 7:26 ` Geert Uytterhoeven
2020-04-10 7:26 ` Geert Uytterhoeven
2020-04-10 17:13 ` Jason Gunthorpe [this message]
2020-04-10 17:13 ` Jason Gunthorpe
2020-04-10 19:04 ` Saeed Mahameed
2020-04-10 19:04 ` Saeed Mahameed
2020-04-14 13:29 ` Jason Gunthorpe
2020-04-14 13:29 ` Jason Gunthorpe
2020-04-14 14:27 ` Arnd Bergmann
2020-04-14 14:27 ` Arnd Bergmann
2020-04-14 15:23 ` Jason Gunthorpe
2020-04-14 15:23 ` Jason Gunthorpe
2020-04-14 15:25 ` Arnd Bergmann
2020-04-14 15:25 ` Arnd Bergmann
2020-04-14 17:49 ` Saeed Mahameed
2020-04-14 17:49 ` Saeed Mahameed
2020-04-14 18:47 ` Arnd Bergmann
2020-04-14 18:47 ` Arnd Bergmann
2020-04-16 3:25 ` Saeed Mahameed
2020-04-16 3:25 ` Saeed Mahameed
2020-04-16 7:20 ` Arnd Bergmann
2020-04-16 7:20 ` Arnd Bergmann
2020-04-16 10:17 ` Jani Nikula
2020-04-16 10:17 ` Jani Nikula
2020-04-16 12:38 ` Arnd Bergmann
2020-04-16 12:38 ` Arnd Bergmann
2020-04-16 14:52 ` Jason Gunthorpe
2020-04-16 14:52 ` Jason Gunthorpe
2020-04-16 15:58 ` Arnd Bergmann
2020-04-16 15:58 ` Arnd Bergmann
2020-04-16 18:05 ` Jason Gunthorpe
2020-04-16 18:05 ` Jason Gunthorpe
2020-04-16 18:38 ` Saeed Mahameed
2020-04-16 18:38 ` Saeed Mahameed
2020-04-16 15:12 ` Nicolas Pitre
2020-04-16 15:12 ` Nicolas Pitre
2020-04-16 18:21 ` Jason Gunthorpe
2020-04-16 18:21 ` Jason Gunthorpe
2020-04-16 19:56 ` Andrzej Hajda
2020-04-16 19:56 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410171320.GN11886@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.