From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Masahiro Yamada <masahiroy@kernel.org>, Nicolas Pitre <nico@fluxnic.net>, Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@siol.net>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, "David S. Miller" <davem@davemloft.net>, Saeed Mahameed <saeedm@mellanox.com>, Leon Romanovsky <leon@kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Networking <netdev@vger.kernel.org>, linux-rdma <linux-rdma@vger.kernel.org> Subject: Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver Date: Thu, 16 Apr 2020 00:12:20 +0300 [thread overview] Message-ID: <20200415211220.GQ4758@pendragon.ideasonboard.com> (raw) In-Reply-To: <CAK8P3a0CoPUTSJp6ddDnmabo59iE73pugGSYayoeB5N57az9_w@mail.gmail.com> Hi Arnd, On Wed, Apr 15, 2020 at 09:07:14PM +0200, Arnd Bergmann wrote: > On Wed, Apr 15, 2020 at 5:18 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Wed, Apr 15, 2020 at 4:13 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > On Wed, Apr 15, 2020 at 3:47 PM Arnd Bergmann <arnd@arndb.de> wrote: > > > > On Tue, Apr 14, 2020 at 10:52 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > > > > Doesn't "imply" mean it gets selected by default but can be manually > > > > > disabled ? > > > > > > > > That may be what it means now (I still don't understand how it's defined > > > > as of v5.7-rc1), but traditionally it was more like a 'select if all > > > > dependencies are met'. > > > > > > That's still what it is supposed to mean right now ;-) > > > Except that now it should correctly handle the modular case, too. > > > > Then there is a bug. If I run 'make menuconfig' now on a mainline kernel > > and enable CONFIG_DRM_RCAR_DU, I can set > > DRM_RCAR_CMM and DRM_RCAR_LVDS to 'y', 'n' or 'm' regardless > > of whether CONFIG_DRM_RCAR_DU is 'm' or 'y'. The 'implies' > > statement seems to be ignored entirely, except as reverse 'default' > > setting. > > Here is another version that should do what we want and is only > half-ugly. I can send that as a proper patch if it passes my testing > and nobody hates it too much. This may be a stupid question, but doesn't this really call for fixing Kconfig ? This seems to be such a common pattern that requiring constructs similar to the ones below will be a never-ending chase of offenders. > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig > index 0919f1f159a4..d2fcec807dfa 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -4,8 +4,6 @@ config DRM_RCAR_DU > depends on DRM && OF > depends on ARM || ARM64 > depends on ARCH_RENESAS || COMPILE_TEST > - imply DRM_RCAR_CMM > - imply DRM_RCAR_LVDS > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > select DRM_GEM_CMA_HELPER > @@ -14,13 +12,17 @@ config DRM_RCAR_DU > Choose this option if you have an R-Car chipset. > If M is selected the module will be called rcar-du-drm. > > -config DRM_RCAR_CMM > - tristate "R-Car DU Color Management Module (CMM) Support" > - depends on DRM && OF > +config DRM_RCAR_USE_CMM > + bool "R-Car DU Color Management Module (CMM) Support" > depends on DRM_RCAR_DU > + default DRM_RCAR_DU > help > Enable support for R-Car Color Management Module (CMM). > > +config DRM_RCAR_CMM > + def_tristate DRM_RCAR_DU > + depends on DRM_RCAR_USE_CMM > + > config DRM_RCAR_DW_HDMI > tristate "R-Car DU Gen3 HDMI Encoder Support" > depends on DRM && OF > @@ -28,15 +30,20 @@ config DRM_RCAR_DW_HDMI > help > Enable support for R-Car Gen3 internal HDMI encoder. > > -config DRM_RCAR_LVDS > - tristate "R-Car DU LVDS Encoder Support" > - depends on DRM && DRM_BRIDGE && OF > +config DRM_RCAR_USE_LVDS > + bool "R-Car DU LVDS Encoder Support" > + depends on DRM_BRIDGE && OF > + default DRM_RCAR_DU > select DRM_PANEL > select OF_FLATTREE > select OF_OVERLAY > help > Enable support for the R-Car Display Unit embedded LVDS encoders. > > +config DRM_RCAR_LVDS > + def_tristate DRM_RCAR_DU > + depends on DRM_RCAR_USE_LVDS > + > config DRM_RCAR_VSP > bool "R-Car DU VSP Compositor Support" if ARM > default y if ARM64 -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Jernej Skrabec <jernej.skrabec@siol.net>, Leon Romanovsky <leon@kernel.org>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, Networking <netdev@vger.kernel.org>, Masahiro Yamada <masahiroy@kernel.org>, Nicolas Pitre <nico@fluxnic.net>, Saeed Mahameed <saeedm@mellanox.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Andrzej Hajda <a.hajda@samsung.com>, Jonas Karlman <jonas@kwiboo.se>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Geert Uytterhoeven <geert@linux-m68k.org>, "David S. Miller" <davem@davemloft.net>, linux-rdma <linux-rdma@vger.kernel.org> Subject: Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver Date: Thu, 16 Apr 2020 00:12:20 +0300 [thread overview] Message-ID: <20200415211220.GQ4758@pendragon.ideasonboard.com> (raw) In-Reply-To: <CAK8P3a0CoPUTSJp6ddDnmabo59iE73pugGSYayoeB5N57az9_w@mail.gmail.com> Hi Arnd, On Wed, Apr 15, 2020 at 09:07:14PM +0200, Arnd Bergmann wrote: > On Wed, Apr 15, 2020 at 5:18 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Wed, Apr 15, 2020 at 4:13 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > On Wed, Apr 15, 2020 at 3:47 PM Arnd Bergmann <arnd@arndb.de> wrote: > > > > On Tue, Apr 14, 2020 at 10:52 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > > > > Doesn't "imply" mean it gets selected by default but can be manually > > > > > disabled ? > > > > > > > > That may be what it means now (I still don't understand how it's defined > > > > as of v5.7-rc1), but traditionally it was more like a 'select if all > > > > dependencies are met'. > > > > > > That's still what it is supposed to mean right now ;-) > > > Except that now it should correctly handle the modular case, too. > > > > Then there is a bug. If I run 'make menuconfig' now on a mainline kernel > > and enable CONFIG_DRM_RCAR_DU, I can set > > DRM_RCAR_CMM and DRM_RCAR_LVDS to 'y', 'n' or 'm' regardless > > of whether CONFIG_DRM_RCAR_DU is 'm' or 'y'. The 'implies' > > statement seems to be ignored entirely, except as reverse 'default' > > setting. > > Here is another version that should do what we want and is only > half-ugly. I can send that as a proper patch if it passes my testing > and nobody hates it too much. This may be a stupid question, but doesn't this really call for fixing Kconfig ? This seems to be such a common pattern that requiring constructs similar to the ones below will be a never-ending chase of offenders. > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig > index 0919f1f159a4..d2fcec807dfa 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -4,8 +4,6 @@ config DRM_RCAR_DU > depends on DRM && OF > depends on ARM || ARM64 > depends on ARCH_RENESAS || COMPILE_TEST > - imply DRM_RCAR_CMM > - imply DRM_RCAR_LVDS > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > select DRM_GEM_CMA_HELPER > @@ -14,13 +12,17 @@ config DRM_RCAR_DU > Choose this option if you have an R-Car chipset. > If M is selected the module will be called rcar-du-drm. > > -config DRM_RCAR_CMM > - tristate "R-Car DU Color Management Module (CMM) Support" > - depends on DRM && OF > +config DRM_RCAR_USE_CMM > + bool "R-Car DU Color Management Module (CMM) Support" > depends on DRM_RCAR_DU > + default DRM_RCAR_DU > help > Enable support for R-Car Color Management Module (CMM). > > +config DRM_RCAR_CMM > + def_tristate DRM_RCAR_DU > + depends on DRM_RCAR_USE_CMM > + > config DRM_RCAR_DW_HDMI > tristate "R-Car DU Gen3 HDMI Encoder Support" > depends on DRM && OF > @@ -28,15 +30,20 @@ config DRM_RCAR_DW_HDMI > help > Enable support for R-Car Gen3 internal HDMI encoder. > > -config DRM_RCAR_LVDS > - tristate "R-Car DU LVDS Encoder Support" > - depends on DRM && DRM_BRIDGE && OF > +config DRM_RCAR_USE_LVDS > + bool "R-Car DU LVDS Encoder Support" > + depends on DRM_BRIDGE && OF > + default DRM_RCAR_DU > select DRM_PANEL > select OF_FLATTREE > select OF_OVERLAY > help > Enable support for the R-Car Display Unit embedded LVDS encoders. > > +config DRM_RCAR_LVDS > + def_tristate DRM_RCAR_DU > + depends on DRM_RCAR_USE_LVDS > + > config DRM_RCAR_VSP > bool "R-Car DU VSP Compositor Support" if ARM > default y if ARM64 -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-15 21:12 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-08 20:27 [RFC 0/6] Regressions for "imply" behavior change Arnd Bergmann 2020-04-08 20:27 ` Arnd Bergmann 2020-04-08 20:27 ` [RFC 1/6] thunder: select PTP driver if possible Arnd Bergmann 2020-04-08 20:27 ` Arnd Bergmann 2020-04-08 20:27 ` [RFC 2/6] net/mlx5e: fix VXLAN dependency Arnd Bergmann 2020-04-08 20:27 ` Arnd Bergmann 2020-04-08 20:27 ` [RFC 3/6] LiquidIO VF: add dependency for PTP_1588_CLOCK Arnd Bergmann 2020-04-08 20:27 ` Arnd Bergmann 2020-04-08 21:10 ` kbuild test robot 2020-04-08 21:13 ` Arnd Bergmann 2020-04-08 20:27 ` [RFC 4/6] drm/bridge/sii8620: fix extcon dependency Arnd Bergmann 2020-04-08 20:27 ` Arnd Bergmann 2020-04-10 6:56 ` Andrzej Hajda 2020-04-10 6:56 ` Andrzej Hajda 2020-04-14 15:04 ` Arnd Bergmann 2020-04-14 15:04 ` Arnd Bergmann 2020-04-14 15:37 ` Daniel Vetter 2020-04-14 15:37 ` Daniel Vetter 2020-04-15 6:58 ` Jani Nikula 2020-04-15 6:58 ` Jani Nikula 2020-04-08 20:27 ` [RFC 5/6] drm/rcar-du: fix selection of CMM driver Arnd Bergmann 2020-04-08 20:27 ` Arnd Bergmann 2020-04-14 20:17 ` Laurent Pinchart 2020-04-14 20:17 ` Laurent Pinchart 2020-04-14 20:38 ` Arnd Bergmann 2020-04-14 20:38 ` Arnd Bergmann 2020-04-14 20:51 ` Laurent Pinchart 2020-04-14 20:51 ` Laurent Pinchart 2020-04-14 21:10 ` Arnd Bergmann 2020-04-14 21:10 ` Arnd Bergmann 2020-04-15 14:13 ` Geert Uytterhoeven 2020-04-15 14:13 ` Geert Uytterhoeven 2020-04-15 15:18 ` Arnd Bergmann 2020-04-15 15:18 ` Arnd Bergmann 2020-04-15 19:07 ` Arnd Bergmann 2020-04-15 19:07 ` Arnd Bergmann 2020-04-15 21:12 ` Laurent Pinchart [this message] 2020-04-15 21:12 ` Laurent Pinchart 2020-04-15 21:22 ` Arnd Bergmann 2020-04-15 21:22 ` Arnd Bergmann 2020-04-16 6:51 ` Daniel Vetter 2020-04-16 6:51 ` Daniel Vetter 2020-04-16 15:17 ` Laurent Pinchart 2020-04-16 15:17 ` Laurent Pinchart 2020-04-08 20:27 ` [RFC 6/6] drm/rcar-du: fix lvds dependency Arnd Bergmann 2020-04-08 20:27 ` Arnd Bergmann 2020-04-08 20:38 ` [RFC 0/6] Regressions for "imply" behavior change Nicolas Pitre 2020-04-08 20:38 ` Nicolas Pitre 2020-04-08 20:46 ` Saeed Mahameed 2020-04-08 20:46 ` Saeed Mahameed 2020-04-08 20:49 ` Arnd Bergmann 2020-04-08 20:49 ` Arnd Bergmann 2020-04-08 21:17 ` Nicolas Pitre 2020-04-08 21:17 ` Nicolas Pitre 2020-04-08 22:42 ` Jason Gunthorpe 2020-04-08 22:42 ` Jason Gunthorpe 2020-04-09 8:41 ` Jani Nikula 2020-04-09 8:41 ` Jani Nikula 2020-04-10 2:40 ` Saeed Mahameed 2020-04-10 2:40 ` Saeed Mahameed 2020-04-10 7:26 ` Geert Uytterhoeven 2020-04-10 7:26 ` Geert Uytterhoeven 2020-04-10 17:13 ` Jason Gunthorpe 2020-04-10 17:13 ` Jason Gunthorpe 2020-04-10 19:04 ` Saeed Mahameed 2020-04-10 19:04 ` Saeed Mahameed 2020-04-14 13:29 ` Jason Gunthorpe 2020-04-14 13:29 ` Jason Gunthorpe 2020-04-14 14:27 ` Arnd Bergmann 2020-04-14 14:27 ` Arnd Bergmann 2020-04-14 15:23 ` Jason Gunthorpe 2020-04-14 15:23 ` Jason Gunthorpe 2020-04-14 15:25 ` Arnd Bergmann 2020-04-14 15:25 ` Arnd Bergmann 2020-04-14 17:49 ` Saeed Mahameed 2020-04-14 17:49 ` Saeed Mahameed 2020-04-14 18:47 ` Arnd Bergmann 2020-04-14 18:47 ` Arnd Bergmann 2020-04-16 3:25 ` Saeed Mahameed 2020-04-16 3:25 ` Saeed Mahameed 2020-04-16 7:20 ` Arnd Bergmann 2020-04-16 7:20 ` Arnd Bergmann 2020-04-16 10:17 ` Jani Nikula 2020-04-16 10:17 ` Jani Nikula 2020-04-16 12:38 ` Arnd Bergmann 2020-04-16 12:38 ` Arnd Bergmann 2020-04-16 14:52 ` Jason Gunthorpe 2020-04-16 14:52 ` Jason Gunthorpe 2020-04-16 15:58 ` Arnd Bergmann 2020-04-16 15:58 ` Arnd Bergmann 2020-04-16 18:05 ` Jason Gunthorpe 2020-04-16 18:05 ` Jason Gunthorpe 2020-04-16 18:38 ` Saeed Mahameed 2020-04-16 18:38 ` Saeed Mahameed 2020-04-16 15:12 ` Nicolas Pitre 2020-04-16 15:12 ` Nicolas Pitre 2020-04-16 18:21 ` Jason Gunthorpe 2020-04-16 18:21 ` Jason Gunthorpe 2020-04-16 19:56 ` Andrzej Hajda 2020-04-16 19:56 ` Andrzej Hajda
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200415211220.GQ4758@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=arnd@arndb.de \ --cc=daniel@ffwll.ch \ --cc=davem@davemloft.net \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=leon@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=masahiroy@kernel.org \ --cc=narmstrong@baylibre.com \ --cc=netdev@vger.kernel.org \ --cc=nico@fluxnic.net \ --cc=saeedm@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.