From: Miquel Raynal <miquel.raynal@bootlin.com> To: Pratyush Yadav <p.yadav@ti.com> Cc: <Tudor.Ambarus@microchip.com>, <richard@nod.at>, <vigneshr@ti.com>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <nsekhar@ti.com>, <boris.brezillon@collabora.com> Subject: Re: [PATCH v14 01/15] mtd: spi-nor: core: use EOPNOTSUPP instead of ENOTSUPP Date: Thu, 1 Oct 2020 09:50:12 +0200 [thread overview] Message-ID: <20201001095012.5c331bf8@xps13> (raw) In-Reply-To: <20201001073425.txsfdngrsugsy6uf@ti.com> Hello, Pratyush Yadav <p.yadav@ti.com> wrote on Thu, 1 Oct 2020 13:04:27 +0530: > On 01/10/20 07:19AM, Tudor.Ambarus@microchip.com wrote: > > On 9/30/20 9:57 PM, Pratyush Yadav wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe It seems that your mailer/server introduced that line automatically, can you do something to avoid it? > > > > > > ENOTSUPP is not a SUSV4 error code. Using EOPNOTSUPP is preferred > > > in its stead. I ran into this checkpatch.pl error recently, I count 80+ iterations in drivers/mtd/ so perhaps having a subsystem wide replacement will be nice. I'm fine with this patch though as it is addressing all SPI-NOR cases already. Cheers, Miquèl > > > > > > Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> > > > > The R-b tag should be after your S-o-b. This applies to other > > patches in the series too. No need to resubmit, it can be fixed when > > applying. > > If we're using chronological order then I first added your Reviewed-by, > and then signed off before resending the patches. So that way s-o-b > comes after r-b. > > Anyway, it doesn't really matter. Use whichever order you prefer. > > > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > > > --- > > > drivers/mtd/spi-nor/core.c | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > > > index 0369d98b2d12..4d0f8d165544 100644 > > > --- a/drivers/mtd/spi-nor/core.c > > > +++ b/drivers/mtd/spi-nor/core.c > > > @@ -2281,7 +2281,7 @@ static int spi_nor_hwcaps_pp2cmd(u32 hwcaps) > > > *@nor: pointer to a 'struct spi_nor' > > > *@op: pointer to op template to be checked > > > * > > > - * Returns 0 if operation is supported, -ENOTSUPP otherwise. > > > + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. > > > */ > > > static int spi_nor_spimem_check_op(struct spi_nor *nor, > > > struct spi_mem_op *op) > > > @@ -2295,12 +2295,12 @@ static int spi_nor_spimem_check_op(struct spi_nor *nor, > > > op->addr.nbytes = 4; > > > if (!spi_mem_supports_op(nor->spimem, op)) { > > > if (nor->mtd.size > SZ_16M) > > > - return -ENOTSUPP; > > > + return -EOPNOTSUPP; > > > > > > /* If flash size <= 16MB, 3 address bytes are sufficient */ > > > op->addr.nbytes = 3; > > > if (!spi_mem_supports_op(nor->spimem, op)) > > > - return -ENOTSUPP; > > > + return -EOPNOTSUPP; > > > } > > > > > > return 0; > > > @@ -2312,7 +2312,7 @@ static int spi_nor_spimem_check_op(struct spi_nor *nor, > > > *@nor: pointer to a 'struct spi_nor' > > > *@read: pointer to op template to be checked > > > * > > > - * Returns 0 if operation is supported, -ENOTSUPP otherwise. > > > + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. > > > */ > > > static int spi_nor_spimem_check_readop(struct spi_nor *nor, > > > const struct spi_nor_read_command *read) > > > @@ -2338,7 +2338,7 @@ static int spi_nor_spimem_check_readop(struct spi_nor *nor, > > > *@nor: pointer to a 'struct spi_nor' > > > *@pp: pointer to op template to be checked > > > * > > > - * Returns 0 if operation is supported, -ENOTSUPP otherwise. > > > + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. > > > */ > > > static int spi_nor_spimem_check_pp(struct spi_nor *nor, > > > const struct spi_nor_pp_command *pp) > > > -- > > > 2.28.0 > > > > > > Thanks, Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Pratyush Yadav <p.yadav@ti.com> Cc: vigneshr@ti.com, Tudor.Ambarus@microchip.com, richard@nod.at, nsekhar@ti.com, linux-kernel@vger.kernel.org, boris.brezillon@collabora.com, linux-mtd@lists.infradead.org Subject: Re: [PATCH v14 01/15] mtd: spi-nor: core: use EOPNOTSUPP instead of ENOTSUPP Date: Thu, 1 Oct 2020 09:50:12 +0200 [thread overview] Message-ID: <20201001095012.5c331bf8@xps13> (raw) In-Reply-To: <20201001073425.txsfdngrsugsy6uf@ti.com> Hello, Pratyush Yadav <p.yadav@ti.com> wrote on Thu, 1 Oct 2020 13:04:27 +0530: > On 01/10/20 07:19AM, Tudor.Ambarus@microchip.com wrote: > > On 9/30/20 9:57 PM, Pratyush Yadav wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe It seems that your mailer/server introduced that line automatically, can you do something to avoid it? > > > > > > ENOTSUPP is not a SUSV4 error code. Using EOPNOTSUPP is preferred > > > in its stead. I ran into this checkpatch.pl error recently, I count 80+ iterations in drivers/mtd/ so perhaps having a subsystem wide replacement will be nice. I'm fine with this patch though as it is addressing all SPI-NOR cases already. Cheers, Miquèl > > > > > > Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> > > > > The R-b tag should be after your S-o-b. This applies to other > > patches in the series too. No need to resubmit, it can be fixed when > > applying. > > If we're using chronological order then I first added your Reviewed-by, > and then signed off before resending the patches. So that way s-o-b > comes after r-b. > > Anyway, it doesn't really matter. Use whichever order you prefer. > > > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > > > --- > > > drivers/mtd/spi-nor/core.c | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > > > index 0369d98b2d12..4d0f8d165544 100644 > > > --- a/drivers/mtd/spi-nor/core.c > > > +++ b/drivers/mtd/spi-nor/core.c > > > @@ -2281,7 +2281,7 @@ static int spi_nor_hwcaps_pp2cmd(u32 hwcaps) > > > *@nor: pointer to a 'struct spi_nor' > > > *@op: pointer to op template to be checked > > > * > > > - * Returns 0 if operation is supported, -ENOTSUPP otherwise. > > > + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. > > > */ > > > static int spi_nor_spimem_check_op(struct spi_nor *nor, > > > struct spi_mem_op *op) > > > @@ -2295,12 +2295,12 @@ static int spi_nor_spimem_check_op(struct spi_nor *nor, > > > op->addr.nbytes = 4; > > > if (!spi_mem_supports_op(nor->spimem, op)) { > > > if (nor->mtd.size > SZ_16M) > > > - return -ENOTSUPP; > > > + return -EOPNOTSUPP; > > > > > > /* If flash size <= 16MB, 3 address bytes are sufficient */ > > > op->addr.nbytes = 3; > > > if (!spi_mem_supports_op(nor->spimem, op)) > > > - return -ENOTSUPP; > > > + return -EOPNOTSUPP; > > > } > > > > > > return 0; > > > @@ -2312,7 +2312,7 @@ static int spi_nor_spimem_check_op(struct spi_nor *nor, > > > *@nor: pointer to a 'struct spi_nor' > > > *@read: pointer to op template to be checked > > > * > > > - * Returns 0 if operation is supported, -ENOTSUPP otherwise. > > > + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. > > > */ > > > static int spi_nor_spimem_check_readop(struct spi_nor *nor, > > > const struct spi_nor_read_command *read) > > > @@ -2338,7 +2338,7 @@ static int spi_nor_spimem_check_readop(struct spi_nor *nor, > > > *@nor: pointer to a 'struct spi_nor' > > > *@pp: pointer to op template to be checked > > > * > > > - * Returns 0 if operation is supported, -ENOTSUPP otherwise. > > > + * Returns 0 if operation is supported, -EOPNOTSUPP otherwise. > > > */ > > > static int spi_nor_spimem_check_pp(struct spi_nor *nor, > > > const struct spi_nor_pp_command *pp) > > > -- > > > 2.28.0 > > > > > > Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-01 7:50 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-30 18:57 [PATCH v14 00/15] mtd: spi-nor: add xSPI Octal DTR support Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-09-30 18:57 ` [PATCH v14 01/15] mtd: spi-nor: core: use EOPNOTSUPP instead of ENOTSUPP Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 7:19 ` Tudor.Ambarus 2020-10-01 7:19 ` Tudor.Ambarus 2020-10-01 7:34 ` Pratyush Yadav 2020-10-01 7:34 ` Pratyush Yadav 2020-10-01 7:50 ` Miquel Raynal [this message] 2020-10-01 7:50 ` Miquel Raynal 2020-10-01 8:18 ` Tudor.Ambarus 2020-10-01 8:18 ` Tudor.Ambarus 2020-10-01 10:50 ` Vignesh Raghavendra 2020-10-01 10:50 ` Vignesh Raghavendra 2020-09-30 18:57 ` [PATCH v14 02/15] mtd: spi-nor: add spi_nor_controller_ops_{read_reg,write_reg,erase}() Pratyush Yadav 2020-09-30 18:57 ` [PATCH v14 02/15] mtd: spi-nor: add spi_nor_controller_ops_{read_reg, write_reg, erase}() Pratyush Yadav 2020-10-01 7:21 ` [PATCH v14 02/15] mtd: spi-nor: add spi_nor_controller_ops_{read_reg,write_reg,erase}() Tudor.Ambarus 2020-10-01 7:21 ` Tudor.Ambarus 2020-09-30 18:57 ` [PATCH v14 03/15] mtd: spi-nor: add support for DTR protocol Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 7:46 ` Tudor.Ambarus 2020-10-01 7:46 ` Tudor.Ambarus 2020-10-01 8:37 ` Pratyush Yadav 2020-10-01 8:37 ` Pratyush Yadav 2020-10-01 8:49 ` Tudor.Ambarus 2020-10-01 8:49 ` Tudor.Ambarus 2020-09-30 18:57 ` [PATCH v14 04/15] mtd: spi-nor: sfdp: get command opcode extension type from BFPT Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-09-30 18:57 ` [PATCH v14 05/15] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 7:49 ` Tudor.Ambarus 2020-10-01 7:49 ` Tudor.Ambarus 2020-09-30 18:57 ` [PATCH v14 06/15] mtd: spi-nor: core: use dummy cycle and address width info from SFDP Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 7:50 ` Tudor.Ambarus 2020-10-01 7:50 ` Tudor.Ambarus 2020-09-30 18:57 ` [PATCH v14 07/15] mtd: spi-nor: core: do 2 byte reads for SR and FSR in DTR mode Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 7:52 ` Tudor.Ambarus 2020-10-01 7:52 ` Tudor.Ambarus 2020-09-30 18:57 ` [PATCH v14 08/15] mtd: spi-nor: core: enable octal DTR mode when possible Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 8:09 ` Tudor.Ambarus 2020-10-01 8:09 ` Tudor.Ambarus 2020-10-01 8:42 ` Pratyush Yadav 2020-10-01 8:42 ` Pratyush Yadav 2020-09-30 18:57 ` [PATCH v14 09/15] mtd: spi-nor: Introduce SNOR_F_IO_MODE_EN_VOLATILE Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-09-30 18:57 ` [PATCH v14 10/15] mtd: spi-nor: Parse SFDP SCCR Map Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 8:20 ` Tudor.Ambarus 2020-10-01 8:20 ` Tudor.Ambarus 2020-10-01 11:56 ` Pratyush Yadav 2020-10-01 11:56 ` Pratyush Yadav 2020-09-30 18:57 ` [PATCH v14 11/15] mtd: spi-nor: sfdp: detect Soft Reset sequence support from BFPT Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 8:21 ` Tudor.Ambarus 2020-10-01 8:21 ` Tudor.Ambarus 2020-09-30 18:57 ` [PATCH v14 12/15] mtd: spi-nor: core: perform a Soft Reset on shutdown Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 8:23 ` Tudor.Ambarus 2020-10-01 8:23 ` Tudor.Ambarus 2020-09-30 18:57 ` [PATCH v14 13/15] mtd: spi-nor: core: disable Octal DTR mode on suspend Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 8:26 ` Tudor.Ambarus 2020-10-01 8:26 ` Tudor.Ambarus 2020-09-30 18:57 ` [PATCH v14 14/15] mtd: spi-nor: spansion: add support for Cypress Semper flash Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 8:35 ` Tudor.Ambarus 2020-10-01 8:35 ` Tudor.Ambarus 2020-10-01 8:40 ` Pratyush Yadav 2020-10-01 8:40 ` Pratyush Yadav 2020-10-01 8:50 ` Tudor.Ambarus 2020-10-01 8:50 ` Tudor.Ambarus 2020-09-30 18:57 ` [PATCH v14 15/15] mtd: spi-nor: micron-st: allow using MT35XU512ABA in Octal DTR mode Pratyush Yadav 2020-09-30 18:57 ` Pratyush Yadav 2020-10-01 8:38 ` Tudor.Ambarus 2020-10-01 8:38 ` Tudor.Ambarus 2020-10-01 19:43 ` Pratyush Yadav 2020-10-01 19:43 ` Pratyush Yadav
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201001095012.5c331bf8@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=boris.brezillon@collabora.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=nsekhar@ti.com \ --cc=p.yadav@ti.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.