From: Pratyush Yadav <p.yadav@ti.com> To: Maxime Ripard <mripard@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Pratyush Yadav <p.yadav@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Steve Longerbeam <slongerbeam@gmail.com>, Benoit Parrot <bparrot@ti.com>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>, <dmaengine@vger.kernel.org> Cc: Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Subject: [PATCH v2 07/18] media: cadence: csi2rx: Soft reset the streams before starting capture Date: Wed, 26 May 2021 20:52:57 +0530 [thread overview] Message-ID: <20210526152308.16525-8-p.yadav@ti.com> (raw) In-Reply-To: <20210526152308.16525-1-p.yadav@ti.com> This resets the stream state machines and FIFOs, giving them a clean slate. On J721E if the streams are not reset before starting the capture, the captured frame gets wrapped around vertically on every run after the first. Signed-off-by: Pratyush Yadav <p.yadav@ti.com> --- (no changes since v1) drivers/media/platform/cadence/cdns-csi2rx.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c index 459326de2eff..80a50284e525 100644 --- a/drivers/media/platform/cadence/cdns-csi2rx.c +++ b/drivers/media/platform/cadence/cdns-csi2rx.c @@ -39,6 +39,7 @@ #define CSI2RX_STREAM_BASE(n) (((n) + 1) * 0x100) #define CSI2RX_STREAM_CTRL_REG(n) (CSI2RX_STREAM_BASE(n) + 0x000) +#define CSI2RX_STREAM_CTRL_SOFT_RST BIT(4) #define CSI2RX_STREAM_CTRL_START BIT(0) #define CSI2RX_STREAM_DATA_CFG_REG(n) (CSI2RX_STREAM_BASE(n) + 0x008) @@ -150,12 +151,22 @@ struct csi2rx_priv *v4l2_subdev_to_csi2rx(struct v4l2_subdev *subdev) static void csi2rx_reset(struct csi2rx_priv *csi2rx) { + int i; + writel(CSI2RX_SOFT_RESET_PROTOCOL | CSI2RX_SOFT_RESET_FRONT, csi2rx->base + CSI2RX_SOFT_RESET_REG); udelay(10); writel(0, csi2rx->base + CSI2RX_SOFT_RESET_REG); + + /* Reset individual streams. */ + for (i = 0; i < csi2rx->max_streams; i++) { + writel(CSI2RX_STREAM_CTRL_SOFT_RST, + csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); + usleep_range(10, 20); + writel(0, csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); + } } static int csi2rx_configure_external_dphy(struct csi2rx_priv *csi2rx) -- 2.30.0
WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <p.yadav@ti.com> To: Maxime Ripard <mripard@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Pratyush Yadav <p.yadav@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Steve Longerbeam <slongerbeam@gmail.com>, Benoit Parrot <bparrot@ti.com>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>, <dmaengine@vger.kernel.org> Cc: Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Subject: [PATCH v2 07/18] media: cadence: csi2rx: Soft reset the streams before starting capture Date: Wed, 26 May 2021 20:52:57 +0530 [thread overview] Message-ID: <20210526152308.16525-8-p.yadav@ti.com> (raw) In-Reply-To: <20210526152308.16525-1-p.yadav@ti.com> This resets the stream state machines and FIFOs, giving them a clean slate. On J721E if the streams are not reset before starting the capture, the captured frame gets wrapped around vertically on every run after the first. Signed-off-by: Pratyush Yadav <p.yadav@ti.com> --- (no changes since v1) drivers/media/platform/cadence/cdns-csi2rx.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c index 459326de2eff..80a50284e525 100644 --- a/drivers/media/platform/cadence/cdns-csi2rx.c +++ b/drivers/media/platform/cadence/cdns-csi2rx.c @@ -39,6 +39,7 @@ #define CSI2RX_STREAM_BASE(n) (((n) + 1) * 0x100) #define CSI2RX_STREAM_CTRL_REG(n) (CSI2RX_STREAM_BASE(n) + 0x000) +#define CSI2RX_STREAM_CTRL_SOFT_RST BIT(4) #define CSI2RX_STREAM_CTRL_START BIT(0) #define CSI2RX_STREAM_DATA_CFG_REG(n) (CSI2RX_STREAM_BASE(n) + 0x008) @@ -150,12 +151,22 @@ struct csi2rx_priv *v4l2_subdev_to_csi2rx(struct v4l2_subdev *subdev) static void csi2rx_reset(struct csi2rx_priv *csi2rx) { + int i; + writel(CSI2RX_SOFT_RESET_PROTOCOL | CSI2RX_SOFT_RESET_FRONT, csi2rx->base + CSI2RX_SOFT_RESET_REG); udelay(10); writel(0, csi2rx->base + CSI2RX_SOFT_RESET_REG); + + /* Reset individual streams. */ + for (i = 0; i < csi2rx->max_streams; i++) { + writel(CSI2RX_STREAM_CTRL_SOFT_RST, + csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); + usleep_range(10, 20); + writel(0, csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); + } } static int csi2rx_configure_external_dphy(struct csi2rx_priv *csi2rx) -- 2.30.0 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-05-26 15:24 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-26 15:22 [PATCH v2 00/18] CSI2RX support on J721E Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav 2021-05-26 15:22 ` [PATCH v2 01/18] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav 2021-05-26 15:22 ` [PATCH v2 02/18] phy: cdns-dphy: Prepare for Rx support Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav 2021-05-26 15:22 ` [PATCH v2 03/18] phy: cdns-dphy: Allow setting mode Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav 2021-05-26 15:22 ` [PATCH v2 04/18] phy: cdns-dphy: Add Rx support Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav 2021-05-28 6:09 ` Tomi Valkeinen 2021-05-28 6:09 ` Tomi Valkeinen 2021-05-26 15:22 ` [PATCH v2 05/18] media: ov5640: Use runtime PM to control sensor power Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav 2021-05-28 6:44 ` Tomi Valkeinen 2021-05-28 6:44 ` Tomi Valkeinen 2021-05-28 7:25 ` Pratyush Yadav 2021-05-28 7:25 ` Pratyush Yadav 2021-05-26 15:22 ` [PATCH v2 06/18] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav 2021-05-28 7:23 ` Tomi Valkeinen 2021-05-28 7:23 ` Tomi Valkeinen 2021-05-28 7:30 ` Pratyush Yadav 2021-05-28 7:30 ` Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav [this message] 2021-05-26 15:22 ` [PATCH v2 07/18] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav 2021-05-26 15:22 ` [PATCH v2 08/18] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav 2021-05-26 15:22 ` [PATCH v2 09/18] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav 2021-05-26 15:22 ` Pratyush Yadav 2021-05-26 15:23 ` [PATCH v2 10/18] media: cadence: csi2rx: Populate subdev devnode Pratyush Yadav 2021-05-26 15:23 ` Pratyush Yadav 2021-05-28 7:16 ` Tomi Valkeinen 2021-05-28 7:16 ` Tomi Valkeinen 2021-05-28 7:24 ` Pratyush Yadav 2021-05-28 7:24 ` Pratyush Yadav 2021-05-28 7:35 ` Tomi Valkeinen 2021-05-28 7:35 ` Tomi Valkeinen 2021-06-03 12:42 ` Pratyush Yadav 2021-06-03 12:42 ` Pratyush Yadav 2021-05-26 15:23 ` [PATCH v2 11/18] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Pratyush Yadav 2021-05-26 15:23 ` Pratyush Yadav 2021-05-31 6:51 ` Péter Ujfalusi 2021-05-31 6:51 ` Péter Ujfalusi 2021-05-31 9:16 ` Pratyush Yadav 2021-05-31 9:16 ` Pratyush Yadav 2021-05-26 15:23 ` [PATCH v2 12/18] media: Re-structure TI platform drivers Pratyush Yadav 2021-05-26 15:23 ` Pratyush Yadav 2021-05-28 8:29 ` Tomi Valkeinen 2021-05-28 8:29 ` Tomi Valkeinen 2021-05-26 15:23 ` [PATCH v2 13/18] media: ti: Add CSI2RX support for J721E Pratyush Yadav 2021-05-26 15:23 ` Pratyush Yadav 2021-05-27 13:29 ` Tomi Valkeinen 2021-05-27 13:29 ` Tomi Valkeinen 2021-06-03 12:49 ` Pratyush Yadav 2021-06-03 12:49 ` Pratyush Yadav 2021-06-04 8:04 ` Tomi Valkeinen 2021-06-04 8:04 ` Tomi Valkeinen 2021-05-26 15:23 ` [PATCH v2 14/18] media: dt-bindings: Add DT bindings for TI J721E CSI2RX driver Pratyush Yadav 2021-05-26 15:23 ` Pratyush Yadav 2021-05-27 14:23 ` Rob Herring 2021-05-27 14:23 ` Rob Herring 2021-06-03 12:43 ` Pratyush Yadav 2021-06-03 12:43 ` Pratyush Yadav 2021-05-26 15:23 ` [PATCH v2 15/18] media: dt-bindings: Convert Cadence CSI2RX binding to YAML Pratyush Yadav 2021-05-26 15:23 ` Pratyush Yadav 2021-06-01 17:45 ` Rob Herring 2021-06-01 17:45 ` Rob Herring 2021-06-03 12:23 ` Pratyush Yadav 2021-06-03 12:23 ` Pratyush Yadav 2021-05-26 15:23 ` [PATCH v2 16/18] phy: dt-bindings: Convert Cadence DPHY " Pratyush Yadav 2021-05-26 15:23 ` Pratyush Yadav 2021-06-02 19:51 ` Rob Herring 2021-06-02 19:51 ` Rob Herring 2021-05-26 15:23 ` [PATCH v2 17/18] phy: dt-bindings: cdns,dphy: make clocks optional Pratyush Yadav 2021-05-26 15:23 ` Pratyush Yadav 2021-06-02 13:27 ` Maxime Ripard 2021-06-02 13:27 ` Maxime Ripard 2021-06-03 8:16 ` Pratyush Yadav 2021-06-03 8:16 ` Pratyush Yadav 2021-06-02 20:03 ` Rob Herring 2021-06-02 20:03 ` Rob Herring 2021-05-26 15:23 ` [PATCH v2 18/18] phy: dt-bindings: cdns,dphy: add power-domains property Pratyush Yadav 2021-05-26 15:23 ` [PATCH v2 18/18] phy: dt-bindings: cdns, dphy: " Pratyush Yadav 2021-06-02 20:03 ` [PATCH v2 18/18] phy: dt-bindings: cdns,dphy: " Rob Herring 2021-06-02 20:03 ` Rob Herring 2021-05-27 12:42 ` [PATCH v2 00/18] CSI2RX support on J721E Tomi Valkeinen 2021-05-27 12:42 ` Tomi Valkeinen 2021-06-03 12:54 ` Pratyush Yadav 2021-06-03 12:54 ` Pratyush Yadav 2021-05-27 13:23 ` Tomi Valkeinen 2021-05-27 13:23 ` Tomi Valkeinen 2021-06-03 12:52 ` Pratyush Yadav 2021-06-03 12:52 ` Pratyush Yadav 2021-06-04 7:54 ` Tomi Valkeinen 2021-06-04 7:54 ` Tomi Valkeinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210526152308.16525-8-p.yadav@ti.com \ --to=p.yadav@ti.com \ --cc=bparrot@ti.com \ --cc=chunfeng.yun@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=kishon@ti.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=mchehab@kernel.org \ --cc=mripard@kernel.org \ --cc=peter.ujfalusi@gmail.com \ --cc=robh+dt@kernel.org \ --cc=slongerbeam@gmail.com \ --cc=tomi.valkeinen@ideasonboard.com \ --cc=vigneshr@ti.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.