From: Suzuki K Poulose <suzuki.poulose@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org, anshuman.khandual@arm.com, will@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, maz@kernel.org, mark.rutland@arm.com, Suzuki K Poulose <suzuki.poulose@arm.com> Subject: [PATCH 05/10] coresight: trbe: Allow driver to choose a different alignment Date: Wed, 28 Jul 2021 14:52:12 +0100 [thread overview] Message-ID: <20210728135217.591173-6-suzuki.poulose@arm.com> (raw) In-Reply-To: <20210728135217.591173-1-suzuki.poulose@arm.com> The TRBE hardware mandates a minimum alignment for the TRBPTR_EL1, advertised via the TRBIDR_EL1. This is used by the driver to align the buffer write head. This patch allows the driver to choose a different alignment from that of the hardware, by decoupling the alignment tracking. This will be useful for working around errata. Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Anshuman Khandual <anshuman.khandual@arm.com> Cc: Mike Leach <mike.leach@linaro.org> Cc: Leo Yan <leo.yan@linaro.org> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- drivers/hwtracing/coresight/coresight-trbe.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c index 9735d514c5e1..9ea28813182b 100644 --- a/drivers/hwtracing/coresight/coresight-trbe.c +++ b/drivers/hwtracing/coresight/coresight-trbe.c @@ -92,7 +92,8 @@ static unsigned long trbe_errata_cpucaps[TRBE_ERRATA_MAX] = { /* * struct trbe_cpudata: TRBE instance specific data * @trbe_flag - TRBE dirty/access flag support - * @tbre_align - Actual TRBE alignment required for TRBPTR_EL1. + * @trbe_hw_align - Actual TRBE alignment required for TRBPTR_EL1. + * @trbe_align - Software alignment used for the TRBPTR_EL1, * @cpu - CPU this TRBE belongs to. * @mode - Mode of current operation. (perf/disabled) * @drvdata - TRBE specific drvdata @@ -100,6 +101,7 @@ static unsigned long trbe_errata_cpucaps[TRBE_ERRATA_MAX] = { */ struct trbe_cpudata { bool trbe_flag; + u64 trbe_hw_align; u64 trbe_align; int cpu; enum cs_mode mode; @@ -906,7 +908,7 @@ static ssize_t align_show(struct device *dev, struct device_attribute *attr, cha { struct trbe_cpudata *cpudata = dev_get_drvdata(dev); - return sprintf(buf, "%llx\n", cpudata->trbe_align); + return sprintf(buf, "%llx\n", cpudata->trbe_hw_align); } static DEVICE_ATTR_RO(align); @@ -995,11 +997,13 @@ static void arm_trbe_probe_cpu(void *info) } trbe_check_errata(cpudata); - cpudata->trbe_align = 1ULL << get_trbe_address_align(trbidr); - if (cpudata->trbe_align > SZ_2K) { + + cpudata->trbe_hw_align = 1ULL << get_trbe_address_align(trbidr); + if (cpudata->trbe_hw_align > SZ_2K) { pr_err("Unsupported alignment on cpu %d\n", cpu); goto cpu_clear; } + cpudata->trbe_align = cpudata->trbe_hw_align; cpudata->trbe_flag = get_trbe_flag_update(trbidr); cpudata->cpu = cpu; cpudata->drvdata = drvdata; -- 2.24.1
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org, anshuman.khandual@arm.com, will@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, maz@kernel.org, mark.rutland@arm.com, Suzuki K Poulose <suzuki.poulose@arm.com> Subject: [PATCH 05/10] coresight: trbe: Allow driver to choose a different alignment Date: Wed, 28 Jul 2021 14:52:12 +0100 [thread overview] Message-ID: <20210728135217.591173-6-suzuki.poulose@arm.com> (raw) In-Reply-To: <20210728135217.591173-1-suzuki.poulose@arm.com> The TRBE hardware mandates a minimum alignment for the TRBPTR_EL1, advertised via the TRBIDR_EL1. This is used by the driver to align the buffer write head. This patch allows the driver to choose a different alignment from that of the hardware, by decoupling the alignment tracking. This will be useful for working around errata. Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Anshuman Khandual <anshuman.khandual@arm.com> Cc: Mike Leach <mike.leach@linaro.org> Cc: Leo Yan <leo.yan@linaro.org> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- drivers/hwtracing/coresight/coresight-trbe.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c index 9735d514c5e1..9ea28813182b 100644 --- a/drivers/hwtracing/coresight/coresight-trbe.c +++ b/drivers/hwtracing/coresight/coresight-trbe.c @@ -92,7 +92,8 @@ static unsigned long trbe_errata_cpucaps[TRBE_ERRATA_MAX] = { /* * struct trbe_cpudata: TRBE instance specific data * @trbe_flag - TRBE dirty/access flag support - * @tbre_align - Actual TRBE alignment required for TRBPTR_EL1. + * @trbe_hw_align - Actual TRBE alignment required for TRBPTR_EL1. + * @trbe_align - Software alignment used for the TRBPTR_EL1, * @cpu - CPU this TRBE belongs to. * @mode - Mode of current operation. (perf/disabled) * @drvdata - TRBE specific drvdata @@ -100,6 +101,7 @@ static unsigned long trbe_errata_cpucaps[TRBE_ERRATA_MAX] = { */ struct trbe_cpudata { bool trbe_flag; + u64 trbe_hw_align; u64 trbe_align; int cpu; enum cs_mode mode; @@ -906,7 +908,7 @@ static ssize_t align_show(struct device *dev, struct device_attribute *attr, cha { struct trbe_cpudata *cpudata = dev_get_drvdata(dev); - return sprintf(buf, "%llx\n", cpudata->trbe_align); + return sprintf(buf, "%llx\n", cpudata->trbe_hw_align); } static DEVICE_ATTR_RO(align); @@ -995,11 +997,13 @@ static void arm_trbe_probe_cpu(void *info) } trbe_check_errata(cpudata); - cpudata->trbe_align = 1ULL << get_trbe_address_align(trbidr); - if (cpudata->trbe_align > SZ_2K) { + + cpudata->trbe_hw_align = 1ULL << get_trbe_address_align(trbidr); + if (cpudata->trbe_hw_align > SZ_2K) { pr_err("Unsupported alignment on cpu %d\n", cpu); goto cpu_clear; } + cpudata->trbe_align = cpudata->trbe_hw_align; cpudata->trbe_flag = get_trbe_flag_update(trbidr); cpudata->cpu = cpu; cpudata->drvdata = drvdata; -- 2.24.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-28 13:54 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-28 13:52 [PATCH 00/10] arm64: Self-hosted trace related erratum workarouds Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-07-28 13:52 ` [PATCH 01/10] coresight: trbe: Add infrastructure for Errata handling Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-08-02 6:43 ` Anshuman Khandual 2021-08-02 6:43 ` Anshuman Khandual 2021-09-07 9:04 ` Suzuki K Poulose 2021-09-07 9:04 ` Suzuki K Poulose 2021-09-09 2:55 ` Anshuman Khandual 2021-09-09 2:55 ` Anshuman Khandual 2021-07-28 13:52 ` [PATCH 02/10] coresight: trbe: Add a helper to calculate the trace generated Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-07-30 10:01 ` Anshuman Khandual 2021-07-30 10:01 ` Anshuman Khandual 2021-07-28 13:52 ` [PATCH 03/10] coresight: trbe: Add a helper to pad a given buffer area Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-07-30 10:05 ` Anshuman Khandual 2021-07-30 10:05 ` Anshuman Khandual 2021-07-28 13:52 ` [PATCH 04/10] coresight: trbe: Decouple buffer base from the hardware base Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-07-30 10:53 ` Anshuman Khandual 2021-07-30 10:53 ` Anshuman Khandual 2021-07-28 13:52 ` Suzuki K Poulose [this message] 2021-07-28 13:52 ` [PATCH 05/10] coresight: trbe: Allow driver to choose a different alignment Suzuki K Poulose 2021-07-30 11:02 ` Anshuman Khandual 2021-07-30 11:02 ` Anshuman Khandual 2021-07-30 14:29 ` Suzuki K Poulose 2021-07-30 14:29 ` Suzuki K Poulose 2021-07-28 13:52 ` [PATCH 06/10] arm64: Add Neoverse-N2, Cortex-A710 CPU part definition Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-07-30 11:26 ` Anshuman Khandual 2021-07-30 11:26 ` Anshuman Khandual 2021-07-30 14:31 ` Suzuki K Poulose 2021-07-30 14:31 ` Suzuki K Poulose 2021-08-02 11:21 ` Catalin Marinas 2021-08-02 11:21 ` Catalin Marinas 2021-08-02 11:21 ` Catalin Marinas 2021-08-02 11:21 ` Catalin Marinas 2021-07-28 13:52 ` [PATCH 07/10] arm64: Add erratum detection for TRBE overwrite in FILL mode Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-08-02 7:44 ` Anshuman Khandual 2021-08-02 7:44 ` Anshuman Khandual 2021-08-02 11:22 ` Catalin Marinas 2021-08-02 11:22 ` Catalin Marinas 2021-08-06 12:44 ` Linu Cherian 2021-08-06 12:44 ` Linu Cherian 2021-09-07 9:10 ` Suzuki K Poulose 2021-09-07 9:10 ` Suzuki K Poulose 2021-07-28 13:52 ` [PATCH 08/10] coresight: trbe: Workaround TRBE errat " Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-08-03 10:25 ` Anshuman Khandual 2021-08-03 10:25 ` Anshuman Khandual 2021-09-07 9:58 ` Suzuki K Poulose 2021-09-07 9:58 ` Suzuki K Poulose 2021-09-09 4:21 ` Anshuman Khandual 2021-09-09 4:21 ` Anshuman Khandual 2021-09-09 8:37 ` Suzuki K Poulose 2021-09-09 8:37 ` Suzuki K Poulose 2021-08-06 16:09 ` Linu Cherian 2021-08-06 16:09 ` Linu Cherian 2021-09-07 9:18 ` Suzuki K Poulose 2021-09-07 9:18 ` Suzuki K Poulose 2021-07-28 13:52 ` [PATCH 09/10] arm64: Enable workaround for TRBE " Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-08-02 9:34 ` Anshuman Khandual 2021-08-02 9:34 ` Anshuman Khandual 2021-08-02 11:24 ` Catalin Marinas 2021-08-02 11:24 ` Catalin Marinas 2021-07-28 13:52 ` [PATCH 10/10] arm64: errata: Add workaround for TSB flush failures Suzuki K Poulose 2021-07-28 13:52 ` Suzuki K Poulose 2021-07-29 9:55 ` Marc Zyngier 2021-07-29 9:55 ` Marc Zyngier 2021-07-29 10:41 ` Suzuki K Poulose 2021-07-29 10:41 ` Suzuki K Poulose 2021-08-02 9:12 ` Anshuman Khandual 2021-08-02 9:12 ` Anshuman Khandual 2021-08-02 9:35 ` Marc Zyngier 2021-08-02 9:35 ` Marc Zyngier 2021-08-03 3:51 ` Anshuman Khandual 2021-08-03 3:51 ` Anshuman Khandual 2021-09-08 13:39 ` Suzuki K Poulose 2021-09-08 13:39 ` Suzuki K Poulose 2021-08-02 11:27 ` Catalin Marinas 2021-08-02 11:27 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210728135217.591173-6-suzuki.poulose@arm.com \ --to=suzuki.poulose@arm.com \ --cc=anshuman.khandual@arm.com \ --cc=catalin.marinas@arm.com \ --cc=coresight@lists.linaro.org \ --cc=james.morse@arm.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=maz@kernel.org \ --cc=mike.leach@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.