From: Aneesh V <aneesh@ti.com> To: Olof Johansson <olof@lixom.net> Cc: devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rajendra Nayak <rnayak@ti.com>, Benoit Cousson <b-cousson@ti.com> Subject: Re: [RFC v2 PATCH 2/3] dt: device tree bindings for TI's EMIF sdram controller Date: Tue, 20 Dec 2011 12:49:29 +0530 [thread overview] Message-ID: <4EF03701.9090809@ti.com> (raw) In-Reply-To: <CAOesGMidr_orQ60wWrDkSPXZziZ6wuThTixmQj-idkkDjrMG0A@mail.gmail.com> On Monday 19 December 2011 10:29 PM, Olof Johansson wrote: > Oh wait, when I saw 3/3 I realized the following too: > > On Mon, Dec 19, 2011 at 6:05 AM, Aneesh V<aneesh@ti.com> wrote: > >> +- phy-type : string indicating the phy type. Should be one of the >> + following: >> + >> + "phy-type-omap4" : PHY used in OMAP4 family of SoCs >> + >> + "phy-type-dm81xx" : PHY used in DM81XX family of SoCs > > No, again please don't define new string properties when a simple > binary property will do just fine. Just use "phy-type-omap4" or > "phy-type-dm81xx" as an empty property to indicate what phy is used. > Or encode as an integer and list the valid values here. Ok. I just got carried away by readability. Somebody told me that something like #define will come to device-tree soon. Probably, I can use that then. Is binary property suitable in situations like this where "one and only one" phy-type should be specified by the user? > > Every time you add a string to the device tree, the data structure > grows, not to mention the fact that it adds a lot of string > comparisons during setup. Please keep that in mind when defining > bindings. Understand. Thanks, Aneesh
WARNING: multiple messages have this Message-ID (diff)
From: aneesh@ti.com (Aneesh V) To: linux-arm-kernel@lists.infradead.org Subject: [RFC v2 PATCH 2/3] dt: device tree bindings for TI's EMIF sdram controller Date: Tue, 20 Dec 2011 12:49:29 +0530 [thread overview] Message-ID: <4EF03701.9090809@ti.com> (raw) In-Reply-To: <CAOesGMidr_orQ60wWrDkSPXZziZ6wuThTixmQj-idkkDjrMG0A@mail.gmail.com> On Monday 19 December 2011 10:29 PM, Olof Johansson wrote: > Oh wait, when I saw 3/3 I realized the following too: > > On Mon, Dec 19, 2011 at 6:05 AM, Aneesh V<aneesh@ti.com> wrote: > >> +- phy-type : string indicating the phy type. Should be one of the >> + following: >> + >> + "phy-type-omap4" : PHY used in OMAP4 family of SoCs >> + >> + "phy-type-dm81xx" : PHY used in DM81XX family of SoCs > > No, again please don't define new string properties when a simple > binary property will do just fine. Just use "phy-type-omap4" or > "phy-type-dm81xx" as an empty property to indicate what phy is used. > Or encode as an integer and list the valid values here. Ok. I just got carried away by readability. Somebody told me that something like #define will come to device-tree soon. Probably, I can use that then. Is binary property suitable in situations like this where "one and only one" phy-type should be specified by the user? > > Every time you add a string to the device tree, the data structure > grows, not to mention the fact that it adds a lot of string > comparisons during setup. Please keep that in mind when defining > bindings. Understand. Thanks, Aneesh
next prev parent reply other threads:[~2011-12-20 7:19 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-12-19 14:05 [RFC v2 PATCH 0/3] dt: device tree bindings and data for EMIF and DDR Aneesh V 2011-12-19 14:05 ` Aneesh V 2011-12-19 14:05 ` [RFC v2 PATCH 1/3] dt: device tree bindings for DDR memories Aneesh V 2011-12-19 14:05 ` Aneesh V 2011-12-19 16:52 ` Olof Johansson 2011-12-19 16:52 ` Olof Johansson 2011-12-20 7:09 ` Aneesh V 2011-12-20 7:09 ` Aneesh V 2012-01-19 12:18 ` Aneesh V 2012-01-19 12:18 ` Aneesh V 2011-12-19 14:05 ` [RFC v2 PATCH 2/3] dt: device tree bindings for TI's EMIF sdram controller Aneesh V 2011-12-19 14:05 ` Aneesh V 2011-12-19 16:56 ` Olof Johansson 2011-12-19 16:56 ` Olof Johansson 2011-12-20 7:12 ` Aneesh V 2011-12-20 7:12 ` Aneesh V 2011-12-19 16:59 ` Olof Johansson 2011-12-19 16:59 ` Olof Johansson 2011-12-20 7:19 ` Aneesh V [this message] 2011-12-20 7:19 ` Aneesh V 2011-12-19 14:05 ` [RFC v2 PATCH 3/3] arm/dts: EMIF and lpddr2 device tree data for OMAP4 boards Aneesh V 2011-12-19 14:05 ` Aneesh V 2011-12-19 23:01 ` [RFC v2 PATCH 0/3] dt: device tree bindings and data for EMIF and DDR Rob Herring 2011-12-19 23:01 ` Rob Herring 2011-12-19 23:35 ` Tony Lindgren 2011-12-19 23:35 ` Tony Lindgren 2011-12-20 10:44 ` Aneesh V 2011-12-20 10:44 ` Aneesh V 2011-12-20 12:40 ` Cousson, Benoit 2011-12-20 12:40 ` Cousson, Benoit 2011-12-20 14:08 ` Aneesh V 2011-12-20 14:08 ` Aneesh V 2012-01-08 17:23 ` Aneesh V 2012-01-08 17:23 ` Aneesh V 2012-01-09 5:42 ` Olof Johansson 2012-01-09 5:42 ` Olof Johansson 2012-01-13 19:36 ` Aneesh V 2012-01-13 19:36 ` Aneesh V 2012-01-16 19:15 ` Turquette, Mike 2012-01-16 19:15 ` Turquette, Mike 2012-01-19 19:26 ` Olof Johansson 2012-01-19 19:26 ` Olof Johansson 2012-01-17 12:06 ` Aneesh V 2012-01-17 12:06 ` Aneesh V 2011-12-20 10:16 ` Aneesh V 2011-12-20 10:16 ` Aneesh V 2012-01-19 14:28 ` Aneesh V 2012-01-19 14:28 ` Aneesh V 2012-01-19 14:31 ` Aneesh V 2012-01-19 14:31 ` Aneesh V 2012-01-19 14:28 ` [PATCH 1/3] dt: device tree bindings for DDR memories Aneesh V 2012-01-19 14:28 ` Aneesh V 2012-01-19 14:28 ` [PATCH 2/3] dt: device tree bindings for TI's EMIF sdram controller Aneesh V 2012-01-19 14:28 ` Aneesh V 2012-01-19 14:28 ` [PATCH 3/3] arm/dts: EMIF and lpddr2 device tree data for OMAP4 boards Aneesh V 2012-01-19 14:28 ` Aneesh V
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4EF03701.9090809@ti.com \ --to=aneesh@ti.com \ --cc=b-cousson@ti.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=olof@lixom.net \ --cc=rnayak@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.