From: "Noralf Trønnes" <noralf@tronnes.org> To: Sam Ravnborg <sam@ravnborg.org>, Javier Martinez Canillas <javierm@redhat.com> Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org, Geert Uytterhoeven <geert@linux-m68k.org>, Maxime Ripard <maxime@cerno.tech>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Emil Velikov <emil.l.velikov@gmail.com> Subject: Re: [PATCH 1/4] drm: Add I2C connector type Date: Tue, 1 Feb 2022 13:58:16 +0100 [thread overview] Message-ID: <4d9a56a7-da25-b411-61cc-372c6fa9011d@tronnes.org> (raw) In-Reply-To: <YfhMESTylI1NTKDg@ravnborg.org> Den 31.01.2022 21.52, skrev Sam Ravnborg: > On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >> There isn't a connector type for display controllers accesed through I2C, >> most drivers use DRM_MODE_CONNECTOR_Unknown or DRM_MODE_CONNECTOR_VIRTUAL. >> >> Add an I2C connector type to match the actual connector. >> >> As Noralf Trønnes mentions in commit fc06bf1d76d6 ("drm: Add SPI connector >> type"), user-space should be able to cope with a connector type that does >> not yet understand. >> It turned out that I wasn't entirely correct here, mpv didn't cope with unknown types. In the PR to add support Emil Velikov wondered if libdrm should handle these connector names: https://github.com/mpv-player/mpv/pull/8989#issuecomment-879187711 >> Tested with `modetest -M ssd1307 -c` and shows the connector as unknown-1. > I had expected unknown-21?? > >> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Sam, didn't you and Laurent discuss adding DRM_MODE_CONNECTOR_PANEL for such a use case? If someone adds parallel bus support to the MIPI DBI helper, there will be one more connector type (I wonder what that one will be called). Noralf. >> --- >> >> drivers/gpu/drm/drm_connector.c | 1 + >> include/uapi/drm/drm_mode.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c >> index a50c82bc2b2f..975a7525a508 100644 >> --- a/drivers/gpu/drm/drm_connector.c >> +++ b/drivers/gpu/drm/drm_connector.c >> @@ -105,6 +105,7 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] = { >> { DRM_MODE_CONNECTOR_WRITEBACK, "Writeback" }, >> { DRM_MODE_CONNECTOR_SPI, "SPI" }, >> { DRM_MODE_CONNECTOR_USB, "USB" }, >> + { DRM_MODE_CONNECTOR_I2C, "I2C" }, >> }; >> >> void drm_connector_ida_init(void) >> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h >> index e1e351682872..d6d6288242db 100644 >> --- a/include/uapi/drm/drm_mode.h >> +++ b/include/uapi/drm/drm_mode.h >> @@ -421,6 +421,7 @@ enum drm_mode_subconnector { >> #define DRM_MODE_CONNECTOR_WRITEBACK 18 >> #define DRM_MODE_CONNECTOR_SPI 19 >> #define DRM_MODE_CONNECTOR_USB 20 >> +#define DRM_MODE_CONNECTOR_I2C 21 >> >> /** >> * struct drm_mode_get_connector - Get connector metadata. >> -- >> 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org> To: Sam Ravnborg <sam@ravnborg.org>, Javier Martinez Canillas <javierm@redhat.com> Cc: linux-fbdev@vger.kernel.org, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, Emil Velikov <emil.l.velikov@gmail.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Geert Uytterhoeven <geert@linux-m68k.org>, Maxime Ripard <maxime@cerno.tech>, Thomas Zimmermann <tzimmermann@suse.de>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH 1/4] drm: Add I2C connector type Date: Tue, 1 Feb 2022 13:58:16 +0100 [thread overview] Message-ID: <4d9a56a7-da25-b411-61cc-372c6fa9011d@tronnes.org> (raw) In-Reply-To: <YfhMESTylI1NTKDg@ravnborg.org> Den 31.01.2022 21.52, skrev Sam Ravnborg: > On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >> There isn't a connector type for display controllers accesed through I2C, >> most drivers use DRM_MODE_CONNECTOR_Unknown or DRM_MODE_CONNECTOR_VIRTUAL. >> >> Add an I2C connector type to match the actual connector. >> >> As Noralf Trønnes mentions in commit fc06bf1d76d6 ("drm: Add SPI connector >> type"), user-space should be able to cope with a connector type that does >> not yet understand. >> It turned out that I wasn't entirely correct here, mpv didn't cope with unknown types. In the PR to add support Emil Velikov wondered if libdrm should handle these connector names: https://github.com/mpv-player/mpv/pull/8989#issuecomment-879187711 >> Tested with `modetest -M ssd1307 -c` and shows the connector as unknown-1. > I had expected unknown-21?? > >> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Sam, didn't you and Laurent discuss adding DRM_MODE_CONNECTOR_PANEL for such a use case? If someone adds parallel bus support to the MIPI DBI helper, there will be one more connector type (I wonder what that one will be called). Noralf. >> --- >> >> drivers/gpu/drm/drm_connector.c | 1 + >> include/uapi/drm/drm_mode.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c >> index a50c82bc2b2f..975a7525a508 100644 >> --- a/drivers/gpu/drm/drm_connector.c >> +++ b/drivers/gpu/drm/drm_connector.c >> @@ -105,6 +105,7 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] = { >> { DRM_MODE_CONNECTOR_WRITEBACK, "Writeback" }, >> { DRM_MODE_CONNECTOR_SPI, "SPI" }, >> { DRM_MODE_CONNECTOR_USB, "USB" }, >> + { DRM_MODE_CONNECTOR_I2C, "I2C" }, >> }; >> >> void drm_connector_ida_init(void) >> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h >> index e1e351682872..d6d6288242db 100644 >> --- a/include/uapi/drm/drm_mode.h >> +++ b/include/uapi/drm/drm_mode.h >> @@ -421,6 +421,7 @@ enum drm_mode_subconnector { >> #define DRM_MODE_CONNECTOR_WRITEBACK 18 >> #define DRM_MODE_CONNECTOR_SPI 19 >> #define DRM_MODE_CONNECTOR_USB 20 >> +#define DRM_MODE_CONNECTOR_I2C 21 >> >> /** >> * struct drm_mode_get_connector - Get connector metadata. >> -- >> 2.34.1
next prev parent reply other threads:[~2022-02-01 12:58 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-31 20:12 [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Javier Martinez Canillas 2022-01-31 20:12 ` Javier Martinez Canillas 2022-01-31 20:12 ` [PATCH 1/4] drm: Add I2C connector type Javier Martinez Canillas 2022-01-31 20:12 ` Javier Martinez Canillas 2022-01-31 20:52 ` Sam Ravnborg 2022-01-31 23:26 ` Javier Martinez Canillas 2022-01-31 23:26 ` Javier Martinez Canillas 2022-02-01 12:58 ` Noralf Trønnes [this message] 2022-02-01 12:58 ` Noralf Trønnes 2022-02-01 13:06 ` Javier Martinez Canillas 2022-02-01 13:20 ` Noralf Trønnes 2022-02-01 13:55 ` Javier Martinez Canillas 2022-02-01 13:38 ` Simon Ser 2022-02-01 13:38 ` Simon Ser 2022-02-01 14:20 ` Noralf Trønnes 2022-02-01 14:20 ` Noralf Trønnes 2022-02-01 20:57 ` Sam Ravnborg 2022-02-01 22:29 ` Simon Ser 2022-02-01 22:29 ` Simon Ser 2022-02-02 8:46 ` Javier Martinez Canillas 2022-02-02 8:46 ` Javier Martinez Canillas 2022-02-02 9:14 ` Thomas Zimmermann 2022-02-02 9:14 ` Thomas Zimmermann 2022-02-02 9:45 ` Noralf Trønnes 2022-02-02 9:45 ` Noralf Trønnes 2022-02-02 15:04 ` Pekka Paalanen 2022-02-02 15:04 ` Pekka Paalanen 2022-02-02 16:00 ` Noralf Trønnes 2022-02-02 16:00 ` Noralf Trønnes 2022-01-31 20:12 ` [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed() Javier Martinez Canillas 2022-01-31 20:12 ` Javier Martinez Canillas 2022-02-01 9:59 ` Thomas Zimmermann 2022-02-01 9:59 ` Thomas Zimmermann 2022-02-01 11:13 ` Pekka Paalanen 2022-02-01 11:13 ` Pekka Paalanen 2022-02-01 11:48 ` Javier Martinez Canillas 2022-02-01 11:48 ` Javier Martinez Canillas 2022-03-14 13:40 ` Geert Uytterhoeven 2022-03-14 13:40 ` Geert Uytterhoeven 2022-03-14 14:07 ` Javier Martinez Canillas 2022-03-14 14:07 ` Javier Martinez Canillas 2022-01-31 20:36 ` [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Simon Ser 2022-01-31 20:36 ` Simon Ser 2022-01-31 20:39 ` Simon Ser 2022-01-31 20:39 ` Simon Ser 2022-01-31 23:21 ` Javier Martinez Canillas 2022-01-31 23:21 ` Javier Martinez Canillas 2022-02-01 8:26 ` Geert Uytterhoeven 2022-02-01 8:26 ` Geert Uytterhoeven 2022-02-01 8:34 ` Simon Ser 2022-02-01 8:34 ` Simon Ser 2022-02-01 8:36 ` Geert Uytterhoeven 2022-02-01 8:36 ` Geert Uytterhoeven 2022-02-01 10:08 ` Thomas Zimmermann 2022-02-01 10:08 ` Thomas Zimmermann 2022-02-01 10:11 ` Simon Ser 2022-02-01 10:11 ` Simon Ser 2022-02-01 10:17 ` Thomas Zimmermann 2022-02-01 10:17 ` Thomas Zimmermann 2022-02-01 8:38 ` Daniel Vetter 2022-02-01 8:38 ` Daniel Vetter 2022-02-01 9:49 ` Javier Martinez Canillas 2022-02-01 9:49 ` Javier Martinez Canillas 2022-02-01 10:42 ` Pekka Paalanen 2022-02-01 10:42 ` Pekka Paalanen 2022-02-01 11:07 ` Geert Uytterhoeven 2022-02-01 11:07 ` Geert Uytterhoeven 2022-02-02 9:19 ` Pekka Paalanen 2022-02-02 9:19 ` Pekka Paalanen 2022-02-02 10:55 ` Geert Uytterhoeven 2022-02-02 10:55 ` Geert Uytterhoeven 2022-01-31 20:56 ` Sam Ravnborg 2022-01-31 23:37 ` Javier Martinez Canillas 2022-01-31 23:37 ` Javier Martinez Canillas 2022-02-01 9:37 ` Andy Shevchenko 2022-02-01 9:37 ` Andy Shevchenko 2022-02-01 11:31 ` Javier Martinez Canillas 2022-02-01 11:31 ` Javier Martinez Canillas 2022-02-01 11:38 ` Geert Uytterhoeven 2022-02-01 11:38 ` Geert Uytterhoeven 2022-02-01 13:09 ` Javier Martinez Canillas 2022-02-01 13:09 ` Javier Martinez Canillas 2022-02-01 14:14 ` Geert Uytterhoeven 2022-02-01 14:14 ` Geert Uytterhoeven 2022-02-01 15:03 ` Javier Martinez Canillas 2022-02-01 15:03 ` Javier Martinez Canillas 2022-02-01 20:40 ` Sam Ravnborg 2022-02-01 20:40 ` Sam Ravnborg 2022-02-02 8:38 ` Javier Martinez Canillas 2022-02-02 8:38 ` Javier Martinez Canillas 2022-02-02 11:06 ` Andy Shevchenko 2022-02-02 11:06 ` Andy Shevchenko 2022-02-02 11:39 ` Javier Martinez Canillas 2022-02-02 11:39 ` Javier Martinez Canillas 2022-02-02 11:50 ` Andy Shevchenko 2022-02-02 11:50 ` Andy Shevchenko 2022-02-02 11:54 ` Javier Martinez Canillas 2022-02-02 11:54 ` Javier Martinez Canillas 2022-02-02 12:21 ` Andy Shevchenko 2022-02-02 12:21 ` Andy Shevchenko 2022-02-01 8:43 ` Geert Uytterhoeven 2022-02-01 8:43 ` Geert Uytterhoeven 2022-02-01 9:27 ` Simon Ser 2022-02-01 9:27 ` Simon Ser 2022-02-01 10:36 ` Javier Martinez Canillas 2022-02-01 10:36 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4d9a56a7-da25-b411-61cc-372c6fa9011d@tronnes.org \ --to=noralf@tronnes.org \ --cc=airlied@linux.ie \ --cc=andriy.shevchenko@linux.intel.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.l.velikov@gmail.com \ --cc=geert@linux-m68k.org \ --cc=javierm@redhat.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime@cerno.tech \ --cc=sam@ravnborg.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.