From: Javier Martinez Canillas <javierm@redhat.com> To: Simon Ser <contact@emersion.fr> Cc: linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, "Thomas Zimmermann" <tzimmermann@suse.de>, "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, "Mark Brown" <broonie@kernel.org>, dri-devel@lists.freedesktop.org, "Liam Girdwood" <lgirdwood@gmail.com>, "Noralf Trønnes" <noralf@tronnes.org>, "Geert Uytterhoeven" <geert@linux-m68k.org>, "Maxime Ripard" <maxime@cerno.tech>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Thierry Reding" <thierry.reding@gmail.com>, "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>, "Lee Jones" <lee.jones@linaro.org> Subject: Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Date: Tue, 1 Feb 2022 00:21:41 +0100 [thread overview] Message-ID: <c7818782-ab41-b526-9e81-e769259baa52@redhat.com> (raw) In-Reply-To: <wuXPJN-K-rvjoV51c4EBmTBScov8rcJTPoYmlfHe04_-4wD1khVxo9HnUsP7UFd5m4AkzGSw2hXe_c77jbSRhjEJ0JZIYwuvuIkcv_KsR-Y=@emersion.fr> Hello Simon, Thanks for your feedback. On 1/31/22 21:39, Simon Ser wrote: > On Monday, January 31st, 2022 at 21:36, Simon Ser <contact@emersion.fr> wrote: > >> This driver only advertises XRGB8888 in ssd1307_formats. It would be nice to >> expose R8 as well so that user-space can directly produce suitable buffers. >> It would also be nice to have some kind of preferred format, so that user-space >> knows R8 is preferred over XRGB8888. > > Hm, since the format used by the hw is actually R1, adding that to drm_fourcc.h > would be even better. > Yes, agreed that would be nice. We discussed this already with Thomas and my suggestion was to land the driver as is, advertising XRGB8888. Which is also what the other driver using monochrome does (drivers/gpu/drm/tiny/repaper.c): https://www.spinics.net/lists/dri-devel/msg331328.html As a follow-up we can wire up al the needed bits to have a DRM/KMS driver that could expose a R1 format. > Let me know if you want me to type up any of the user-space bits. > Thanks! I also could help to add the needed support in the user-space stack. Best reagards, -- Javier Martinez Canillas Linux Engineering Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com> To: Simon Ser <contact@emersion.fr> Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, "Noralf Trønnes" <noralf@tronnes.org>, "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Liam Girdwood" <lgirdwood@gmail.com>, "Mark Brown" <broonie@kernel.org>, "Geert Uytterhoeven" <geert@linux-m68k.org>, "Maxime Ripard" <maxime@cerno.tech>, "Thomas Zimmermann" <tzimmermann@suse.de>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Thierry Reding" <thierry.reding@gmail.com>, "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>, "Lee Jones" <lee.jones@linaro.org> Subject: Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Date: Tue, 1 Feb 2022 00:21:41 +0100 [thread overview] Message-ID: <c7818782-ab41-b526-9e81-e769259baa52@redhat.com> (raw) In-Reply-To: <wuXPJN-K-rvjoV51c4EBmTBScov8rcJTPoYmlfHe04_-4wD1khVxo9HnUsP7UFd5m4AkzGSw2hXe_c77jbSRhjEJ0JZIYwuvuIkcv_KsR-Y=@emersion.fr> Hello Simon, Thanks for your feedback. On 1/31/22 21:39, Simon Ser wrote: > On Monday, January 31st, 2022 at 21:36, Simon Ser <contact@emersion.fr> wrote: > >> This driver only advertises XRGB8888 in ssd1307_formats. It would be nice to >> expose R8 as well so that user-space can directly produce suitable buffers. >> It would also be nice to have some kind of preferred format, so that user-space >> knows R8 is preferred over XRGB8888. > > Hm, since the format used by the hw is actually R1, adding that to drm_fourcc.h > would be even better. > Yes, agreed that would be nice. We discussed this already with Thomas and my suggestion was to land the driver as is, advertising XRGB8888. Which is also what the other driver using monochrome does (drivers/gpu/drm/tiny/repaper.c): https://www.spinics.net/lists/dri-devel/msg331328.html As a follow-up we can wire up al the needed bits to have a DRM/KMS driver that could expose a R1 format. > Let me know if you want me to type up any of the user-space bits. > Thanks! I also could help to add the needed support in the user-space stack. Best reagards, -- Javier Martinez Canillas Linux Engineering Red Hat
next prev parent reply other threads:[~2022-01-31 23:21 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-31 20:12 [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Javier Martinez Canillas 2022-01-31 20:12 ` Javier Martinez Canillas 2022-01-31 20:12 ` [PATCH 1/4] drm: Add I2C connector type Javier Martinez Canillas 2022-01-31 20:12 ` Javier Martinez Canillas 2022-01-31 20:52 ` Sam Ravnborg 2022-01-31 23:26 ` Javier Martinez Canillas 2022-01-31 23:26 ` Javier Martinez Canillas 2022-02-01 12:58 ` Noralf Trønnes 2022-02-01 12:58 ` Noralf Trønnes 2022-02-01 13:06 ` Javier Martinez Canillas 2022-02-01 13:20 ` Noralf Trønnes 2022-02-01 13:55 ` Javier Martinez Canillas 2022-02-01 13:38 ` Simon Ser 2022-02-01 13:38 ` Simon Ser 2022-02-01 14:20 ` Noralf Trønnes 2022-02-01 14:20 ` Noralf Trønnes 2022-02-01 20:57 ` Sam Ravnborg 2022-02-01 22:29 ` Simon Ser 2022-02-01 22:29 ` Simon Ser 2022-02-02 8:46 ` Javier Martinez Canillas 2022-02-02 8:46 ` Javier Martinez Canillas 2022-02-02 9:14 ` Thomas Zimmermann 2022-02-02 9:14 ` Thomas Zimmermann 2022-02-02 9:45 ` Noralf Trønnes 2022-02-02 9:45 ` Noralf Trønnes 2022-02-02 15:04 ` Pekka Paalanen 2022-02-02 15:04 ` Pekka Paalanen 2022-02-02 16:00 ` Noralf Trønnes 2022-02-02 16:00 ` Noralf Trønnes 2022-01-31 20:12 ` [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed() Javier Martinez Canillas 2022-01-31 20:12 ` Javier Martinez Canillas 2022-02-01 9:59 ` Thomas Zimmermann 2022-02-01 9:59 ` Thomas Zimmermann 2022-02-01 11:13 ` Pekka Paalanen 2022-02-01 11:13 ` Pekka Paalanen 2022-02-01 11:48 ` Javier Martinez Canillas 2022-02-01 11:48 ` Javier Martinez Canillas 2022-03-14 13:40 ` Geert Uytterhoeven 2022-03-14 13:40 ` Geert Uytterhoeven 2022-03-14 14:07 ` Javier Martinez Canillas 2022-03-14 14:07 ` Javier Martinez Canillas 2022-01-31 20:36 ` [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Simon Ser 2022-01-31 20:36 ` Simon Ser 2022-01-31 20:39 ` Simon Ser 2022-01-31 20:39 ` Simon Ser 2022-01-31 23:21 ` Javier Martinez Canillas [this message] 2022-01-31 23:21 ` Javier Martinez Canillas 2022-02-01 8:26 ` Geert Uytterhoeven 2022-02-01 8:26 ` Geert Uytterhoeven 2022-02-01 8:34 ` Simon Ser 2022-02-01 8:34 ` Simon Ser 2022-02-01 8:36 ` Geert Uytterhoeven 2022-02-01 8:36 ` Geert Uytterhoeven 2022-02-01 10:08 ` Thomas Zimmermann 2022-02-01 10:08 ` Thomas Zimmermann 2022-02-01 10:11 ` Simon Ser 2022-02-01 10:11 ` Simon Ser 2022-02-01 10:17 ` Thomas Zimmermann 2022-02-01 10:17 ` Thomas Zimmermann 2022-02-01 8:38 ` Daniel Vetter 2022-02-01 8:38 ` Daniel Vetter 2022-02-01 9:49 ` Javier Martinez Canillas 2022-02-01 9:49 ` Javier Martinez Canillas 2022-02-01 10:42 ` Pekka Paalanen 2022-02-01 10:42 ` Pekka Paalanen 2022-02-01 11:07 ` Geert Uytterhoeven 2022-02-01 11:07 ` Geert Uytterhoeven 2022-02-02 9:19 ` Pekka Paalanen 2022-02-02 9:19 ` Pekka Paalanen 2022-02-02 10:55 ` Geert Uytterhoeven 2022-02-02 10:55 ` Geert Uytterhoeven 2022-01-31 20:56 ` Sam Ravnborg 2022-01-31 23:37 ` Javier Martinez Canillas 2022-01-31 23:37 ` Javier Martinez Canillas 2022-02-01 9:37 ` Andy Shevchenko 2022-02-01 9:37 ` Andy Shevchenko 2022-02-01 11:31 ` Javier Martinez Canillas 2022-02-01 11:31 ` Javier Martinez Canillas 2022-02-01 11:38 ` Geert Uytterhoeven 2022-02-01 11:38 ` Geert Uytterhoeven 2022-02-01 13:09 ` Javier Martinez Canillas 2022-02-01 13:09 ` Javier Martinez Canillas 2022-02-01 14:14 ` Geert Uytterhoeven 2022-02-01 14:14 ` Geert Uytterhoeven 2022-02-01 15:03 ` Javier Martinez Canillas 2022-02-01 15:03 ` Javier Martinez Canillas 2022-02-01 20:40 ` Sam Ravnborg 2022-02-01 20:40 ` Sam Ravnborg 2022-02-02 8:38 ` Javier Martinez Canillas 2022-02-02 8:38 ` Javier Martinez Canillas 2022-02-02 11:06 ` Andy Shevchenko 2022-02-02 11:06 ` Andy Shevchenko 2022-02-02 11:39 ` Javier Martinez Canillas 2022-02-02 11:39 ` Javier Martinez Canillas 2022-02-02 11:50 ` Andy Shevchenko 2022-02-02 11:50 ` Andy Shevchenko 2022-02-02 11:54 ` Javier Martinez Canillas 2022-02-02 11:54 ` Javier Martinez Canillas 2022-02-02 12:21 ` Andy Shevchenko 2022-02-02 12:21 ` Andy Shevchenko 2022-02-01 8:43 ` Geert Uytterhoeven 2022-02-01 8:43 ` Geert Uytterhoeven 2022-02-01 9:27 ` Simon Ser 2022-02-01 9:27 ` Simon Ser 2022-02-01 10:36 ` Javier Martinez Canillas 2022-02-01 10:36 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c7818782-ab41-b526-9e81-e769259baa52@redhat.com \ --to=javierm@redhat.com \ --cc=airlied@linux.ie \ --cc=andriy.shevchenko@linux.intel.com \ --cc=broonie@kernel.org \ --cc=contact@emersion.fr \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=maxime@cerno.tech \ --cc=noralf@tronnes.org \ --cc=thierry.reding@gmail.com \ --cc=tzimmermann@suse.de \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.