All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Maxime Ripard <maxime@cerno.tech>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Emil Velikov <emil.l.velikov@gmail.com>
Subject: Re: [PATCH 1/4] drm: Add I2C connector type
Date: Wed, 2 Feb 2022 10:45:42 +0100	[thread overview]
Message-ID: <c6100ec3-b511-17cf-c542-e124c14fb334@tronnes.org> (raw)
In-Reply-To: <4966d03e-ee0c-5130-3819-05a90a8f6d06@suse.de>



Den 02.02.2022 10.14, skrev Thomas Zimmermann:
> Hi Noralf,
> 
> since you're here, I'll just hijack the discussion to ask something only
> semi-related.
> 
> IIRC the gud driver doesn't update the display immediately during atomic
> commits. Instead, it instructs a helper thread to do the update. What's
> the rational behind this design? Is that something we should adopt for
> other drivers that operate over slow buses (USB, I2C, etc)? Would this
> be relevant for the ssd1307 driver?
> 

Async flushing is only necessary on multi display setups where there's
only one rendering loop for all the displays. I saw what tiny/gm12u320.c
did and Hans gave me the rationale. The SPI drivers run flushing inline.
Info on the gud wiki:
https://github.com/notro/gud/wiki/Linux-Host-Driver#asynchronous-flushing

Noralf.

WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	 Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-fbdev@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Maxime Ripard <maxime@cerno.tech>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 1/4] drm: Add I2C connector type
Date: Wed, 2 Feb 2022 10:45:42 +0100	[thread overview]
Message-ID: <c6100ec3-b511-17cf-c542-e124c14fb334@tronnes.org> (raw)
In-Reply-To: <4966d03e-ee0c-5130-3819-05a90a8f6d06@suse.de>



Den 02.02.2022 10.14, skrev Thomas Zimmermann:
> Hi Noralf,
> 
> since you're here, I'll just hijack the discussion to ask something only
> semi-related.
> 
> IIRC the gud driver doesn't update the display immediately during atomic
> commits. Instead, it instructs a helper thread to do the update. What's
> the rational behind this design? Is that something we should adopt for
> other drivers that operate over slow buses (USB, I2C, etc)? Would this
> be relevant for the ssd1307 driver?
> 

Async flushing is only necessary on multi display setups where there's
only one rendering loop for all the displays. I saw what tiny/gm12u320.c
did and Hans gave me the rationale. The SPI drivers run flushing inline.
Info on the gud wiki:
https://github.com/notro/gud/wiki/Linux-Host-Driver#asynchronous-flushing

Noralf.

  reply	other threads:[~2022-02-02  9:45 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 20:12 [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Javier Martinez Canillas
2022-01-31 20:12 ` Javier Martinez Canillas
2022-01-31 20:12 ` [PATCH 1/4] drm: Add I2C connector type Javier Martinez Canillas
2022-01-31 20:12   ` Javier Martinez Canillas
2022-01-31 20:52   ` Sam Ravnborg
2022-01-31 23:26     ` Javier Martinez Canillas
2022-01-31 23:26       ` Javier Martinez Canillas
2022-02-01 12:58     ` Noralf Trønnes
2022-02-01 12:58       ` Noralf Trønnes
2022-02-01 13:06       ` Javier Martinez Canillas
2022-02-01 13:20         ` Noralf Trønnes
2022-02-01 13:55           ` Javier Martinez Canillas
2022-02-01 13:38       ` Simon Ser
2022-02-01 13:38         ` Simon Ser
2022-02-01 14:20         ` Noralf Trønnes
2022-02-01 14:20           ` Noralf Trønnes
2022-02-01 20:57       ` Sam Ravnborg
2022-02-01 22:29         ` Simon Ser
2022-02-01 22:29           ` Simon Ser
2022-02-02  8:46           ` Javier Martinez Canillas
2022-02-02  8:46             ` Javier Martinez Canillas
2022-02-02  9:14       ` Thomas Zimmermann
2022-02-02  9:14         ` Thomas Zimmermann
2022-02-02  9:45         ` Noralf Trønnes [this message]
2022-02-02  9:45           ` Noralf Trønnes
2022-02-02 15:04           ` Pekka Paalanen
2022-02-02 15:04             ` Pekka Paalanen
2022-02-02 16:00             ` Noralf Trønnes
2022-02-02 16:00               ` Noralf Trønnes
2022-01-31 20:12 ` [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed() Javier Martinez Canillas
2022-01-31 20:12   ` Javier Martinez Canillas
2022-02-01  9:59   ` Thomas Zimmermann
2022-02-01  9:59     ` Thomas Zimmermann
2022-02-01 11:13     ` Pekka Paalanen
2022-02-01 11:13       ` Pekka Paalanen
2022-02-01 11:48     ` Javier Martinez Canillas
2022-02-01 11:48       ` Javier Martinez Canillas
2022-03-14 13:40   ` Geert Uytterhoeven
2022-03-14 13:40     ` Geert Uytterhoeven
2022-03-14 14:07     ` Javier Martinez Canillas
2022-03-14 14:07       ` Javier Martinez Canillas
2022-01-31 20:36 ` [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Simon Ser
2022-01-31 20:36   ` Simon Ser
2022-01-31 20:39   ` Simon Ser
2022-01-31 20:39     ` Simon Ser
2022-01-31 23:21     ` Javier Martinez Canillas
2022-01-31 23:21       ` Javier Martinez Canillas
2022-02-01  8:26     ` Geert Uytterhoeven
2022-02-01  8:26       ` Geert Uytterhoeven
2022-02-01  8:34       ` Simon Ser
2022-02-01  8:34         ` Simon Ser
2022-02-01  8:36         ` Geert Uytterhoeven
2022-02-01  8:36           ` Geert Uytterhoeven
2022-02-01 10:08           ` Thomas Zimmermann
2022-02-01 10:08             ` Thomas Zimmermann
2022-02-01 10:11             ` Simon Ser
2022-02-01 10:11               ` Simon Ser
2022-02-01 10:17               ` Thomas Zimmermann
2022-02-01 10:17                 ` Thomas Zimmermann
2022-02-01  8:38         ` Daniel Vetter
2022-02-01  8:38           ` Daniel Vetter
2022-02-01  9:49           ` Javier Martinez Canillas
2022-02-01  9:49             ` Javier Martinez Canillas
2022-02-01 10:42             ` Pekka Paalanen
2022-02-01 10:42               ` Pekka Paalanen
2022-02-01 11:07               ` Geert Uytterhoeven
2022-02-01 11:07                 ` Geert Uytterhoeven
2022-02-02  9:19                 ` Pekka Paalanen
2022-02-02  9:19                   ` Pekka Paalanen
2022-02-02 10:55                   ` Geert Uytterhoeven
2022-02-02 10:55                     ` Geert Uytterhoeven
2022-01-31 20:56 ` Sam Ravnborg
2022-01-31 23:37   ` Javier Martinez Canillas
2022-01-31 23:37     ` Javier Martinez Canillas
2022-02-01  9:37   ` Andy Shevchenko
2022-02-01  9:37     ` Andy Shevchenko
2022-02-01 11:31     ` Javier Martinez Canillas
2022-02-01 11:31       ` Javier Martinez Canillas
2022-02-01 11:38       ` Geert Uytterhoeven
2022-02-01 11:38         ` Geert Uytterhoeven
2022-02-01 13:09         ` Javier Martinez Canillas
2022-02-01 13:09           ` Javier Martinez Canillas
2022-02-01 14:14           ` Geert Uytterhoeven
2022-02-01 14:14             ` Geert Uytterhoeven
2022-02-01 15:03             ` Javier Martinez Canillas
2022-02-01 15:03               ` Javier Martinez Canillas
2022-02-01 20:40               ` Sam Ravnborg
2022-02-01 20:40                 ` Sam Ravnborg
2022-02-02  8:38                 ` Javier Martinez Canillas
2022-02-02  8:38                   ` Javier Martinez Canillas
2022-02-02 11:06                   ` Andy Shevchenko
2022-02-02 11:06                     ` Andy Shevchenko
2022-02-02 11:39                     ` Javier Martinez Canillas
2022-02-02 11:39                       ` Javier Martinez Canillas
2022-02-02 11:50                       ` Andy Shevchenko
2022-02-02 11:50                         ` Andy Shevchenko
2022-02-02 11:54                         ` Javier Martinez Canillas
2022-02-02 11:54                           ` Javier Martinez Canillas
2022-02-02 12:21                           ` Andy Shevchenko
2022-02-02 12:21                             ` Andy Shevchenko
2022-02-01  8:43 ` Geert Uytterhoeven
2022-02-01  8:43   ` Geert Uytterhoeven
2022-02-01  9:27   ` Simon Ser
2022-02-01  9:27     ` Simon Ser
2022-02-01 10:36   ` Javier Martinez Canillas
2022-02-01 10:36     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6100ec3-b511-17cf-c542-e124c14fb334@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=airlied@linux.ie \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=javierm@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.