All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
Date: Mon, 01 Oct 2012 10:05:21 +0200	[thread overview]
Message-ID: <50694EC1.8060006@siemens.com> (raw)
In-Reply-To: <20120930191146.GA20012@amt.cnet>

On 2012-09-30 21:11, Marcelo Tosatti wrote:
> 
> Option is deprecated and warning has been in place for one year.

Do we really care about such cosmetics? What is the big plan for
qemu-kvm now? For 1.3 and then beyond?

Jan

> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> diff --git a/blockdev.c b/blockdev.c
> index 4a5266e..7c83baa 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -432,12 +432,6 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
>          return NULL;
>      }
>  
> -    if (qemu_opt_get(opts, "boot") != NULL) {
> -        fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
> -                "ignored. Future versions will reject this parameter. Please "
> -                "update your scripts.\n");
> -    }
> -
>      on_write_error = BLOCK_ERR_STOP_ENOSPC;
>      if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
>          if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type != IF_NONE) {
> diff --git a/qemu-config.c b/qemu-config.c
> index 3eaee48..eba977e 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -114,10 +114,6 @@ static QemuOptsList qemu_drive_opts = {
>              .name = "copy-on-read",
>              .type = QEMU_OPT_BOOL,
>              .help = "copy read data from backing file into image file",
> -        },{
> -            .name = "boot",
> -            .type = QEMU_OPT_BOOL,
> -            .help = "(deprecated, ignored)",
>          },
>          { /* end of list */ }
>      },
> 

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

  parent reply	other threads:[~2012-10-01  8:05 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-30 19:11 qemu-kvm: remove "boot=on|off" drive parameter compatibility Marcelo Tosatti
2012-10-01  1:02 ` Amos Kong
2012-10-01  8:05 ` Jan Kiszka [this message]
2012-10-01  9:31   ` Marcelo Tosatti
2012-10-01 10:21     ` Jan Kiszka
2012-10-01 13:03       ` Marcelo Tosatti
2012-10-01 13:14         ` Jan Kiszka
2012-10-01 13:19       ` Anthony Liguori
2012-10-01 13:19         ` [Qemu-devel] " Anthony Liguori
2012-10-01 13:26         ` Jan Kiszka
2012-10-01 13:26           ` [Qemu-devel] " Jan Kiszka
2012-10-03  9:55           ` Gleb Natapov
2012-10-03  9:55             ` Gleb Natapov
2012-10-03 10:06             ` Jan Kiszka
2012-10-03 10:06               ` Jan Kiszka
2012-10-03 10:11               ` Gleb Natapov
2012-10-03 10:11                 ` Gleb Natapov
2012-10-03 10:57             ` Lucas Meneghel Rodrigues
2012-10-03 10:57               ` [Qemu-devel] " Lucas Meneghel Rodrigues
2012-10-03 13:19               ` Paolo Bonzini
2012-10-03 13:19                 ` [Qemu-devel] " Paolo Bonzini
2012-10-03 13:27                 ` Gleb Natapov
2012-10-03 13:27                   ` [Qemu-devel] " Gleb Natapov
2012-10-04 10:48                 ` Jan Kiszka
2012-10-04 10:48                   ` [Qemu-devel] " Jan Kiszka
2012-10-04 12:10                   ` Lucas Meneghel Rodrigues
2012-10-04 12:10                     ` [Qemu-devel] " Lucas Meneghel Rodrigues
2012-10-04 12:27                     ` Jan Kiszka
2012-10-04 12:27                       ` [Qemu-devel] " Jan Kiszka
2012-10-04 17:21                       ` Lucas Meneghel Rodrigues
2012-10-04 17:21                         ` [Qemu-devel] " Lucas Meneghel Rodrigues
2012-10-04 17:24                         ` Jan Kiszka
2012-10-04 17:24                           ` [Qemu-devel] " Jan Kiszka
2012-10-01 13:31         ` Marcelo Tosatti
2012-10-01 13:31           ` [Qemu-devel] " Marcelo Tosatti
2012-10-01 13:36           ` Jan Kiszka
2012-10-01 13:36             ` [Qemu-devel] " Jan Kiszka
2012-10-01 13:44             ` Michael Tokarev
2012-10-01 13:44               ` [Qemu-devel] " Michael Tokarev
2012-10-01 13:48               ` Jan Kiszka
2012-10-01 13:48                 ` [Qemu-devel] " Jan Kiszka
2012-10-01 13:38         ` Paolo Bonzini
2012-10-01 13:38           ` [Qemu-devel] " Paolo Bonzini
2012-10-01 13:46           ` Jan Kiszka
2012-10-01 13:46             ` [Qemu-devel] " Jan Kiszka
2012-10-01 14:04           ` Anthony Liguori
2012-10-01 14:04             ` [Qemu-devel] " Anthony Liguori
2012-10-01 14:34             ` [PATCH] kvm: Set default accelerator to "kvm" if the host supports it Jan Kiszka
2012-10-01 14:34               ` [Qemu-devel] " Jan Kiszka
2012-10-01 16:20               ` Anthony Liguori
2012-10-01 16:20                 ` [Qemu-devel] " Anthony Liguori
2012-10-01 16:56                 ` Aurelien Jarno
2012-10-01 16:56                   ` [Qemu-devel] " Aurelien Jarno
2012-10-03  9:02                 ` Jan Kiszka
2012-10-03  9:02                   ` [Qemu-devel] " Jan Kiszka
2012-10-03 20:01                 ` Blue Swirl
2012-10-03 20:01                   ` [Qemu-devel] " Blue Swirl
2012-10-03 20:26                   ` Peter Maydell
2012-10-03 20:26                     ` Peter Maydell
2012-10-05  1:15                     ` Alexander Graf
2012-10-05  1:15                       ` Alexander Graf
2012-10-05  2:17                       ` Anthony Liguori
2012-10-05  2:17                         ` [Qemu-devel] " Anthony Liguori
2012-10-05  2:24                         ` Alexander Graf
2012-10-05  2:24                           ` Alexander Graf
2012-10-05  8:15                           ` Peter Maydell
2012-10-05  8:15                             ` Peter Maydell
2012-10-08 14:03                           ` Andreas Färber
2012-10-08 14:03                             ` Andreas Färber
2012-10-08 14:08                             ` Alexander Graf
2012-10-08 14:08                               ` Alexander Graf
2012-10-01 16:43               ` Andreas Färber
2012-10-01 16:43                 ` Andreas Färber
2012-10-01 16:47                 ` Daniel P. Berrange
2012-10-01 16:47                   ` Daniel P. Berrange
2012-10-01 19:03                   ` Anthony Liguori
2012-10-01 19:03                     ` Anthony Liguori
2012-10-01 19:25                     ` Paolo Bonzini
2012-10-01 19:25                       ` [Qemu-devel] " Paolo Bonzini
2012-10-01 20:07                       ` Anthony Liguori
2012-10-01 20:07                         ` Anthony Liguori
2012-10-02  7:46                   ` Markus Armbruster
2012-10-02  7:46                     ` [Qemu-devel] " Markus Armbruster
2012-10-02  8:15                     ` Aurelien Jarno
2012-10-02  8:15                       ` Aurelien Jarno
2012-10-03  6:58                     ` Michael Tokarev
2012-10-03  6:58                       ` Michael Tokarev
2012-10-03  9:05                       ` Jan Kiszka
2012-10-03  9:05                         ` [Qemu-devel] " Jan Kiszka
2012-10-01 14:07         ` qemu-kvm: remove "boot=on|off" drive parameter compatibility Alexander Graf
2012-10-01 14:07           ` [Qemu-devel] " Alexander Graf
2012-10-01 14:20           ` Paolo Bonzini
2012-10-01 14:20             ` [Qemu-devel] " Paolo Bonzini
2012-10-01 15:39         ` Bruce Rogers
2012-10-01 15:39           ` Bruce Rogers
2012-10-02  8:14         ` Daniel P. Berrange
2012-10-02  8:14           ` [Qemu-devel] " Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50694EC1.8060006@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.