All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Lucas Meneghel Rodrigues" <lmr@redhat.com>,
	kvm <kvm@vger.kernel.org>, "Scott Moser" <smoser@ubuntu.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Anthony Liguori" <anthony@codemonkey.ws>,
	"Cole Robinson" <crobinso@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
Date: Wed, 3 Oct 2012 15:27:55 +0200	[thread overview]
Message-ID: <20121003132755.GR23096@redhat.com> (raw)
In-Reply-To: <506C3B7C.408@redhat.com>

On Wed, Oct 03, 2012 at 03:19:56PM +0200, Paolo Bonzini wrote:
> Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto:
> > Yep, I did send patches with the testdev device present on qemu-kvm.git
> > to qemu.git a while ago, but there were many comments on the review, I
> > ended up not implementing everything that was asked and the patches were
> > archived.
> > 
> > If nobody wants to step up to port it, I'll re-read the original thread
> > and will spin up new patches (and try to go through the end with it).
> > Executing the KVM unittests is something that we can't afford to lose,
> > so I'd say it's important on this last mile effort to get rid of qemu-kvm.
> 
> Absolutely, IIRC the problem was that testdev did a little bit of
> everything... let's see what's the functionality of testdev:
> 
> - write (port 0xf1), can be replaced in autotest with:
> -device isa-debugcon,iobase=0xf1,chardev=...
> 
kvm-unit-tests no longer uses 0xf1 for output. It uses serial.

> - exit code (port 0xf4), see this series:
> http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html
> 
> - ram size (port 0xd1).  If we can also patch kvm-unittests, the memory
> is available in the CMOS or in fwcfg.  Here is the SeaBIOS code:
> 
>         u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24));
>         if (rs)
>             rs += 16 * 1024 * 1024;
>         else
>             rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18))
>                   + 1 * 1024 * 1024);
> 
> The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev.
> 
> Paolo

--
			Gleb.

WARNING: multiple messages have this Message-ID (diff)
From: Gleb Natapov <gleb@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Lucas Meneghel Rodrigues" <lmr@redhat.com>,
	kvm <kvm@vger.kernel.org>, "Scott Moser" <smoser@ubuntu.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Anthony Liguori" <anthony@codemonkey.ws>,
	"Cole Robinson" <crobinso@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility
Date: Wed, 3 Oct 2012 15:27:55 +0200	[thread overview]
Message-ID: <20121003132755.GR23096@redhat.com> (raw)
In-Reply-To: <506C3B7C.408@redhat.com>

On Wed, Oct 03, 2012 at 03:19:56PM +0200, Paolo Bonzini wrote:
> Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto:
> > Yep, I did send patches with the testdev device present on qemu-kvm.git
> > to qemu.git a while ago, but there were many comments on the review, I
> > ended up not implementing everything that was asked and the patches were
> > archived.
> > 
> > If nobody wants to step up to port it, I'll re-read the original thread
> > and will spin up new patches (and try to go through the end with it).
> > Executing the KVM unittests is something that we can't afford to lose,
> > so I'd say it's important on this last mile effort to get rid of qemu-kvm.
> 
> Absolutely, IIRC the problem was that testdev did a little bit of
> everything... let's see what's the functionality of testdev:
> 
> - write (port 0xf1), can be replaced in autotest with:
> -device isa-debugcon,iobase=0xf1,chardev=...
> 
kvm-unit-tests no longer uses 0xf1 for output. It uses serial.

> - exit code (port 0xf4), see this series:
> http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html
> 
> - ram size (port 0xd1).  If we can also patch kvm-unittests, the memory
> is available in the CMOS or in fwcfg.  Here is the SeaBIOS code:
> 
>         u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24));
>         if (rs)
>             rs += 16 * 1024 * 1024;
>         else
>             rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18))
>                   + 1 * 1024 * 1024);
> 
> The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev.
> 
> Paolo

--
			Gleb.

  reply	other threads:[~2012-10-03 13:27 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-30 19:11 qemu-kvm: remove "boot=on|off" drive parameter compatibility Marcelo Tosatti
2012-10-01  1:02 ` Amos Kong
2012-10-01  8:05 ` Jan Kiszka
2012-10-01  9:31   ` Marcelo Tosatti
2012-10-01 10:21     ` Jan Kiszka
2012-10-01 13:03       ` Marcelo Tosatti
2012-10-01 13:14         ` Jan Kiszka
2012-10-01 13:19       ` Anthony Liguori
2012-10-01 13:19         ` [Qemu-devel] " Anthony Liguori
2012-10-01 13:26         ` Jan Kiszka
2012-10-01 13:26           ` [Qemu-devel] " Jan Kiszka
2012-10-03  9:55           ` Gleb Natapov
2012-10-03  9:55             ` Gleb Natapov
2012-10-03 10:06             ` Jan Kiszka
2012-10-03 10:06               ` Jan Kiszka
2012-10-03 10:11               ` Gleb Natapov
2012-10-03 10:11                 ` Gleb Natapov
2012-10-03 10:57             ` Lucas Meneghel Rodrigues
2012-10-03 10:57               ` [Qemu-devel] " Lucas Meneghel Rodrigues
2012-10-03 13:19               ` Paolo Bonzini
2012-10-03 13:19                 ` [Qemu-devel] " Paolo Bonzini
2012-10-03 13:27                 ` Gleb Natapov [this message]
2012-10-03 13:27                   ` Gleb Natapov
2012-10-04 10:48                 ` Jan Kiszka
2012-10-04 10:48                   ` [Qemu-devel] " Jan Kiszka
2012-10-04 12:10                   ` Lucas Meneghel Rodrigues
2012-10-04 12:10                     ` [Qemu-devel] " Lucas Meneghel Rodrigues
2012-10-04 12:27                     ` Jan Kiszka
2012-10-04 12:27                       ` [Qemu-devel] " Jan Kiszka
2012-10-04 17:21                       ` Lucas Meneghel Rodrigues
2012-10-04 17:21                         ` [Qemu-devel] " Lucas Meneghel Rodrigues
2012-10-04 17:24                         ` Jan Kiszka
2012-10-04 17:24                           ` [Qemu-devel] " Jan Kiszka
2012-10-01 13:31         ` Marcelo Tosatti
2012-10-01 13:31           ` [Qemu-devel] " Marcelo Tosatti
2012-10-01 13:36           ` Jan Kiszka
2012-10-01 13:36             ` [Qemu-devel] " Jan Kiszka
2012-10-01 13:44             ` Michael Tokarev
2012-10-01 13:44               ` [Qemu-devel] " Michael Tokarev
2012-10-01 13:48               ` Jan Kiszka
2012-10-01 13:48                 ` [Qemu-devel] " Jan Kiszka
2012-10-01 13:38         ` Paolo Bonzini
2012-10-01 13:38           ` [Qemu-devel] " Paolo Bonzini
2012-10-01 13:46           ` Jan Kiszka
2012-10-01 13:46             ` [Qemu-devel] " Jan Kiszka
2012-10-01 14:04           ` Anthony Liguori
2012-10-01 14:04             ` [Qemu-devel] " Anthony Liguori
2012-10-01 14:34             ` [PATCH] kvm: Set default accelerator to "kvm" if the host supports it Jan Kiszka
2012-10-01 14:34               ` [Qemu-devel] " Jan Kiszka
2012-10-01 16:20               ` Anthony Liguori
2012-10-01 16:20                 ` [Qemu-devel] " Anthony Liguori
2012-10-01 16:56                 ` Aurelien Jarno
2012-10-01 16:56                   ` [Qemu-devel] " Aurelien Jarno
2012-10-03  9:02                 ` Jan Kiszka
2012-10-03  9:02                   ` [Qemu-devel] " Jan Kiszka
2012-10-03 20:01                 ` Blue Swirl
2012-10-03 20:01                   ` [Qemu-devel] " Blue Swirl
2012-10-03 20:26                   ` Peter Maydell
2012-10-03 20:26                     ` Peter Maydell
2012-10-05  1:15                     ` Alexander Graf
2012-10-05  1:15                       ` Alexander Graf
2012-10-05  2:17                       ` Anthony Liguori
2012-10-05  2:17                         ` [Qemu-devel] " Anthony Liguori
2012-10-05  2:24                         ` Alexander Graf
2012-10-05  2:24                           ` Alexander Graf
2012-10-05  8:15                           ` Peter Maydell
2012-10-05  8:15                             ` Peter Maydell
2012-10-08 14:03                           ` Andreas Färber
2012-10-08 14:03                             ` Andreas Färber
2012-10-08 14:08                             ` Alexander Graf
2012-10-08 14:08                               ` Alexander Graf
2012-10-01 16:43               ` Andreas Färber
2012-10-01 16:43                 ` Andreas Färber
2012-10-01 16:47                 ` Daniel P. Berrange
2012-10-01 16:47                   ` Daniel P. Berrange
2012-10-01 19:03                   ` Anthony Liguori
2012-10-01 19:03                     ` Anthony Liguori
2012-10-01 19:25                     ` Paolo Bonzini
2012-10-01 19:25                       ` [Qemu-devel] " Paolo Bonzini
2012-10-01 20:07                       ` Anthony Liguori
2012-10-01 20:07                         ` Anthony Liguori
2012-10-02  7:46                   ` Markus Armbruster
2012-10-02  7:46                     ` [Qemu-devel] " Markus Armbruster
2012-10-02  8:15                     ` Aurelien Jarno
2012-10-02  8:15                       ` Aurelien Jarno
2012-10-03  6:58                     ` Michael Tokarev
2012-10-03  6:58                       ` Michael Tokarev
2012-10-03  9:05                       ` Jan Kiszka
2012-10-03  9:05                         ` [Qemu-devel] " Jan Kiszka
2012-10-01 14:07         ` qemu-kvm: remove "boot=on|off" drive parameter compatibility Alexander Graf
2012-10-01 14:07           ` [Qemu-devel] " Alexander Graf
2012-10-01 14:20           ` Paolo Bonzini
2012-10-01 14:20             ` [Qemu-devel] " Paolo Bonzini
2012-10-01 15:39         ` Bruce Rogers
2012-10-01 15:39           ` Bruce Rogers
2012-10-02  8:14         ` Daniel P. Berrange
2012-10-02  8:14           ` [Qemu-devel] " Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121003132755.GR23096@redhat.com \
    --to=gleb@redhat.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=crobinso@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=smoser@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.