All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Blue Swirl" <blauwirbel@gmail.com>, kvm <kvm@vger.kernel.org>,
	"Scott Moser" <smoser@ubuntu.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	qemu-devel <qemu-devel@nongnu.org>, "Avi Kivity" <avi@redhat.com>,
	"Anthony Liguori" <anthony@codemonkey.ws>,
	"Cole Robinson" <crobinso@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it
Date: Fri, 5 Oct 2012 03:15:59 +0200	[thread overview]
Message-ID: <7F16819A-D454-4412-A21D-CD6185C8D505@suse.de> (raw)
In-Reply-To: <CAFEAcA8red0vEQpbV2onWNcdO+rhL1PJD5O0aBrDeG2Mb7ULpw@mail.gmail.com>


On 03.10.2012, at 22:26, Peter Maydell wrote:

> On 3 October 2012 21:01, Blue Swirl <blauwirbel@gmail.com> wrote:
>> On Mon, Oct 1, 2012 at 4:20 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>>> Jan Kiszka <jan.kiszka@siemens.com> writes:
>>>> +        /* The default accelerator depends on the availability of KVM. */
>>>> +        p = kvm_configured ? "kvm" : "tcg";
>>>>     }
> 
>>> Blue/Aurelien, any objections?
>> 
>> No, maybe a message could be printed that says that the default has
>> changed, for a few releases.
> 
> I've lost track of the conversation, are we currently proposing
> the accelerator default to be "kvm" (as per the original patch
> you quote here) or "kvm:tcg" ?
> 
> I'm not entirely sure which I prefer from an ARM perspective
> For some time to come and for a lot of targets (ie any target
> CPU except A15), having a default of "kvm" is going to cause
> existing working commandlines to stop working. [I expect that
> ARM-host qemu binaries will be built with CONFIG_KVM once ARM
> KVM support lands, but the same binary will be run on hosts
> without virtualization extensions.] On the other hand, perhaps
> there just aren't really very many people who run QEMU on
> ARM hosts, and so we can ignore them :-)

We get similar problems on PPC. Take the following example:

  $ qemu-system-ppc -M mpc8544ds -kernel uImage -nographic

That command line would work just fine if you run it on a G5 today. However, if we switch to accel=kvm:tcg, it will stop working, because kvm on the G5 can not virtualize an e500 CPU.

I don't know any good way around that one either the way the code is layered today. We only know the type of CPU we want to create after we made the decision whether we do KVM or not.


Alex


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm <kvm@vger.kernel.org>, "Scott Moser" <smoser@ubuntu.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Blue Swirl" <blauwirbel@gmail.com>,
	"Avi Kivity" <avi@redhat.com>,
	"Anthony Liguori" <anthony@codemonkey.ws>,
	"Cole Robinson" <crobinso@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it
Date: Fri, 5 Oct 2012 03:15:59 +0200	[thread overview]
Message-ID: <7F16819A-D454-4412-A21D-CD6185C8D505@suse.de> (raw)
In-Reply-To: <CAFEAcA8red0vEQpbV2onWNcdO+rhL1PJD5O0aBrDeG2Mb7ULpw@mail.gmail.com>


On 03.10.2012, at 22:26, Peter Maydell wrote:

> On 3 October 2012 21:01, Blue Swirl <blauwirbel@gmail.com> wrote:
>> On Mon, Oct 1, 2012 at 4:20 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>>> Jan Kiszka <jan.kiszka@siemens.com> writes:
>>>> +        /* The default accelerator depends on the availability of KVM. */
>>>> +        p = kvm_configured ? "kvm" : "tcg";
>>>>     }
> 
>>> Blue/Aurelien, any objections?
>> 
>> No, maybe a message could be printed that says that the default has
>> changed, for a few releases.
> 
> I've lost track of the conversation, are we currently proposing
> the accelerator default to be "kvm" (as per the original patch
> you quote here) or "kvm:tcg" ?
> 
> I'm not entirely sure which I prefer from an ARM perspective
> For some time to come and for a lot of targets (ie any target
> CPU except A15), having a default of "kvm" is going to cause
> existing working commandlines to stop working. [I expect that
> ARM-host qemu binaries will be built with CONFIG_KVM once ARM
> KVM support lands, but the same binary will be run on hosts
> without virtualization extensions.] On the other hand, perhaps
> there just aren't really very many people who run QEMU on
> ARM hosts, and so we can ignore them :-)

We get similar problems on PPC. Take the following example:

  $ qemu-system-ppc -M mpc8544ds -kernel uImage -nographic

That command line would work just fine if you run it on a G5 today. However, if we switch to accel=kvm:tcg, it will stop working, because kvm on the G5 can not virtualize an e500 CPU.

I don't know any good way around that one either the way the code is layered today. We only know the type of CPU we want to create after we made the decision whether we do KVM or not.


Alex

  reply	other threads:[~2012-10-05  1:16 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-30 19:11 qemu-kvm: remove "boot=on|off" drive parameter compatibility Marcelo Tosatti
2012-10-01  1:02 ` Amos Kong
2012-10-01  8:05 ` Jan Kiszka
2012-10-01  9:31   ` Marcelo Tosatti
2012-10-01 10:21     ` Jan Kiszka
2012-10-01 13:03       ` Marcelo Tosatti
2012-10-01 13:14         ` Jan Kiszka
2012-10-01 13:19       ` Anthony Liguori
2012-10-01 13:19         ` [Qemu-devel] " Anthony Liguori
2012-10-01 13:26         ` Jan Kiszka
2012-10-01 13:26           ` [Qemu-devel] " Jan Kiszka
2012-10-03  9:55           ` Gleb Natapov
2012-10-03  9:55             ` Gleb Natapov
2012-10-03 10:06             ` Jan Kiszka
2012-10-03 10:06               ` Jan Kiszka
2012-10-03 10:11               ` Gleb Natapov
2012-10-03 10:11                 ` Gleb Natapov
2012-10-03 10:57             ` Lucas Meneghel Rodrigues
2012-10-03 10:57               ` [Qemu-devel] " Lucas Meneghel Rodrigues
2012-10-03 13:19               ` Paolo Bonzini
2012-10-03 13:19                 ` [Qemu-devel] " Paolo Bonzini
2012-10-03 13:27                 ` Gleb Natapov
2012-10-03 13:27                   ` [Qemu-devel] " Gleb Natapov
2012-10-04 10:48                 ` Jan Kiszka
2012-10-04 10:48                   ` [Qemu-devel] " Jan Kiszka
2012-10-04 12:10                   ` Lucas Meneghel Rodrigues
2012-10-04 12:10                     ` [Qemu-devel] " Lucas Meneghel Rodrigues
2012-10-04 12:27                     ` Jan Kiszka
2012-10-04 12:27                       ` [Qemu-devel] " Jan Kiszka
2012-10-04 17:21                       ` Lucas Meneghel Rodrigues
2012-10-04 17:21                         ` [Qemu-devel] " Lucas Meneghel Rodrigues
2012-10-04 17:24                         ` Jan Kiszka
2012-10-04 17:24                           ` [Qemu-devel] " Jan Kiszka
2012-10-01 13:31         ` Marcelo Tosatti
2012-10-01 13:31           ` [Qemu-devel] " Marcelo Tosatti
2012-10-01 13:36           ` Jan Kiszka
2012-10-01 13:36             ` [Qemu-devel] " Jan Kiszka
2012-10-01 13:44             ` Michael Tokarev
2012-10-01 13:44               ` [Qemu-devel] " Michael Tokarev
2012-10-01 13:48               ` Jan Kiszka
2012-10-01 13:48                 ` [Qemu-devel] " Jan Kiszka
2012-10-01 13:38         ` Paolo Bonzini
2012-10-01 13:38           ` [Qemu-devel] " Paolo Bonzini
2012-10-01 13:46           ` Jan Kiszka
2012-10-01 13:46             ` [Qemu-devel] " Jan Kiszka
2012-10-01 14:04           ` Anthony Liguori
2012-10-01 14:04             ` [Qemu-devel] " Anthony Liguori
2012-10-01 14:34             ` [PATCH] kvm: Set default accelerator to "kvm" if the host supports it Jan Kiszka
2012-10-01 14:34               ` [Qemu-devel] " Jan Kiszka
2012-10-01 16:20               ` Anthony Liguori
2012-10-01 16:20                 ` [Qemu-devel] " Anthony Liguori
2012-10-01 16:56                 ` Aurelien Jarno
2012-10-01 16:56                   ` [Qemu-devel] " Aurelien Jarno
2012-10-03  9:02                 ` Jan Kiszka
2012-10-03  9:02                   ` [Qemu-devel] " Jan Kiszka
2012-10-03 20:01                 ` Blue Swirl
2012-10-03 20:01                   ` [Qemu-devel] " Blue Swirl
2012-10-03 20:26                   ` Peter Maydell
2012-10-03 20:26                     ` Peter Maydell
2012-10-05  1:15                     ` Alexander Graf [this message]
2012-10-05  1:15                       ` Alexander Graf
2012-10-05  2:17                       ` Anthony Liguori
2012-10-05  2:17                         ` [Qemu-devel] " Anthony Liguori
2012-10-05  2:24                         ` Alexander Graf
2012-10-05  2:24                           ` Alexander Graf
2012-10-05  8:15                           ` Peter Maydell
2012-10-05  8:15                             ` Peter Maydell
2012-10-08 14:03                           ` Andreas Färber
2012-10-08 14:03                             ` Andreas Färber
2012-10-08 14:08                             ` Alexander Graf
2012-10-08 14:08                               ` Alexander Graf
2012-10-01 16:43               ` Andreas Färber
2012-10-01 16:43                 ` Andreas Färber
2012-10-01 16:47                 ` Daniel P. Berrange
2012-10-01 16:47                   ` Daniel P. Berrange
2012-10-01 19:03                   ` Anthony Liguori
2012-10-01 19:03                     ` Anthony Liguori
2012-10-01 19:25                     ` Paolo Bonzini
2012-10-01 19:25                       ` [Qemu-devel] " Paolo Bonzini
2012-10-01 20:07                       ` Anthony Liguori
2012-10-01 20:07                         ` Anthony Liguori
2012-10-02  7:46                   ` Markus Armbruster
2012-10-02  7:46                     ` [Qemu-devel] " Markus Armbruster
2012-10-02  8:15                     ` Aurelien Jarno
2012-10-02  8:15                       ` Aurelien Jarno
2012-10-03  6:58                     ` Michael Tokarev
2012-10-03  6:58                       ` Michael Tokarev
2012-10-03  9:05                       ` Jan Kiszka
2012-10-03  9:05                         ` [Qemu-devel] " Jan Kiszka
2012-10-01 14:07         ` qemu-kvm: remove "boot=on|off" drive parameter compatibility Alexander Graf
2012-10-01 14:07           ` [Qemu-devel] " Alexander Graf
2012-10-01 14:20           ` Paolo Bonzini
2012-10-01 14:20             ` [Qemu-devel] " Paolo Bonzini
2012-10-01 15:39         ` Bruce Rogers
2012-10-01 15:39           ` Bruce Rogers
2012-10-02  8:14         ` Daniel P. Berrange
2012-10-02  8:14           ` [Qemu-devel] " Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7F16819A-D454-4412-A21D-CD6185C8D505@suse.de \
    --to=agraf@suse.de \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=aurelien@aurel32.net \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=crobinso@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=smoser@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.