From: "ZHU Yi (ST-FIR/ENG1-Zhu)" <Yi.Zhu5@cn.bosch.com>
To: Pankaj Bansal <pankaj.bansal@nxp.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Cc: Varun Sethi <V.Sethi@nxp.com>,
Poonam Aggrwal <poonam.aggrwal@nxp.com>,
Bhupesh Sharma <bhupesh.sharma@freescale.com>
Subject: RE: [PATCH v2 2/2] can: flexcan: adding platform specific details for LS1021A
Date: Tue, 21 Nov 2017 03:31:01 +0000 [thread overview]
Message-ID: <63a0798d1f5b4fa6ada730c6ba03480c@SGPMBX1017.APAC.bosch.com> (raw)
In-Reply-To: <AM0PR0402MB3940F2C5AEB0734DC8B79608F1230@AM0PR0402MB3940.eurprd04.prod.outlook.com>
Hello Pankaj,
>From: Pankaj Bansal [mailto:pankaj.bansal@nxp.com]
>Sent: Tuesday, November 21, 2017 10:38 AM
> [...]
>
>Thanks Zhu Yi. In that case do we even need to put these changes in a quirk?
>Shouldn't this code be generic flexcan code, irrespective of the platform?
If in the future version of flexcan supports the complete set of
state interrupts, then the new core which don't need the workaround
can switch it off easily via not specifying these quirks.
Make it irrespective of the platform will add the unnecessary overhead
to the new core (although the overhead is little).
>
> [...]
>
>I will test this after PERR_STATE quirk. But as I mentioned above, in my opinion
>we should remove FLEXCAN_QUIRK_BROKEN_PERR_STATE, and make these changes
>common for all platforms.
Thanks, I'm looking forward to the test results. As explained above,
we are still in the hope that FLEXCAN might improve in the future. :)
Best regards
Yi
next prev parent reply other threads:[~2017-11-21 3:31 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 9:59 [PATCH 1/2] can: flexcan: Remodel FlexCAN register r/w APIs for big endian FlexCAN controllers Pankaj Bansal
2017-11-10 9:59 ` [PATCH 2/2] can: flexcan: adding platform specific details for LS1021A Pankaj Bansal
2017-11-10 10:06 ` [PATCH 1/2] can: flexcan: Remodel FlexCAN register r/w APIs for big endian FlexCAN controllers Marc Kleine-Budde
2017-11-10 11:06 ` Pankaj Bansal
2017-11-10 11:09 ` Marc Kleine-Budde
2017-11-10 12:35 ` Pankaj Bansal
[not found] ` <AM0PR0402MB394051B0FAADBC45AF71439CF1540-mYCQpYF9suc3mfjNbz3WnI3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-11-10 12:49 ` Marc Kleine-Budde
2017-11-10 16:32 ` Pankaj Bansal
[not found] ` <AM0PR0402MB3940DE05B2BA456D0FF54498F1540-mYCQpYF9suc3mfjNbz3WnI3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-11-13 15:50 ` Marc Kleine-Budde
2017-11-10 10:48 ` Marc Kleine-Budde
2017-11-14 11:56 ` [PATCH v2 " Pankaj Bansal
2017-11-14 11:56 ` [PATCH v2 2/2] can: flexcan: adding platform specific details for LS1021A Pankaj Bansal
2017-11-14 12:59 ` Marc Kleine-Budde
2017-11-16 5:34 ` Pankaj Bansal
2017-11-16 7:05 ` Wolfgang Grandegger
2017-11-16 7:23 ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-11-20 11:11 ` Pankaj Bansal
2017-11-21 2:13 ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-11-21 2:37 ` Pankaj Bansal
2017-11-21 3:31 ` ZHU Yi (ST-FIR/ENG1-Zhu) [this message]
2017-11-21 10:01 ` Pankaj Bansal
2017-11-23 7:23 ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-11-21 12:43 ` Marc Kleine-Budde
2017-11-22 2:56 ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-11-22 6:27 ` Pankaj Bansal
2017-11-22 13:56 ` Marc Kleine-Budde
2017-11-22 11:59 ` Marc Kleine-Budde
2017-11-23 1:26 ` ZHU Yi (ST-FIR/ENG1-Zhu)
[not found] ` <CALw8SCUGuCmq+S_9-o-ZDYJuASveuj71WH97jYsEvNZX2N5ZXA@mail.gmail.com>
2017-11-23 20:17 ` Mirza Krak
2017-11-23 21:05 ` Wolfgang Grandegger
2017-11-24 16:02 ` Mirza Krak
2017-11-24 19:19 ` Wolfgang Grandegger
2017-11-26 21:11 ` Mirza Krak
2017-11-27 14:00 ` Marc Kleine-Budde
[not found] ` <CALw8SCVNqN0SM1e=bxXZFMVL0VN0iy0LgFj9Hv4BeRwAbb9Y6A@mail.gmail.com>
2017-11-28 22:11 ` Mirza Krak
2017-12-01 10:12 ` Mirza Krak
2017-12-01 10:32 ` Marc Kleine-Budde
2017-11-27 16:34 ` Stefan Agner
2017-11-14 15:24 ` [PATCH v2 1/2] can: flexcan: Remodel FlexCAN register r/w APIs for big endian FlexCAN controllers Marc Kleine-Budde
2017-11-16 5:24 ` Pankaj Bansal
2017-11-16 12:04 ` Marc Kleine-Budde
2017-11-21 12:18 ` Pankaj Bansal
2017-11-21 12:38 ` Marc Kleine-Budde
2017-11-23 9:09 ` [PATCH v3 " Pankaj Bansal
2017-11-23 9:09 ` [PATCH v3 2/2] can: flexcan: adding platform specific details for LS1021A Pankaj Bansal
2017-11-23 9:16 ` Marc Kleine-Budde
2017-11-23 10:01 ` Pankaj Bansal
2017-11-23 10:07 ` Marc Kleine-Budde
2017-11-23 12:01 ` Pankaj Bansal
2017-11-23 12:33 ` Marc Kleine-Budde
2017-11-23 9:18 ` [PATCH v3 1/2] can: flexcan: Remodel FlexCAN register r/w APIs for big endian FlexCAN controllers Marc Kleine-Budde
2017-11-23 9:55 ` Pankaj Bansal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63a0798d1f5b4fa6ada730c6ba03480c@SGPMBX1017.APAC.bosch.com \
--to=yi.zhu5@cn.bosch.com \
--cc=V.Sethi@nxp.com \
--cc=bhupesh.sharma@freescale.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=pankaj.bansal@nxp.com \
--cc=poonam.aggrwal@nxp.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.