Re: [PATCH v3 2/2] can: flexcan: adding platform specific details for LS1021A

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1979 bytes --]

On 11/23/2017 11:01 AM, Pankaj Bansal wrote:
>>> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
>>> index 4c873fb..21d0dd8 100644
>>> --- a/drivers/net/can/flexcan.c
>>> +++ b/drivers/net/can/flexcan.c
>>> @@ -190,6 +190,7 @@
>>>   *   MX53  FlexCAN2  03.00.00.00    yes        no        no       no        no
>>>   *   MX6s  FlexCAN3  10.00.12.00    yes       yes        no       no       yes
>>>   *   VF610 FlexCAN3  ?               no       yes         ?      yes       yes?
>>> + * LS1021A FlexCAN2  03.00.04.00     no       yes        no       no       yes
>>
>> Out of curiosity, where have you got the IP core version from?

> I got this version from Bill Of Material details of LS1021A SOC.

Oh, nice. Do you have access to the vf610 list to get the IP core version?


>>>   *
>>>   * Some SOCs do not have the RX_WARN & TX_WARN interrupt line
>> connected.
>>>   */
>>> @@ -304,6 +305,13 @@ static const struct flexcan_devtype_data
>> fsl_vf610_devtype_data = {
>>>  		FLEXCAN_QUIRK_DISABLE_MECR |
>> FLEXCAN_QUIRK_USE_OFF_TIMESTAMP,  };
>>>
>>> +/* LS1021A-Rev2 has functional RX-FIFO mode  */
>>
>> That comment is obsolete, isn't it? If it's a noteworthy feature, add it to the
>> overview table above.
> 
> Actually in LS1021A Rev1 RX-FIFO mode is broken. Rev1 is initial release, and Rev2
> Is final release. Which is why this comment.

Ahh, can you please add this to the table above.

You're not using the mailbox mode anymore, right? This means the driver
should work with the broken r1 silicon, too? Are any of these silicons
out in the wild? Does it make sense to use "fsl,ls1021ar1-flexcan" for
this compatible?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]