Re: [PATCH v3 2/2] can: flexcan: adding platform specific details for LS1021A

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1571 bytes --]

On 11/23/2017 01:01 PM, Pankaj Bansal wrote:
>>> I got this version from Bill Of Material details of LS1021A SOC.
>>
>> Oh, nice. Do you have access to the vf610 list to get the IP core version?
> 
> I am sorry but I don't have access to vf610 list.

Ok.

>>> Actually in LS1021A Rev1 RX-FIFO mode is broken. Rev1 is initial
>>> release, and Rev2 Is final release. Which is why this comment.
>>
>> Ahh, can you please add this to the table above.
> 
> I have already added LS1021A in table.

Yes, but not the information that the r1 has a broken FIFO.

>> You're not using the mailbox mode anymore, right? 
> 
> No, we are using timestamp based RX fifo.
> 
>> This means the driver should work with the broken r1 silicon, too?
> 
> I would think so. But as r1 is not officially supported version, I
> have not checked it.

Ok - I don't mind if nxp doesn't support it or not...

>> Are any of these silicons out in
>> the wild? Does it make sense to use "fsl,ls1021ar1-flexcan" for this
>> compatible?
> 
> No. r1 silicon has not been delivered to any customer. We need not to support
> r1 silicon in compatible, as its not official supported version.

...but if it's not out in the wild we don't have to add it. And wait
until someone complains :)

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]