Re: [PATCH v2 2/2] can: flexcan: adding platform specific details for LS1021A - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "ZHU Yi (ST-FIR/ENG1-Zhu)" <Yi.Zhu5@cn.bosch.com>,
	Pankaj Bansal <pankaj.bansal@nxp.com>,
	Wolfgang Grandegger <wg@grandegger.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Cc: Varun Sethi <V.Sethi@nxp.com>,
	Poonam Aggrwal <poonam.aggrwal@nxp.com>,
	Bhupesh Sharma <bhupesh.sharma@freescale.com>
Subject: Re: [PATCH v2 2/2] can: flexcan: adding platform specific details for LS1021A
Date: Tue, 21 Nov 2017 13:43:53 +0100	[thread overview]
Message-ID: <be8f51ff-8775-fe03-d299-2dc1f963ebcc@pengutronix.de> (raw)
In-Reply-To: <cf35f42c513946918031b4c1cf6d8778@SGPMBX1017.APAC.bosch.com>

[-- Attachment #1.1: Type: text/plain, Size: 1784 bytes --]

On 11/21/2017 03:13 AM, ZHU Yi (ST-FIR/ENG1-Zhu) wrote:
> Hello Pankaj,
> 
>> From: Pankaj Bansal [mailto:pankaj.bansal@nxp.com]
>> Sent: Monday, November 20, 2017 7:11 PM
>> [...]
>> Thank you Zhu Yi for this explanation. This helped me in understanding the quirks.
>> Is there any flexcan core which generates passive state interrupt ?

> I'm afraid so far no known flexcan core supports it.

Should we update the table and add a "IRQ Err Passive" no for all cores?

>  * Below is some version info we got:
>  *    SOC   Version   IP-Version  Glitch- [TR]WRN_INT IRQ Err Memory err RTR re-
>  *                                Filter? connected?  Passive detection  ception in MB
>  *   MX25  FlexCAN2  03.00.00.00     no        no         ?       no        no
>  *   MX28  FlexCAN2  03.00.04.00    yes       yes        no       no        no
>  *   MX35  FlexCAN2  03.00.00.00     no        no         ?       no        no
>  *   MX53  FlexCAN2  03.00.00.00    yes        no        no       no        no
>  *   MX6s  FlexCAN3  10.00.12.00    yes       yes        no       no       yes
>  *   VF610 FlexCAN3  ?               no       yes         ?      yes       yes?

And does it make sense to add "FLEXCAN_QUIRK_BROKEN_PERR_STATE" to the
vf610, too?

> static const struct flexcan_devtype_data fsl_vf610_devtype_data = {
> 	.quirks = FLEXCAN_QUIRK_DISABLE_RXFG | FLEXCAN_QUIRK_ENABLE_EACEN_RRS |
> 		FLEXCAN_QUIRK_DISABLE_MECR | FLEXCAN_QUIRK_USE_OFF_TIMESTAMP,
> };

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]