From: Samuel Holland <samuel@sholland.org> To: Conor.Dooley@microchip.com, wens@csie.org, jernej.skrabec@gmail.com, linux-sunxi@lists.linux.dev, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, robh+dt@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/12] riscv: Allwinner D1 platform support Date: Mon, 15 Aug 2022 21:42:07 -0500 [thread overview] Message-ID: <6d54da3f-d4fc-7c40-38d6-4f02c7346458@sholland.org> (raw) In-Reply-To: <6b8cd27d-5671-7bcb-549d-e903cf019fe3@microchip.com> On 8/15/22 12:12 PM, Conor.Dooley@microchip.com wrote: > On 15/08/2022 08:05, Conor Dooley wrote: >> Hey Samuel, >> Apologies for the last email, the first 5 patches in this series >> didn't correctly land in my inbox and I skimmed & replied to the >> wrong cover letter... I blame it being pre 8 AM ;) >> >> On 15/08/2022 06:08, Samuel Holland wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> This series adds the Kconfig/defconfig plumbing and devicetrees for a >>> range of Allwinner D1-based boards. Many features are already enabled, >>> including USB, Ethernet, and WiFi. >>> >>> The SoC devicetree uses bindings from the following series which have >>> not yet been merged: >>> - SRAM controller: >>> https://lore.kernel.org/lkml/20220815041248.53268-1-samuel@sholland.org/ >>> - NVMEM cell bits property change: >>> https://lore.kernel.org/lkml/20220814173656.11856-1-samuel@sholland.org/ >>> - In-package LDO regulators: >>> https://lore.kernel.org/lkml/20220815043436.20170-1-samuel@sholland.org/ >>> >>> All three of these are required to set the correct I/O domain voltages >>> in the pin controller, which I would consider important to have in the >>> initial version of the devicetree. >>> >>> The SoC devicetree does contain one small hack to avoid a dependency on >>> the audio codec binding, since that is not ready yet: the codec node >>> uses a bare "simple-mfd", "syscon" compatible. >> >> >> I tried this series on top of both 6.0-rc1 & next, but I saw a shed >> load of errors from dtbs_check. I'll take a look at the rest of the >> series later on, but just FYI. This time I did at least read the >> right cover letter and actually applied your dependent series.. >> /facepalm >> >> I have been trying to get riscv down to 0 warnings and would not be >> in favour of accepting patches that go in the other direction. >> (This patchset currently produces about 47 new warnings) Only 4 unique ones :) Thanks for checking this. I had done a couple of passes cleaning things up. The remaining warnings are the ones I was unsure how to fix. > FWIW this is what I see, LMK if I am missing something. > allwinner/sun20i-d1-lichee-rv.dtb: i2c@2502000: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) This one is new with dt-schema 2022.08.1 (I was previously on d1f3102e locally). I'm not sure if it is a bug in the binding or in the dt-schema tool. The warnings go away if I do: --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml @@ -72,6 +72,7 @@ required: - interrupts allOf: + - $ref: /schemas/dma/dma.yaml# - $ref: /schemas/i2c/i2c-controller.yaml# - if: properties: But I wouldn't expect this to be necessary, since dma.yaml has "select: true". Compare the this with the UARTs. Neither serial/snps-dw-apb-uart.yaml nor serial/serial.yaml references any DMA properties, yet there is no warning for those. > allwinner/sun20i-d1-clockworkpi-v3.14.dtb: pmic@34: compatible: 'oneOf' conditional failed, one must be fixed: > allwinner/sun20i-d1-devterm-v3.14.dtb: pmic@34: compatible: 'oneOf' conditional failed, one must be fixed: The new compatible is in linux-next. I can add it to the cover letter for v2: https://lore.kernel.org/linux-devicetree/20220810013430.27061-1-samuel@sholland.org/ https://git.kernel.org/lee/mfd/c/97ecda0f615e > allwinner/sun20i-d1-lichee-rv.dtb: ethernet@4500000: Unevaluated properties are not allowed ('mdio', 'reset-names', 'resets' were unexpected) This showed up with a dt-schema update in the last year or so. This may be a bug in the binding? allwinner,sun8i-a83t-emac.yaml picks up these three properties from snps,dwmac.yaml, but does not have them in its own "properties" block. (resets and reset-names are even in "required"!) > allwinner/sun20i-d1-lichee-rv-86-panel-720p.dtb: ethernet@4500000: Unevaluated properties are not allowed ('phy-supply' was unexpected) > allwinner/sun20i-d1-dongshan-nezha-stu.dtb: ethernet@4500000: Unevaluated properties are not allowed ('phy-supply' was unexpected) I think this one is just flat out missing from the binding. It is present in the other two Allwinner Ethernet MAC bindings, but not this one. Regards, Samuel
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Holland <samuel@sholland.org> To: Conor.Dooley@microchip.com, wens@csie.org, jernej.skrabec@gmail.com, linux-sunxi@lists.linux.dev, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, robh+dt@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/12] riscv: Allwinner D1 platform support Date: Mon, 15 Aug 2022 21:42:07 -0500 [thread overview] Message-ID: <6d54da3f-d4fc-7c40-38d6-4f02c7346458@sholland.org> (raw) In-Reply-To: <6b8cd27d-5671-7bcb-549d-e903cf019fe3@microchip.com> On 8/15/22 12:12 PM, Conor.Dooley@microchip.com wrote: > On 15/08/2022 08:05, Conor Dooley wrote: >> Hey Samuel, >> Apologies for the last email, the first 5 patches in this series >> didn't correctly land in my inbox and I skimmed & replied to the >> wrong cover letter... I blame it being pre 8 AM ;) >> >> On 15/08/2022 06:08, Samuel Holland wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> This series adds the Kconfig/defconfig plumbing and devicetrees for a >>> range of Allwinner D1-based boards. Many features are already enabled, >>> including USB, Ethernet, and WiFi. >>> >>> The SoC devicetree uses bindings from the following series which have >>> not yet been merged: >>> - SRAM controller: >>> https://lore.kernel.org/lkml/20220815041248.53268-1-samuel@sholland.org/ >>> - NVMEM cell bits property change: >>> https://lore.kernel.org/lkml/20220814173656.11856-1-samuel@sholland.org/ >>> - In-package LDO regulators: >>> https://lore.kernel.org/lkml/20220815043436.20170-1-samuel@sholland.org/ >>> >>> All three of these are required to set the correct I/O domain voltages >>> in the pin controller, which I would consider important to have in the >>> initial version of the devicetree. >>> >>> The SoC devicetree does contain one small hack to avoid a dependency on >>> the audio codec binding, since that is not ready yet: the codec node >>> uses a bare "simple-mfd", "syscon" compatible. >> >> >> I tried this series on top of both 6.0-rc1 & next, but I saw a shed >> load of errors from dtbs_check. I'll take a look at the rest of the >> series later on, but just FYI. This time I did at least read the >> right cover letter and actually applied your dependent series.. >> /facepalm >> >> I have been trying to get riscv down to 0 warnings and would not be >> in favour of accepting patches that go in the other direction. >> (This patchset currently produces about 47 new warnings) Only 4 unique ones :) Thanks for checking this. I had done a couple of passes cleaning things up. The remaining warnings are the ones I was unsure how to fix. > FWIW this is what I see, LMK if I am missing something. > allwinner/sun20i-d1-lichee-rv.dtb: i2c@2502000: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) This one is new with dt-schema 2022.08.1 (I was previously on d1f3102e locally). I'm not sure if it is a bug in the binding or in the dt-schema tool. The warnings go away if I do: --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml @@ -72,6 +72,7 @@ required: - interrupts allOf: + - $ref: /schemas/dma/dma.yaml# - $ref: /schemas/i2c/i2c-controller.yaml# - if: properties: But I wouldn't expect this to be necessary, since dma.yaml has "select: true". Compare the this with the UARTs. Neither serial/snps-dw-apb-uart.yaml nor serial/serial.yaml references any DMA properties, yet there is no warning for those. > allwinner/sun20i-d1-clockworkpi-v3.14.dtb: pmic@34: compatible: 'oneOf' conditional failed, one must be fixed: > allwinner/sun20i-d1-devterm-v3.14.dtb: pmic@34: compatible: 'oneOf' conditional failed, one must be fixed: The new compatible is in linux-next. I can add it to the cover letter for v2: https://lore.kernel.org/linux-devicetree/20220810013430.27061-1-samuel@sholland.org/ https://git.kernel.org/lee/mfd/c/97ecda0f615e > allwinner/sun20i-d1-lichee-rv.dtb: ethernet@4500000: Unevaluated properties are not allowed ('mdio', 'reset-names', 'resets' were unexpected) This showed up with a dt-schema update in the last year or so. This may be a bug in the binding? allwinner,sun8i-a83t-emac.yaml picks up these three properties from snps,dwmac.yaml, but does not have them in its own "properties" block. (resets and reset-names are even in "required"!) > allwinner/sun20i-d1-lichee-rv-86-panel-720p.dtb: ethernet@4500000: Unevaluated properties are not allowed ('phy-supply' was unexpected) > allwinner/sun20i-d1-dongshan-nezha-stu.dtb: ethernet@4500000: Unevaluated properties are not allowed ('phy-supply' was unexpected) I think this one is just flat out missing from the binding. It is present in the other two Allwinner Ethernet MAC bindings, but not this one. Regards, Samuel _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-08-16 2:42 UTC|newest] Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-15 5:08 [PATCH 00/12] riscv: Allwinner D1 platform support Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 5:08 ` [PATCH 01/12] MAINTAINERS: Match the sun20i family of Allwinner SoCs Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 17:06 ` Heiko Stübner 2022-08-15 17:06 ` Heiko Stübner 2022-08-15 5:08 ` [PATCH 02/12] dt-bindings: riscv: Add T-HEAD C906 and C910 compatibles Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 17:07 ` Heiko Stübner 2022-08-15 17:07 ` Heiko Stübner 2022-08-16 17:34 ` Rob Herring 2022-08-16 17:34 ` Rob Herring 2022-11-04 2:57 ` Icenowy Zheng 2022-11-04 2:57 ` Icenowy Zheng 2022-11-20 11:23 ` Conor Dooley 2022-11-20 11:23 ` Conor Dooley 2022-11-20 11:25 ` Conor Dooley 2022-11-20 11:25 ` Conor Dooley 2022-08-15 5:08 ` [PATCH 03/12] dt-bindings: vendor-prefixes: Add Allwinner D1 board vendors Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 17:12 ` Heiko Stübner 2022-08-15 17:12 ` Heiko Stübner 2022-08-16 17:34 ` Rob Herring 2022-08-16 17:34 ` Rob Herring 2022-08-15 5:08 ` [PATCH 04/12] dt-bindings: riscv: Add Allwinner D1 board compatibles Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-16 7:39 ` Krzysztof Kozlowski 2022-08-16 7:39 ` Krzysztof Kozlowski 2022-08-16 9:02 ` Heiko Stübner 2022-08-16 9:02 ` Heiko Stübner 2022-08-16 9:12 ` Heiko Stübner 2022-08-16 9:12 ` Heiko Stübner 2022-08-16 17:35 ` Rob Herring 2022-08-16 17:35 ` Rob Herring 2022-08-15 5:08 ` [PATCH 05/12] riscv: Add the Allwinner SoC family Kconfig option Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 16:56 ` Conor.Dooley 2022-08-15 16:56 ` Conor.Dooley 2022-08-16 9:17 ` Heiko Stübner 2022-08-16 9:17 ` Heiko Stübner 2022-08-16 9:23 ` Conor.Dooley 2022-08-16 9:23 ` Conor.Dooley 2022-08-15 17:13 ` Heiko Stübner 2022-08-15 17:13 ` Heiko Stübner 2022-08-15 5:08 ` [PATCH 06/12] riscv: dts: allwinner: Add the D1 SoC base devicetree Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 13:11 ` Andre Przywara 2022-08-15 13:11 ` Andre Przywara 2022-08-15 17:01 ` Conor.Dooley 2022-08-15 17:01 ` Conor.Dooley 2022-08-20 17:24 ` Samuel Holland 2022-08-20 17:24 ` Samuel Holland 2022-08-20 17:29 ` Conor.Dooley 2022-08-20 17:29 ` Conor.Dooley 2022-08-21 6:45 ` Icenowy Zheng 2022-08-21 6:45 ` Icenowy Zheng 2022-08-21 10:04 ` Conor.Dooley 2022-08-21 10:04 ` Conor.Dooley 2022-08-22 11:46 ` Geert Uytterhoeven 2022-08-22 11:46 ` Geert Uytterhoeven 2022-08-22 12:13 ` Conor.Dooley 2022-08-22 12:13 ` Conor.Dooley 2022-08-22 12:29 ` Andre Przywara 2022-08-22 12:29 ` Andre Przywara 2022-08-22 12:31 ` Geert Uytterhoeven 2022-08-22 12:31 ` Geert Uytterhoeven 2022-08-22 13:56 ` Conor.Dooley 2022-08-22 13:56 ` Conor.Dooley 2022-08-22 15:29 ` Jessica Clarke 2022-08-22 15:29 ` Jessica Clarke 2022-09-09 3:42 ` Samuel Holland 2022-09-09 3:42 ` Samuel Holland 2022-09-09 7:10 ` Geert Uytterhoeven 2022-09-09 7:10 ` Geert Uytterhoeven 2022-09-21 7:49 ` Geert Uytterhoeven 2022-09-21 7:49 ` Geert Uytterhoeven 2022-08-22 10:50 ` Andre Przywara 2022-08-22 10:50 ` Andre Przywara 2022-08-16 7:41 ` Krzysztof Kozlowski 2022-08-16 7:41 ` Krzysztof Kozlowski 2022-08-16 7:49 ` Jernej Škrabec 2022-08-16 7:49 ` Jernej Škrabec 2022-08-16 9:12 ` Heiko Stübner 2022-08-16 9:12 ` Heiko Stübner 2022-08-16 9:25 ` Jernej Škrabec 2022-08-16 9:25 ` Jernej Škrabec 2022-08-16 9:42 ` Krzysztof Kozlowski 2022-08-16 9:42 ` Krzysztof Kozlowski 2022-08-16 11:00 ` Andre Przywara 2022-08-16 11:00 ` Andre Przywara 2022-08-16 11:11 ` Krzysztof Kozlowski 2022-08-16 11:11 ` Krzysztof Kozlowski 2022-08-16 11:12 ` Krzysztof Kozlowski 2022-08-16 11:12 ` Krzysztof Kozlowski 2022-08-16 11:34 ` Conor.Dooley 2022-08-16 11:34 ` Conor.Dooley 2022-08-22 11:40 ` Geert Uytterhoeven 2022-08-22 11:40 ` Geert Uytterhoeven 2022-08-16 9:11 ` Heiko Stübner 2022-08-16 9:11 ` Heiko Stübner 2022-08-17 8:29 ` Krzysztof Kozlowski 2022-08-17 8:29 ` Krzysztof Kozlowski 2022-08-19 22:19 ` Conor.Dooley 2022-08-19 22:19 ` Conor.Dooley 2022-08-15 5:08 ` [PATCH 07/12] riscv: dts: allwinner: Add Allwinner D1 Nezha devicetree Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 17:37 ` Conor.Dooley 2022-08-15 17:37 ` Conor.Dooley 2022-08-15 18:34 ` Conor.Dooley 2022-08-15 18:34 ` Conor.Dooley 2022-08-16 8:55 ` Heiko Stübner 2022-08-16 8:55 ` Heiko Stübner 2022-08-19 22:10 ` Conor.Dooley 2022-08-19 22:10 ` Conor.Dooley 2022-08-21 7:06 ` Icenowy Zheng 2022-08-21 7:06 ` Icenowy Zheng 2022-09-04 20:10 ` Peter Korsgaard 2022-09-04 20:10 ` Peter Korsgaard 2022-09-09 4:37 ` Samuel Holland 2022-09-09 4:37 ` Samuel Holland 2022-09-09 7:18 ` Conor.Dooley 2022-09-09 7:18 ` Conor.Dooley 2022-09-09 8:11 ` Heiko Stübner 2022-09-09 8:11 ` Heiko Stübner 2022-09-09 19:04 ` Jessica Clarke 2022-09-09 19:04 ` Jessica Clarke 2022-09-03 15:21 ` Peter Korsgaard 2022-09-03 15:21 ` Peter Korsgaard 2022-08-15 5:08 ` [PATCH 08/12] riscv: dts: allwinner: Add Sipeed Lichee RV devicetrees Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 5:08 ` [PATCH 09/12] riscv: dts: allwinner: Add MangoPi MQ Pro devicetree Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 5:08 ` [PATCH 10/12] riscv: dts: allwinner: Add Dongshan Nezha STU devicetree Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 5:08 ` [PATCH 11/12] riscv: dts: allwinner: Add ClockworkPi and DevTerm devicetrees Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 5:08 ` [PATCH 12/12] riscv: defconfig: Enable the Allwinner D1 platform and drivers Samuel Holland 2022-08-15 5:08 ` Samuel Holland 2022-08-15 7:05 ` [PATCH 00/12] riscv: Allwinner D1 platform support Conor.Dooley 2022-08-15 7:05 ` Conor.Dooley 2022-08-15 17:12 ` Conor.Dooley 2022-08-15 17:12 ` Conor.Dooley 2022-08-16 2:42 ` Samuel Holland [this message] 2022-08-16 2:42 ` Samuel Holland 2022-08-16 6:38 ` Conor.Dooley 2022-08-16 6:38 ` Conor.Dooley 2022-09-01 18:10 ` Palmer Dabbelt 2022-09-01 18:10 ` Palmer Dabbelt 2022-09-02 5:42 ` Conor.Dooley 2022-09-02 5:42 ` Conor.Dooley 2022-09-06 20:29 ` Jernej Škrabec 2022-09-06 20:29 ` Jernej Škrabec 2022-09-07 20:43 ` Conor.Dooley 2022-09-07 20:43 ` Conor.Dooley 2022-09-08 7:00 ` Geert Uytterhoeven 2022-09-08 7:00 ` Geert Uytterhoeven 2022-09-08 9:04 ` Arnd Bergmann 2022-09-08 9:04 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6d54da3f-d4fc-7c40-38d6-4f02c7346458@sholland.org \ --to=samuel@sholland.org \ --cc=Conor.Dooley@microchip.com \ --cc=aou@eecs.berkeley.edu \ --cc=devicetree@vger.kernel.org \ --cc=jernej.skrabec@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.