From: Stefan Agner <stefan@agner.ch> To: Dong Aisheng <aisheng.dong@nxp.com> Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, jslaby@suse.com, fugang.duan@nxp.com, Mingkai.Hu@nxp.com, yangbo.lu@nxp.com Subject: Re: [PATCH 1/6] tty: serial: lpuart: introduce lpuart_soc_data to represent SoC property Date: Tue, 09 May 2017 20:50:44 -0700 [thread overview] Message-ID: <83e341e654f5e8e788ee684bf3de51e6@agner.ch> (raw) In-Reply-To: <1494316248-24052-2-git-send-email-aisheng.dong@nxp.com> On 2017-05-09 00:50, Dong Aisheng wrote: > This is used to dynamically check the SoC specific lpuart properies. > Currently only the checking of 32 bit register width is added which > functions the same as before. More will be added later for supporting > new chips. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: Fugang Duan <fugang.duan@nxp.com> > Cc: Stefan Agner <stefan@agner.ch> > Cc: Mingkai Hu <Mingkai.Hu@nxp.com> > Cc: Yangbo Lu <yangbo.lu@nxp.com> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > drivers/tty/serial/fsl_lpuart.c | 25 ++++++++++++++++++------- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > index 15df1ba7..cd4e905 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -258,13 +258,21 @@ struct lpuart_port { > wait_queue_head_t dma_wait; > }; > > +struct lpuart_soc_data { > + bool is_32; > +}; > + > +static struct lpuart_soc_data vf_data = { > + .is_32 = false, > +}; > + > +static struct lpuart_soc_data ls_data = { > + .is_32 = true, > +}; This could be const I guess? -- Stefan > + > static const struct of_device_id lpuart_dt_ids[] = { > - { > - .compatible = "fsl,vf610-lpuart", > - }, > - { > - .compatible = "fsl,ls1021a-lpuart", > - }, > + { .compatible = "fsl,vf610-lpuart", .data = &vf_data, }, > + { .compatible = "fsl,ls1021a-lpuart", .data = &ls_data, }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, lpuart_dt_ids); > @@ -1971,6 +1979,9 @@ static struct uart_driver lpuart_reg = { > > static int lpuart_probe(struct platform_device *pdev) > { > + const struct of_device_id *of_id = of_match_device(lpuart_dt_ids, > + &pdev->dev); > + const struct lpuart_soc_data *sdata = of_id->data; > struct device_node *np = pdev->dev.of_node; > struct lpuart_port *sport; > struct resource *res; > @@ -1988,7 +1999,7 @@ static int lpuart_probe(struct platform_device *pdev) > return ret; > } > sport->port.line = ret; > - sport->lpuart32 = of_device_is_compatible(np, "fsl,ls1021a-lpuart"); > + sport->lpuart32 = sdata->is_32; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > sport->port.membase = devm_ioremap_resource(&pdev->dev, res);
WARNING: multiple messages have this Message-ID (diff)
From: stefan@agner.ch (Stefan Agner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/6] tty: serial: lpuart: introduce lpuart_soc_data to represent SoC property Date: Tue, 09 May 2017 20:50:44 -0700 [thread overview] Message-ID: <83e341e654f5e8e788ee684bf3de51e6@agner.ch> (raw) In-Reply-To: <1494316248-24052-2-git-send-email-aisheng.dong@nxp.com> On 2017-05-09 00:50, Dong Aisheng wrote: > This is used to dynamically check the SoC specific lpuart properies. > Currently only the checking of 32 bit register width is added which > functions the same as before. More will be added later for supporting > new chips. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: Fugang Duan <fugang.duan@nxp.com> > Cc: Stefan Agner <stefan@agner.ch> > Cc: Mingkai Hu <Mingkai.Hu@nxp.com> > Cc: Yangbo Lu <yangbo.lu@nxp.com> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > drivers/tty/serial/fsl_lpuart.c | 25 ++++++++++++++++++------- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > index 15df1ba7..cd4e905 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -258,13 +258,21 @@ struct lpuart_port { > wait_queue_head_t dma_wait; > }; > > +struct lpuart_soc_data { > + bool is_32; > +}; > + > +static struct lpuart_soc_data vf_data = { > + .is_32 = false, > +}; > + > +static struct lpuart_soc_data ls_data = { > + .is_32 = true, > +}; This could be const I guess? -- Stefan > + > static const struct of_device_id lpuart_dt_ids[] = { > - { > - .compatible = "fsl,vf610-lpuart", > - }, > - { > - .compatible = "fsl,ls1021a-lpuart", > - }, > + { .compatible = "fsl,vf610-lpuart", .data = &vf_data, }, > + { .compatible = "fsl,ls1021a-lpuart", .data = &ls_data, }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, lpuart_dt_ids); > @@ -1971,6 +1979,9 @@ static struct uart_driver lpuart_reg = { > > static int lpuart_probe(struct platform_device *pdev) > { > + const struct of_device_id *of_id = of_match_device(lpuart_dt_ids, > + &pdev->dev); > + const struct lpuart_soc_data *sdata = of_id->data; > struct device_node *np = pdev->dev.of_node; > struct lpuart_port *sport; > struct resource *res; > @@ -1988,7 +1999,7 @@ static int lpuart_probe(struct platform_device *pdev) > return ret; > } > sport->port.line = ret; > - sport->lpuart32 = of_device_is_compatible(np, "fsl,ls1021a-lpuart"); > + sport->lpuart32 = sdata->is_32; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > sport->port.membase = devm_ioremap_resource(&pdev->dev, res);
next prev parent reply other threads:[~2017-05-10 3:51 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-09 7:50 [PATCH 0/6] tty: serial: lpuart: add imx7ulp support Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-09 7:50 ` [PATCH 1/6] tty: serial: lpuart: introduce lpuart_soc_data to represent SoC property Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-10 3:50 ` Stefan Agner [this message] 2017-05-10 3:50 ` Stefan Agner 2017-05-10 6:06 ` Dong Aisheng 2017-05-10 6:06 ` Dong Aisheng 2017-05-10 6:06 ` Dong Aisheng 2017-05-09 7:50 ` [PATCH 2/6] tty: serial: lpuart: add little endian 32 bit register support Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-10 3:58 ` Stefan Agner 2017-05-10 3:58 ` Stefan Agner 2017-05-10 6:19 ` Dong Aisheng 2017-05-10 6:19 ` Dong Aisheng 2017-05-10 6:19 ` Dong Aisheng 2017-05-09 7:50 ` [PATCH 3/6] dt-bindings: serial: fsl-lpuart: add i.MX7ULP support Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-12 20:12 ` Rob Herring 2017-05-12 20:12 ` Rob Herring 2017-05-12 20:12 ` Rob Herring 2017-05-09 7:50 ` [PATCH 4/6] tty: serial: lpuart: add imx7ulp support Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-10 4:10 ` Stefan Agner 2017-05-10 4:10 ` Stefan Agner 2017-05-10 6:14 ` Dong Aisheng 2017-05-10 6:14 ` Dong Aisheng 2017-05-10 6:14 ` Dong Aisheng 2017-05-10 20:37 ` Stefan Agner 2017-05-10 20:37 ` Stefan Agner 2017-05-12 13:28 ` Dong Aisheng 2017-05-12 13:28 ` Dong Aisheng 2017-05-09 7:50 ` [PATCH 5/6] tty: serial: lpuart: add earlycon support for imx7ulp Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-09 7:50 ` [PATCH 6/6] tty: serial: lpuart: add a more accurate baud rate calculation method Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-09 7:50 ` Dong Aisheng 2017-05-28 0:04 ` Andy Shevchenko 2017-05-28 0:04 ` Andy Shevchenko 2017-05-31 14:18 ` A.S. Dong 2017-05-31 14:18 ` A.S. Dong 2017-06-02 17:11 ` Andy Shevchenko 2017-06-02 17:11 ` Andy Shevchenko 2017-06-09 8:01 ` A.S. Dong 2017-06-09 8:01 ` A.S. Dong 2017-06-09 9:26 ` Andy Shevchenko 2017-06-09 9:26 ` Andy Shevchenko 2017-06-09 14:20 ` A.S. Dong 2017-06-09 14:20 ` A.S. Dong 2017-06-09 15:48 ` Andy Shevchenko 2017-06-09 15:48 ` Andy Shevchenko 2017-06-12 14:23 ` A.S. Dong 2017-06-12 14:23 ` A.S. Dong 2017-05-09 11:13 ` [PATCH 0/6] tty: serial: lpuart: add imx7ulp support Andy Duan 2017-05-09 11:13 ` Andy Duan 2017-05-09 11:13 ` Andy Duan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=83e341e654f5e8e788ee684bf3de51e6@agner.ch \ --to=stefan@agner.ch \ --cc=Mingkai.Hu@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=fugang.duan@nxp.com \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=yangbo.lu@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.