All of lore.kernel.org
 help / color / mirror / Atom feed
From: "A.S. Dong" <aisheng.dong@nxp.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>, Andy Duan <fugang.duan@nxp.com>,
	Stefan Agner <stefan@agner.ch>, Mingkai Hu <mingkai.hu@nxp.com>,
	"Y.B. Lu" <yangbo.lu@nxp.com>, Dong Aisheng <dongas86@gmail.com>
Subject: RE: [PATCH 6/6] tty: serial: lpuart: add a more accurate baud rate calculation method
Date: Mon, 12 Jun 2017 14:23:10 +0000	[thread overview]
Message-ID: <AM3PR04MB30630CDA4E0FD2B5079072E80CD0@AM3PR04MB306.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VdgLoavZrf+T1-cyPj2A30mGeyDEgye3qZoWXJE6inE_Q@mail.gmail.com>

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Friday, June 09, 2017 11:49 PM
> To: A.S. Dong
> Cc: linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm
> Mailing List; Greg Kroah-Hartman; Jiri Slaby; Andy Duan; Stefan Agner;
> Mingkai Hu; Y.B. Lu; Dong Aisheng
> Subject: Re: [PATCH 6/6] tty: serial: lpuart: add a more accurate baud
> rate calculation method
> 
> On Fri, Jun 9, 2017 at 5:20 PM, A.S. Dong <aisheng.dong@nxp.com> wrote:
> >> > How about you send a separate baud algorithm improvement patch later?
> >>
> >> Why not to do it right a way?
> >>
> >
> > Because I thought that could be a separate patch which is doing
> > algorithm improvement, then we can have the full history and a clear
> comparison.
> >
> > And also we are still not sure whether it works, we don't want to
> > block on it too long.
> >
> > But if you're pretty sure about it, I would wait for some more time.
> >
> > However, personally I would still rather keep them in two separate
> > Patches for clearer history and comparison.
> 
> Since we already near to -rc5, I would rather agree with you.
> So, please proceed with your approach and we can modify it in relaxing
> mode later on.
> 
> Thanks, and sorry for the delay!

Never mind.
A professional review is always respectable and appreciated.

Thanks

Regards
Dong Aisheng

WARNING: multiple messages have this Message-ID (diff)
From: aisheng.dong@nxp.com (A.S. Dong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] tty: serial: lpuart: add a more accurate baud rate calculation method
Date: Mon, 12 Jun 2017 14:23:10 +0000	[thread overview]
Message-ID: <AM3PR04MB30630CDA4E0FD2B5079072E80CD0@AM3PR04MB306.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VdgLoavZrf+T1-cyPj2A30mGeyDEgye3qZoWXJE6inE_Q@mail.gmail.com>

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko at gmail.com]
> Sent: Friday, June 09, 2017 11:49 PM
> To: A.S. Dong
> Cc: linux-serial at vger.kernel.org; linux-kernel at vger.kernel.org; linux-arm
> Mailing List; Greg Kroah-Hartman; Jiri Slaby; Andy Duan; Stefan Agner;
> Mingkai Hu; Y.B. Lu; Dong Aisheng
> Subject: Re: [PATCH 6/6] tty: serial: lpuart: add a more accurate baud
> rate calculation method
> 
> On Fri, Jun 9, 2017 at 5:20 PM, A.S. Dong <aisheng.dong@nxp.com> wrote:
> >> > How about you send a separate baud algorithm improvement patch later?
> >>
> >> Why not to do it right a way?
> >>
> >
> > Because I thought that could be a separate patch which is doing
> > algorithm improvement, then we can have the full history and a clear
> comparison.
> >
> > And also we are still not sure whether it works, we don't want to
> > block on it too long.
> >
> > But if you're pretty sure about it, I would wait for some more time.
> >
> > However, personally I would still rather keep them in two separate
> > Patches for clearer history and comparison.
> 
> Since we already near to -rc5, I would rather agree with you.
> So, please proceed with your approach and we can modify it in relaxing
> mode later on.
> 
> Thanks, and sorry for the delay!

Never mind.
A professional review is always respectable and appreciated.

Thanks

Regards
Dong Aisheng

  reply	other threads:[~2017-06-12 14:23 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09  7:50 [PATCH 0/6] tty: serial: lpuart: add imx7ulp support Dong Aisheng
2017-05-09  7:50 ` Dong Aisheng
2017-05-09  7:50 ` Dong Aisheng
2017-05-09  7:50 ` [PATCH 1/6] tty: serial: lpuart: introduce lpuart_soc_data to represent SoC property Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-10  3:50   ` Stefan Agner
2017-05-10  3:50     ` Stefan Agner
2017-05-10  6:06     ` Dong Aisheng
2017-05-10  6:06       ` Dong Aisheng
2017-05-10  6:06       ` Dong Aisheng
2017-05-09  7:50 ` [PATCH 2/6] tty: serial: lpuart: add little endian 32 bit register support Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-10  3:58   ` Stefan Agner
2017-05-10  3:58     ` Stefan Agner
2017-05-10  6:19     ` Dong Aisheng
2017-05-10  6:19       ` Dong Aisheng
2017-05-10  6:19       ` Dong Aisheng
2017-05-09  7:50 ` [PATCH 3/6] dt-bindings: serial: fsl-lpuart: add i.MX7ULP support Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-12 20:12   ` Rob Herring
2017-05-12 20:12     ` Rob Herring
2017-05-12 20:12     ` Rob Herring
2017-05-09  7:50 ` [PATCH 4/6] tty: serial: lpuart: add imx7ulp support Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-10  4:10   ` Stefan Agner
2017-05-10  4:10     ` Stefan Agner
2017-05-10  6:14     ` Dong Aisheng
2017-05-10  6:14       ` Dong Aisheng
2017-05-10  6:14       ` Dong Aisheng
2017-05-10 20:37       ` Stefan Agner
2017-05-10 20:37         ` Stefan Agner
2017-05-12 13:28         ` Dong Aisheng
2017-05-12 13:28           ` Dong Aisheng
2017-05-09  7:50 ` [PATCH 5/6] tty: serial: lpuart: add earlycon support for imx7ulp Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-09  7:50 ` [PATCH 6/6] tty: serial: lpuart: add a more accurate baud rate calculation method Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-09  7:50   ` Dong Aisheng
2017-05-28  0:04   ` Andy Shevchenko
2017-05-28  0:04     ` Andy Shevchenko
2017-05-31 14:18     ` A.S. Dong
2017-05-31 14:18       ` A.S. Dong
2017-06-02 17:11       ` Andy Shevchenko
2017-06-02 17:11         ` Andy Shevchenko
2017-06-09  8:01         ` A.S. Dong
2017-06-09  8:01           ` A.S. Dong
2017-06-09  9:26           ` Andy Shevchenko
2017-06-09  9:26             ` Andy Shevchenko
2017-06-09 14:20             ` A.S. Dong
2017-06-09 14:20               ` A.S. Dong
2017-06-09 15:48               ` Andy Shevchenko
2017-06-09 15:48                 ` Andy Shevchenko
2017-06-12 14:23                 ` A.S. Dong [this message]
2017-06-12 14:23                   ` A.S. Dong
2017-05-09 11:13 ` [PATCH 0/6] tty: serial: lpuart: add imx7ulp support Andy Duan
2017-05-09 11:13   ` Andy Duan
2017-05-09 11:13   ` Andy Duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM3PR04MB30630CDA4E0FD2B5079072E80CD0@AM3PR04MB306.eurprd04.prod.outlook.com \
    --to=aisheng.dong@nxp.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dongas86@gmail.com \
    --cc=fugang.duan@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mingkai.hu@nxp.com \
    --cc=stefan@agner.ch \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.