From: Kevin Hilman <khilman@ti.com>
To: NeilBrown <neilb@suse.de>
Cc: Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ.
Date: Thu, 26 Apr 2012 13:39:32 -0700 [thread overview]
Message-ID: <874ns69qij.fsf@ti.com> (raw)
In-Reply-To: <20120425030524.7832.66013.stgit@notabene.brown> (NeilBrown's message of "Wed, 25 Apr 2012 13:05:24 +1000")
NeilBrown <neilb@suse.de> writes:
> Most of the interrupts that come through this line should trigger
> wakeups:
> power button
> RTC alarm
> power available
> usb plug/unplug
>
> so mark the interrupt as a wakeup interrupt.
> This is particularly important for when the interrupt arrives during
> the late suspend phase. Without this setting it will be ignored.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Kevin Hilman <khilman@ti.com>
> ---
>
> drivers/mfd/twl4030-irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> index 5d656e8..ad733d7 100644
> --- a/drivers/mfd/twl4030-irq.c
> +++ b/drivers/mfd/twl4030-irq.c
> @@ -757,6 +757,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
> dev_err(dev, "could not claim irq%d: %d\n", irq_num, status);
> goto fail_rqirq;
> }
> + enable_irq_wake(irq_num);
>
> return irq_base;
> fail_rqirq:
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ.
Date: Thu, 26 Apr 2012 13:39:32 -0700 [thread overview]
Message-ID: <874ns69qij.fsf@ti.com> (raw)
In-Reply-To: <20120425030524.7832.66013.stgit@notabene.brown> (NeilBrown's message of "Wed, 25 Apr 2012 13:05:24 +1000")
NeilBrown <neilb@suse.de> writes:
> Most of the interrupts that come through this line should trigger
> wakeups:
> power button
> RTC alarm
> power available
> usb plug/unplug
>
> so mark the interrupt as a wakeup interrupt.
> This is particularly important for when the interrupt arrives during
> the late suspend phase. Without this setting it will be ignored.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Kevin Hilman <khilman@ti.com>
> ---
>
> drivers/mfd/twl4030-irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> index 5d656e8..ad733d7 100644
> --- a/drivers/mfd/twl4030-irq.c
> +++ b/drivers/mfd/twl4030-irq.c
> @@ -757,6 +757,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
> dev_err(dev, "could not claim irq%d: %d\n", irq_num, status);
> goto fail_rqirq;
> }
> + enable_irq_wake(irq_num);
>
> return irq_base;
> fail_rqirq:
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-04-26 20:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 3:05 [PATCH 0/3] Ensure twl4030 interrupts are lost during suspend NeilBrown
2012-04-25 3:05 ` NeilBrown
2012-04-25 3:05 ` [PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ NeilBrown
2012-04-25 3:05 ` NeilBrown
2012-04-26 20:39 ` Kevin Hilman [this message]
2012-04-26 20:39 ` Kevin Hilman
2012-05-09 16:03 ` Samuel Ortiz
2012-05-09 16:03 ` Samuel Ortiz
2012-04-25 3:05 ` [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts NeilBrown
2012-04-25 3:05 ` NeilBrown
2012-04-26 20:08 ` Kevin Hilman
2012-04-26 20:08 ` Kevin Hilman
2012-04-26 20:25 ` Tony Lindgren
2012-04-26 20:25 ` Tony Lindgren
2012-04-26 20:39 ` Kevin Hilman
2012-04-26 20:39 ` Kevin Hilman
2012-04-26 20:50 ` NeilBrown
2012-04-26 20:50 ` NeilBrown
2012-04-27 22:01 ` Kevin Hilman
2012-04-27 22:01 ` Kevin Hilman
2012-04-27 6:20 ` Shilimkar, Santosh
2012-04-27 6:20 ` Shilimkar, Santosh
2012-04-27 6:20 ` Shilimkar, Santosh
2012-04-25 3:05 ` [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts NeilBrown
2012-04-25 3:05 ` NeilBrown
2012-04-25 8:50 ` Thomas Gleixner
2012-04-25 8:50 ` Thomas Gleixner
2012-04-25 9:39 ` NeilBrown
2012-04-25 9:39 ` NeilBrown
2012-04-25 12:54 ` Thomas Gleixner
2012-04-25 12:54 ` Thomas Gleixner
2012-04-25 21:04 ` NeilBrown
2012-04-25 21:04 ` NeilBrown
2012-05-04 5:12 ` NeilBrown
2012-05-04 5:12 ` NeilBrown
2012-05-04 16:01 ` Thomas Gleixner
2012-05-04 16:01 ` Thomas Gleixner
2012-05-08 20:52 ` NeilBrown
2012-05-08 20:52 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ns69qij.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=neilb@suse.de \
--cc=rjw@sisk.pl \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.