From: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: NeilBrown <neilb@suse.de>, Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.
Date: Fri, 27 Apr 2012 11:50:58 +0530 [thread overview]
Message-ID: <CAMQu2gyfE6otEmWhJ7pkNYPjb8iUY21dzL6a3-qAGZXWP_kk-w@mail.gmail.com> (raw)
In-Reply-To: <878vhi9qj8.fsf@ti.com>
On Fri, Apr 27, 2012 at 2:09 AM, Kevin Hilman <khilman@ti.com> wrote:
> NeilBrown <neilb@suse.de> writes:
>
[...]
>
> From 644742ddae59731bc10aacde94645d7c49ca5ecd Mon Sep 17 00:00:00 2001
> From: NeilBrown <neilb@suse.de>
> Date: Wed, 25 Apr 2012 13:05:24 +1000
> Subject: [PATCH] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.
>
> Without an ->irq_set_wake() method in an irq_chip, calls to
> enable_irq_wake() will fail. This also causes these interrupts to not
> be able to abort suspend (via check_wakeup_irqs() in late suspend.)
>
> Currently, we don't implement ->irq_set_wake() for INTC interrupts
> because they default to be wakeup enabled by setting the GRPSEL bits
> in PM init. Even though there is no ->irq_set_wake(), we want
> enable_irq_wake() to succeed so these interrupts can abort suspend
> when necessary.
>
> To fix, set IRQCHIP_SKIP_SET_WAKE flag for all the INTC
> interrupts which avoids trying to check irq_chip->irq_set_wake()
> and failing when it doesn't exist.
>
> Longer term, we need to implement ->irq_set_wake() for the INTC
> which can manage the appropriate GRPSEL bits.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
> [khilman@ti.com: rework changelog]
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: NeilBrown <neilb@suse.de>, Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.
Date: Fri, 27 Apr 2012 11:50:58 +0530 [thread overview]
Message-ID: <CAMQu2gyfE6otEmWhJ7pkNYPjb8iUY21dzL6a3-qAGZXWP_kk-w@mail.gmail.com> (raw)
In-Reply-To: <878vhi9qj8.fsf@ti.com>
On Fri, Apr 27, 2012 at 2:09 AM, Kevin Hilman <khilman@ti.com> wrote:
> NeilBrown <neilb@suse.de> writes:
>
[...]
>
> From 644742ddae59731bc10aacde94645d7c49ca5ecd Mon Sep 17 00:00:00 2001
> From: NeilBrown <neilb@suse.de>
> Date: Wed, 25 Apr 2012 13:05:24 +1000
> Subject: [PATCH] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.
>
> Without an ->irq_set_wake() method in an irq_chip, calls to
> enable_irq_wake() will fail. This also causes these interrupts to not
> be able to abort suspend (via check_wakeup_irqs() in late suspend.)
>
> Currently, we don't implement ->irq_set_wake() for INTC interrupts
> because they default to be wakeup enabled by setting the GRPSEL bits
> in PM init. Even though there is no ->irq_set_wake(), we want
> enable_irq_wake() to succeed so these interrupts can abort suspend
> when necessary.
>
> To fix, set IRQCHIP_SKIP_SET_WAKE flag for all the INTC
> interrupts which avoids trying to check irq_chip->irq_set_wake()
> and failing when it doesn't exist.
>
> Longer term, we need to implement ->irq_set_wake() for the INTC
> which can manage the appropriate GRPSEL bits.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
> [khilman@ti.com: rework changelog]
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Shilimkar, Santosh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.
Date: Fri, 27 Apr 2012 11:50:58 +0530 [thread overview]
Message-ID: <CAMQu2gyfE6otEmWhJ7pkNYPjb8iUY21dzL6a3-qAGZXWP_kk-w@mail.gmail.com> (raw)
In-Reply-To: <878vhi9qj8.fsf@ti.com>
On Fri, Apr 27, 2012 at 2:09 AM, Kevin Hilman <khilman@ti.com> wrote:
> NeilBrown <neilb@suse.de> writes:
>
[...]
>
> From 644742ddae59731bc10aacde94645d7c49ca5ecd Mon Sep 17 00:00:00 2001
> From: NeilBrown <neilb@suse.de>
> Date: Wed, 25 Apr 2012 13:05:24 +1000
> Subject: [PATCH] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.
>
> Without an ->irq_set_wake() method in an irq_chip, calls to
> enable_irq_wake() will fail. ?This also causes these interrupts to not
> be able to abort suspend (via check_wakeup_irqs() in late suspend.)
>
> Currently, we don't implement ->irq_set_wake() for INTC interrupts
> because they default to be wakeup enabled by setting the GRPSEL bits
> in PM init. ?Even though there is no ->irq_set_wake(), we want
> enable_irq_wake() to succeed so these interrupts can abort suspend
> when necessary.
>
> To fix, set IRQCHIP_SKIP_SET_WAKE flag for all the INTC
> interrupts which avoids trying to check irq_chip->irq_set_wake()
> and failing when it doesn't exist.
>
> Longer term, we need to implement ->irq_set_wake() for the INTC
> which can manage the appropriate GRPSEL bits.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
> [khilman at ti.com: rework changelog]
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2012-04-27 6:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 3:05 [PATCH 0/3] Ensure twl4030 interrupts are lost during suspend NeilBrown
2012-04-25 3:05 ` NeilBrown
2012-04-25 3:05 ` [PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ NeilBrown
2012-04-25 3:05 ` NeilBrown
2012-04-26 20:39 ` Kevin Hilman
2012-04-26 20:39 ` Kevin Hilman
2012-05-09 16:03 ` Samuel Ortiz
2012-05-09 16:03 ` Samuel Ortiz
2012-04-25 3:05 ` [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts NeilBrown
2012-04-25 3:05 ` NeilBrown
2012-04-26 20:08 ` Kevin Hilman
2012-04-26 20:08 ` Kevin Hilman
2012-04-26 20:25 ` Tony Lindgren
2012-04-26 20:25 ` Tony Lindgren
2012-04-26 20:39 ` Kevin Hilman
2012-04-26 20:39 ` Kevin Hilman
2012-04-26 20:50 ` NeilBrown
2012-04-26 20:50 ` NeilBrown
2012-04-27 22:01 ` Kevin Hilman
2012-04-27 22:01 ` Kevin Hilman
2012-04-27 6:20 ` Shilimkar, Santosh [this message]
2012-04-27 6:20 ` Shilimkar, Santosh
2012-04-27 6:20 ` Shilimkar, Santosh
2012-04-25 3:05 ` [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts NeilBrown
2012-04-25 3:05 ` NeilBrown
2012-04-25 8:50 ` Thomas Gleixner
2012-04-25 8:50 ` Thomas Gleixner
2012-04-25 9:39 ` NeilBrown
2012-04-25 9:39 ` NeilBrown
2012-04-25 12:54 ` Thomas Gleixner
2012-04-25 12:54 ` Thomas Gleixner
2012-04-25 21:04 ` NeilBrown
2012-04-25 21:04 ` NeilBrown
2012-05-04 5:12 ` NeilBrown
2012-05-04 5:12 ` NeilBrown
2012-05-04 16:01 ` Thomas Gleixner
2012-05-04 16:01 ` Thomas Gleixner
2012-05-08 20:52 ` NeilBrown
2012-05-08 20:52 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMQu2gyfE6otEmWhJ7pkNYPjb8iUY21dzL6a3-qAGZXWP_kk-w@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=neilb@suse.de \
--cc=rjw@sisk.pl \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.