All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: NeilBrown <neilb@suse.de>
Cc: Tony Lindgren <tony@atomide.com>,
	Russell King <linux@arm.linux.org.uk>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.
Date: Fri, 27 Apr 2012 15:01:52 -0700	[thread overview]
Message-ID: <8762ckzve7.fsf@ti.com> (raw)
In-Reply-To: <20120427065040.3ba0fce2@notabene.brown> (NeilBrown's message of "Fri, 27 Apr 2012 06:50:40 +1000")

NeilBrown <neilb@suse.de> writes:

> On Thu, 26 Apr 2012 13:39:07 -0700 Kevin Hilman <khilman@ti.com> wrote:
>
>> NeilBrown <neilb@suse.de> writes:
>> 
>> > All interrupts can wake-from-sleep (I think) so it should be
>> > permissible to call enable_irq_wake().  Setting this flag allows that.
>> >
>> > It is needed because without this, an interrupt which is delivered
>> > during late suspend will get ignored but will not cause suspend to
>> > abort.
>> > If enable_irq_wake() is called and succeeds, check_wakuep_irqs()
>> > will abort the suspend if the interrupt has fired.
>> >
>> > Signed-off-by: NeilBrown <neilb@suse.de>
>> 
>> The name of this flag and the effect of setting it are somewhat
>> confusing (e.g. why does skipping set_wake suddenly make wakeups work.)
>> So I tried to make it clearer with a reworking of the changelog (below.)
>> 
>> If I understood this correctly, and if you're OK with the updated
>> changelog, I'll queue this up for v3.5.
>> 
>
> I'm very OK with your updated changelog - thanks.  Filling in various bits
> that I didn't know and clarifies the rest :-)

Great, thanks.

Adding ack from Santosh (thanks!) and queuing for v3.5[1]

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.5/pm-misc

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.
Date: Fri, 27 Apr 2012 15:01:52 -0700	[thread overview]
Message-ID: <8762ckzve7.fsf@ti.com> (raw)
In-Reply-To: <20120427065040.3ba0fce2@notabene.brown> (NeilBrown's message of "Fri, 27 Apr 2012 06:50:40 +1000")

NeilBrown <neilb@suse.de> writes:

> On Thu, 26 Apr 2012 13:39:07 -0700 Kevin Hilman <khilman@ti.com> wrote:
>
>> NeilBrown <neilb@suse.de> writes:
>> 
>> > All interrupts can wake-from-sleep (I think) so it should be
>> > permissible to call enable_irq_wake().  Setting this flag allows that.
>> >
>> > It is needed because without this, an interrupt which is delivered
>> > during late suspend will get ignored but will not cause suspend to
>> > abort.
>> > If enable_irq_wake() is called and succeeds, check_wakuep_irqs()
>> > will abort the suspend if the interrupt has fired.
>> >
>> > Signed-off-by: NeilBrown <neilb@suse.de>
>> 
>> The name of this flag and the effect of setting it are somewhat
>> confusing (e.g. why does skipping set_wake suddenly make wakeups work.)
>> So I tried to make it clearer with a reworking of the changelog (below.)
>> 
>> If I understood this correctly, and if you're OK with the updated
>> changelog, I'll queue this up for v3.5.
>> 
>
> I'm very OK with your updated changelog - thanks.  Filling in various bits
> that I didn't know and clarifies the rest :-)

Great, thanks.

Adding ack from Santosh (thanks!) and queuing for v3.5[1]

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.5/pm-misc

  reply	other threads:[~2012-04-27 22:01 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25  3:05 [PATCH 0/3] Ensure twl4030 interrupts are lost during suspend NeilBrown
2012-04-25  3:05 ` NeilBrown
2012-04-25  3:05 ` [PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ NeilBrown
2012-04-25  3:05   ` NeilBrown
2012-04-26 20:39   ` Kevin Hilman
2012-04-26 20:39     ` Kevin Hilman
2012-05-09 16:03   ` Samuel Ortiz
2012-05-09 16:03     ` Samuel Ortiz
2012-04-25  3:05 ` [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts NeilBrown
2012-04-25  3:05   ` NeilBrown
2012-04-26 20:08   ` Kevin Hilman
2012-04-26 20:08     ` Kevin Hilman
2012-04-26 20:25     ` Tony Lindgren
2012-04-26 20:25       ` Tony Lindgren
2012-04-26 20:39   ` Kevin Hilman
2012-04-26 20:39     ` Kevin Hilman
2012-04-26 20:50     ` NeilBrown
2012-04-26 20:50       ` NeilBrown
2012-04-27 22:01       ` Kevin Hilman [this message]
2012-04-27 22:01         ` Kevin Hilman
2012-04-27  6:20     ` Shilimkar, Santosh
2012-04-27  6:20       ` Shilimkar, Santosh
2012-04-27  6:20       ` Shilimkar, Santosh
2012-04-25  3:05 ` [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts NeilBrown
2012-04-25  3:05   ` NeilBrown
2012-04-25  8:50   ` Thomas Gleixner
2012-04-25  8:50     ` Thomas Gleixner
2012-04-25  9:39     ` NeilBrown
2012-04-25  9:39       ` NeilBrown
2012-04-25 12:54       ` Thomas Gleixner
2012-04-25 12:54         ` Thomas Gleixner
2012-04-25 21:04         ` NeilBrown
2012-04-25 21:04           ` NeilBrown
2012-05-04  5:12         ` NeilBrown
2012-05-04  5:12           ` NeilBrown
2012-05-04 16:01           ` Thomas Gleixner
2012-05-04 16:01             ` Thomas Gleixner
2012-05-08 20:52             ` NeilBrown
2012-05-08 20:52               ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762ckzve7.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=neilb@suse.de \
    --cc=rjw@sisk.pl \
    --cc=sameo@linux.intel.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.