From: Kevin Hilman <khilman@ti.com> To: NeilBrown <neilb@suse.de> Cc: Tony Lindgren <tony@atomide.com>, Russell King <linux@arm.linux.org.uk>, Samuel Ortiz <sameo@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>, "Rafael J. Wysocki" <rjw@sisk.pl>, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. Date: Thu, 26 Apr 2012 13:39:07 -0700 [thread overview] Message-ID: <878vhi9qj8.fsf@ti.com> (raw) In-Reply-To: <20120425030524.7832.52047.stgit@notabene.brown> (NeilBrown's message of "Wed, 25 Apr 2012 13:05:24 +1000") NeilBrown <neilb@suse.de> writes: > All interrupts can wake-from-sleep (I think) so it should be > permissible to call enable_irq_wake(). Setting this flag allows that. > > It is needed because without this, an interrupt which is delivered > during late suspend will get ignored but will not cause suspend to > abort. > If enable_irq_wake() is called and succeeds, check_wakuep_irqs() > will abort the suspend if the interrupt has fired. > > Signed-off-by: NeilBrown <neilb@suse.de> The name of this flag and the effect of setting it are somewhat confusing (e.g. why does skipping set_wake suddenly make wakeups work.) So I tried to make it clearer with a reworking of the changelog (below.) If I understood this correctly, and if you're OK with the updated changelog, I'll queue this up for v3.5. Thanks, Kevin >From 644742ddae59731bc10aacde94645d7c49ca5ecd Mon Sep 17 00:00:00 2001 From: NeilBrown <neilb@suse.de> Date: Wed, 25 Apr 2012 13:05:24 +1000 Subject: [PATCH] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. Without an ->irq_set_wake() method in an irq_chip, calls to enable_irq_wake() will fail. This also causes these interrupts to not be able to abort suspend (via check_wakeup_irqs() in late suspend.) Currently, we don't implement ->irq_set_wake() for INTC interrupts because they default to be wakeup enabled by setting the GRPSEL bits in PM init. Even though there is no ->irq_set_wake(), we want enable_irq_wake() to succeed so these interrupts can abort suspend when necessary. To fix, set IRQCHIP_SKIP_SET_WAKE flag for all the INTC interrupts which avoids trying to check irq_chip->irq_set_wake() and failing when it doesn't exist. Longer term, we need to implement ->irq_set_wake() for the INTC which can manage the appropriate GRPSEL bits. Signed-off-by: NeilBrown <neilb@suse.de> [khilman@ti.com: rework changelog] Signed-off-by: Kevin Hilman <khilman@ti.com> --- arch/arm/mach-omap2/irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c index 65f0d257..b0790a9 100644 --- a/arch/arm/mach-omap2/irq.c +++ b/arch/arm/mach-omap2/irq.c @@ -148,6 +148,7 @@ omap_alloc_gc(void __iomem *base, unsigned int irq_start, unsigned int num) ct->chip.irq_ack = omap_mask_ack_irq; ct->chip.irq_mask = irq_gc_mask_disable_reg; ct->chip.irq_unmask = irq_gc_unmask_enable_reg; + ct->chip.flags |= IRQCHIP_SKIP_SET_WAKE; ct->regs.ack = INTC_CONTROL; ct->regs.enable = INTC_MIR_CLEAR0; -- 1.7.9.2
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. Date: Thu, 26 Apr 2012 13:39:07 -0700 [thread overview] Message-ID: <878vhi9qj8.fsf@ti.com> (raw) In-Reply-To: <20120425030524.7832.52047.stgit@notabene.brown> (NeilBrown's message of "Wed, 25 Apr 2012 13:05:24 +1000") NeilBrown <neilb@suse.de> writes: > All interrupts can wake-from-sleep (I think) so it should be > permissible to call enable_irq_wake(). Setting this flag allows that. > > It is needed because without this, an interrupt which is delivered > during late suspend will get ignored but will not cause suspend to > abort. > If enable_irq_wake() is called and succeeds, check_wakuep_irqs() > will abort the suspend if the interrupt has fired. > > Signed-off-by: NeilBrown <neilb@suse.de> The name of this flag and the effect of setting it are somewhat confusing (e.g. why does skipping set_wake suddenly make wakeups work.) So I tried to make it clearer with a reworking of the changelog (below.) If I understood this correctly, and if you're OK with the updated changelog, I'll queue this up for v3.5. Thanks, Kevin >From 644742ddae59731bc10aacde94645d7c49ca5ecd Mon Sep 17 00:00:00 2001 From: NeilBrown <neilb@suse.de> Date: Wed, 25 Apr 2012 13:05:24 +1000 Subject: [PATCH] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. Without an ->irq_set_wake() method in an irq_chip, calls to enable_irq_wake() will fail. This also causes these interrupts to not be able to abort suspend (via check_wakeup_irqs() in late suspend.) Currently, we don't implement ->irq_set_wake() for INTC interrupts because they default to be wakeup enabled by setting the GRPSEL bits in PM init. Even though there is no ->irq_set_wake(), we want enable_irq_wake() to succeed so these interrupts can abort suspend when necessary. To fix, set IRQCHIP_SKIP_SET_WAKE flag for all the INTC interrupts which avoids trying to check irq_chip->irq_set_wake() and failing when it doesn't exist. Longer term, we need to implement ->irq_set_wake() for the INTC which can manage the appropriate GRPSEL bits. Signed-off-by: NeilBrown <neilb@suse.de> [khilman at ti.com: rework changelog] Signed-off-by: Kevin Hilman <khilman@ti.com> --- arch/arm/mach-omap2/irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c index 65f0d257..b0790a9 100644 --- a/arch/arm/mach-omap2/irq.c +++ b/arch/arm/mach-omap2/irq.c @@ -148,6 +148,7 @@ omap_alloc_gc(void __iomem *base, unsigned int irq_start, unsigned int num) ct->chip.irq_ack = omap_mask_ack_irq; ct->chip.irq_mask = irq_gc_mask_disable_reg; ct->chip.irq_unmask = irq_gc_unmask_enable_reg; + ct->chip.flags |= IRQCHIP_SKIP_SET_WAKE; ct->regs.ack = INTC_CONTROL; ct->regs.enable = INTC_MIR_CLEAR0; -- 1.7.9.2
next prev parent reply other threads:[~2012-04-26 20:39 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-25 3:05 [PATCH 0/3] Ensure twl4030 interrupts are lost during suspend NeilBrown 2012-04-25 3:05 ` NeilBrown 2012-04-25 3:05 ` [PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ NeilBrown 2012-04-25 3:05 ` NeilBrown 2012-04-26 20:39 ` Kevin Hilman 2012-04-26 20:39 ` Kevin Hilman 2012-05-09 16:03 ` Samuel Ortiz 2012-05-09 16:03 ` Samuel Ortiz 2012-04-25 3:05 ` [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts NeilBrown 2012-04-25 3:05 ` NeilBrown 2012-04-26 20:08 ` Kevin Hilman 2012-04-26 20:08 ` Kevin Hilman 2012-04-26 20:25 ` Tony Lindgren 2012-04-26 20:25 ` Tony Lindgren 2012-04-26 20:39 ` Kevin Hilman [this message] 2012-04-26 20:39 ` Kevin Hilman 2012-04-26 20:50 ` NeilBrown 2012-04-26 20:50 ` NeilBrown 2012-04-27 22:01 ` Kevin Hilman 2012-04-27 22:01 ` Kevin Hilman 2012-04-27 6:20 ` Shilimkar, Santosh 2012-04-27 6:20 ` Shilimkar, Santosh 2012-04-27 6:20 ` Shilimkar, Santosh 2012-04-25 3:05 ` [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts NeilBrown 2012-04-25 3:05 ` NeilBrown 2012-04-25 8:50 ` Thomas Gleixner 2012-04-25 8:50 ` Thomas Gleixner 2012-04-25 9:39 ` NeilBrown 2012-04-25 9:39 ` NeilBrown 2012-04-25 12:54 ` Thomas Gleixner 2012-04-25 12:54 ` Thomas Gleixner 2012-04-25 21:04 ` NeilBrown 2012-04-25 21:04 ` NeilBrown 2012-05-04 5:12 ` NeilBrown 2012-05-04 5:12 ` NeilBrown 2012-05-04 16:01 ` Thomas Gleixner 2012-05-04 16:01 ` Thomas Gleixner 2012-05-08 20:52 ` NeilBrown 2012-05-08 20:52 ` NeilBrown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=878vhi9qj8.fsf@ti.com \ --to=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=neilb@suse.de \ --cc=rjw@sisk.pl \ --cc=sameo@linux.intel.com \ --cc=tglx@linutronix.de \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.