All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: NeilBrown <neilb@suse.de>
Cc: Tony Lindgren <tony@atomide.com>,
	Russell King <linux@arm.linux.org.uk>,
	Samuel Ortiz <sameo@linux.intel.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.
Date: Fri, 4 May 2012 18:01:22 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1205041759540.6271@ionos> (raw)
In-Reply-To: <20120504151221.6998d4e5@notabene.brown>

Neil,

On Fri, 4 May 2012, NeilBrown wrote:

> On Wed, 25 Apr 2012 14:54:54 +0200 (CEST) Thomas Gleixner
> <tglx@linutronix.de> wrote:
> 
> > Why not simply managing the pending bit for level irqs ?
> > 
> 
> Hi Thomas,
>  thanks again for the patch.  I finally made time to test it and it works as
> expected.  I've included it below with a change-log entry and tested-by:
> in case that helps.

thanks for testing. The changelog is great. You know how to make the
live of lazy buggers easier :)
  
>  	for_each_irq_desc(irq, desc) {
> -		if (irqd_is_wakeup_set(&desc->irq_data)) {
> +		if (desc->depth == 1 &&
> +		    irqd_is_wakeup_set(&desc->irq_data)) {
>  			if (desc->istate & IRQS_PENDING)
>  				return -EBUSY;
>  			continue;

I split that part into a separate patch, as it's really a different
issue.

Thanks,

	tglx

WARNING: multiple messages have this Message-ID (diff)
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.
Date: Fri, 4 May 2012 18:01:22 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1205041759540.6271@ionos> (raw)
In-Reply-To: <20120504151221.6998d4e5@notabene.brown>

Neil,

On Fri, 4 May 2012, NeilBrown wrote:

> On Wed, 25 Apr 2012 14:54:54 +0200 (CEST) Thomas Gleixner
> <tglx@linutronix.de> wrote:
> 
> > Why not simply managing the pending bit for level irqs ?
> > 
> 
> Hi Thomas,
>  thanks again for the patch.  I finally made time to test it and it works as
> expected.  I've included it below with a change-log entry and tested-by:
> in case that helps.

thanks for testing. The changelog is great. You know how to make the
live of lazy buggers easier :)
  
>  	for_each_irq_desc(irq, desc) {
> -		if (irqd_is_wakeup_set(&desc->irq_data)) {
> +		if (desc->depth == 1 &&
> +		    irqd_is_wakeup_set(&desc->irq_data)) {
>  			if (desc->istate & IRQS_PENDING)
>  				return -EBUSY;
>  			continue;

I split that part into a separate patch, as it's really a different
issue.

Thanks,

	tglx

  reply	other threads:[~2012-05-04 16:01 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25  3:05 [PATCH 0/3] Ensure twl4030 interrupts are lost during suspend NeilBrown
2012-04-25  3:05 ` NeilBrown
2012-04-25  3:05 ` [PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ NeilBrown
2012-04-25  3:05   ` NeilBrown
2012-04-26 20:39   ` Kevin Hilman
2012-04-26 20:39     ` Kevin Hilman
2012-05-09 16:03   ` Samuel Ortiz
2012-05-09 16:03     ` Samuel Ortiz
2012-04-25  3:05 ` [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts NeilBrown
2012-04-25  3:05   ` NeilBrown
2012-04-26 20:08   ` Kevin Hilman
2012-04-26 20:08     ` Kevin Hilman
2012-04-26 20:25     ` Tony Lindgren
2012-04-26 20:25       ` Tony Lindgren
2012-04-26 20:39   ` Kevin Hilman
2012-04-26 20:39     ` Kevin Hilman
2012-04-26 20:50     ` NeilBrown
2012-04-26 20:50       ` NeilBrown
2012-04-27 22:01       ` Kevin Hilman
2012-04-27 22:01         ` Kevin Hilman
2012-04-27  6:20     ` Shilimkar, Santosh
2012-04-27  6:20       ` Shilimkar, Santosh
2012-04-27  6:20       ` Shilimkar, Santosh
2012-04-25  3:05 ` [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts NeilBrown
2012-04-25  3:05   ` NeilBrown
2012-04-25  8:50   ` Thomas Gleixner
2012-04-25  8:50     ` Thomas Gleixner
2012-04-25  9:39     ` NeilBrown
2012-04-25  9:39       ` NeilBrown
2012-04-25 12:54       ` Thomas Gleixner
2012-04-25 12:54         ` Thomas Gleixner
2012-04-25 21:04         ` NeilBrown
2012-04-25 21:04           ` NeilBrown
2012-05-04  5:12         ` NeilBrown
2012-05-04  5:12           ` NeilBrown
2012-05-04 16:01           ` Thomas Gleixner [this message]
2012-05-04 16:01             ` Thomas Gleixner
2012-05-08 20:52             ` NeilBrown
2012-05-08 20:52               ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1205041759540.6271@ionos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=neilb@suse.de \
    --cc=rjw@sisk.pl \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.