From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Marek Majtyka <alardam@gmail.com>,
Saeed Mahameed <saeed@kernel.org>,
David Ahern <dsahern@gmail.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
John Fastabend <john.fastabend@gmail.com>,
Jesper Dangaard Brouer <jbrouer@redhat.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Maciej Fijalkowski <maciejromanfijalkowski@gmail.com>
Cc: "Björn Töpel" <bjorn.topel@intel.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
hawk@kernel.org, bpf <bpf@vger.kernel.org>,
intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set
Date: Mon, 01 Feb 2021 17:16:01 +0100 [thread overview]
Message-ID: <87h7mvsr0e.fsf@toke.dk> (raw)
In-Reply-To: <CAAOQfrHN1-oHmbOksDv-BKWv4gDF2zHZ5dTew6R_QTh6s_1abg@mail.gmail.com>
Marek Majtyka <alardam@gmail.com> writes:
> I would like to thank you for your time, comments, nitpicking as well
> as encouraging.
>
> One thing needs clarification I think, that is, that those flags
> describe driver static feature sets - which are read-only. They have
> nothing in common with driver runtime configuration change yet.
> Runtime change of this state can be added but it needs a new variable
> and it can be done later on if someone needs it.
>
> Obviously, it is not possible to make everybody happy, especially with
> XDP_BASE flags set. To be honest, this XDP_BASE definition is a
> syntactic sugar for me and I can live without it. We can either remove
> it completely, from
> which IMO we all and other developers will suffer later on, or maybe
> we can agree on these two helper set of flags: XDP_BASE (TX, ABORTED,
> PASS, DROP) and XDP_LIMITED_BASE(ABORTED,PASS_DROP).
> What do you think?
>
> I am also going to add a new XDP_REDIRECT_TARGET flag and retrieving
> XDP flags over rtnelink interface.
>
> I also think that for completeness, ethtool implementation should be
> kept together with rtnelink part in order to cover both ip and
> ethtool tools. Do I have your approval or disagreement? Please let me
> know.
Hi Marek
I just realised that it seems no one actually replied to your email. On
my part at least that was because I didn't have any objections, so I'm
hoping you didn't feel the lack of response was discouraging (and that
you're still working on a revision of this series)? :)
-Toke
WARNING: multiple messages have this Message-ID (diff)
From: Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set
Date: Mon, 01 Feb 2021 17:16:01 +0100 [thread overview]
Message-ID: <87h7mvsr0e.fsf@toke.dk> (raw)
In-Reply-To: <CAAOQfrHN1-oHmbOksDv-BKWv4gDF2zHZ5dTew6R_QTh6s_1abg@mail.gmail.com>
Marek Majtyka <alardam@gmail.com> writes:
> I would like to thank you for your time, comments, nitpicking as well
> as encouraging.
>
> One thing needs clarification I think, that is, that those flags
> describe driver static feature sets - which are read-only. They have
> nothing in common with driver runtime configuration change yet.
> Runtime change of this state can be added but it needs a new variable
> and it can be done later on if someone needs it.
>
> Obviously, it is not possible to make everybody happy, especially with
> XDP_BASE flags set. To be honest, this XDP_BASE definition is a
> syntactic sugar for me and I can live without it. We can either remove
> it completely, from
> which IMO we all and other developers will suffer later on, or maybe
> we can agree on these two helper set of flags: XDP_BASE (TX, ABORTED,
> PASS, DROP) and XDP_LIMITED_BASE(ABORTED,PASS_DROP).
> What do you think?
>
> I am also going to add a new XDP_REDIRECT_TARGET flag and retrieving
> XDP flags over rtnelink interface.
>
> I also think that for completeness, ethtool implementation should be
> kept together with rtnelink part in order to cover both ip and
> ethtool tools. Do I have your approval or disagreement? Please let me
> know.
Hi Marek
I just realised that it seems no one actually replied to your email. On
my part at least that was because I didn't have any objections, so I'm
hoping you didn't feel the lack of response was discouraging (and that
you're still working on a revision of this series)? :)
-Toke
next prev parent reply other threads:[~2021-02-01 16:17 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 10:28 [PATCH v2 bpf 0/5] New netdev feature flags for XDP alardam
2020-12-04 10:28 ` [Intel-wired-lan] " alardam
2020-12-04 10:28 ` [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set alardam
2020-12-04 10:28 ` [Intel-wired-lan] " alardam
2020-12-04 12:18 ` Toke Høiland-Jørgensen
2020-12-04 12:18 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2020-12-04 12:46 ` Maciej Fijalkowski
2020-12-04 12:46 ` [Intel-wired-lan] " Maciej Fijalkowski
2020-12-04 15:21 ` Daniel Borkmann
2020-12-04 15:21 ` [Intel-wired-lan] " Daniel Borkmann
2020-12-04 17:20 ` Toke Høiland-Jørgensen
2020-12-04 17:20 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2020-12-04 22:19 ` Daniel Borkmann
2020-12-04 22:19 ` [Intel-wired-lan] " Daniel Borkmann
2020-12-07 11:54 ` Jesper Dangaard Brouer
2020-12-07 11:54 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2020-12-07 12:08 ` Toke Høiland-Jørgensen
2020-12-07 12:08 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2020-12-07 12:03 ` Toke Høiland-Jørgensen
2020-12-07 12:03 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2020-12-07 12:54 ` Jesper Dangaard Brouer
2020-12-07 12:54 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2020-12-07 20:52 ` John Fastabend
2020-12-07 20:52 ` [Intel-wired-lan] " John Fastabend
2020-12-07 22:38 ` Saeed Mahameed
2020-12-07 22:38 ` [Intel-wired-lan] " Saeed Mahameed
2020-12-07 23:07 ` Maciej Fijalkowski
2020-12-07 23:07 ` [Intel-wired-lan] " Maciej Fijalkowski
2020-12-09 6:03 ` John Fastabend
2020-12-09 6:03 ` [Intel-wired-lan] " John Fastabend
2020-12-09 9:54 ` Maciej Fijalkowski
2020-12-09 9:54 ` [Intel-wired-lan] " Maciej Fijalkowski
2020-12-09 11:52 ` Jesper Dangaard Brouer
2020-12-09 11:52 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2020-12-09 15:41 ` David Ahern
2020-12-09 15:41 ` [Intel-wired-lan] " David Ahern
2020-12-09 17:15 ` Saeed Mahameed
2020-12-09 17:15 ` [Intel-wired-lan] " Saeed Mahameed
2020-12-10 3:34 ` David Ahern
2020-12-10 3:34 ` [Intel-wired-lan] " David Ahern
2020-12-10 6:48 ` Saeed Mahameed
2020-12-10 6:48 ` [Intel-wired-lan] " Saeed Mahameed
2020-12-10 15:30 ` David Ahern
2020-12-10 15:30 ` [Intel-wired-lan] " David Ahern
2020-12-10 18:58 ` Saeed Mahameed
2020-12-10 18:58 ` [Intel-wired-lan] " Saeed Mahameed
2021-01-05 11:56 ` Marek Majtyka
2021-01-05 11:56 ` [Intel-wired-lan] " Marek Majtyka
2021-02-01 16:16 ` Toke Høiland-Jørgensen [this message]
2021-02-01 16:16 ` Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2021-02-02 11:26 ` Marek Majtyka
2021-02-02 11:26 ` [Intel-wired-lan] " Marek Majtyka
2021-02-02 12:05 ` Toke Høiland-Jørgensen
2021-02-02 12:05 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2021-02-02 19:34 ` Jakub Kicinski
2021-02-02 19:34 ` [Intel-wired-lan] " Jakub Kicinski
2021-02-03 12:50 ` Marek Majtyka
2021-02-03 12:50 ` [Intel-wired-lan] " Marek Majtyka
2021-02-03 17:02 ` Jakub Kicinski
2021-02-03 17:02 ` [Intel-wired-lan] " Jakub Kicinski
2021-02-10 10:53 ` Toke Høiland-Jørgensen
2021-02-10 10:53 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2021-02-10 18:31 ` Jakub Kicinski
2021-02-10 18:31 ` [Intel-wired-lan] " Jakub Kicinski
2021-02-10 22:52 ` Toke Høiland-Jørgensen
2021-02-10 22:52 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2021-02-12 1:26 ` Jakub Kicinski
2021-02-12 1:26 ` [Intel-wired-lan] " Jakub Kicinski
2021-02-12 2:05 ` Alexei Starovoitov
2021-02-12 2:05 ` [Intel-wired-lan] " Alexei Starovoitov
2021-02-12 7:02 ` Marek Majtyka
2021-02-12 7:02 ` [Intel-wired-lan] " Marek Majtyka
2021-02-16 14:30 ` Toke Høiland-Jørgensen
2021-02-16 14:30 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2020-12-09 15:44 ` David Ahern
2020-12-09 15:44 ` [Intel-wired-lan] " David Ahern
2020-12-10 13:32 ` Explaining XDP redirect bulk size design (Was: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set) Jesper Dangaard Brouer
2020-12-10 13:32 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2020-12-10 14:14 ` Magnus Karlsson
2020-12-10 14:14 ` Magnus Karlsson
2020-12-10 17:30 ` Jesper Dangaard Brouer
2020-12-10 17:30 ` Jesper Dangaard Brouer
2020-12-10 19:20 ` Saeed Mahameed
2020-12-10 19:20 ` [Intel-wired-lan] " Saeed Mahameed
2020-12-08 1:01 ` [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set David Ahern
2020-12-08 1:01 ` [Intel-wired-lan] " David Ahern
2020-12-08 8:28 ` Jesper Dangaard Brouer
2020-12-08 8:28 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2020-12-08 11:58 ` Toke Høiland-Jørgensen
2020-12-08 11:58 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2020-12-09 5:50 ` John Fastabend
2020-12-09 5:50 ` [Intel-wired-lan] " John Fastabend
2020-12-09 10:26 ` Toke Høiland-Jørgensen
2020-12-09 10:26 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2020-12-08 9:00 ` Jesper Dangaard Brouer
2020-12-08 9:00 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2020-12-08 9:42 ` Daniel Borkmann
2020-12-08 9:42 ` [Intel-wired-lan] " Daniel Borkmann
2020-12-04 12:57 ` Maciej Fijalkowski
2020-12-04 12:57 ` [Intel-wired-lan] " Maciej Fijalkowski
2020-12-04 10:28 ` [PATCH v2 bpf 2/5] drivers/net: turn XDP properties on alardam
2020-12-04 10:28 ` [Intel-wired-lan] " alardam
2020-12-04 12:19 ` Toke Høiland-Jørgensen
2020-12-04 12:19 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2020-12-09 19:05 ` kernel test robot
2020-12-09 19:05 ` kernel test robot
2020-12-04 10:28 ` [PATCH v2 bpf 3/5] xsk: add usage of xdp properties flags alardam
2020-12-04 10:28 ` [Intel-wired-lan] " alardam
2020-12-04 10:29 ` [PATCH v2 bpf 4/5] xsk: add check for full support of XDP in bind alardam
2020-12-04 10:29 ` [Intel-wired-lan] " alardam
2020-12-04 10:29 ` [PATCH v2 bpf 5/5] ethtool: provide xdp info with XDP_PROPERTIES_GET alardam
2020-12-04 10:29 ` [Intel-wired-lan] " alardam
2020-12-04 17:20 ` [PATCH v2 bpf 0/5] New netdev feature flags for XDP Jakub Kicinski
2020-12-04 17:20 ` [Intel-wired-lan] " Jakub Kicinski
2020-12-04 17:26 ` Toke Høiland-Jørgensen
2020-12-04 17:26 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2020-12-04 19:22 ` Jakub Kicinski
2020-12-04 19:22 ` [Intel-wired-lan] " Jakub Kicinski
2020-12-07 12:04 ` Toke Høiland-Jørgensen
2020-12-07 12:04 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7mvsr0e.fsf@toke.dk \
--to=toke@redhat.com \
--cc=alardam@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jbrouer@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.