From: Thomas Gleixner <tglx@linutronix.de> To: Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>, David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>, Dave Hansen <dave.hansen@intel.com>, Tony Luck <tony.luck@intel.com>, Ashok Raj <ashok.raj@intel.com>, Jacob Jun Pan <jacob.jun.pan@intel.com>, Dave Jiang <dave.jiang@intel.com>, Sohil Mehta <sohil.mehta@intel.com>, Ravi V Shankar <ravi.v.shankar@intel.com> Cc: linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>, iommu@lists.linux-foundation.org, Fenghua Yu <fenghua.yu@intel.com> Subject: Re: [PATCH 5/7] x86/mmu: Allocate/free PASID Date: Sun, 26 Apr 2020 16:55:25 +0200 [thread overview] Message-ID: <87pnbus3du.fsf@nanos.tec.linutronix.de> (raw) In-Reply-To: <1585596788-193989-6-git-send-email-fenghua.yu@intel.com> Fenghua Yu <fenghua.yu@intel.com> writes: > PASID is shared by all threads in a process. So the logical place to keep > track of it is in the "mm". Add the field to the architecture specific > mm_context_t structure. > > A PASID is allocated for an "mm" the first time any thread attaches > to an SVM capable device. Later device atatches (whether to the same atatches? > device or another SVM device) will re-use the same PASID. > > The PASID is freed when the process exits (so no need to keep > reference counts on how many SVM devices are sharing the PASID). I'm not buying that. If there is an outstanding request with the PASID of a process then tearing down the process address space and freeing the PASID (which might be reused) is fundamentally broken. > +void __free_pasid(struct mm_struct *mm); > + > #endif /* _ASM_X86_IOMMU_H */ > diff --git a/arch/x86/include/asm/mmu.h b/arch/x86/include/asm/mmu.h > index bdeae9291e5c..137bf51f19e6 100644 > --- a/arch/x86/include/asm/mmu.h > +++ b/arch/x86/include/asm/mmu.h > @@ -50,6 +50,10 @@ typedef struct { > u16 pkey_allocation_map; > s16 execute_only_pkey; > #endif > + > +#ifdef CONFIG_INTEL_IOMMU_SVM > + int pasid; int? It's a value which gets programmed into the MSR along with the valid bit (bit 31) set. > extern void switch_mm(struct mm_struct *prev, struct mm_struct *next, > diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c > index d7f2a5358900..da718a49e91e 100644 > --- a/drivers/iommu/intel-svm.c > +++ b/drivers/iommu/intel-svm.c > @@ -226,6 +226,45 @@ static LIST_HEAD(global_svm_list); > list_for_each_entry((sdev), &(svm)->devs, list) \ > if ((d) != (sdev)->dev) {} else > > +/* > + * If this mm already has a PASID we can use it. Otherwise allocate a new one. > + * Let the caller know if we did an allocation via 'new_pasid'. > + */ > +static int alloc_pasid(struct intel_svm *svm, struct mm_struct *mm, > + int pasid_max, bool *new_pasid, int flags) Again, data types please. flags are generally unsigned and not plain int. Also pasid_max is certainly not plain int either. > +{ > + int pasid; > + > + /* > + * Reuse the PASID if the mm already has a PASID and not a private > + * PASID is requested. > + */ > + if (mm && mm->context.pasid && !(flags & SVM_FLAG_PRIVATE_PASID)) { > + /* > + * Once a PASID is allocated for this mm, the PASID > + * stays with the mm until the mm is dropped. Reuse > + * the PASID which has been already allocated for the > + * mm instead of allocating a new one. > + */ > + ioasid_set_data(mm->context.pasid, svm); So if the PASID is reused several times for different SVMs then every time ioasid_data->private is set to a different SVM. How is that supposed to work? > + *new_pasid = false; > + > + return mm->context.pasid; > + } > + > + /* > + * Allocate a new pasid. Do not use PASID 0, reserved for RID to > + * PASID. > + */ > + pasid = ioasid_alloc(NULL, PASID_MIN, pasid_max - 1, svm); ioasid_alloc() uses ioasid_t which is typedef unsigned int ioasid_t; Can we please have consistent types and behaviour all over the place? > + if (pasid == INVALID_IOASID) > + return -ENOSPC; > + > + *new_pasid = true; > + > + return pasid; > +} > + > int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ops *ops) > { > struct intel_iommu *iommu = intel_svm_device_to_iommu(dev); > @@ -324,6 +363,8 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ > init_rcu_head(&sdev->rcu); > > if (!svm) { > + bool new_pasid; > + > svm = kzalloc(sizeof(*svm), GFP_KERNEL); > if (!svm) { > ret = -ENOMEM; > @@ -335,15 +376,13 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ > if (pasid_max > intel_pasid_max_id) > pasid_max = intel_pasid_max_id; > > - /* Do not use PASID 0, reserved for RID to PASID */ > - svm->pasid = ioasid_alloc(NULL, PASID_MIN, > - pasid_max - 1, svm); > - if (svm->pasid == INVALID_IOASID) { > + svm->pasid = alloc_pasid(svm, mm, pasid_max, &new_pasid, flags); > + if (svm->pasid < 0) { > kfree(svm); > kfree(sdev); > - ret = -ENOSPC; ret gets magically initialized to an error return value, right? > goto out; > } > + > svm->notifier.ops = &intel_mmuops; > svm->mm = mm; > svm->flags = flags; > @@ -353,7 +392,8 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ > if (mm) { > ret = mmu_notifier_register(&svm->notifier, mm); > if (ret) { > - ioasid_free(svm->pasid); > + if (new_pasid) > + ioasid_free(svm->pasid); > kfree(svm); > kfree(sdev); > goto out; > @@ -371,12 +411,21 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ > if (ret) { > if (mm) > mmu_notifier_unregister(&svm->notifier, mm); > - ioasid_free(svm->pasid); > + if (new_pasid) > + ioasid_free(svm->pasid); > kfree(svm); > kfree(sdev); So there are 3 places now freeing svm ad sdev and 2 of them conditionally free svm->pasid. Can you please rewrite that to have a proper error exit path instead of glueing that stuff into the existing mess? > goto out; > } > > + if (mm && new_pasid && !(flags & SVM_FLAG_PRIVATE_PASID)) { > + /* > + * Track the new pasid in the mm. The pasid will be > + * freed at process exit. Don't track requested > + * private PASID in the mm. What happens to private PASIDs? Thanks, tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de> To: Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>, David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>, Dave Hansen <dave.hansen@intel.com>, Tony Luck <tony.luck@intel.com>, Ashok Raj <ashok.raj@intel.com>, Jacob Jun Pan <jacob.jun.pan@intel.com>, Dave Jiang <dave.jiang@intel.com>, Sohil Mehta <sohil.mehta@intel.com>, Ravi V Shankar <ravi.v.shankar@intel.com> Cc: Fenghua Yu <fenghua.yu@intel.com>, iommu@lists.linux-foundation.org, x86 <x86@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 5/7] x86/mmu: Allocate/free PASID Date: Sun, 26 Apr 2020 16:55:25 +0200 [thread overview] Message-ID: <87pnbus3du.fsf@nanos.tec.linutronix.de> (raw) In-Reply-To: <1585596788-193989-6-git-send-email-fenghua.yu@intel.com> Fenghua Yu <fenghua.yu@intel.com> writes: > PASID is shared by all threads in a process. So the logical place to keep > track of it is in the "mm". Add the field to the architecture specific > mm_context_t structure. > > A PASID is allocated for an "mm" the first time any thread attaches > to an SVM capable device. Later device atatches (whether to the same atatches? > device or another SVM device) will re-use the same PASID. > > The PASID is freed when the process exits (so no need to keep > reference counts on how many SVM devices are sharing the PASID). I'm not buying that. If there is an outstanding request with the PASID of a process then tearing down the process address space and freeing the PASID (which might be reused) is fundamentally broken. > +void __free_pasid(struct mm_struct *mm); > + > #endif /* _ASM_X86_IOMMU_H */ > diff --git a/arch/x86/include/asm/mmu.h b/arch/x86/include/asm/mmu.h > index bdeae9291e5c..137bf51f19e6 100644 > --- a/arch/x86/include/asm/mmu.h > +++ b/arch/x86/include/asm/mmu.h > @@ -50,6 +50,10 @@ typedef struct { > u16 pkey_allocation_map; > s16 execute_only_pkey; > #endif > + > +#ifdef CONFIG_INTEL_IOMMU_SVM > + int pasid; int? It's a value which gets programmed into the MSR along with the valid bit (bit 31) set. > extern void switch_mm(struct mm_struct *prev, struct mm_struct *next, > diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c > index d7f2a5358900..da718a49e91e 100644 > --- a/drivers/iommu/intel-svm.c > +++ b/drivers/iommu/intel-svm.c > @@ -226,6 +226,45 @@ static LIST_HEAD(global_svm_list); > list_for_each_entry((sdev), &(svm)->devs, list) \ > if ((d) != (sdev)->dev) {} else > > +/* > + * If this mm already has a PASID we can use it. Otherwise allocate a new one. > + * Let the caller know if we did an allocation via 'new_pasid'. > + */ > +static int alloc_pasid(struct intel_svm *svm, struct mm_struct *mm, > + int pasid_max, bool *new_pasid, int flags) Again, data types please. flags are generally unsigned and not plain int. Also pasid_max is certainly not plain int either. > +{ > + int pasid; > + > + /* > + * Reuse the PASID if the mm already has a PASID and not a private > + * PASID is requested. > + */ > + if (mm && mm->context.pasid && !(flags & SVM_FLAG_PRIVATE_PASID)) { > + /* > + * Once a PASID is allocated for this mm, the PASID > + * stays with the mm until the mm is dropped. Reuse > + * the PASID which has been already allocated for the > + * mm instead of allocating a new one. > + */ > + ioasid_set_data(mm->context.pasid, svm); So if the PASID is reused several times for different SVMs then every time ioasid_data->private is set to a different SVM. How is that supposed to work? > + *new_pasid = false; > + > + return mm->context.pasid; > + } > + > + /* > + * Allocate a new pasid. Do not use PASID 0, reserved for RID to > + * PASID. > + */ > + pasid = ioasid_alloc(NULL, PASID_MIN, pasid_max - 1, svm); ioasid_alloc() uses ioasid_t which is typedef unsigned int ioasid_t; Can we please have consistent types and behaviour all over the place? > + if (pasid == INVALID_IOASID) > + return -ENOSPC; > + > + *new_pasid = true; > + > + return pasid; > +} > + > int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ops *ops) > { > struct intel_iommu *iommu = intel_svm_device_to_iommu(dev); > @@ -324,6 +363,8 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ > init_rcu_head(&sdev->rcu); > > if (!svm) { > + bool new_pasid; > + > svm = kzalloc(sizeof(*svm), GFP_KERNEL); > if (!svm) { > ret = -ENOMEM; > @@ -335,15 +376,13 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ > if (pasid_max > intel_pasid_max_id) > pasid_max = intel_pasid_max_id; > > - /* Do not use PASID 0, reserved for RID to PASID */ > - svm->pasid = ioasid_alloc(NULL, PASID_MIN, > - pasid_max - 1, svm); > - if (svm->pasid == INVALID_IOASID) { > + svm->pasid = alloc_pasid(svm, mm, pasid_max, &new_pasid, flags); > + if (svm->pasid < 0) { > kfree(svm); > kfree(sdev); > - ret = -ENOSPC; ret gets magically initialized to an error return value, right? > goto out; > } > + > svm->notifier.ops = &intel_mmuops; > svm->mm = mm; > svm->flags = flags; > @@ -353,7 +392,8 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ > if (mm) { > ret = mmu_notifier_register(&svm->notifier, mm); > if (ret) { > - ioasid_free(svm->pasid); > + if (new_pasid) > + ioasid_free(svm->pasid); > kfree(svm); > kfree(sdev); > goto out; > @@ -371,12 +411,21 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ > if (ret) { > if (mm) > mmu_notifier_unregister(&svm->notifier, mm); > - ioasid_free(svm->pasid); > + if (new_pasid) > + ioasid_free(svm->pasid); > kfree(svm); > kfree(sdev); So there are 3 places now freeing svm ad sdev and 2 of them conditionally free svm->pasid. Can you please rewrite that to have a proper error exit path instead of glueing that stuff into the existing mess? > goto out; > } > > + if (mm && new_pasid && !(flags & SVM_FLAG_PRIVATE_PASID)) { > + /* > + * Track the new pasid in the mm. The pasid will be > + * freed at process exit. Don't track requested > + * private PASID in the mm. What happens to private PASIDs? Thanks, tglx _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-04-26 14:55 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-30 19:33 [PATCH 0/7] x86: tag application address space for devices Fenghua Yu 2020-03-30 19:33 ` Fenghua Yu 2020-03-30 19:33 ` [PATCH 1/7] docs: x86: Add a documentation for ENQCMD Fenghua Yu 2020-03-30 19:33 ` Fenghua Yu 2020-04-26 11:02 ` Thomas Gleixner 2020-04-26 11:02 ` Thomas Gleixner 2020-04-27 20:13 ` Fenghua Yu 2020-04-27 20:13 ` Fenghua Yu 2020-03-30 19:33 ` [PATCH 2/7] x86/cpufeatures: Enumerate ENQCMD and ENQCMDS instructions Fenghua Yu 2020-03-30 19:33 ` Fenghua Yu 2020-04-26 11:06 ` Thomas Gleixner 2020-04-26 11:06 ` Thomas Gleixner 2020-04-27 20:17 ` Fenghua Yu 2020-04-27 20:17 ` Fenghua Yu 2020-03-30 19:33 ` [PATCH 3/7] x86/fpu/xstate: Add supervisor PASID state for ENQCMD feature Fenghua Yu 2020-03-30 19:33 ` Fenghua Yu 2020-04-26 11:17 ` Thomas Gleixner 2020-04-26 11:17 ` Thomas Gleixner 2020-04-27 20:33 ` Fenghua Yu 2020-04-27 20:33 ` Fenghua Yu 2020-03-30 19:33 ` [PATCH 4/7] x86/msr-index: Define IA32_PASID MSR Fenghua Yu 2020-03-30 19:33 ` Fenghua Yu 2020-04-26 11:22 ` Thomas Gleixner 2020-04-26 11:22 ` Thomas Gleixner 2020-04-27 20:50 ` Fenghua Yu 2020-04-27 20:50 ` Fenghua Yu 2020-03-30 19:33 ` [PATCH 5/7] x86/mmu: Allocate/free PASID Fenghua Yu 2020-03-30 19:33 ` Fenghua Yu 2020-04-26 14:55 ` Thomas Gleixner [this message] 2020-04-26 14:55 ` Thomas Gleixner 2020-04-27 22:18 ` Fenghua Yu 2020-04-27 22:18 ` Fenghua Yu 2020-04-27 23:44 ` Thomas Gleixner 2020-04-27 23:44 ` Thomas Gleixner 2020-04-28 18:21 ` Jacob Pan (Jun) 2020-04-28 18:21 ` Jacob Pan (Jun) 2020-04-28 18:54 ` Thomas Gleixner 2020-04-28 18:54 ` Thomas Gleixner 2020-04-28 19:07 ` Luck, Tony 2020-04-28 19:07 ` Luck, Tony 2020-04-28 20:42 ` Jacob Pan (Jun) 2020-04-28 20:42 ` Jacob Pan (Jun) 2020-04-28 20:59 ` Luck, Tony 2020-04-28 20:59 ` Luck, Tony 2020-04-28 22:13 ` Jacob Pan (Jun) 2020-04-28 22:13 ` Jacob Pan (Jun) 2020-04-28 22:32 ` Luck, Tony 2020-04-28 22:32 ` Luck, Tony 2020-04-28 20:40 ` Jacob Pan (Jun) 2020-04-28 20:40 ` Jacob Pan (Jun) 2020-04-28 20:57 ` Fenghua Yu 2020-04-28 20:57 ` Fenghua Yu 2020-03-30 19:33 ` [PATCH 6/7] x86/traps: Fix up invalid PASID Fenghua Yu 2020-03-30 19:33 ` Fenghua Yu 2020-04-26 15:25 ` Thomas Gleixner 2020-04-26 15:25 ` Thomas Gleixner 2020-04-27 20:11 ` Fenghua Yu 2020-04-27 20:11 ` Fenghua Yu 2020-04-28 0:13 ` Thomas Gleixner 2020-04-28 0:13 ` Thomas Gleixner 2020-04-27 22:46 ` Raj, Ashok 2020-04-27 22:46 ` Raj, Ashok 2020-04-27 23:08 ` Luck, Tony 2020-04-27 23:08 ` Luck, Tony 2020-04-28 0:20 ` Thomas Gleixner 2020-04-28 0:20 ` Thomas Gleixner 2020-04-28 0:54 ` Thomas Gleixner 2020-04-28 0:54 ` Thomas Gleixner 2020-04-28 1:08 ` Raj, Ashok 2020-04-28 1:08 ` Raj, Ashok 2020-03-30 19:33 ` [PATCH 7/7] x86/process: Clear PASID state for a newly forked/cloned thread Fenghua Yu 2020-03-30 19:33 ` Fenghua Yu 2020-04-22 20:41 ` [PATCH 0/7] x86: tag application address space for devices Fenghua Yu 2020-04-22 20:41 ` Fenghua Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87pnbus3du.fsf@nanos.tec.linutronix.de \ --to=tglx@linutronix.de \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=bp@alien8.de \ --cc=dave.hansen@intel.com \ --cc=dave.jiang@intel.com \ --cc=dwmw2@infradead.org \ --cc=fenghua.yu@intel.com \ --cc=hpa@zytor.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=ravi.v.shankar@intel.com \ --cc=sohil.mehta@intel.com \ --cc=tony.luck@intel.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.