All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Anup Patel <anup@brainfault.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 1/6] dt-bindings: arm: renesas: Ignore the schema for RISC-V arch
Date: Wed, 27 Jul 2022 09:55:37 +0100	[thread overview]
Message-ID: <CA+V-a8vCRNb9r8o=C97DV11ZA4Uf+7rHmbO6+Gjq+q=CUuDPRA@mail.gmail.com> (raw)
In-Reply-To: <7a02225c-5c7b-f342-e29e-995d1ae0f4e3@linaro.org>

Hi Krzysztof,

Thank you for the review.

On Wed, Jul 27, 2022 at 9:51 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/07/2022 20:06, Lad Prabhakar wrote:
> > Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK
> > (RISC-V arch).
>
> Your commit msg says one, but patch ignores r9a07g043f01 which sounds
> entirely different for non-Renesas people. Be a bit more clear.
>
Sure will update the commit message.

> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> > index ff80152f092f..f646df1a23af 100644
> > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings
> >  maintainers:
> >    - Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > +# We want to ignore this schema if the board is of RISC-V arch
> > +select:
> > +  not:
> > +    properties:
> > +      compatible:
> > +        contains:
> > +          items:
>
> It is only one item, so I guess you wanted here enum.
>
> Just like syscon is doing...
>
Ok I will switch to enum.

Cheers,
Prabhakar

WARNING: multiple messages have this Message-ID (diff)
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	 Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 Albert Ou <aou@eecs.berkeley.edu>,
	Anup Patel <anup@brainfault.org>,
	 Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	 LKML <linux-kernel@vger.kernel.org>,
	Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 1/6] dt-bindings: arm: renesas: Ignore the schema for RISC-V arch
Date: Wed, 27 Jul 2022 09:55:37 +0100	[thread overview]
Message-ID: <CA+V-a8vCRNb9r8o=C97DV11ZA4Uf+7rHmbO6+Gjq+q=CUuDPRA@mail.gmail.com> (raw)
In-Reply-To: <7a02225c-5c7b-f342-e29e-995d1ae0f4e3@linaro.org>

Hi Krzysztof,

Thank you for the review.

On Wed, Jul 27, 2022 at 9:51 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/07/2022 20:06, Lad Prabhakar wrote:
> > Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK
> > (RISC-V arch).
>
> Your commit msg says one, but patch ignores r9a07g043f01 which sounds
> entirely different for non-Renesas people. Be a bit more clear.
>
Sure will update the commit message.

> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> > index ff80152f092f..f646df1a23af 100644
> > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings
> >  maintainers:
> >    - Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > +# We want to ignore this schema if the board is of RISC-V arch
> > +select:
> > +  not:
> > +    properties:
> > +      compatible:
> > +        contains:
> > +          items:
>
> It is only one item, so I guess you wanted here enum.
>
> Just like syscon is doing...
>
Ok I will switch to enum.

Cheers,
Prabhakar

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-07-27  8:56 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 18:06 [PATCH 0/6] Add support for Renesas RZ/Five SoC Lad Prabhakar
2022-07-26 18:06 ` Lad Prabhakar
2022-07-26 18:06 ` [PATCH 1/6] dt-bindings: arm: renesas: Ignore the schema for RISC-V arch Lad Prabhakar
2022-07-26 18:06   ` Lad Prabhakar
2022-07-27  8:50   ` Krzysztof Kozlowski
2022-07-27  8:50     ` Krzysztof Kozlowski
2022-07-27  8:55     ` Lad, Prabhakar [this message]
2022-07-27  8:55       ` Lad, Prabhakar
2022-07-27  8:53   ` Krzysztof Kozlowski
2022-07-27  8:53     ` Krzysztof Kozlowski
2022-07-27  9:00     ` Lad, Prabhakar
2022-07-27  9:00       ` Lad, Prabhakar
2022-07-27  9:31       ` Krzysztof Kozlowski
2022-07-27  9:31         ` Krzysztof Kozlowski
2022-07-27  9:48         ` Lad, Prabhakar
2022-07-27  9:48           ` Lad, Prabhakar
2022-08-11 15:26           ` Geert Uytterhoeven
2022-08-11 15:26             ` Geert Uytterhoeven
2022-08-11 23:37             ` Lad, Prabhakar
2022-08-11 23:37               ` Lad, Prabhakar
2022-07-27 15:43   ` Rob Herring
2022-07-27 15:43     ` Rob Herring
2022-07-26 18:06 ` [PATCH 2/6] dt-bindings: riscv: Sort the CPU core list alphabetically Lad Prabhakar
2022-07-26 18:06   ` Lad Prabhakar
2022-07-27  8:51   ` Krzysztof Kozlowski
2022-07-27  8:51     ` Krzysztof Kozlowski
2022-07-26 18:06 ` [PATCH 3/6] dt-bindings: riscv: Add Andes AX45MP core to the list Lad Prabhakar
2022-07-26 18:06   ` Lad Prabhakar
2022-07-27  8:51   ` Krzysztof Kozlowski
2022-07-27  8:51     ` Krzysztof Kozlowski
2022-07-26 18:06 ` [PATCH 4/6] dt-bindings: riscv: Add DT binding documentation for Renesas RZ/Five SoC and SMARC EVK Lad Prabhakar
2022-07-26 18:06   ` Lad Prabhakar
2022-07-27  8:54   ` Krzysztof Kozlowski
2022-07-27  8:54     ` Krzysztof Kozlowski
2022-07-27  9:05     ` Lad, Prabhakar
2022-07-27  9:05       ` Lad, Prabhakar
2022-07-27  9:27       ` Biju Das
2022-07-27  9:27         ` Biju Das
2022-07-27  9:35         ` Lad, Prabhakar
2022-07-27  9:35           ` Lad, Prabhakar
2022-07-27  9:54       ` Krzysztof Kozlowski
2022-07-27  9:54         ` Krzysztof Kozlowski
2022-07-27 10:06         ` Lad, Prabhakar
2022-07-27 10:06           ` Lad, Prabhakar
2022-07-27 10:09           ` Krzysztof Kozlowski
2022-07-27 10:09             ` Krzysztof Kozlowski
2022-07-27 11:37             ` Lad, Prabhakar
2022-07-27 11:37               ` Lad, Prabhakar
2022-07-27 11:44               ` Krzysztof Kozlowski
2022-07-27 11:44                 ` Krzysztof Kozlowski
2022-07-27 12:21                 ` Biju Das
2022-07-27 12:21                   ` Biju Das
2022-07-27 12:36                   ` Krzysztof Kozlowski
2022-07-27 12:36                     ` Krzysztof Kozlowski
2022-07-27 12:56                     ` Biju Das
2022-07-27 12:56                       ` Biju Das
2022-07-27 13:00                       ` Krzysztof Kozlowski
2022-07-27 13:00                         ` Krzysztof Kozlowski
2022-07-27 13:29                         ` Conor.Dooley
2022-07-27 13:29                           ` Conor.Dooley
2022-07-27 15:32                           ` Lad, Prabhakar
2022-07-27 15:32                             ` Lad, Prabhakar
2022-08-11 15:42                     ` Geert Uytterhoeven
2022-08-11 15:42                       ` Geert Uytterhoeven
2022-08-12  6:23                       ` Krzysztof Kozlowski
2022-08-12  6:23                         ` Krzysztof Kozlowski
2022-08-12  9:49                         ` Lad, Prabhakar
2022-08-12  9:49                           ` Lad, Prabhakar
2022-08-12 15:10                         ` Palmer Dabbelt
2022-08-12 15:10                           ` Palmer Dabbelt
2022-07-26 18:06 ` [PATCH 5/6] RISC-V: Kconfig.socs: Add Renesas RZ/Five SoC kconfig option Lad Prabhakar
2022-07-26 18:06   ` Lad Prabhakar
2022-07-26 18:49   ` Conor.Dooley
2022-07-26 18:49     ` Conor.Dooley
2022-07-27  8:19     ` Lad, Prabhakar
2022-07-27  8:19       ` Lad, Prabhakar
2022-07-26 18:06 ` [PATCH 6/6] riscv: dts: renesas: Add initial devicetree for Renesas RZ/Five SoC Lad Prabhakar
2022-07-26 18:06   ` Lad Prabhakar
2022-07-26 18:25   ` Conor.Dooley
2022-07-26 18:25     ` Conor.Dooley
2022-07-26 18:53     ` Conor.Dooley
2022-07-26 18:53       ` Conor.Dooley
2022-07-27  8:09     ` Lad, Prabhakar
2022-07-27  8:09       ` Lad, Prabhakar
2022-07-27  8:21       ` Conor.Dooley
2022-07-27  8:21         ` Conor.Dooley
2022-07-27  8:30         ` Lad, Prabhakar
2022-07-27  8:30           ` Lad, Prabhakar
2022-07-27  8:55   ` Krzysztof Kozlowski
2022-07-27  8:55     ` Krzysztof Kozlowski
2022-07-27  9:08     ` Lad, Prabhakar
2022-07-27  9:08       ` Lad, Prabhakar
2022-07-26 18:51 ` [PATCH 0/6] Add support " Conor.Dooley
2022-07-26 18:51   ` Conor.Dooley
2022-07-27  8:00   ` Lad, Prabhakar
2022-07-27  8:00     ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+V-a8vCRNb9r8o=C97DV11ZA4Uf+7rHmbO6+Gjq+q=CUuDPRA@mail.gmail.com' \
    --to=prabhakar.csengg@gmail.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=magnus.damm@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.