Re: [PATCH 19/19] LoongArch: Add Loongson-3 default config file

[Huacai Chen <chenhuacai@gmail.com>]

Hi, Arnd,

On Tue, Jul 6, 2021 at 6:18 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, Jul 6, 2021 at 6:18 AM Huacai Chen <chenhuacai@loongson.cn> wrote:
>
> > +CONFIG_EMBEDDED=y
>
> You probably should not set this one.
>
> > +CONFIG_CAIF=y
>
> And almost certainly not this one.
>
> > +CONFIG_PCCARD=m
> > +CONFIG_YENTA=m
> > +CONFIG_RAPIDIO=y
> > +CONFIG_RAPIDIO_TSI721=y
>
> These seem unlikely as well. Can you confirm that you have both old-style
> PC-Card support and RAPIDIO support on your most common hardware?
>
> > +CONFIG_PARPORT=y
> > +CONFIG_PARPORT_PC=y
> > +CONFIG_PARPORT_SERIAL=y
> > +CONFIG_PARPORT_PC_FIFO=y
> > +CONFIG_PRINTER=m
>
> Is this an on-board PCI device you actually have?
> What do you connect to the PC parport? Most printers
> in the past 15 years only have USB or network connections.
>
> > +CONFIG_8139CP=m
> > +CONFIG_8139TOO=m
>
> Do you actually support legacy PCI slots?
>
> > +CONFIG_SERIAL_8250=y
> > +CONFIG_SERIAL_8250_CONSOLE=y
> > +CONFIG_SERIAL_8250_NR_UARTS=16
> > +CONFIG_SERIAL_8250_RUNTIME_UARTS=16
> > +CONFIG_SERIAL_8250_EXTENDED=y
> > +CONFIG_SERIAL_8250_MANY_PORTS=y
> > +CONFIG_SERIAL_8250_SHARE_IRQ=y
> > +CONFIG_SERIAL_8250_RSA=y
> > +CONFIG_SERIAL_OF_PLATFORM=y
>
> I don't see any device tree support in your patches, so I think the
> SERIAL_OF_PLATFORM is not needed.
>
> > +CONFIG_RAW_DRIVER=m
>
> This is gone now.
>
> > +CONFIG_INFINIBAND=m
>
> You don't seem to enable any infiniband host drivers, so the core
> layer can probably remain turned off
>
> > +CONFIG_RTC_CLASS=y
> > +CONFIG_RTC_DRV_EFI=y
> > +CONFIG_UIO=m
>
> same for UIO.
>
> > +CONFIG_EXT2_FS=y
> > +CONFIG_EXT2_FS_XATTR=y
> > +CONFIG_EXT2_FS_POSIX_ACL=y
> > +CONFIG_EXT2_FS_SECURITY=y
> > +CONFIG_EXT3_FS=y
> > +CONFIG_EXT3_FS_POSIX_ACL=y
> > +CONFIG_EXT3_FS_SECURITY=y
>
> I would generally recommend using EXT4 over EXT2 or EXT3
>
> > +CONFIG_FRAME_WARN=1024
>
> On 64-bit platforms, you probably want to increase this a bit,
> otherwise you get extra warnings about code that works as
> intended. The default is 2048, but you should be able to get by
> with 1280, if that lets you build a defconfig kernel without warnings.
Most of your suggestions here will be accepted, but PARPORT and PCMCIA
will be keeped, we use some legacy devices with superio.

Huacai
>
>
>       Arnd