* console: Drop added "static" for newport_con
@ 2018-04-26 17:46 Dmitry Shmidt
2018-04-26 18:37 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Shmidt @ 2018-04-26 17:46 UTC (permalink / raw)
To: stable
Please add this patch to stable 4.14
commit f54450ad1942287cc76b38021c0441fc4901d2de
Author: Kees Cook <keescook@chromium.org>
Date: Tue Feb 27 13:11:21 2018 -0800
console: Drop added "static" for newport_con
Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
added "static" to newport_con instance of struct consw, while trying to
normalize the declarations. This, however, needed to stay non-static as it
has an extern.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: console: Drop added "static" for newport_con
2018-04-26 17:46 console: Drop added "static" for newport_con Dmitry Shmidt
@ 2018-04-26 18:37 ` Greg KH
2018-04-26 19:19 ` Dmitry Shmidt
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2018-04-26 18:37 UTC (permalink / raw)
To: Dmitry Shmidt; +Cc: stable
On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote:
> Please add this patch to stable 4.14
>
> commit f54450ad1942287cc76b38021c0441fc4901d2de
> Author: Kees Cook <keescook@chromium.org>
> Date: Tue Feb 27 13:11:21 2018 -0800
>
> console: Drop added "static" for newport_con
>
> Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
> added "static" to newport_con instance of struct consw, while trying to
> normalize the declarations. This, however, needed to stay non-static as it
> has an extern.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Why does 4.14.y need it?
It really fixes commit c396a5bf457f ("console: Expand dummy functions
for CFI") which only showed up in 4.17-rc1.
Why would 4.14.y need it?
confused,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: console: Drop added "static" for newport_con
2018-04-26 18:37 ` Greg KH
@ 2018-04-26 19:19 ` Dmitry Shmidt
2018-04-26 19:26 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Shmidt @ 2018-04-26 19:19 UTC (permalink / raw)
To: Greg KH; +Cc: stable
On Thu, Apr 26, 2018 at 11:37 AM, Greg KH <greg@kroah.com> wrote:
> On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote:
>> Please add this patch to stable 4.14
>>
>> commit f54450ad1942287cc76b38021c0441fc4901d2de
>> Author: Kees Cook <keescook@chromium.org>
>> Date: Tue Feb 27 13:11:21 2018 -0800
>>
>> console: Drop added "static" for newport_con
>>
>> Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
>> added "static" to newport_con instance of struct consw, while trying to
>> normalize the declarations. This, however, needed to stay non-static as it
>> has an extern.
>>
>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>
> Why does 4.14.y need it?
https://kernelci.org/build/android/branch/android-4.14/kernel/ASB-2018-04-05_4.14-637-gbb60f28e486c/
Errors Summary
2drivers/video/console/newport_con.c:683:27: error: static declaration
of 'newport_con' follows non-static declaration
> It really fixes commit c396a5bf457f ("console: Expand dummy functions
> for CFI") which only showed up in 4.17-rc1.
>
> Why would 4.14.y need it?
>
> confused,
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: console: Drop added "static" for newport_con
2018-04-26 19:19 ` Dmitry Shmidt
@ 2018-04-26 19:26 ` Greg KH
2018-04-26 19:32 ` Dmitry Shmidt
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2018-04-26 19:26 UTC (permalink / raw)
To: Dmitry Shmidt; +Cc: stable
On Thu, Apr 26, 2018 at 12:19:17PM -0700, Dmitry Shmidt wrote:
> On Thu, Apr 26, 2018 at 11:37 AM, Greg KH <greg@kroah.com> wrote:
> > On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote:
> >> Please add this patch to stable 4.14
> >>
> >> commit f54450ad1942287cc76b38021c0441fc4901d2de
> >> Author: Kees Cook <keescook@chromium.org>
> >> Date: Tue Feb 27 13:11:21 2018 -0800
> >>
> >> console: Drop added "static" for newport_con
> >>
> >> Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
> >> added "static" to newport_con instance of struct consw, while trying to
> >> normalize the declarations. This, however, needed to stay non-static as it
> >> has an extern.
> >>
> >> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> >> Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
> >> Signed-off-by: Kees Cook <keescook@chromium.org>
> >> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> >
> > Why does 4.14.y need it?
>
> https://kernelci.org/build/android/branch/android-4.14/kernel/ASB-2018-04-05_4.14-637-gbb60f28e486c/
Why would I care about an android-specific branch for the kernel.org
releases? :)
> Errors Summary
>
> 2drivers/video/console/newport_con.c:683:27: error: static declaration
> of 'newport_con' follows non-static declaration
Ok, but:
> > It really fixes commit c396a5bf457f ("console: Expand dummy functions
> > for CFI") which only showed up in 4.17-rc1.
As this commit is not in the 4.14.y tree, why should it be applied
there?
Still confused,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: console: Drop added "static" for newport_con
2018-04-26 19:26 ` Greg KH
@ 2018-04-26 19:32 ` Dmitry Shmidt
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Shmidt @ 2018-04-26 19:32 UTC (permalink / raw)
To: Greg KH; +Cc: stable
On Thu, Apr 26, 2018 at 12:26 PM, Greg KH <greg@kroah.com> wrote:
> On Thu, Apr 26, 2018 at 12:19:17PM -0700, Dmitry Shmidt wrote:
>> On Thu, Apr 26, 2018 at 11:37 AM, Greg KH <greg@kroah.com> wrote:
>> > On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote:
>> >> Please add this patch to stable 4.14
>> >>
>> >> commit f54450ad1942287cc76b38021c0441fc4901d2de
>> >> Author: Kees Cook <keescook@chromium.org>
>> >> Date: Tue Feb 27 13:11:21 2018 -0800
>> >>
>> >> console: Drop added "static" for newport_con
>> >>
>> >> Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
>> >> added "static" to newport_con instance of struct consw, while trying to
>> >> normalize the declarations. This, however, needed to stay non-static as it
>> >> has an extern.
>> >>
>> >> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> >> Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
>> >> Signed-off-by: Kees Cook <keescook@chromium.org>
>> >> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> >
>> >
>> > Why does 4.14.y need it?
>>
>> https://kernelci.org/build/android/branch/android-4.14/kernel/ASB-2018-04-05_4.14-637-gbb60f28e486c/
>
> Why would I care about an android-specific branch for the kernel.org
> releases? :)
>
>> Errors Summary
>>
>> 2drivers/video/console/newport_con.c:683:27: error: static declaration
>> of 'newport_con' follows non-static declaration
>
> Ok, but:
>
>> > It really fixes commit c396a5bf457f ("console: Expand dummy functions
>> > for CFI") which only showed up in 4.17-rc1.
>
> As this commit is not in the 4.14.y tree, why should it be applied
> there?
>
> Still confused,
My bad. I made wrong assumption that build failure happened
after stable update. Sorry about the noise. I will submit fix to proper branch.
Thanks,
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-26 19:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 17:46 console: Drop added "static" for newport_con Dmitry Shmidt
2018-04-26 18:37 ` Greg KH
2018-04-26 19:19 ` Dmitry Shmidt
2018-04-26 19:26 ` Greg KH
2018-04-26 19:32 ` Dmitry Shmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.