* Ethernet on my CycloneV broke since 4.9.124 @ 2018-10-31 13:01 Clément Péron 2018-10-31 14:42 ` Dinh Nguyen 0 siblings, 1 reply; 7+ messages in thread From: Clément Péron @ 2018-10-31 13:01 UTC (permalink / raw) To: Dinh Nguyen; +Cc: netdev Hi, The patch "net: stmmac: socfpga: add additional ocp reset line for Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV board. When I boot i have this issue : socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 socfpga-dwmac: probe of ff702000.ethernet failed with error -2 Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue. Thanks, Clement ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ethernet on my CycloneV broke since 4.9.124 2018-10-31 13:01 Ethernet on my CycloneV broke since 4.9.124 Clément Péron @ 2018-10-31 14:42 ` Dinh Nguyen 2018-10-31 15:36 ` Clément Péron 0 siblings, 1 reply; 7+ messages in thread From: Dinh Nguyen @ 2018-10-31 14:42 UTC (permalink / raw) To: Clément Péron; +Cc: netdev Hi Clement, On 10/31/2018 08:01 AM, Clément Péron wrote: > Hi, > > The patch "net: stmmac: socfpga: add additional ocp reset line for > Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV > board. > > When I boot i have this issue : > > socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 > socfpga-dwmac: probe of ff702000.ethernet failed with error -2 > > Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue. > Are you sure? I just booted v4.9.124 and did not see any errors. The error should not appear because the commit is using devm_reset_control_get_optional(). Dinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ethernet on my CycloneV broke since 4.9.124 2018-10-31 14:42 ` Dinh Nguyen @ 2018-10-31 15:36 ` Clément Péron 2018-10-31 22:01 ` Dinh Nguyen 0 siblings, 1 reply; 7+ messages in thread From: Clément Péron @ 2018-10-31 15:36 UTC (permalink / raw) To: Dinh Nguyen; +Cc: netdev Hi Dinh, On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen <dinguyen@kernel.org> wrote: > > Hi Clement, > > On 10/31/2018 08:01 AM, Clément Péron wrote: > > Hi, > > > > The patch "net: stmmac: socfpga: add additional ocp reset line for > > Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV > > board. > > > > When I boot i have this issue : > > > > socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 > > socfpga-dwmac: probe of ff702000.ethernet failed with error -2 > > > > Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue. > > > > Are you sure? I just booted v4.9.124 and did not see any errors. The > error should not appear because the commit is using > devm_reset_control_get_optional(). I'm booting on 4.9.130 actually, Agree with you that devm_reset_control_get_optional should not failed but checking other usage of this helper https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i2c-mv64xxx.c#L824 https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi-ss/sun4i-ss-core.c#L259 Show that they don't check for errors except for PROBE_DEFER Thanks, Clement > > Dinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ethernet on my CycloneV broke since 4.9.124 2018-10-31 15:36 ` Clément Péron @ 2018-10-31 22:01 ` Dinh Nguyen 2018-11-02 10:02 ` Clément Péron 0 siblings, 1 reply; 7+ messages in thread From: Dinh Nguyen @ 2018-10-31 22:01 UTC (permalink / raw) To: Clément Péron; +Cc: netdev Hi Clement, On 10/31/2018 10:36 AM, Clément Péron wrote: > Hi Dinh, > > On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen <dinguyen@kernel.org> wrote: >> >> Hi Clement, >> >> On 10/31/2018 08:01 AM, Clément Péron wrote: >>> Hi, >>> >>> The patch "net: stmmac: socfpga: add additional ocp reset line for >>> Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV >>> board. >>> >>> When I boot i have this issue : >>> >>> socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 >>> socfpga-dwmac: probe of ff702000.ethernet failed with error -2 >>> >>> Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue. >>> >> >> Are you sure? I just booted v4.9.124 and did not see any errors. The >> error should not appear because the commit is using >> devm_reset_control_get_optional(). > > I'm booting on 4.9.130 actually, Agree with you that > devm_reset_control_get_optional should not failed but checking other > usage of this helper > https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i2c-mv64xxx.c#L824 > https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi-ss/sun4i-ss-core.c#L259 > Show that they don't check for errors except for PROBE_DEFER > I made a mistake, I was booting linux-next. I am seeing the error with v4.9.124. It's due to this commit not getting backported: "bb475230b8e59a reset: make optional functions really optional" I have backported the patch and is available here if you like to take a look: https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=v4.9.124_optional_reset Dinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ethernet on my CycloneV broke since 4.9.124 2018-10-31 22:01 ` Dinh Nguyen @ 2018-11-02 10:02 ` Clément Péron 2018-11-15 15:50 ` Clément Péron 0 siblings, 1 reply; 7+ messages in thread From: Clément Péron @ 2018-11-02 10:02 UTC (permalink / raw) To: Dinh Nguyen; +Cc: netdev Hi Dinh, On Wed, 31 Oct 2018 at 23:02, Dinh Nguyen <dinguyen@kernel.org> wrote: > > Hi Clement, > > On 10/31/2018 10:36 AM, Clément Péron wrote: > > Hi Dinh, > > > > On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen <dinguyen@kernel.org> wrote: > >> > >> Hi Clement, > >> > >> On 10/31/2018 08:01 AM, Clément Péron wrote: > >>> Hi, > >>> > >>> The patch "net: stmmac: socfpga: add additional ocp reset line for > >>> Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV > >>> board. > >>> > >>> When I boot i have this issue : > >>> > >>> socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 > >>> socfpga-dwmac: probe of ff702000.ethernet failed with error -2 > >>> > >>> Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue. > >>> > >> > >> Are you sure? I just booted v4.9.124 and did not see any errors. The > >> error should not appear because the commit is using > >> devm_reset_control_get_optional(). > > > > I'm booting on 4.9.130 actually, Agree with you that > > devm_reset_control_get_optional should not failed but checking other > > usage of this helper > > https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i2c-mv64xxx.c#L824 > > https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi-ss/sun4i-ss-core.c#L259 > > Show that they don't check for errors except for PROBE_DEFER > > > > I made a mistake, I was booting linux-next. I am seeing the error with > v4.9.124. It's due to this commit not getting backported: > > "bb475230b8e59a reset: make optional functions really optional" > > I have backported the patch and is available here if you like to take a > look: Thanks, works fine on my board too. Regards, Clement > > https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=v4.9.124_optional_reset > > Dinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ethernet on my CycloneV broke since 4.9.124 2018-11-02 10:02 ` Clément Péron @ 2018-11-15 15:50 ` Clément Péron 2018-11-15 16:21 ` Dinh Nguyen 0 siblings, 1 reply; 7+ messages in thread From: Clément Péron @ 2018-11-15 15:50 UTC (permalink / raw) To: Dinh Nguyen; +Cc: netdev Hi Dinh, Did you upstream the patch on linux-stable ? Thanks, Clement On Fri, 2 Nov 2018 at 11:02, Clément Péron <peron.clem@gmail.com> wrote: > > Hi Dinh, > > On Wed, 31 Oct 2018 at 23:02, Dinh Nguyen <dinguyen@kernel.org> wrote: > > > > Hi Clement, > > > > On 10/31/2018 10:36 AM, Clément Péron wrote: > > > Hi Dinh, > > > > > > On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen <dinguyen@kernel.org> wrote: > > >> > > >> Hi Clement, > > >> > > >> On 10/31/2018 08:01 AM, Clément Péron wrote: > > >>> Hi, > > >>> > > >>> The patch "net: stmmac: socfpga: add additional ocp reset line for > > >>> Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV > > >>> board. > > >>> > > >>> When I boot i have this issue : > > >>> > > >>> socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 > > >>> socfpga-dwmac: probe of ff702000.ethernet failed with error -2 > > >>> > > >>> Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue. > > >>> > > >> > > >> Are you sure? I just booted v4.9.124 and did not see any errors. The > > >> error should not appear because the commit is using > > >> devm_reset_control_get_optional(). > > > > > > I'm booting on 4.9.130 actually, Agree with you that > > > devm_reset_control_get_optional should not failed but checking other > > > usage of this helper > > > https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i2c-mv64xxx.c#L824 > > > https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi-ss/sun4i-ss-core.c#L259 > > > Show that they don't check for errors except for PROBE_DEFER > > > > > > > I made a mistake, I was booting linux-next. I am seeing the error with > > v4.9.124. It's due to this commit not getting backported: > > > > "bb475230b8e59a reset: make optional functions really optional" > > > > I have backported the patch and is available here if you like to take a > > look: > > Thanks, works fine on my board too. > Regards, > Clement > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=v4.9.124_optional_reset > > > > Dinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ethernet on my CycloneV broke since 4.9.124 2018-11-15 15:50 ` Clément Péron @ 2018-11-15 16:21 ` Dinh Nguyen 0 siblings, 0 replies; 7+ messages in thread From: Dinh Nguyen @ 2018-11-15 16:21 UTC (permalink / raw) To: Clément Péron; +Cc: netdev On 11/15/18 9:50 AM, Clément Péron wrote: > Hi Dinh, > > Did you upstream the patch on linux-stable ? > Not yet... Dinh > On Fri, 2 Nov 2018 at 11:02, Clément Péron <peron.clem@gmail.com> wrote: >> >> Hi Dinh, >> >> On Wed, 31 Oct 2018 at 23:02, Dinh Nguyen <dinguyen@kernel.org> wrote: >>> >>> Hi Clement, >>> >>> On 10/31/2018 10:36 AM, Clément Péron wrote: >>>> Hi Dinh, >>>> >>>> On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen <dinguyen@kernel.org> wrote: >>>>> >>>>> Hi Clement, >>>>> >>>>> On 10/31/2018 08:01 AM, Clément Péron wrote: >>>>>> Hi, >>>>>> >>>>>> The patch "net: stmmac: socfpga: add additional ocp reset line for >>>>>> Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV >>>>>> board. >>>>>> >>>>>> When I boot i have this issue : >>>>>> >>>>>> socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 >>>>>> socfpga-dwmac: probe of ff702000.ethernet failed with error -2 >>>>>> >>>>>> Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue. >>>>>> >>>>> >>>>> Are you sure? I just booted v4.9.124 and did not see any errors. The >>>>> error should not appear because the commit is using >>>>> devm_reset_control_get_optional(). >>>> >>>> I'm booting on 4.9.130 actually, Agree with you that >>>> devm_reset_control_get_optional should not failed but checking other >>>> usage of this helper >>>> https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i2c-mv64xxx.c#L824 >>>> https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi-ss/sun4i-ss-core.c#L259 >>>> Show that they don't check for errors except for PROBE_DEFER >>>> >>> >>> I made a mistake, I was booting linux-next. I am seeing the error with >>> v4.9.124. It's due to this commit not getting backported: >>> >>> "bb475230b8e59a reset: make optional functions really optional" >>> >>> I have backported the patch and is available here if you like to take a >>> look: >> >> Thanks, works fine on my board too. >> Regards, >> Clement >> >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=v4.9.124_optional_reset >>> >>> Dinh ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-11-16 2:30 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-10-31 13:01 Ethernet on my CycloneV broke since 4.9.124 Clément Péron 2018-10-31 14:42 ` Dinh Nguyen 2018-10-31 15:36 ` Clément Péron 2018-10-31 22:01 ` Dinh Nguyen 2018-11-02 10:02 ` Clément Péron 2018-11-15 15:50 ` Clément Péron 2018-11-15 16:21 ` Dinh Nguyen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.