All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Chulski <stefanc@marvell.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Nadav Haklai <nadavh@marvell.com>,
	Yan Markman <ymarkman@marvell.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"mw@semihalf.com" <mw@semihalf.com>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"atenart@kernel.org" <atenart@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>,
	"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control
Date: Thu, 11 Feb 2021 13:06:41 +0000	[thread overview]
Message-ID: <CO6PR18MB3873E18A4761D8DCB6D4300FB08C9@CO6PR18MB3873.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210211125606.GH1463@shell.armlinux.org.uk>


> > +/* Configure Rx FIFO Flow control thresholds */ void
> > +mvpp23_rx_fifo_fc_en(struct mvpp2 *priv, int port, bool en) {
> > +	int val;
> 
> 	u32 ?

OK.

> > +
> > +	val = mvpp2_read(priv, MVPP2_RX_FC_REG(port));
> > +
> > +	if (en)
> > +		val |= MVPP2_RX_FC_EN;
> > +	else
> > +		val &= ~MVPP2_RX_FC_EN;
> > +
> > +	mvpp2_write(priv, MVPP2_RX_FC_REG(port), val);
> 
> 	if (en)
> 		val = MVPP2_RX_FC_EN;
> 	else
> 		val = 0;
> 
> 	mvpp2_modify(priv + MVPP2_RX_FC_REG(port),
> MVPP2_RX_FC_EN, val);
> 
> ?

OK, I would use mvpp2_modify Here.

Thanks,
Stefan.

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Chulski <stefanc@marvell.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
	Yan Markman <ymarkman@marvell.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"atenart@kernel.org" <atenart@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Nadav Haklai <nadavh@marvell.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"mw@semihalf.com" <mw@semihalf.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
	"sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>
Subject: RE: [EXT] Re: [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control
Date: Thu, 11 Feb 2021 13:06:41 +0000	[thread overview]
Message-ID: <CO6PR18MB3873E18A4761D8DCB6D4300FB08C9@CO6PR18MB3873.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210211125606.GH1463@shell.armlinux.org.uk>


> > +/* Configure Rx FIFO Flow control thresholds */ void
> > +mvpp23_rx_fifo_fc_en(struct mvpp2 *priv, int port, bool en) {
> > +	int val;
> 
> 	u32 ?

OK.

> > +
> > +	val = mvpp2_read(priv, MVPP2_RX_FC_REG(port));
> > +
> > +	if (en)
> > +		val |= MVPP2_RX_FC_EN;
> > +	else
> > +		val &= ~MVPP2_RX_FC_EN;
> > +
> > +	mvpp2_write(priv, MVPP2_RX_FC_REG(port), val);
> 
> 	if (en)
> 		val = MVPP2_RX_FC_EN;
> 	else
> 		val = 0;
> 
> 	mvpp2_modify(priv + MVPP2_RX_FC_REG(port),
> MVPP2_RX_FC_EN, val);
> 
> ?

OK, I would use mvpp2_modify Here.

Thanks,
Stefan.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-11 13:32 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 10:48 [PATCH v13 net-next 00/15] net: mvpp2: Add TX Flow Control support stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 10:48 ` [PATCH v13 net-next 01/15] doc: marvell: add CM3 address space and PPv2.3 description stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 11:02   ` Russell King - ARM Linux admin
2021-02-11 11:02     ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp11x ethernet device tree stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 10:48 ` [PATCH v13 net-next 03/15] net: mvpp2: add CM3 SRAM memory map stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 11:05   ` Russell King - ARM Linux admin
2021-02-11 11:05     ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21 stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 11:08   ` Russell King - ARM Linux admin
2021-02-11 11:08     ` Russell King - ARM Linux admin
2021-02-11 11:10     ` [EXT] " Stefan Chulski
2021-02-11 11:10       ` Stefan Chulski
2021-02-11 10:48 ` [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 11:42   ` Russell King - ARM Linux admin
2021-02-11 11:42     ` Russell King - ARM Linux admin
2021-02-11 11:49     ` [EXT] " Stefan Chulski
2021-02-11 11:49       ` Stefan Chulski
2021-02-11 19:26       ` Marcin Wojtas
2021-02-11 19:26         ` Marcin Wojtas
2021-02-11 10:48 ` [PATCH v13 net-next 06/15] net: mvpp2: increase BM pool and RXQ size stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 11:09   ` Russell King - ARM Linux admin
2021-02-11 11:09     ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 07/15] net: mvpp2: add FCA periodic timer configurations stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 12:47   ` Russell King - ARM Linux admin
2021-02-11 12:47     ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 12:50   ` Russell King - ARM Linux admin
2021-02-11 12:50     ` Russell King - ARM Linux admin
2021-02-11 13:02     ` [EXT] " Stefan Chulski
2021-02-11 13:02       ` Stefan Chulski
2021-02-11 13:29       ` Russell King - ARM Linux admin
2021-02-11 13:29         ` Russell King - ARM Linux admin
2021-02-11 13:22     ` Stefan Chulski
2021-02-11 13:22       ` Stefan Chulski
2021-02-11 13:31       ` Russell King - ARM Linux admin
2021-02-11 13:31         ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 09/15] net: mvpp2: enable global flow control stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 12:52   ` Russell King - ARM Linux admin
2021-02-11 12:52     ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 10/15] net: mvpp2: add RXQ flow control configurations stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 10:48 ` [PATCH v13 net-next 11/15] net: mvpp2: add ethtool flow control configuration support stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 10:48 ` [PATCH v13 net-next 12/15] net: mvpp2: add BM protection underrun feature support stefanc
2021-02-11 10:48   ` stefanc
2021-02-11 10:49 ` [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control stefanc
2021-02-11 10:49   ` stefanc
2021-02-11 12:56   ` Russell King - ARM Linux admin
2021-02-11 12:56     ` Russell King - ARM Linux admin
2021-02-11 13:06     ` Stefan Chulski [this message]
2021-02-11 13:06       ` [EXT] " Stefan Chulski
2021-02-11 10:49 ` [PATCH v13 net-next 14/15] net: mvpp2: set 802.3x GoP Flow Control mode stefanc
2021-02-11 10:49   ` stefanc
2021-02-11 12:57   ` Russell King - ARM Linux admin
2021-02-11 12:57     ` Russell King - ARM Linux admin
2021-02-11 10:49 ` [PATCH v13 net-next 15/15] net: mvpp2: add TX FC firmware check stefanc
2021-02-11 10:49   ` stefanc
2021-02-11 23:00 ` [PATCH v13 net-next 00/15] net: mvpp2: Add TX Flow Control support patchwork-bot+netdevbpf
2021-02-11 23:00   ` patchwork-bot+netdevbpf
2021-02-12  8:54   ` [EXT] " Stefan Chulski
2021-02-12  8:54     ` Stefan Chulski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB3873E18A4761D8DCB6D4300FB08C9@CO6PR18MB3873.namprd18.prod.outlook.com \
    --to=stefanc@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.