From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: stefanc@marvell.com
Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com,
davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com,
linux-kernel@vger.kernel.org, kuba@kernel.org, mw@semihalf.com,
andrew@lunn.ch, atenart@kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, sebastian.hesselbarth@gmail.com,
gregory.clement@bootlin.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 net-next 09/15] net: mvpp2: enable global flow control
Date: Thu, 11 Feb 2021 12:52:35 +0000 [thread overview]
Message-ID: <20210211125235.GG1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <1613040542-16500-10-git-send-email-stefanc@marvell.com>
On Thu, Feb 11, 2021 at 12:48:56PM +0200, stefanc@marvell.com wrote:
> +static void mvpp2_cm3_write(struct mvpp2 *priv, u32 offset, u32 data)
> +{
> + writel(data, priv->cm3_base + offset);
> +}
> +
> +static u32 mvpp2_cm3_read(struct mvpp2 *priv, u32 offset)
> +{
> + return readl(priv->cm3_base + offset);
> +}
> +
Would it also make sense to have mvpp2_cm3_modify() ? You seem to be
adding several instances of read-modify-write sequences to CM3 RAM in
your series.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: stefanc@marvell.com
Cc: andrew@lunn.ch, ymarkman@marvell.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, atenart@kernel.org,
linux-kernel@vger.kernel.org, nadavh@marvell.com,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@bootlin.com, kuba@kernel.org, mw@semihalf.com,
davem@davemloft.net, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH v13 net-next 09/15] net: mvpp2: enable global flow control
Date: Thu, 11 Feb 2021 12:52:35 +0000 [thread overview]
Message-ID: <20210211125235.GG1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <1613040542-16500-10-git-send-email-stefanc@marvell.com>
On Thu, Feb 11, 2021 at 12:48:56PM +0200, stefanc@marvell.com wrote:
> +static void mvpp2_cm3_write(struct mvpp2 *priv, u32 offset, u32 data)
> +{
> + writel(data, priv->cm3_base + offset);
> +}
> +
> +static u32 mvpp2_cm3_read(struct mvpp2 *priv, u32 offset)
> +{
> + return readl(priv->cm3_base + offset);
> +}
> +
Would it also make sense to have mvpp2_cm3_modify() ? You seem to be
adding several instances of read-modify-write sequences to CM3 RAM in
your series.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-11 13:13 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 10:48 [PATCH v13 net-next 00/15] net: mvpp2: Add TX Flow Control support stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 10:48 ` [PATCH v13 net-next 01/15] doc: marvell: add CM3 address space and PPv2.3 description stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 11:02 ` Russell King - ARM Linux admin
2021-02-11 11:02 ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp11x ethernet device tree stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 10:48 ` [PATCH v13 net-next 03/15] net: mvpp2: add CM3 SRAM memory map stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 11:05 ` Russell King - ARM Linux admin
2021-02-11 11:05 ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21 stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 11:08 ` Russell King - ARM Linux admin
2021-02-11 11:08 ` Russell King - ARM Linux admin
2021-02-11 11:10 ` [EXT] " Stefan Chulski
2021-02-11 11:10 ` Stefan Chulski
2021-02-11 10:48 ` [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 11:42 ` Russell King - ARM Linux admin
2021-02-11 11:42 ` Russell King - ARM Linux admin
2021-02-11 11:49 ` [EXT] " Stefan Chulski
2021-02-11 11:49 ` Stefan Chulski
2021-02-11 19:26 ` Marcin Wojtas
2021-02-11 19:26 ` Marcin Wojtas
2021-02-11 10:48 ` [PATCH v13 net-next 06/15] net: mvpp2: increase BM pool and RXQ size stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 11:09 ` Russell King - ARM Linux admin
2021-02-11 11:09 ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 07/15] net: mvpp2: add FCA periodic timer configurations stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 12:47 ` Russell King - ARM Linux admin
2021-02-11 12:47 ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 12:50 ` Russell King - ARM Linux admin
2021-02-11 12:50 ` Russell King - ARM Linux admin
2021-02-11 13:02 ` [EXT] " Stefan Chulski
2021-02-11 13:02 ` Stefan Chulski
2021-02-11 13:29 ` Russell King - ARM Linux admin
2021-02-11 13:29 ` Russell King - ARM Linux admin
2021-02-11 13:22 ` Stefan Chulski
2021-02-11 13:22 ` Stefan Chulski
2021-02-11 13:31 ` Russell King - ARM Linux admin
2021-02-11 13:31 ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 09/15] net: mvpp2: enable global flow control stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 12:52 ` Russell King - ARM Linux admin [this message]
2021-02-11 12:52 ` Russell King - ARM Linux admin
2021-02-11 10:48 ` [PATCH v13 net-next 10/15] net: mvpp2: add RXQ flow control configurations stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 10:48 ` [PATCH v13 net-next 11/15] net: mvpp2: add ethtool flow control configuration support stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 10:48 ` [PATCH v13 net-next 12/15] net: mvpp2: add BM protection underrun feature support stefanc
2021-02-11 10:48 ` stefanc
2021-02-11 10:49 ` [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control stefanc
2021-02-11 10:49 ` stefanc
2021-02-11 12:56 ` Russell King - ARM Linux admin
2021-02-11 12:56 ` Russell King - ARM Linux admin
2021-02-11 13:06 ` [EXT] " Stefan Chulski
2021-02-11 13:06 ` Stefan Chulski
2021-02-11 10:49 ` [PATCH v13 net-next 14/15] net: mvpp2: set 802.3x GoP Flow Control mode stefanc
2021-02-11 10:49 ` stefanc
2021-02-11 12:57 ` Russell King - ARM Linux admin
2021-02-11 12:57 ` Russell King - ARM Linux admin
2021-02-11 10:49 ` [PATCH v13 net-next 15/15] net: mvpp2: add TX FC firmware check stefanc
2021-02-11 10:49 ` stefanc
2021-02-11 23:00 ` [PATCH v13 net-next 00/15] net: mvpp2: Add TX Flow Control support patchwork-bot+netdevbpf
2021-02-11 23:00 ` patchwork-bot+netdevbpf
2021-02-12 8:54 ` [EXT] " Stefan Chulski
2021-02-12 8:54 ` Stefan Chulski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211125235.GG1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.